I hope this serves to remind everyone that we need to keep the tree in
a state where it is always shippable.
If you're going to implement only a portion of a feature, make sure
it's not visible to the user until it's fully operational. Even if you
intend to flip the rest on in a few hours,
Hi chromium-dev,
A small group of us joined forces to create a Green Tree task force. The
goal of this task
force is to make sure the tree stays green most of the time. The 2 main
pain points that
we are attacking at this time are reducing the buildbot cycle time, to
catch errors earlier, and
It seems like it's coming from about_window_controller - I'm surprised
that's being pulled in by worker_uitest.cc, though.
I see some comments in the .gyp file around manually including
keystone_glue, which is why I was wondering if I have to do something
special for targets that need it. Just
I've started a little wiki to record useful git recipes that people use for
developing chromium.
http://code.google.com/p/chromium/wiki/GitCookbook
Currently, it just has an entry for how to exclude files from a git-cl
upload, while preserving them in another branch. If you have a useful
Why is cocoa_test_helper.mm listed in the browser library? This
results in the class being linked into Google Chrome Framework
(meaning it ships). Doesn't seem appropriate to me. This came up
because I have some helper code I was listing in the unit_tests
section of chrome.gyp. Since it's in
Remove it, see what happens?
On Mon, Sep 21, 2009 at 12:47 PM, Scott Hess sh...@chromium.org wrote:
Why is cocoa_test_helper.mm listed in the browser library? This
results in the class being linked into Google Chrome Framework
(meaning it ships). Doesn't seem appropriate to me. This came
On Sun, Sep 20, 2009 at 10:56 PM, Joel Stanley j...@jms.id.au wrote:
On Mon, Sep 21, 2009 at 15:02, Peter Kasting pkast...@chromium.org wrote:
You're referring to crbug.com/406. This is a nasty bug, but it doesn't kick
in until you're several megabytes into a resource, so I doubt it is the
On Sun, Sep 20, 2009 at 10:43 PM, Evan Martin e...@chromium.org wrote:
- He's bookmarking by pasting urls into add page dialog found via
the bookmark manager(!). Maybe he doesn't realize the star is the add
bookmark button?
My response: I'm no UI designer, but I wonder if it'd help to put
On Mon, Sep 21, 2009 at 10:20 AM, Robert Sesek rse...@chromium.org wrote:
At least on Mac, in the bookmark menu/bar we use the generic globe favicon
for sites that don't have their own icon. Perhaps we should switch this to
be a star icon? That way there'd be a subtle suggestion to the user
It seems to be an informal convention amongst some Mac developers to prefix
their changes with [Mac] in the CL subject line. This is extremely helpful
for quickly picking out changes that only affect the single platform,
especially if that information is not clear from the CL's description. I was
On Mon, Sep 21, 2009 at 8:25 AM, Nicolas Sylvain nsylv...@chromium.orgwrote:
Hi chromium-dev,
A small group of us joined forces to create a Green Tree task force.
The goal of this task
force is to make sure the tree stays green most of the time. The 2 main
pain points that
we are
On Mon, Sep 21, 2009 at 10:29 AM, Peter Kasting pkast...@google.com wrote:
On Mon, Sep 21, 2009 at 10:20 AM, Robert Sesek rse...@chromium.org wrote:
At least on Mac, in the bookmark menu/bar we use the generic globe favicon
for sites that don't have their own icon. Perhaps we should switch
Please run
git cl config http://src.chromium.org/svn/
It will autoconfigure itself. This will make it correctly amend
codereviews with whether they've been committed or not.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
Hi All,
We're having a conversation over on the o3d-discuss list about how to
support third-party C++ extensions for o3d:
http://groups.google.com/group/o3d-discuss/browse_thread/thread/6fee1142eafd08b1
Does anyone know if adding this capability is currently planned?
Thanks,
Marshall
crbug.com/18189
crbug.com/18539
I got the first because it involved the status bubble; I got the second
because I got the first.
NSRectFill(). Deep down that ends up in sseCGSFill8by1, which looks like it
sometimes scribbles off the end of some buffer. I have no idea what we could
be doing wrong
Could it possibly be related to passing a zero-sized rect in somewhere?
On Mon, Sep 21, 2009 at 12:27 PM, Avi Drissman a...@google.com wrote:
crbug.com/18189
crbug.com/18539
I got the first because it involved the status bubble; I got the second
because I got the first.
NSRectFill(). Deep
I have no evidence to confirm/deny that. Even so it deserves an upstreaming.
I'll look at it but why would it show up 1/30 times?
Avi
On Mon, Sep 21, 2009 at 4:07 PM, Evan Martin e...@chromium.org wrote:
Could it possibly be related to passing a zero-sized rect in somewhere?
On Mon, Sep 21,
No idea! I was just suggesting that if it's possible to work around
it, you'd have less memory getting stomped. :)
On Mon, Sep 21, 2009 at 1:15 PM, Avi Drissman a...@google.com wrote:
I have no evidence to confirm/deny that. Even so it deserves an upstreaming.
I'll look at it but why would
On Sun, Sep 20, 2009 at 7:43 PM, Evan Martin e...@chromium.org wrote:
It’s been a little over a month since I started using Chromium, the
Open Source version of the Google Chrome Web browser. Since then, I’ve
been using Chromium quite extensively. While the honeymoon isn’t over
yet, I do
I think we need to re-consider our practice of shipping beta/stable browsers
with experimental features hidden behind flags--at least when they have any
side-effects in JavaScript. An example of where this has bitten us is
http://code.google.com/p/chromium/issues/detail?id=22181
Although part of
http://code.google.com/p/nativeclient/
On Mon, Sep 21, 2009 at 12:44 PM, Marshall Greenblatt
magreenbl...@gmail.com wrote:
Hi All,
We're having a conversation over on the o3d-discuss list about how to
support third-party C++ extensions for o3d:
i never experienced images partially load issue, but i see it posted
once in a while in crbug.com
for example, http://crbug.com/15785 started as such and morphed into a
different issue because the reporter couldn't provide real repro steps
(at least that's the way i see it...)
also there's
That raises an excellent point! I would extend those compile time flags to
include prevent experiments from getting into beta/stable as well.
Kind Regards,
Anthony Laforge
Technical Program Manager
Mountain View, CA
On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow jor...@chromium.org wrote:
I
It is really useful to have early code compiling and running as much
as possible on all platforms right from the beginning. This catches a
lot of issues early in the development cycle and prevents scary
monolithic integration phases.
Could we also fix this problem by doing something in the
On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow jor...@chromium.org wrote:
I think we need to re-consider our practice of shipping beta/stable
browsers with experimental features hidden behind flags--at least when they
have any side-effects in JavaScript. An example of where this has bitten us
On Mon, Sep 21, 2009 at 2:47 PM, Aaron Boodman a...@chromium.org wrote:
It is really useful to have early code compiling and running as much
as possible on all platforms right from the beginning. This catches a
lot of issues early in the development cycle and prevents scary
monolithic
On Mon, Sep 21, 2009 at 2:55 PM, Jeremy Orlow jor...@chromium.org wrote:
On Mon, Sep 21, 2009 at 2:47 PM, Aaron Boodman a...@chromium.org wrote:
It is really useful to have early code compiling and running as much
as possible on all platforms right from the beginning. This catches a
lot of
On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow jor...@chromium.org wrote:
I think we need to re-consider our practice of shipping beta/stable
browsers with experimental features hidden behind flags--at least when they
have any side-effects in JavaScript. An example of where this has bitten us
On Mon, Sep 21, 2009 at 3:29 PM, John Abd-El-Malek j...@chromium.org wrote:
On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow jor...@chromium.org wrote:
I think we need to re-consider our practice of shipping beta/stable
browsers with experimental features hidden behind flags--at least when
On Mon, Sep 21, 2009 at 3:43 PM, Jeremy Orlow jor...@chromium.org wrote:
On Mon, Sep 21, 2009 at 3:29 PM, John Abd-El-Malek j...@chromium.orgwrote:
On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow jor...@chromium.orgwrote:
I think we need to re-consider our practice of shipping beta/stable
On Mon, Sep 21, 2009 at 3:51 PM, John Abd-El-Malek j...@chromium.org wrote:
On Mon, Sep 21, 2009 at 3:43 PM, Jeremy Orlow jor...@chromium.org wrote:
On Mon, Sep 21, 2009 at 3:29 PM, John Abd-El-Malek j...@chromium.orgwrote:
On Mon, Sep 21, 2009 at 2:31 PM, Jeremy Orlow
On Mon, Sep 21, 2009 at 3:59 PM, Jeremy Orlow jor...@chromium.org wrote:
On Mon, Sep 21, 2009 at 3:51 PM, John Abd-El-Malek j...@chromium.orgwrote:
On Mon, Sep 21, 2009 at 3:43 PM, Jeremy Orlow jor...@chromium.orgwrote:
On Mon, Sep 21, 2009 at 3:29 PM, John Abd-El-Malek
I agree. Our practice of releasing experimental features default disabled
behinda command line flag is extremely valuable. We should make sure that
this works
well for new web APIs. It will continue to be a valuable tool down the
road.
It is important that we have features available in stable,
Very cool! I'll check it out :-)
On Mon, Sep 21, 2009 at 5:39 PM, Erik Kay erik...@chromium.org wrote:
http://code.google.com/p/nativeclient/
On Mon, Sep 21, 2009 at 12:44 PM, Marshall Greenblatt
magreenbl...@gmail.com wrote:
Hi All,
We're having a conversation over on the o3d-discuss
On Mon, Sep 21, 2009 at 12:27 PM, Evan Martin e...@chromium.org wrote:
Please run
git cl config http://src.chromium.org/svn/
It will autoconfigure itself. This will make it correctly amend
codereviews with whether they've been committed or not.
BTW, this command just loads $url +
All right. I'm not 100% convinced, but either way I think we need to
understand better how to remove these features' side-effects from JavaScript
when disabled.
Mads (or anyone else) can you provide any thoughts on how we can implement
the following in our bindings generator?
(1) We need to be
Ooops, sorry. Got bit by reply vs reply-all. See my notes below regarding
implementation details.
-atw
-- Forwarded message --
From: Drew Wilson atwil...@google.com
Date: Mon, Sep 21, 2009 at 5:03 PM
Subject: Re: [chromium-dev] Shipping features behind a run-time flag can
Of the three slowest tests as of last week, two has been fixed (thanks
to evan and jcampan) and the third one has a fix being reviewed.
The Linux trybots build almost as fast as the Mac trybots now, thanks
to shared ccache with a ~80% cache hit rate. Windows trybots are still
struggling - taking
On Mon, Sep 21, 2009 at 6:24 PM, Lei Zhang thes...@chromium.org wrote:
Of the three slowest tests as of last week, two has been fixed (thanks
to evan and jcampan) and the third one has a fix being reviewed.
The Linux trybots build almost as fast as the Mac trybots now, thanks
to shared
Some subset of the team uses the de-facto standard of area: one-liner
description seen in projects like the kernel.
% git log --pretty=format:'%an %s' | sed -nre 's/^(\w+)@chromium.org
(.{,20}: .*)$/* \1 \2/p'
* pfeldman DevTools: Get rid of utility functions and
ExecuteUtilityFunction as a
On Mon, Sep 21, 2009 at 5:41 PM, Jeremy Orlow jor...@chromium.org wrote:
On Mon, Sep 21, 2009 at 5:32 PM, Drew Wilson atwil...@chromium.orgwrote:
Ooops, sorry. Got bit by reply vs reply-all. See my notes below regarding
implementation details.
-atw
-- Forwarded message --
Indeed. BTW I filed http://crbug.com/18577 so it'd be easier to find (and
copy-paste) the command line flags used for a build. We can add this to the
default template if it'd be useful.
-Ben
On Mon, Sep 21, 2009 at 4:37 PM, Darin Fisher da...@chromium.org wrote:
I agree. Our practice of
It's only available in 1.5+.
Kind Regards,
Anthony Laforge
Technical Program Manager
Mountain View, CA
On Mon, Sep 21, 2009 at 9:03 PM, Drew Wilson atwil...@chromium.org wrote:
Hi all,
I'm trying to do a gcl try on my mac, but getting this error:
svn checkout --depth empty
Drew Wilson wrote:
I'm trying to do a gcl try on my mac, but getting this error:
svn checkout --depth empty svn://svn.chromium.org/chrome-try/try
/var/folders/zz/zzzivhrRnAmviuee++2D3++-1lE/-Tmp-/tmpMRXSrL --username
atwil...@google.com
Ouput:
svn: invalid option: --depth
Type 'svn help'
Hi all,
I'm trying to do a gcl try on my mac, but getting this error:
svn checkout --depth empty
svn://svn.chromium.org/chrome-try/try/var/folders/zz/zzzivhrRnAmviuee++2D3++-1lE/-Tmp-/tmpMRXSrL
--username
atwil...@google.com
Ouput:
svn: invalid option: --depth
Type 'svn help' for usage.
Sorry,
No comment on 1.4 compatibility goals. :)
I would bet most developers would want to upgrade to 1.6 for all the
speed improvements. Official package:
http://www.open.collab.net/downloads/community/
(Which installs it in the strange place of /opt/subversion/bin.)
-eric
On Mon, Sep 21, 2009 at
Thanks, updating my svn version and updating my EMAIL_ADDRESS setting (so it
uses the proper acct for svn access) did the trick.
-atw
On Mon, Sep 21, 2009 at 9:18 PM, Eric Seidel esei...@chromium.org wrote:
No comment on 1.4 compatibility goals. :)
I would bet most developers would want to
47 matches
Mail list logo
