[chromium-dev] Re: there was some error on backgournd image display
Yes, between major stable versions and almost every dev version, the rendering engine is improved\changed. ☆PhistucK On Mon, Jun 8, 2009 at 08:57, kindy kind...@gmail.com wrote: the page i browsed(http://www.163.com/) is incorrect now, but it's right in google chrome v1. the attachment is a screen capture. is there any change in the render engine? -- Regards, Lin Qing --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How to change the cursor smoothly for a view
Changing the default class cursor to NULL in widget_win.cc makes not difference that I can see. Any other thoughts? On Jun 13, 4:00 pm, Ben Goodger (Google) b...@chromium.org wrote: No problem. Get well soon! On Sat, Jun 13, 2009 at 3:55 PM, Daniel Cowxdaniel.c...@gmail.com wrote: Sure, I'll take care of this. It'll have to wait a few days though as I broke my index finger and I'm having a bit of a time typing right now. Hope that's cool. Cheers, Daniel On Jun 11, 2:55 pm, Ben Goodger (Google) b...@chromium.org wrote: It's in the class registration function in widget_win.cc -Ben On Thu, Jun 11, 2009 at 2:52 PM, Peter Kastingpkast...@google.com wrote: On Thu, Jun 11, 2009 at 2:48 PM, Ben Goodger (Google) b...@chromium.org wrote: Daniel, do you want to try making this change instead? It'll be pretty obvious to you if it doesn't work. Filed as crbug.com/13926 . We should try and find if we set a value in the WindowWin or WidgetWin (or somewhere) window creation calls and just ditch it. Daniel, feel free to whip up a patch, if it works Ben or I can review. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Developing Chrome using tip-of-tree WebKit
Has anyone actually gotten this to work? I'm having trouble with line
endings. It looks like my webkit.org checkout got converted to using
CR LF line endings, but WebKitTools seems to want LF line endings.
Relatedly, which svn.exe should I have in my path for WebKitTools
(depot_tools or cygwin)?
Thoughts?
Adam
On Mon, May 11, 2009 at 10:16 AM, Darin Fisherda...@chromium.org wrote:
It is now fairly easy to develop Chrome using tip-of-tree WebKit.
First before doing anything, you should make sure that the canary bot
is green (at least the compile step):
http://hae14.jail.google.com:8016/waterfall?builder=Webkit%20(webkit.org)
Then, create a .gclient file like so:
solutions = [
{ name : src,
url : http://src.chromium.org/svn/trunk/src;,
custom_deps : {
'src/third_party/WebKit':
'http://svn.webkit.org/repository/webkit/trunk',
'src/third_party/WebKit/JavaScriptCore': None,
'src/third_party/WebKit/WebCore': None,
'src/third_party/WebKit/WebKitLibraries': None,
'src/third_party/WebKit/WebKit/mac': None,
'src/webkit/data/layout_tests/LayoutTests': None,
}
}
]
If you are starting from a clean slate, you will need to run gclient
config http://src.chromium.org/svn/trunk/src; to generate a default
.gclient file.
NOTE: If you have commit access to Chromium, and want to commit to
Chromium from this checkout, then be sure to change
http://src.chromium.org/svn/trunk/src appropriately.
After gclient sync, you will be left with a normal working copy of
WebKit under src/third_party/WebKit. You can now prepare WebKit
patches for sending to bugs.webkit.org from here, and if you have
commit access to svn.webkit.org, you can even commit from here :-)
Regards,
-Darin
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: Developing Chrome using tip-of-tree WebKit
Yeah, that issue is a pain. I'm using a Windows svn.exe (from depot_tools).
The only time it bugged me was with ChangeLog. After running
prepare-ChangeLog, I run dos2unix ChangeLog, and then I convert \ to /
manually. Kind of sucks, so I filed
https://bugs.webkit.org/show_bug.cgi?id=26000.
-Darin
On Mon, Jun 15, 2009 at 11:15 PM, Adam Barth aba...@chromium.org wrote:
Has anyone actually gotten this to work? I'm having trouble with line
endings. It looks like my webkit.org checkout got converted to using
CR LF line endings, but WebKitTools seems to want LF line endings.
Relatedly, which svn.exe should I have in my path for WebKitTools
(depot_tools or cygwin)?
Thoughts?
Adam
On Mon, May 11, 2009 at 10:16 AM, Darin Fisherda...@chromium.org wrote:
It is now fairly easy to develop Chrome using tip-of-tree WebKit.
First before doing anything, you should make sure that the canary bot
is green (at least the compile step):
http://hae14.jail.google.com:8016/waterfall?builder=Webkit%20(webkit.org)
Then, create a .gclient file like so:
solutions = [
{ name : src,
url : http://src.chromium.org/svn/trunk/src;,
custom_deps : {
'src/third_party/WebKit': '
http://svn.webkit.org/repository/webkit/trunk',
'src/third_party/WebKit/JavaScriptCore': None,
'src/third_party/WebKit/WebCore': None,
'src/third_party/WebKit/WebKitLibraries': None,
'src/third_party/WebKit/WebKit/mac': None,
'src/webkit/data/layout_tests/LayoutTests': None,
}
}
]
If you are starting from a clean slate, you will need to run gclient
config http://src.chromium.org/svn/trunk/src; to generate a default
.gclient file.
NOTE: If you have commit access to Chromium, and want to commit to
Chromium from this checkout, then be sure to change
http://src.chromium.org/svn/trunk/src appropriately.
After gclient sync, you will be left with a normal working copy of
WebKit under src/third_party/WebKit. You can now prepare WebKit
patches for sending to bugs.webkit.org from here, and if you have
commit access to svn.webkit.org, you can even commit from here :-)
Regards,
-Darin
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---
[chromium-dev] Re: How to change the cursor smoothly for a view
On Mon, Jun 15, 2009 at 11:13 PM, Daniel Cowx daniel.c...@gmail.com wrote: Changing the default class cursor to NULL in widget_win.cc makes not difference that I can see. Any other thoughts? Look at all the classes along the inheritance hierarchy between you and the root and see if anyone else is setting the default cursor class. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Developing Chrome using tip-of-tree WebKit
On Mon, Jun 15, 2009 at 11:15 PM, Adam Barth aba...@chromium.org wrote: Has anyone actually gotten this to work? I'm having trouble with line endings. It looks like my webkit.org checkout got converted to using CR LF line endings, but WebKitTools seems to want LF line endings. Relatedly, which svn.exe should I have in my path for WebKitTools (depot_tools or cygwin)? WebKit trunk checkouts only work when you only use the cygwin svn. You must never use a depot_tools svn or you will hose your checkout. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Developing Chrome using tip-of-tree WebKit
On Tue, Jun 16, 2009 at 9:55 AM, Darin Fisherda...@chromium.org wrote: On Tue, Jun 16, 2009 at 9:47 AM, Peter Kasting pkast...@google.com wrote: WebKit trunk checkouts only work when you only use the cygwin svn. You must never use a depot_tools svn or you will hose your checkout. PK That's not true anymore. The canary bot uses svn from depot_tools. What Adam did last night was to fix prepare-ChangeLog to also work with svn from depot_tools. There's still a bit more work to do. I just got an r+ to make the commit-log-editor work in this Frankenstein world. I'll dogfood it for a bit longer and try to work out the kinks. Then I'll write up instructions for dev.chromium.org. Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Developing Chrome using tip-of-tree WebKit
On Tue, Jun 16, 2009 at 9:55 AM, Darin Fisher da...@chromium.org wrote: That's not true anymore. The canary bot uses svn from depot_tools. Then all I can say is: when I accidentally used the depot_tools svn on my existing cygwin svn checkout late last week, I had to blow away the checkout to recover :( So perhaps using one or the other from the very beginning works OK now? I wouldn't mix them though. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Developing Chrome using tip-of-tree WebKit
On Tue, Jun 16, 2009 at 10:01 AM, Peter Kasting pkast...@google.com wrote: On Tue, Jun 16, 2009 at 9:55 AM, Darin Fisher da...@chromium.org wrote: That's not true anymore. The canary bot uses svn from depot_tools. Then all I can say is: when I accidentally used the depot_tools svn on my existing cygwin svn checkout late last week, I had to blow away the checkout to recover :( That I don't doubt :-( So perhaps using one or the other from the very beginning works OK now? I wouldn't mix them though. Yeah, that's been my experience. Where OK comes with some caveats where svn from depot_tools is concerned. -Darin --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How Render process send Image IO request to Browser process
There are a surprising number of comic characters on here. I bet you know Meryl Silverburgh! Generally this type of thing is on the dev site like here: http://dev.chromium.org/developers/design-documents/multi-process-resource-loading Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac painting problems
r18363 introduced mem leaks in test_shell_tests and unit_tests. It would be nice if they get sorted out with this too. http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/1084/steps/valgrind%20test%3A%20test_shell/logs/stdio http://build.chromium.org/buildbot/waterfall/builders/Modules%20Mac%20(valgrind)/builds/1084/steps/valgrind%20test%3A%20unit/logs/stdio On Mon, Jun 15, 2009 at 10:08 PM, Mark Mentovai m...@chromium.org wrote: I see the problem here, I'll fix it. -- ../NiR --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] v8 support in other browsers
Is this project (or some other Google project) considering to provide a browser extension for other browsers (like Internet Explorer), which would allow existing JavaScript pages to run faster (and provide Chrome behavior) on such browsers? For example, a site that requires v8 performance or v8 compliance could just switch: script type=text/javascript ... // my old script here. /script with script type=text/javascript_v8 ... ... // my old script here. /script or maybe using Flash-like style: object classid=... codebase=http://download.google.com/ v8engine ... // my old script here. /object Is somebody considering this? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] V8 Generated Constructors
Hey I'm looking into these layout tests: LayoutTests/media/audio-constructor-src.html LayoutTests/media/audio-constructor.html LayoutTests/media/constructors.html and I need to know how constructors are generated. The failures all appear to be due to the Audio constructor, specifically: TypeError: Illegal constructor Thanks. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] V8 Generated Constructors
Hey I'm looking into these layout tests: LayoutTests/media/audio-constructor-src.html LayoutTests/media/audio-constructor.html LayoutTests/media/constructors.html and I need to know how constructors are generated. The failures all appear to be due to the Audio constructor, specifically: TypeError: Illegal constructor Thanks. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] why some chrome's tests fail?
I'm trying to run chrome's tests, but find lots of failures up there. I wanna ask: 1. most of tests fail like below, why? [--] Global test environment tear-down [==] 42 tests from 8 test cases ran. (3984 ms total) [ PASSED ] 41 tests. [ FAILED ] 1 test, listed below: [ FAILED ] TextEliderTest.TestGeneralEliding 1 FAILED TEST YOU HAVE 1 DISABLED TEST 2.I want to test webkit with its layouttest, but find src/webkit/data/layout_tests/LayoutTests: None in .gclient. If I comment it out and execute gclient sync --rivision s...@ Will I get the layouttest? 3.I think I miss some test data in my src, but I did get a completed gclient sync which I'm very sure. For exmaple, in tab_switching_tests, I can't find src/data/ directory which is a part of testing url: file:///F:/chrometrunk/src/data/tab_switching/kannada.chakradeo.net/index.html --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: why some chrome's tests fail?
2009/6/16 David Jones ds...@163.com: 1. most of tests fail like below, why? [--] Global test environment tear-down [==] 42 tests from 8 test cases ran. (3984 ms total) [ PASSED ] 41 tests. [ FAILED ] 1 test, listed below: [ FAILED ] TextEliderTest.TestGeneralEliding 1 FAILED TEST YOU HAVE 1 DISABLED TEST You will have to debug this one on your own. They pass here. 2.I want to test webkit with its layouttest, but find src/webkit/data/layout_tests/LayoutTests: None in .gclient. If I comment it out and execute gclient sync --rivision s...@ Will I get the layouttest? You can comment it out and just run gclient sync again. Not sure why you'd want to pass the --revision flag. 3.I think I miss some test data in my src, but I did get a completed gclient sync which I'm very sure. For exmaple, in tab_switching_tests, I can't find src/data/ directory which is a part of testing url: file:///F:/chrometrunk/src/data/tab_switching/kannada.chakradeo.net/index.html Some data used by tests is not in the public tree, as many (like performance tests) are attempting to test against real web sites and we can't republish their content. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: V8 Generated Constructors
A good place to start would be to look at existing *Constructor.cpp files in WebCore/bindings/v8 and see how they are hooked in (like Image constructor). Also, you have dimich and levin in close proximity you who have added a V8 constructor or two in the past (I think). ;DG On Mon, Jun 15, 2009 at 5:47 PM, Kyle Preteky...@chromium.org wrote: Hey I'm looking into these layout tests: LayoutTests/media/audio-constructor-src.html LayoutTests/media/audio-constructor.html LayoutTests/media/constructors.html and I need to know how constructors are generated. The failures all appear to be due to the Audio constructor, specifically: TypeError: Illegal constructor Thanks. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] AutomationProvider for gtk?
AutomationProvider::GetActiveWindow() comes from browser/automation/automation_provider.cc on windows, but common/temp_scaffolding_stubs.cc on mac and linux. Is anyone working on a real AutomationProvider implementation for Linux? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] wiki page on third-party linux (ubuntu, fedora) packaging
I tried to shovel everything I knew that would be of interest to packagers onto this page: http://code.google.com/p/chromium/wiki/LinuxPackaging If you know of other contacts (like for Gentoo), please add them there. If you have any other packaging-related questions, feed free to ask here. :) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: AutomationProvider for gtk?
A bunch of automation provider is compiled and works on linux/mac (it's what UI tests use). A bunch still needs to be ported (behind #ifs and some test files are not compiled). File a bug and have at it! On Tue, Jun 16, 2009 at 1:20 PM, Dan Kegeldaniel.r.ke...@gmail.com wrote: AutomationProvider::GetActiveWindow() comes from browser/automation/automation_provider.cc on windows, but common/temp_scaffolding_stubs.cc on mac and linux. Is anyone working on a real AutomationProvider implementation for Linux? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Crash reporting and about:crash.
about:crash is quite naturally one of our top crashers. When the Mac dev channel went out, I saw this an entered http://crbug.com/13453 , thinking that the fact that we were receiving those crashes probably meant we'd forgot to disable something before executing the handler. But, no, it's also a popular crasher on Windows. It has been suggested to me that disabling the crash reporting for this might not be appropriate. As-is, it can perhaps be used to debug whether crash-reporting is working for a particular user. So, I'm inclined to mark it WontFix, except that then searches in the Issues database won't find it. Instead I'm going to mark it Assigned to me, and describe the situation in a comment. Anyone think that's an unreasonable disposition? Thanks, scott --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crash reporting and about:crash.
On Tue, Jun 16, 2009 at 2:32 PM, Scott Hesssh...@chromium.org wrote: So, I'm inclined to mark it WontFix, except that then searches in the Issues database won't find it. Do we think it's something people are actually likely to search for? The crash aggregator will still have the bug number listed for that stack, and that seems like the most likely (only?) place someone would be inspired to look for a bug about it in the first place. -Stuart --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: roc on X scrolling
Thanks a ton for posting this, BTW. I've been thinking about it but didn't have much to say. As he mentions, this guffaw scrolling trickery is all necessary for scrolling a window and its child X windows simultaneously. He also mentions in the first paragraph that Mozilla (and a commenter mentions GTK as well) are moving away from using child windows for a variety of reasons. We, almost coincidentally (because of the sandbox), don't use any child windows for our renderers so we sidestep this issue mostly. Except for plugins for exactly the reason he mentions. For similar sorts of reasons, on Windows John has spent a lot of effort trying to get windowed plugins to move in sync with scrolling. (Our plugin performance is more complicated than Mozilla because our plugins are out of process and we still work when the plugin process is hung.) The approach he suggests here couldn't be too bad to implement on Linux as well, since we already have these special separate code paths for dealing with scrolling plugins. I expect once I get the initial windowed plugins on Linux working they will be incredibly janky for scrolling, and then I will return to this and think about it harder. Though the way it works definitely feels like a hack, it's a good one. :) On Sun, Jun 14, 2009 at 11:00 PM, Peter Kastingpkast...@google.com wrote: http://weblogs.mozillazine.org/roc/archives/2009/06/stupid_x_tricks.html Worth a read by folks working on the Linux port, in case the idea is useful to us. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: gcl upload fails with AttributeError: 'InputApi' object has no attribute 'DEFAULT_BLACK_LIST'
Getting the same error -- can anyone say what the fix is? (I just synced a few hours ago...) On Jun 12, 3:06 pm, Nebojša Ćirić nci...@gmail.com wrote: maruel fixed the issue. On Fri, Jun 12, 2009 at 2:20 PM, Nebojša Ćirić nci...@gmail.com wrote: I downloaded depot_tools today around 10am. On Fri, Jun 12, 2009 at 2:17 PM, Nebojša Ćirić nci...@gmail.com wrote: I've successfully created first CL with gcl change some_name: Fixing problem where ml, hi, pt-PT and bg first run bubbles were truncated or to narrow to hold all of text. Increased width of bubble by 4+ chars, and for bg increased the height of bubble by 1. BUG=12208 ---All lines above this line become the description. ---Repository Root: E:\chromium\src ---Paths in this changelist (first_run_bubble_truncation): M chrome\app\resources\locale_settings_bg.xtb M chrome\app\resources\locale_settings_pt-PT.xtb M chrome\app\resources\locale_settings_ml.xtb M chrome\app\resources\locale_settings_hi.xtb ---Paths modified but not in any changelist: but I have problems uploading it. gcl upload some_name fails with: Traceback (most recent call last): File E:\depot_tools\gcl.py, line 1149, in ? sys.exit(main()) File E:\depot_tools\gcl.py, line 1122, in main UploadCL(change_info, argv[3:]) File E:\depot_tools\gcl.py, line 723, in UploadCL if not DoPresubmitChecks(change_info, committing=False): File E:\depot_tools\gcl.py, line 1032, in DoPresubmitChecks default_presubmit=root_presubmit) File E:\depot_tools\presubmit_support.py, line 688, in DoPresubmitChecks results += executer.ExecPresubmitScript(presubmit_script, filename) File E:\depot_tools\presubmit_support.py, line 631, in ExecPresubmitScript result = eval(function_name + '(*__args)', context) File string, line 0, in ? File string, line 26, in CheckChangeOnUpload AttributeError: 'InputApi' object has no attribute 'DEFAULT_BLACK_LIST' Any pointers? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Crash reporting and about:crash.
On Tue, Jun 16, 2009 at 3:37 PM, Stuart Morganstuartmor...@chromium.org wrote: On Tue, Jun 16, 2009 at 2:32 PM, Scott Hesssh...@chromium.org wrote: So, I'm inclined to mark it WontFix, except that then searches in the Issues database won't find it. Do we think it's something people are actually likely to search for? The crash aggregator will still have the bug number listed for that stack, and that seems like the most likely (only?) place someone would be inspired to look for a bug about it in the first place. Is the crash aggregator's annotation stable across releases? If so, then that makes sense. I was assuming that if the fingerprint changes because we rearrange the calling sequence somehow, then maybe someone has to re-annotate things. -scott --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: gcl upload fails with AttributeError: 'InputApi' object has no attribute 'DEFAULT_BLACK_LIST'
Problem was that my depot_tools were so corrupted that they weren't syncing properly (nor was svn cleanup having any effect). Complete removal and reinstallation seems to have done the trick. On Jun 16, 4:09 pm, miran...@chromium.org miran...@chromium.org wrote: Getting the same error -- can anyone say what the fix is? (I just synced a few hours ago...) On Jun 12, 3:06 pm, Nebojša Ćirić nci...@gmail.com wrote: maruel fixed the issue. On Fri, Jun 12, 2009 at 2:20 PM, Nebojša Ćirić nci...@gmail.com wrote: I downloaded depot_tools today around 10am. On Fri, Jun 12, 2009 at 2:17 PM, Nebojša Ćirić nci...@gmail.com wrote: I've successfully created first CL with gcl change some_name: Fixing problem where ml, hi, pt-PT and bg first run bubbles were truncated or to narrow to hold all of text. Increased width of bubble by 4+ chars, and for bg increased the height of bubble by 1. BUG=12208 ---All lines above this line become the description. ---Repository Root: E:\chromium\src ---Paths in this changelist (first_run_bubble_truncation): M chrome\app\resources\locale_settings_bg.xtb M chrome\app\resources\locale_settings_pt-PT.xtb M chrome\app\resources\locale_settings_ml.xtb M chrome\app\resources\locale_settings_hi.xtb ---Paths modified but not in any changelist: but I have problems uploading it. gcl upload some_name fails with: Traceback (most recent call last): File E:\depot_tools\gcl.py, line 1149, in ? sys.exit(main()) File E:\depot_tools\gcl.py, line 1122, in main UploadCL(change_info, argv[3:]) File E:\depot_tools\gcl.py, line 723, in UploadCL if not DoPresubmitChecks(change_info, committing=False): File E:\depot_tools\gcl.py, line 1032, in DoPresubmitChecks default_presubmit=root_presubmit) File E:\depot_tools\presubmit_support.py, line 688, in DoPresubmitChecks results += executer.ExecPresubmitScript(presubmit_script, filename) File E:\depot_tools\presubmit_support.py, line 631, in ExecPresubmitScript result = eval(function_name + '(*__args)', context) File string, line 0, in ? File string, line 26, in CheckChangeOnUpload AttributeError: 'InputApi' object has no attribute 'DEFAULT_BLACK_LIST' Any pointers? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] The meaning of + ? ! / characters in gyp
Hi, The GypLanguageSpecification does not document the meaning of + ? ! / characters currently. TODO(sgk+mark): document settings merging with new = + ? ! / characters I guess these characters determine the merging policy of settings in gyp, but I am not sure. Can I get the precise meaning? Regards, Kwang Yul Seo --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: The meaning of + ? ! / characters in gyp
Yes, they are to set the merge policy. Extensive documentation is here: http://code.google.com/p/gyp/wiki/InputFormatReference http://code.google.com/p/gyp/wiki/InputFormatReference- James On Tue, Jun 16, 2009 at 11:51 PM, KwangYul Seo kwangyul@gmail.comwrote: Hi, The GypLanguageSpecification does not document the meaning of + ? ! / characters currently. TODO(sgk+mark): document settings merging with new = + ? ! / characters I guess these characters determine the merging policy of settings in gyp, but I am not sure. Can I get the precise meaning? Regards, Kwang Yul Seo --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] How do you generate the VS project files from GYP without gclient?
I know that you typically generate the project files via gclient runhooks --force, but I'm curious to know how to generate the project files via python directly, instead of via gclient. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: How do you generate the VS project files from GYP without gclient?
In the same directory with your .gclient file run:src/tools/gyp/gyp src/build/all.gyp -BradN On Tue, Jun 16, 2009 at 9:17 PM, Daniel Cowx daniel.c...@gmail.com wrote: I know that you typically generate the project files via gclient runhooks --force, but I'm curious to know how to generate the project files via python directly, instead of via gclient. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Is it possible to create branches?
What is the recommended procedure for working on long/big features? In the past, I've always created a separate branch and then done all my work there. I then do regular integrations from trunk into my branch to ensure that that my branch doesn't drift too far out of sync with the trunk (i.e. so as to minimize the amount of merge work I have to do when I'm ready to have my branch-specific changes reviewed and merged back into the trunk). However, being that chromium is hosted on a remote SVN server which I have no control over, what is the recommended way of doing dev? I'd really like to be able to do commits of my incremental work, but without a sep branch to fiddle around with, how can I accomplish this? All input and feedback welcome. Cheers, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is it possible to create branches?
Use git-svn? See http://code.google.com/p/chromium/wiki/UsingGit . On Tue, Jun 16, 2009 at 9:35 PM, Daniel Cowxdaniel.c...@gmail.com wrote: What is the recommended procedure for working on long/big features? In the past, I've always created a separate branch and then done all my work there. I then do regular integrations from trunk into my branch to ensure that that my branch doesn't drift too far out of sync with the trunk (i.e. so as to minimize the amount of merge work I have to do when I'm ready to have my branch-specific changes reviewed and merged back into the trunk). However, being that chromium is hosted on a remote SVN server which I have no control over, what is the recommended way of doing dev? I'd really like to be able to do commits of my incremental work, but without a sep branch to fiddle around with, how can I accomplish this? All input and feedback welcome. Cheers, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is it possible to create branches?
It might take a bit of getting used to, but git is a revision control tool that allows you to create your own personal branches. Many Chromium developers use it for their daily work. The way it interfaces with svn is a bit clunky, but if you're not committing very often, it probably won't matter much to you. That said, I'm not sure if you're going to be able to do work like you have on other projects. We take code reviews very seriously, and it's pretty hard to do code reviews except in small increments. This is partially because it's hard for a reviewer to understand all the elements of a large change. But it's also partially because a reviewers will have suggestions for how you could do things better. Even people who have been working on Chromium from the beginning still go through reviews and often need to tweak designs based on said reviews. One way or another, you'll need to figure out how to get from point A to point B in small increments. Sometimes I like to prototype in a branch and then re-implement it in the trunk as multiple smaller patches. This seems wasteful, but since you're not worrying about the details in the first phase and you know exactly what you need to do and how to do it in the second phase, it's actually not a bad way to go. If, on the other hand, you understand the path you want to take pretty well, then maybe you should just do it in the trunk. You can do it behind a run-time flag if necessary. Out of curiosity, what are you planning on working on? J On Tue, Jun 16, 2009 at 9:35 PM, Daniel Cowx daniel.c...@gmail.com wrote: What is the recommended procedure for working on long/big features? In the past, I've always created a separate branch and then done all my work there. I then do regular integrations from trunk into my branch to ensure that that my branch doesn't drift too far out of sync with the trunk (i.e. so as to minimize the amount of merge work I have to do when I'm ready to have my branch-specific changes reviewed and merged back into the trunk). However, being that chromium is hosted on a remote SVN server which I have no control over, what is the recommended way of doing dev? I'd really like to be able to do commits of my incremental work, but without a sep branch to fiddle around with, how can I accomplish this? All input and feedback welcome. Cheers, Daniel --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] git isn't sync'ing latest svn revisions for me
sorry to evanerg for the remail, my @google.com one bounced Hi, I dunno what's up, but git isn't sync'ing to the latest svn revisions for me: (21:37:35) willchan: any git experts around? (21:37:35) mdengfeng left the room (quit: Read error: 104 (Connection reset by peer)). (21:38:21) willchan: my git repo isn't syncing the latest svn revisions, gives me an error like (21:38:32) willchan: Index mismatch: ab650084ec5d9d308af33d7417442925d645a149 != 9951dd9bfdc1b0cecbad98604aaf9f3f28de27cc (21:38:59) markybob: heh, true, those are != :P (21:39:12) willchan: :) (21:39:24) dave_levin: willchan: I would delete that branch. (21:39:40) willchan: dave_levin: i created a new branch that had the same prob :( (21:39:42) dave_levin: then recreated it (21:39:45) dave_levin: oh (21:39:47) dave_levin: bummer (21:42:26) shenki: pulling the latest changes wfm (21:45:52) willchan: for some reason it seems i can only sync up to r18549 (21:46:48) shenki: that's not the latest commit? (21:46:54) willchan: no (21:46:57) shenki: oh (21:47:01) willchan: it's 6 hours ago (21:47:08) shenki: i assumed it was, as that's the latest im getting = willc...@panda:/usr/local/google/chromium4/src$ git checkout -b new_test origin Branch new_test set up to track remote branch refs/remotes/origin/trunk. Switched to a new branch new_test willc...@panda:/usr/local/google/chromium4/src$ git pull Already up-to-date. willc...@panda:/usr/local/google/chromium4/src$ git log -n5 commit 5aa424b09d8ee966947e69e82244550e40e4c787 Author: t...@chromium.org t...@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98 Date: Tue Jun 16 22:44:58 2009 + Add a small untility for checking to see if the X server is alive. This will be used by the buildbots after Xvfb is executated to make sure that Xvfb is alive. Review URL: http://codereview.chromium.org/126165 git-svn-id: svn://svn.chromium.org/chrome/trunk/s...@18549 0039d316-1c4b-4281-b951-d872f2087c98 ... willc...@panda:/usr/local/google/chromium4/src$ git svn fetch Index mismatch: ab650084ec5d9d308af33d7417442925d645a149 != 9951dd9bfdc1b0cecbad98604aaf9f3f28de27cc rereading 5aa424b09d8ee966947e69e82244550e40e4c787 A chrome/test/data/media/player.html A chrome/test/data/media/bear.mp4 A chrome/browser/media_uitest.cc Checksum mismatch: trunk/src/chrome/chrome.gyp c5184bb887fa26a89e4cd1894e6a9c96a866c020 expected: 0e4f507ffaca2f5c5070acfbc5cf2495 got: ad54c53174d56906eb5391091924f3dc === Can some git ninja help me out? Thanks :) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Is it possible to create branches?
On Tue, Jun 16, 2009 at 9:35 PM, Daniel Cowx daniel.c...@gmail.com wrote: What is the recommended procedure for working on long/big features? Make an off-by-default switch and write your code under the switch, in the trunk. Branches eventually have to be integrated. This is never as easy to review as simply writing the change in the trunk to begin with. Plus code review along the way is very useful. Perhaps you can locally do something without checking in just to make a rough prototype (if you must), but I would generally avoid working on a branch. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
