[chromium-dev] How can I tell if a Renderer process finishes loading a page

2010-01-09 Thread hap 497
In chromium, it has 2 parts: browser process and renderer process? How does the renderer process know the page is finished loading (all css/js are loaded, all images, and all frames/iframes are loaded? I have tried setting up breakpoints in RenderView::didFinishLoad(), but for a page with

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-09 Thread Victor Khimenko
On Sat, Jan 9, 2010 at 6:08 AM, Antoine Labour pi...@google.com wrote: How about: int fd = open(file_or_url, O_RDONLY); if (fd = 0) { close(fd); OpenLocalFile(file_or_url); } else { OpenURL(file_or_url); } Security risk. It's fine for interactive work (eve then it's risky), but

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-09 Thread Antoine Labour
On Sat, Jan 9, 2010 at 2:44 AM, Victor Khimenko k...@google.com wrote: On Sat, Jan 9, 2010 at 6:08 AM, Antoine Labour pi...@google.com wrote: How about: int fd = open(file_or_url, O_RDONLY); if (fd = 0) { close(fd); OpenLocalFile(file_or_url); } else { OpenURL(file_or_url); }

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-09 Thread Victor Khimenko
On Sat, Jan 9, 2010 at 2:55 PM, Antoine Labour pi...@google.com wrote: I'm not sure I understand the security risk... If an attacker is able to write files on my disk I have a lot more things to worry about than my browser spoofing urls. Are you sure? The idea is the same as with $PATH

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-09 Thread Pierre-Antoine LaFayette
Bash won't let me do this: $ mkdir https: mkdir: cannot create directory `https:': No such file or directory $ mkdir https: mkdir: cannot create directory `https:': No such file or director 2010/1/9 Victor Khimenko k...@google.com On Sat, Jan 9, 2010 at 2:55 PM, Antoine Labour

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-09 Thread Victor Khimenko
What OS is it? What FS ? I've checked with GHardy - everything works just fine. You can create filenames with :, , , etc. Anything except / but then it's compensated by the fact that duplicated slashes are ignored. Cygwin works too (starting from version 1.7 where support for POSIX FS namespace

Re: [chromium-dev] How can I tell if a Renderer process finishes loading a page

2010-01-09 Thread Peter Kasting
On Sat, Jan 9, 2010 at 12:15 AM, hap 497 hap...@gmail.com wrote: So how does renderer process knows the whole page is loaded completely and tell the browser process to stop the spinning icons and shows the favicon of the page? Sounds like you should start by looking in the browser for what

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-09 Thread Pierre-Antoine LaFayette
Actually it was Cygwin on Windows Vista (GNU bash, version 3.2.49(22)-release (i686-pc-cygwin) Copyright (C) 2007 Free Software Foundation, Inc.). However this isn't very important with regards to the point you're trying to make. I was just curious. 2010/1/9 Victor Khimenko k...@google.com What

Re: [chromium-dev] WebKit Gardeners 3 rebaseline.py -w

2010-01-09 Thread Eric Seidel
Once we have this sort of tool for webkit.org then those of us who work on webkit.org could just add the new baselines when we commit the patches in the first place. :) On Fri, Jan 8, 2010 at 5:38 PM, Julie Parent jpar...@chromium.org wrote: Yeah, me too. This is what tends to lead to me

Re: [chromium-dev] opening local files with chrome from command line, relative paths

2010-01-09 Thread Victor Khimenko
CygWin is not POSIX system. It tries to emulate POSIX as much as feasible but version 1.5, for example, does not even use POSIX filesystem namespace! Anyway I've checked: latest stable version (1.7.1-1) works just fine here. You can create directory http: - but it'll look really funny in Explorer

[chromium-dev] buildbot failure in Chromium on Chromium Mac Builder, revision 35883

2010-01-09 Thread buildbot
Automatically closing tree for compile on Chromium Mac Builder http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac%20Builder/builds/9220 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Mac%20Builder --= Automatically closing tree for compile on