[chromium-dev] PrefsService shared with OffTheRecordProfile

2009-11-25 Thread John Gregg
Hi, I was investigating how notifications should work in incognito mode, and came across the fact that the PrefsService for the incognito profile is the same one as the real profile. In some ways I guess that makes sense, since it's state about *how* the user uses the browser, not what the user

Re: [chromium-dev] PrefsService shared with OffTheRecordProfile

2009-11-25 Thread John Gregg
On Wed, Nov 25, 2009 at 12:26 PM, Peter Kasting pkast...@google.com wrote: On Wed, Nov 25, 2009 at 12:14 PM, Adam Barth aba...@chromium.org wrote: On Wed, Nov 25, 2009 at 11:38 AM, John Gregg john...@google.com wrote: if you whitelist an origin for popups while in incognito mode

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-09 Thread John Gregg
? Thanks for your help. Marcos On Thu, Nov 5, 2009 at 6:22 PM, Marcos Aruj marcos.a...@gmail.com wrote: Ok, done: http://www.crbug.com/26859 I attached a crx to the report that triggers the bug. Thanks! On Thu, Nov 5, 2009 at 5:19 PM, John Gregg john...@google.com wrote: Thanks

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-05 Thread John Gregg
, Darin Fisher da...@chromium.orgwrote: OK, that sounds reasonable to me. -Darin On Tue, Oct 20, 2009 at 9:51 AM, John Gregg john...@google.com wrote: Not precisely embedding a TabContents; I'm drawing a custom toast using views and putting a RenderViewHost+RenderWidgetHostView in it. -John

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-10-20 Thread John Gregg
AM, Ian Fette i...@chromium.org wrote: We're trying to come up with a way to display html notifications on these platforms, once we get the windows one checked in. (Likely code that we will have to write.) 2009/10/19 Evan Martin e...@chromium.org On Mon, Oct 19, 2009 at 11:16 AM, John Gregg

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-10-19 Thread John Gregg
The implementation of notifications is nearly complete for Windows chromium with the final pieces being reviewed right now. Hopefully it will be available on the dev channel very soon behind a command-line switch for developers to start using. If you have questions about the specifics of the API,

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-10-19 Thread John Gregg
I've posted the (draft) API spec to http://sites.google.com/a/chromium.org/dev/developers/design-documents/desktop-notifications/api-specification . -John On Mon, Oct 19, 2009 at 11:58 AM, Marcos Aruj marcos.a...@gmail.com wrote: Hi all, Thanks for your answer. @John Gregg, We would really

[chromium-dev] Changed WebKit build flags, may require clobber after sync

2009-10-05 Thread John Gregg
Hi all, I checked in a change yesterday which sets ENABLE_NOTIFICATIONS=1 for the Chromium build of WebKit (in features_override.gypi). If you sync up and are seeing linking errors regarding notifications, this should be fixed by rebuilding WebCore. Some of the build bots seem to be fine, but

[chromium-dev] Re: buildbot failure in Chromium on Linux Builder (Views dbg), revision 28054

2009-10-05 Thread John Gregg
Looks like a merge problem with my recent change to render_messages.h regarding WebPreferences. I can submit a fix. -John On Mon, Oct 5, 2009 at 3:03 PM, build...@chromium.org wrote: http://build.chromium.org/buildbot/waterfall/ Automatically closing tree for compile on Linux Builder

[chromium-dev] desktop notifications, preliminary code for review

2009-08-05 Thread John Gregg
Hi all, I'm still waiting for my WebKit patch which creates the Desktop Notification API to be reviewed and get checked in, but since it may yet be a while I posted some of the chromium-side code at http://codereview.appspot.com/104044/. As I mentioned to some of you offline, I would greatly

[chromium-dev] Re: desktop notifications, preliminary code for review

2009-08-05 Thread John Gregg
The plan for linux is to use libnotify, which is Growl-like, for text notifications, and possibly something we build for HTML balloon notifications which could be turned on or off by the user. Can you elaborate on what you mean by more broad? We think that offering a text version and an html

[chromium-dev] Re: desktop notifications, preliminary code for review

2009-08-05 Thread John Gregg
Sorry, maybe not. It's a big world to keep up to date! Between WHATWG, webkit-dev, and offline it's been discussed at some length at many levels, but not much on this list as I check the archives. But in any case, while the code patch is large as I said I consider it preliminary, and this is

[chromium-dev] sandboxing external libraries (like Growl)

2009-06-18 Thread John Gregg
Hi all, I'm working on a desktop notifications javascript API for web apps; on Mac these calls will go out to the Growl notification system if it's installed and user has granted permission to get notifications from that origin. I'm still trying to completely grasp the sandbox architecture, so

[chromium-dev] Re: sandboxing external libraries (like Growl)

2009-06-18 Thread John Gregg
Yes, on Linux the plan is the use the libnotify library, which is a DBus service. Thanks for all the responses; it's clear this needs to be thought of more like a system call than an untrusted library, and the better plan is to check inputs including icon data in the renderer as much as possible,

[chromium-dev] RenderViewHost::LoadAlternateHTMLString

2009-05-22 Thread John Gregg
I'm trying to load a static HTML string into a small render view (for the purpose of desktop notifications), and I came across the method RenderViewHost::LoadAlternateHTMLString, which, based on the name, sounds like what I want. I have things working the way I want if I call