Re: [chromium-dev] Don't use Empty[String,WString,String16,GURL]() unless you really need to

2010-01-07 Thread Michael Nordman
On Thu, Jan 7, 2010 at 4:02 PM, Darin Fisher da...@chromium.org wrote: On Thu, Jan 7, 2010 at 3:45 PM, Aaron Boodman a...@google.com wrote: On Thu, Jan 7, 2010 at 1:28 PM, Peter Kasting pkast...@google.com wrote: If you have ever used any of the EmptyXXX() functions, or ever will, please

[chromium-dev] WebKit roll status

2009-12-08 Thread Michael Nordman
Hi all, Just a note to let you know what's up with webkit rolls (or lack thereof) right now. We're at r51794 and have been for a while. Tip-of-tree webkit is at r51868. * All manner of svg tests are borked from some reason around r 51800, senorblanco is on that. * A couple of build breaks

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Michael Nordman
tracked at http://code.google.com/p/chromium/issues/detail?id=29737 Stephen On Tue, Dec 8, 2009 at 3:23 PM, Michael Nordman micha...@chromium.org wrote: Hi all, Just a note to let you know what's up with webkit rolls (or lack thereof) right now. We're at r51794 and have been

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Michael Nordman
Ah... thank you for the ptr. On Tue, Dec 8, 2009 at 1:00 PM, Adam Langley a...@chromium.org wrote: On Tue, Dec 8, 2009 at 12:55 PM, Michael Nordman micha...@chromium.org wrote: yikes 481 failures on linux... k... holding off rolling until we get a handle on the nature of the linux borkage

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Michael Nordman
Yes, It sounds like in all cases, there's going to be a big rebaseline-them-all-on-linux step at some point, the sooner the better. Given the nature of the problem (scrollbar drawing differences), lets roll and deal with the rebaselining seperately. But that should be done soonish, in the interim

Re: [chromium-dev] Profiles + SharedWorkers

2009-12-07 Thread Michael Nordman
I was wondering if worker processes have a profile affinity too. Eric's bringing up Databases in workers right now and databases are definitely per-profile. I'd vote to assert that a worker process only runs workers on behalf one profile, just like renderers. ResourceMessageFilter has a reference

[chromium-dev] Re: PSA: Virtual dispatch doesn't work (as you might expect) in destructors!

2009-10-30 Thread Michael Nordman
On Fri, Oct 30, 2009 at 3:46 PM, Scott Hess sh...@chromium.org wrote: Just to be clear for those of us who are wobbly on C++, this is because during the constructor or destructor, your object is of the class in question, NOT of the class it will finally be, because in the constructor the

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Michael Nordman
On Wed, Oct 14, 2009 at 4:42 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 3:50 PM, Adam Barth aba...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:48 PM, Michael Nordman micha...@google.com wrote: As mentioned f2f, this falls apart as soon as Chrome tries

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Michael Nordman
On Thu, Oct 15, 2009 at 11:45 AM, Jeremy Orlow jor...@chromium.org wrote: On Thu, Oct 15, 2009 at 11:33 AM, Michael Nordman micha...@google.comwrote: On Wed, Oct 14, 2009 at 4:42 PM, Darin Fisher da...@chromium.org wrote: On Wed, Oct 14, 2009 at 3:50 PM, Adam Barth aba...@chromium.org

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-15 Thread Michael Nordman
On Thu, Oct 15, 2009 at 12:16 PM, Michael Nordman micha...@google.comwrote: On Thu, Oct 15, 2009 at 11:45 AM, Jeremy Orlow jor...@chromium.orgwrote: On Thu, Oct 15, 2009 at 11:33 AM, Michael Nordman micha...@google.comwrote: On Wed, Oct 14, 2009 at 4:42 PM, Darin Fisher da

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Michael Nordman
+1 SecurityOrigin class Sounds like a reasonable plan. I suspect there may already be cases where we're actually comparing a chrome generated security origin, as produced by GURL.GetOrigin(), with a webkit generated security origin, as produced by WebSecurityOrigin.toString(). So we may want to

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Michael Nordman
On Wed, Oct 14, 2009 at 2:08 PM, Jeremy Orlow jor...@chromium.org wrote: On Wed, Oct 14, 2009 at 2:00 PM, Michael Nordman micha...@google.comwrote: +1 SecurityOrigin class Sounds like a reasonable plan. I suspect there may already be cases where we're actually comparing a chrome generated

[chromium-dev] Re: Is it time to create a SecurityOrigin class in Chromium?

2009-10-14 Thread Michael Nordman
: On Wed, Oct 14, 2009 at 2:23 PM, Darin Fisher da...@chromium.orgwrote: On Wed, Oct 14, 2009 at 2:08 PM, Jeremy Orlow jor...@chromium.orgwrote: On Wed, Oct 14, 2009 at 2:00 PM, Michael Nordman micha...@google.com wrote: +1 SecurityOrigin class Sounds like a reasonable plan. I suspect

[chromium-dev] Re: linux startup regression

2009-09-02 Thread Michael Nordman
There's is nothing platform specific about r25099, since other platforms don't show a hit... probably not it. r25112 - use x11_util::GetXWindowStack Does that load additional libraries? On Wed, Sep 2, 2009 at 6:41 PM, James Hawkins jhawk...@chromium.org wrote: Maybe r25099? I don't know

[chromium-dev] Re: Question about resource_dispatcher_host.h

2009-08-27 Thread Michael Nordman
On Thu, Aug 27, 2009 at 11:57 AM, hap 497 hap...@gmail.com wrote: On Mon, Aug 24, 2009 at 1:26 PM, John Abd-El-Malek j...@chromium.orgwrote: On Mon, Aug 24, 2009 at 1:06 PM, Brett Wilson bre...@chromium.orgwrote: On Mon, Aug 24, 2009 at 12:49 PM, hap 497hap...@gmail.com wrote: Thanks.

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Michael Nordman
Is the OS in the user-agent string? Mozilla/5.0 (*Windows*; U; Windows NT 6.0; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/3.0.195.6 Safari/532.0 There's a chance that http resource caches will contain data tweeked per OS. Maybe for cosmetic purposes... to make it look more OSX'y or

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Michael Nordman
+ chromium-dev (this time, sorry for the resend) Is the OS in the user-agent string? Mozilla/5.0 (*Windows*; U; Windows NT 6.0; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/3.0.195.6 Safari/532.0 There's a chance that http resource caches will contain data tweeked per OS. Maybe for

[chromium-dev] Re: tryserver flakiness

2009-08-12 Thread Michael Nordman
I just submitted the change that ENABLE's that flag a moment ago... we're clobbering things now On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow jor...@google.com wrote: Clobber needed? I know Michael just enabled this within the last 24 hours. On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr.

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Michael Nordman
These instructions turn src/third_party/WebKit into a full-fledged WebKit checkout Hallelujah... thank you for writing this up! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or

[chromium-dev] Re: LayoutTest unexpected success

2009-07-14 Thread Michael Nordman
I'd leave decisions about the worker related message port tests for drew and dimich... the feature isn't fully functional yet in chrome (even if they don't crash and happen to pass and such). I've been unable to dup the LayoutTests/fast/events/mouseover-mouseout2.html failure locally and have no

[chromium-dev] Fwd: 1) Roll WebKit DEPS to 45685...

2009-07-10 Thread Michael Nordman
the change in webkit. So we can't pick any new webkit changes w/o coming to terms with this change first. Ouch... just ran a local build and got a crashing YouTube page when navigating away... For now I'm NOT rolling DEPs :( -- From: *Michael Nordman* micha...@google.com Date: Thu, Jul 9

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-25 Thread Michael Nordman
2009/6/25 Fumitoshi Ukai (鵜飼文敏) u...@chromium.org Thanks for review. 2009/6/25 Michael Nordman micha...@google.com Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the chrome doc would be nice in the webkit doc too

[chromium-dev] Re: HTML5 Web Socket design doc

2009-06-24 Thread Michael Nordman
Only skimmed thusfar as well... but from what i've seen, looks reasonable to me. * A version of the diagram you have in the chrome doc would be nice in the webkit doc too. * Does WebSocketHandle really need to be refcounted. I know ResourceHandle is a refcounted object and this design looks

[chromium-dev] Re: does chromium care about appcache manifests?

2009-06-17 Thread Michael Nordman
Chromium has no behavior whatsoever yet... the feature is utterly unimplemented thus far... but it will have identical behavior to safari, iphone, andriod by virtue of the same code base performing those behaviors... thats the plan at least, and I'm working on the code now. Gears (i'm partly

[chromium-dev] Re: Difference between TestShell and Chromium

2009-06-09 Thread Michael Nordman
On Tue, Jun 9, 2009 at 12:34 PM, Daniel Dreiberg daniel.dreiber...@gmail.com wrote: Hi I understand TestShell is a test harness for running layout tests and a Chromium is a multi-process web browser. And I understand Chromium's browser thread does the I/O for each renderer process (using

[chromium-dev] Re: HTTP POST via net package?

2009-06-08 Thread Michael Nordman
If you're interested in seeing the multipart form data encoder, that's in WebCore. WebCore/platform/network/FormData.cpp h WebCore/platform/network/FormDataBuilder.cpp h In Chrome, the webcore FormData data type is translated to a chrome net::UploadData structure in WebRequestImpl::GetUploadData.

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some browser helper process

2009-04-30 Thread Michael Nordman
On Thu, Apr 30, 2009 at 11:40 AM, Darin Fisher da...@chromium.org wrote: On Tue, Apr 28, 2009 at 6:22 PM, Aaron Boodman a...@chromium.org wrote: On Tue, Apr 28, 2009 at 6:18 PM, Michael Nordman micha...@chromium.org wrote: + chromium-dev Can you please explain what you think has

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some browser helper process

2009-04-29 Thread Michael Nordman
dev. For workers, we thought about how/where it made sense to split the impl for chrome and talked with a...@webkit about it.  There was some iteration as we figured out things better and as he made suggestions and it has worked out fine so far. On Wed, Apr 29, 2009 at 11:49 AM, Michael

[chromium-dev] Re: Need to run parts of WebCore in either the browser process or some browser helper process

2009-04-28 Thread Michael Nordman
+ chromium-dev Can you please explain what you think has changed since such decisions were made (or why it's time to revisit such decisions)? I don't think there was code in webcore suitable for this purpose before... html parsing, javascript,sql interpretting... all dangerous from a

[chromium-dev] Re: localStorage design document - please offer feedback!

2009-04-15 Thread Michael Nordman
+ chromium-dev chromium-dev@googlegroups.com On Tue, Apr 14, 2009 at 9:36 AM, Darin Fisher da...@chromium.org wrote: DOM Storage Overview LGTM LocalStorage The exception is when a synchronous operation (synch XHR or alert() are examples) or when navigator.unlockStorage() is executed -- I

[chromium-dev] Re: Need advice on where localStorage should live

2009-03-23 Thread Michael Nordman
+chromium-dev On Mon, Mar 23, 2009 at 12:03 PM, Darin Fisher da...@chromium.org wrote: On Fri, Mar 20, 2009 at 7:04 PM, Jeremy Orlow jor...@chromium.org wrote: *If you don't care where various bits of the localStorage implementation live and you aren't scared about letting stuff out of the

[chromium-dev] Re: Need advice on where localStorage should live

2009-03-21 Thread Michael Nordman
+chromium-dev. On Sat, Mar 21, 2009 at 9:30 AM, John Abd-El-Malek j...@chromium.org wrote: On Fri, Mar 20, 2009 at 7:04 PM, Jeremy Orlow jor...@chromium.org wrote: *If you don't care where various bits of the localStorage implementation live and you aren't scared about letting stuff out of