[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-24 Thread zeniko
On Aug 24, 3:58 am, Peter Kasting pkast...@google.com wrote: We already have this since web pages take over things like ctrl-w and ctrl-f (and we wouldn't want to change that since in many cases it's important that they do so). AFAICT, at least Alt+Shift+T and Alt+D seem not to be preventable

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-24 Thread Peter Kasting
On Sun, Aug 23, 2009 at 11:14 PM, zeniko zen...@gmail.com wrote: Then again: Is accessibility one of the goals for Chrome at all? Or is it just not tested for for lack of manpower? As it currently stands, it can get quite frustrating to use without a mouse (double accesskeys in menus, no

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-24 Thread zeniko
On Aug 24, 7:42 pm, Peter Kasting pkast...@google.com wrote: Please file bugs on all these. Filed http://code.google.com/p/chromium/issues/detail?id=20086 , http://code.google.com/p/chromium/issues/detail?id=20160 , http://code.google.com/p/chromium/issues/detail?id=20164 ,

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-24 Thread Evan Stade
On Sat, Aug 22, 2009 at 6:18 PM, Evan Martine...@chromium.org wrote: On Fri, Aug 21, 2009 at 11:05 PM, zenikozen...@gmail.com wrote: If you e.g. use Alt+F for Chrome, you break quick access to Wikipedia's in-page search box. It's already the case that if a page grabs a key it overrides the

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-23 Thread zeniko
On Aug 23, 3:18 am, Evan Martin e...@chromium.org wrote: It's already the case that if a page grabs a key it overrides the Chrome shortcut, so this would actually work properly with no additional effort. In that case, the issue is that the menu shortcuts won't work reliably, which (1) can get

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-23 Thread zeniko
On Aug 23, 2:45 am, Peter Kasting pkast...@google.com wrote: At least IE and Firefox already map this, so I don't think this is a big loss for web pages. It isn't a loss for web pages but for users relying on the keyboard (think handicapped users or netbook users without a proper mouse). And

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-23 Thread PhistucK
Are you saying a website cannot use such combination as well? (Alt+Shift+AccessKey) ☆PhistucK On Sun, Aug 23, 2009 at 10:00, zeniko zen...@gmail.com wrote: On Aug 23, 2:45 am, Peter Kasting pkast...@google.com wrote: At least IE and Firefox already map this, so I don't think this is a big

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-23 Thread Peter Kasting
On Sat, Aug 22, 2009 at 11:57 PM, zeniko zen...@gmail.com wrote: In that case, the issue is that the menu shortcuts won't work reliably, which (1) can get quite frustrating because you never really know what a shortcut will do and (2) leads to the menus or other core functionality remaining

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-22 Thread zeniko
On Aug 21, 10:20 pm, Peter Kasting pkast...@google.com wrote: Windows native behavior is that hitting alt+accesskey opens the menu in question. Do we really want to follow native behavior in this place? Websites use Alt+accesskey as well, and every combo you reserve for Chrome won't (or at

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-22 Thread Peter Kasting
On Fri, Aug 21, 2009 at 11:05 PM, zeniko zen...@gmail.com wrote: On Aug 21, 10:20 pm, Peter Kasting pkast...@google.com wrote: Windows native behavior is that hitting alt+accesskey opens the menu in question. Websites use Alt+accesskey as well, and every combo you reserve for Chrome

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-22 Thread Evan Martin
On Fri, Aug 21, 2009 at 11:05 PM, zenikozen...@gmail.com wrote: If you e.g. use Alt+F for Chrome, you break quick access to Wikipedia's in-page search box. It's already the case that if a page grabs a key it overrides the Chrome shortcut, so this would actually work properly with no additional

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-21 Thread Mohamed Mansour
Let me summarize what you all have stated: - ALT: Highlight App menu button - ALT-P: Show Page menu - ALT-A: Show App menu or.. - ALT: Highlight App menu button - ALT-P: Highlight Page menu button - ALT-A: Highlight App menu button First set or second set? Thanks! -

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-21 Thread Mohamed Mansour
I really want to name it tools as Peter stated, If anyone has any objections, please let me know, it will now be: ALT-T = Tools Menu (previously known as App menu) ALT-P = Page Menu. The only difference within these sets is that within the first set, it shows the menu (the menu popup will be

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-21 Thread Peter Kasting
On Fri, Aug 21, 2009 at 1:17 PM, Mohamed Mansour m...@chromium.org wrote: I really want to name it tools as Peter stated, If anyone has any objections, please let me know, it will now be: ALT-T = Tools Menu (previously known as App menu) ALT-P = Page Menu. The only difference within these

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-21 Thread Peter Kasting
On Fri, Aug 21, 2009 at 11:41 AM, Mohamed Mansour m...@chromium.org wrote: Let me summarize what you all have stated: - ALT: Highlight App menu button - ALT-P: Show Page menu - ALT-A: Show App menu or.. - ALT: Highlight App menu button - ALT-P: Highlight Page menu button

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-20 Thread Evan Martin
For what it's worth, Alt-F is already used by extensions like FlashBlock for Chrome: http://userscripts.org/scripts/show/46673 On Wed, Aug 19, 2009 at 4:33 PM, Peter Kastingpkast...@google.com wrote: On Wed, Aug 19, 2009 at 4:31 PM, Mohamed Mansour m...@chromium.org wrote: Are you guys

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-19 Thread Nick Baum
I agree with Ben and Peter, alt should highlight the wrench menu. -Nick On Tue, Aug 18, 2009 at 9:43 PM, Peter Kasting pkast...@google.com wrote: On Tue, Aug 18, 2009 at 9:40 PM, Evan Stade est...@chromium.org wrote: Also, I don't really care which one alt highlights, but it seems to me that

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-19 Thread Glen Murphy
Highlighting the Tools menu is important for a similar reason that hooking it to alt-f instead of alt-t is: people have ingrained key combos like alt-f, x or alt, enter, x that they expect to work. Or alt-f+s, or alt-f+p Oh wait. --~--~-~--~~~---~--~~

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-19 Thread Peter Kasting
On Wed, Aug 19, 2009 at 4:31 PM, Mohamed Mansour m...@chromium.org wrote: Are you guys referring to alt alone or alt-f, alt-e to highlight the menu item?. alt-f if triggered appropriately brings up full screen which is another problem ... Alt alone. Fullscreen is F11 on Windows, not

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-19 Thread Peter Kasting
On Wed, Aug 19, 2009 at 4:30 PM, Glen Murphy g...@chromium.org wrote: Highlighting the Tools menu is important for a similar reason that hooking it to alt-f instead of alt-t is: people have ingrained key combos like alt-f, x or alt, enter, x that they expect to work. Or alt-f+s, or

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-19 Thread Mohamed Mansour
Are you guys referring to alt alone or alt-f, alt-e to highlight the menu item?. alt-f if triggered appropriately brings up full screen which is another problem ... - Mohamed Mansour On Wed, Aug 19, 2009 at 7:01 PM, Nick Baum nickb...@chromium.org wrote: I agree with Ben and Peter, alt

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-18 Thread Ben Goodger (Google)
I'm not sure about accesskeys, but my feeling is just pressing Alt should definitely hilight the one of the two menus. -Ben On Tue, Aug 18, 2009 at 8:11 PM, Mohamed Mansourm...@chromium.org wrote: Hi all, Currently, all the functionality in Chrome toolbar has a keyboard shortcut connected to

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-18 Thread Evan Stade
on linux we do alt+e for page menu and alt+f for wrench menu. The reasoning is that these two menus are reasonable approximations of the Edit and File menus, respectively. -- Evan Stade On Tue, Aug 18, 2009 at 8:14 PM, Ben Goodger (Google)b...@chromium.org wrote: I'm not sure about

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-18 Thread Ben Goodger (Google)
sgtm. -Ben On Tue, Aug 18, 2009 at 8:32 PM, Evan Stadeest...@chromium.org wrote: on linux we do alt+e for page menu and alt+f for wrench menu. The reasoning is that these two menus are reasonable approximations of the Edit and File menus, respectively. -- Evan Stade On Tue, Aug 18,

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-18 Thread Mohamed Mansour
Alright, I have changed it to use alt+e and alt+f. http://codereview.chromium.org/174044/show http://codereview.chromium.org/174044/showWould be nice if a user presses just alt and it would bring up the default main menu. The page menu is used more than the app menu. Would be nice to incorporate

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-18 Thread Ben Goodger (Google)
Is the page menu really used more than the app menu? If the keys correspond to file/edit equivs, that would suggest wrench should be default. -Ben On Tue, Aug 18, 2009 at 9:20 PM, Mohamed Mansourm...@chromium.org wrote: Alright, I have changed it to use alt+e and alt+f.

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-18 Thread Peter Kasting
On Tue, Aug 18, 2009 at 9:20 PM, Mohamed Mansour m...@chromium.org wrote: Would be nice if a user presses just alt and it would bring up the default main menu. The page menu is used more than the app menu. Would be nice to incorporate that into Chromium. What do you all think? Please copy

[chromium-dev] Re: Access keys for Chrome menus, what do you prefer?

2009-08-18 Thread Evan Stade
btw, alt alone appears to do nothing for gtk apps. Also, I don't really care which one alt highlights, but it seems to me that alt just highlights the leftmost menu. This happens to always be File. If the File menu is not leftmost, then it's unclear which should be highlighted. -- Evan Stade