[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-21 Thread Peter Kasting
On Tue, Jul 21, 2009 at 3:56 PM, Jeremy Orlow wrote: > I was suggesting that any scripts that depend on the eol style could set > the flag on any files it's touching. For example, svn-create-patch could > set it on all the files that have been modified. This could even be done > only when runni

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-21 Thread Jeremy Orlow
On Tue, Jul 21, 2009 at 3:48 PM, Peter Kasting wrote: > On Tue, Jul 21, 2009 at 3:40 PM, Jeremy Orlow wrote: > >> Therefore, once those four patches land (might be a little while, one may >>> cause problems for Apple folks), I claim that this setup is finally ready >>> for Windows developers to u

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-21 Thread Peter Kasting
On Tue, Jul 21, 2009 at 3:40 PM, Jeremy Orlow wrote: > Therefore, once those four patches land (might be a little while, one may >> cause problems for Apple folks), I claim that this setup is finally ready >> for Windows developers to use. There are still a few rough edges (creating >> patches t

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-21 Thread Darin Fisher
On Tue, Jul 21, 2009 at 3:35 PM, Peter Kasting wrote: > On Wed, Jul 15, 2009 at 12:39 PM, Adam Barth wrote: > >> Thanks to some recent work by Dimitri, Victor, and others, hacking on >> WebKit is now easier than ever. If you work on WebKit and Chromium, I >> recommend using a hybrid source tree:

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-21 Thread Jeremy Orlow
On Tue, Jul 21, 2009 at 3:35 PM, Peter Kasting wrote: > On Wed, Jul 15, 2009 at 12:39 PM, Adam Barth wrote: > >> Thanks to some recent work by Dimitri, Victor, and others, hacking on >> WebKit is now easier than ever. If you work on WebKit and Chromium, I >> recommend using a hybrid source tree:

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-21 Thread Peter Kasting
On Wed, Jul 15, 2009 at 12:39 PM, Adam Barth wrote: > Thanks to some recent work by Dimitri, Victor, and others, hacking on > WebKit is now easier than ever. If you work on WebKit and Chromium, I > recommend using a hybrid source tree: > > http://dev.chromium.org/developers/contributing-to-webki

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-16 Thread Peter Kasting
On Thu, Jul 16, 2009 at 4:31 PM, Peter Kasting wrote: > prepare-ChangeLog, svn-create-patch, and commit-log-editor all work now, > except that I still have an outstanding review for a change to make > svn-create-patch not get confused about where the repository root for WebKit > is. > This is now

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-16 Thread Peter Kasting
On Wed, Jul 15, 2009 at 5:28 PM, Peter Kasting wrote: > I am now working on this upstream at > https://bugs.webkit.org/show_bug.cgi?id=27323 . > I have just checked in some changes that should help a bit. Builds should get farther than before (I haven't fixed all issues here) because all shell s

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Peter Kasting
On Wed, Jul 15, 2009 at 2:49 PM, Peter Kasting wrote: > On Wed, Jul 15, 2009 at 12:57 PM, Peter Kasting wrote: > >> This is my concern. A number of WebKit things at least used to only work >> with a Cygwin SVN checkout. >> > > Sadly, it looks as if this is still the case. Using Adam's instructio

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Peter Kasting
On Wed, Jul 15, 2009 at 12:57 PM, Peter Kasting wrote: > This is my concern. A number of WebKit things at least used to only work > with a Cygwin SVN checkout. > Sadly, it looks as if this is still the case. Using Adam's instructions on Windows results in a WebKit checkout where scripts like bu

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Michael Nordman
> These instructions turn src/third_party/WebKit into a full-fledged WebKit checkout Hallelujah... thank you for writing this up! --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscri

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Adam Barth
On Wed, Jul 15, 2009 at 1:55 PM, Adam Barth wrote: > On Wed, Jul 15, 2009 at 1:53 PM, Peter Kasting wrote: >> On Wed, Jul 15, 2009 at 1:45 PM, Adam Barth wrote: >>> >>> Maybe try removing those directories from your .gclient_entries file? >> >> This fixed things.  Updated the directions.  Also no

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Adam Barth
On Wed, Jul 15, 2009 at 1:53 PM, Peter Kasting wrote: > On Wed, Jul 15, 2009 at 1:45 PM, Adam Barth wrote: >> >> Maybe try removing those directories from your .gclient_entries file? > > This fixed things.  Updated the directions.  Also noted that people should > still run update-webkit at least

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Darin Fisher
On Wed, Jul 15, 2009 at 1:45 PM, Adam Barth wrote: > > On Wed, Jul 15, 2009 at 1:40 PM, Peter Kasting > wrote: > > On Wed, Jul 15, 2009 at 1:34 PM, Adam Barth wrote: > >> > >> On Wed, Jul 15, 2009 at 12:57 PM, Peter Kasting > >> wrote: > >> > I am still confused. > >> > >> I recommend the experi

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Peter Kasting
On Wed, Jul 15, 2009 at 1:45 PM, Adam Barth wrote: > Maybe try removing those directories from your .gclient_entries file? > This fixed things. Updated the directions. Also noted that people should still run update-webkit at least once (for the WebKitLibraries install step). PK --~--~---

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread 王重傑
On Wed, Jul 15, 2009 at 1:45 PM, Adam Barth wrote: > > On Wed, Jul 15, 2009 at 1:40 PM, Peter Kasting > wrote: > > On Wed, Jul 15, 2009 at 1:34 PM, Adam Barth wrote: > >> > >> On Wed, Jul 15, 2009 at 12:57 PM, Peter Kasting > >> wrote: > >> > I am still confused. > >> > >> I recommend the experi

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Evan Martin
On Wed, Jul 15, 2009 at 1:40 PM, Peter Kasting wrote: > On Wed, Jul 15, 2009 at 1:34 PM, Adam Barth wrote: >> >> On Wed, Jul 15, 2009 at 12:57 PM, Peter Kasting >> wrote: >> > I am still confused. >> >> I recommend the experimental method.  If you have trouble, we can try >> to figure out what's

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Adam Barth
On Wed, Jul 15, 2009 at 1:40 PM, Peter Kasting wrote: > On Wed, Jul 15, 2009 at 1:34 PM, Adam Barth wrote: >> >> On Wed, Jul 15, 2009 at 12:57 PM, Peter Kasting >> wrote: >> > I am still confused. >> >> I recommend the experimental method.  If you have trouble, we can try >> to figure out what's

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Peter Kasting
On Wed, Jul 15, 2009 at 1:34 PM, Adam Barth wrote: > On Wed, Jul 15, 2009 at 12:57 PM, Peter Kasting > wrote: > > I am still confused. > > I recommend the experimental method. If you have trouble, we can try > to figure out what's different between your setup and my setup. OK, first problem: I

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Adam Barth
On Wed, Jul 15, 2009 at 12:57 PM, Peter Kasting wrote: > I am still confused. I recommend the experimental method. If you have trouble, we can try to figure out what's different between your setup and my setup. Adam --~--~-~--~~~---~--~~ Chromium Developers mail

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Peter Kasting
On Wed, Jul 15, 2009 at 12:50 PM, Adam Barth wrote: > I think gclient uses the depot_tools one to update the files, but the > WebKitTools/Scripts use the svn in your path (for me, the Cygwin one) > for svn status, diff, commit, etc. Yes, this is true. This is why I was asking. It might be key

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Adam Barth
On Wed, Jul 15, 2009 at 12:44 PM, Peter Kasting wrote: > On Wed, Jul 15, 2009 at 12:39 PM, Adam Barth wrote: >> Thanks to some recent work by Dimitri, Victor, and others, hacking on >> WebKit is now easier than ever.  If you work on WebKit and Chromium, I >> recommend using a hybrid source tree:

[chromium-dev] Re: Hacking on WebKit is easier than ever

2009-07-15 Thread Peter Kasting
On Wed, Jul 15, 2009 at 12:39 PM, Adam Barth wrote: > Thanks to some recent work by Dimitri, Victor, and others, hacking on > WebKit is now easier than ever. If you work on WebKit and Chromium, I > recommend using a hybrid source tree: > > http://dev.chromium.org/developers/contributing-to-webki