[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.

2009-04-08 Thread Scott Hess
I can see how that's happening in pref_service_uitest.cc and memory_test.cc, but AFAICT I don't see how it's being done generally for ui_tests test cases. Perhaps it's that --user-data-dir should be passed to ui_tests itself, which means if you run ui_tests without that flag, it will still use yo

[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.

2009-04-08 Thread Evan Martin
Note that a NOTIMPLEMENTED() prints when the code runs that tries to abort when Chromium is already running. One thing that I think has helped us on Linux is reducing the NOTIMPLEMENTED prints to the bare minimum -- for stuff that we know is broken (like the "star" button on the toolbar) having i

[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.

2009-04-08 Thread Scott Hess
That would be my expectation, too. Like I said, I think this is a known issue (the Mac port's profile stuff is sort of wired together). -scott On Wed, Apr 8, 2009 at 11:21 AM, Darin Fisher wrote: > Maybe this is well known, but what we did to avoid this problem on Windows > is to leverage the

[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.

2009-04-08 Thread Darin Fisher
Also, unless you do something like this, it ends up being difficult for developers to dogfood the product, or if they do try to dogfood the product, then they are strongly inscentivized not to run the ui_tests. Neither option is good. -Darin On Wed, Apr 8, 2009 at 11:21 AM, Darin Fisher wrote:

[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.

2009-04-08 Thread Scott Hess
With this response, I have reached enlightenment! On Wed, Apr 8, 2009 at 11:20 AM, Evan Martin wrote: > On Wed, Apr 8, 2009 at 11:10 AM, Scott Hess wrote: >> It occurs to me that if you ran ui_tests while running Chromium.app, >> or two ui_tests, you may also see strange and wonderful results.

[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.

2009-04-08 Thread Darin Fisher
Maybe this is well known, but what we did to avoid this problem on Windows is to leverage the --user-data-dir command line switch to force the chrome instance launched by the ui_tests to use a dedicated user data directory. We toss that directory prior to each test case IIRC. -Darin On Wed, Apr

[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.

2009-04-08 Thread Evan Martin
On Wed, Apr 8, 2009 at 11:10 AM, Scott Hess wrote: > It occurs to me that if you ran ui_tests while running Chromium.app, > or two ui_tests, you may also see strange and wonderful results. This depends on the Pawel patch I mentioned in my previous mail. Current code looks like: void UITest::As