[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.
Also, unless you do something like this, it ends up being difficult for developers to dogfood the product, or if they do try to dogfood the product, then they are strongly inscentivized not to run the ui_tests. Neither option is good. -Darin On Wed, Apr 8, 2009 at 11:21 AM, Darin Fisher da...@chromium.org wrote: Maybe this is well known, but what we did to avoid this problem on Windows is to leverage the --user-data-dir command line switch to force the chrome instance launched by the ui_tests to use a dedicated user data directory. We toss that directory prior to each test case IIRC. -Darin On Wed, Apr 8, 2009 at 11:10 AM, Scott Hess sh...@chromium.org wrote: I posted this on the irc channel yesterday, I know at least Peter noticed, but John suggested something more overt. When you run ui_tests on Mac, you will blow away some fraction of your Chromium.app profile. Things like history and bookmarks. This is a known issue, but may not be a known consequence. If anyone wants to circle back and fix profiles, that would be wonderous. I was thinking of looking at it myself, but am instead trying to figure out where my omnibox stuff is going wrong. It occurs to me that if you ran ui_tests while running Chromium.app, or two ui_tests, you may also see strange and wonderful results. -scott --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.
Note that a NOTIMPLEMENTED() prints when the code runs that tries to abort when Chromium is already running. One thing that I think has helped us on Linux is reducing the NOTIMPLEMENTED prints to the bare minimum -- for stuff that we know is broken (like the star button on the toolbar) having it print out a warning on every page load masks important printouts like the one above. I have converted many such printouts into bugs instead (it's obvious the star button doesn't* work if you click on it). If you do the same, please be sure to tag it with the relevant OS labels if it affects more than just Mac. :) * I think ours actually does work now; just an example. On Wed, Apr 8, 2009 at 11:23 AM, Scott Hess sh...@chromium.org wrote: That would be my expectation, too. Like I said, I think this is a known issue (the Mac port's profile stuff is sort of wired together). -scott On Wed, Apr 8, 2009 at 11:21 AM, Darin Fisher da...@chromium.org wrote: Maybe this is well known, but what we did to avoid this problem on Windows is to leverage the --user-data-dir command line switch to force the chrome instance launched by the ui_tests to use a dedicated user data directory. We toss that directory prior to each test case IIRC. -Darin On Wed, Apr 8, 2009 at 11:10 AM, Scott Hess sh...@chromium.org wrote: I posted this on the irc channel yesterday, I know at least Peter noticed, but John suggested something more overt. When you run ui_tests on Mac, you will blow away some fraction of your Chromium.app profile. Things like history and bookmarks. This is a known issue, but may not be a known consequence. If anyone wants to circle back and fix profiles, that would be wonderous. I was thinking of looking at it myself, but am instead trying to figure out where my omnibox stuff is going wrong. It occurs to me that if you ran ui_tests while running Chromium.app, or two ui_tests, you may also see strange and wonderful results. -scott --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac ui_tests blows away from fraction of your profile.
I can see how that's happening in pref_service_uitest.cc and memory_test.cc, but AFAICT I don't see how it's being done generally for ui_tests test cases. Perhaps it's that --user-data-dir should be passed to ui_tests itself, which means if you run ui_tests without that flag, it will still use your default profile. Or maybe I misunderstand entirely. BTW, I was just stupid when I thought that Mac was broken because of being hacked together. Some of the profile setup is certainly hacked together, but as far as I can tell, it does the right thing for --user-data-dir (though having it fall back to the default dir when the provided one doesn't exist threw me for awhile, that seems unexpected). -scott On Wed, Apr 8, 2009 at 11:23 AM, Darin Fisher da...@chromium.org wrote: Also, unless you do something like this, it ends up being difficult for developers to dogfood the product, or if they do try to dogfood the product, then they are strongly inscentivized not to run the ui_tests. Neither option is good. -Darin On Wed, Apr 8, 2009 at 11:21 AM, Darin Fisher da...@chromium.org wrote: Maybe this is well known, but what we did to avoid this problem on Windows is to leverage the --user-data-dir command line switch to force the chrome instance launched by the ui_tests to use a dedicated user data directory. We toss that directory prior to each test case IIRC. -Darin On Wed, Apr 8, 2009 at 11:10 AM, Scott Hess sh...@chromium.org wrote: I posted this on the irc channel yesterday, I know at least Peter noticed, but John suggested something more overt. When you run ui_tests on Mac, you will blow away some fraction of your Chromium.app profile. Things like history and bookmarks. This is a known issue, but may not be a known consequence. If anyone wants to circle back and fix profiles, that would be wonderous. I was thinking of looking at it myself, but am instead trying to figure out where my omnibox stuff is going wrong. It occurs to me that if you ran ui_tests while running Chromium.app, or two ui_tests, you may also see strange and wonderful results. -scott --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
