[chromium-dev] Inline PDF Support

2009-03-03 Thread Daniel
Hi guys, Are there any plans to support the viewing of PDF documents (inline/ natively) within chromium without the need for an external app/plugin like acrobat...i.e. kinda like how Safari does it on mac? alternatively, some manner of first converting them to PNG/HTML/etc?

[chromium-dev] Re: Mac Dogfood Planning

2009-03-03 Thread Jeremy Moskovich
I'll tackle breakpad support, if anyone else is already working on this, please ping me. Best regards, Jeremy On Mon, Mar 2, 2009 at 9:27 PM, Mike Pinkerton pinker...@chromium.orgwrote: As we're making rapid progress, I wanted to start to organize a little more around the 5 minute browser

[chromium-dev] App Mode

2009-03-03 Thread Thomas Van Lenten
Is there a design doc/notes/etc. for App Mode on Windows? I'm starting to look at it for the Mac because there could be some arch issues we'll have to deal w/, so I want to understand the Windows side first. TVL --~--~-~--~~~---~--~~ Chromium Developers mailing

[chromium-dev] Re: App Mode

2009-03-03 Thread Ben Goodger (Google)
Short answer: no. But talk to me if you need to know more about the Chrome side. Some elements of it are implemented in Gears - specifically the shortcut creation step. -Ben On Tue, Mar 3, 2009 at 10:56 AM, Thomas Van Lenten thoma...@chromium.org wrote: Is there a design doc/notes/etc. for App

[chromium-dev] Need an idiot's guide to GYP

2009-03-03 Thread Mike Belshe
I probably missed the email on the new Mac build system. (I was gypped!) So I went to http://dev.chromium.org/developers/quick-reference to try to learn how to add a file to the mac port. But alas, it just talks about xcodeproj. And of course, GMail search doesn't work, so I can't find any doc

[chromium-dev] Linux TabStrip design doc 3-3-09

2009-03-03 Thread James Hawkins
Hi, We on the Linux team have settled on a TabStrip design that will allow us to share as much code as possible without having to reimplement Views, which would take a considerable amount of time and effort. The TabStrip interfaces will be refactored to have cross-platform super-classes and

[chromium-dev] Re: Linux TabStrip design doc 3-3-09

2009-03-03 Thread Ben Goodger (Google)
Can you give a more detailed breakdown of the code/methods that'll be moved to the shared base? -Ben On Tue, Mar 3, 2009 at 11:32 AM, James Hawkins jhawk...@chromium.org wrote: Hi, We on the Linux team have settled on a TabStrip design that will allow us to share as much code as possible

[chromium-dev] Re: Linux TabStrip design doc 3-3-09

2009-03-03 Thread James Hawkins
On Tue, Mar 3, 2009 at 11:36 AM, Ben Goodger (Google) b...@chromium.org wrote: Can you give a more detailed breakdown of the code/methods that'll be moved to the shared base? To be shared: * All of the TabAnimation classes. * The following methods: - GetPreferredHeight -

[chromium-dev] Re: Need an idiot's guide to GYP

2009-03-03 Thread Mike Belshe
The answer to this question lies in the thread Let's make build system history. I've minimally updated the wiki page below. We should expand the gyp docs as it gets more mature. Mike On Tue, Mar 3, 2009 at 11:22 AM, Mike Belshe mbel...@google.com wrote: I probably missed the email on the new

[chromium-dev] Re: Need an idiot's guide to GYP

2009-03-03 Thread Mark Mentovai
I'm working on documenting everything this week. There's some stuff at http://code.google.com/p/gyp/w/list now. Mike Belshe wrote: I probably missed the email on the new Mac build system.  (I was gypped!) So I went to http://dev.chromium.org/developers/quick-reference to try to learn how to

[chromium-dev] Re: Linux TabStrip design doc 3-3-09

2009-03-03 Thread Ben Goodger (Google)
Because you're reusing display methods that retrieve metrics, I assume your tabstrip will have exactly the same bounds for itself and its contents as the windows one? -Ben On Tue, Mar 3, 2009 at 11:49 AM, James Hawkins jhawk...@chromium.org wrote: On Tue, Mar 3, 2009 at 11:36 AM, Ben Goodger

[chromium-dev] Re: Linux TabStrip design doc 3-3-09

2009-03-03 Thread James Hawkins
Yes that is the case. On Tue, Mar 3, 2009 at 1:57 PM, Ben Goodger (Google) b...@chromium.org wrote: Because you're reusing display methods that retrieve metrics, I assume your tabstrip will have exactly the same bounds for itself and its contents as the windows one? -Ben On Tue, Mar 3,

[chromium-dev] Re: Linux TabStrip design doc 3-3-09

2009-03-03 Thread Ben Goodger (Google)
OK. I understand what you're doing. I still don't understand then why given the identical rendering on Windows and Linux why is this approach easier than using Views/Canvas for that last 15% (rendering, hit testing)? Sorry to keep harping on this but the Mac display tree is totally different

[chromium-dev] Re: Linux TabStrip design doc 3-3-09

2009-03-03 Thread Ben Goodger (Google)
I chatted with Evan as well and he's said there's going to be linux-specific rendering in some components of the UI so that answers my question. -Ben On Tue, Mar 3, 2009 at 2:33 PM, James Hawkins jhawk...@chromium.org wrote: Our initial estimation is that it would take significantly longer to

[chromium-dev] Unit tests and anonymous namespaces.

2009-03-03 Thread Scott Hess
On the Mac, code like this: namespace { class MyTest : public testing::Test { }; } // namespace TEST_F(MyTest, ATest) { } generates errors like this: warning: ‘MyTest_ATest_Test’ has a field ‘MyTest_ATest_Test::anonymous’ whose type uses the anonymous namespace warning: ‘MyTest_ATest_Test’

[chromium-dev] Re: Unit tests and anonymous namespaces.

2009-03-03 Thread Brett Wilson
On Tue, Mar 3, 2009 at 3:55 PM, Scott Hess sh...@chromium.org wrote: On the Mac, code like this: namespace { class MyTest : public testing::Test { }; }  // namespace TEST_F(MyTest, ATest) { } generates errors like this: warning: ‘MyTest_ATest_Test’ has a field

[chromium-dev] Re: Unit tests and anonymous namespaces.

2009-03-03 Thread Darin Fisher
On Tue, Mar 3, 2009 at 3:55 PM, Scott Hess sh...@chromium.org wrote: On the Mac, code like this: namespace { class MyTest : public testing::Test { }; } // namespace TEST_F(MyTest, ATest) { } generates errors like this: warning: ‘MyTest_ATest_Test’ has a field

[chromium-dev] Re: Unit tests and anonymous namespaces.

2009-03-03 Thread 陈智昌
My old team never really used FRIEND_TEST. We found it ugly that our production code depended on test code. We typically used friended Peer classes defined in the unittest file, but not in the anonymous namespace. These are simple shims that provide access to the private section. It also

[chromium-dev] Re: Unit tests and anonymous namespaces.

2009-03-03 Thread Darin Fisher
That sounds like an even better solution, thanks!-Darin On Tue, Mar 3, 2009 at 4:49 PM, William Chan (陈智昌) willc...@chromium.orgwrote: My old team never really used FRIEND_TEST. We found it ugly that our production code depended on test code. We typically used friended Peer classes defined

[chromium-dev] Re: Unit tests and anonymous namespaces.

2009-03-03 Thread Brett Wilson
On Tue, Mar 3, 2009 at 4:49 PM, William Chan (陈智昌) willc...@chromium.org wrote: My old team never really used FRIEND_TEST. We found it ugly that our production code depended on test code. We typically used friended Peer classes defined in the unittest file, but not in the anonymous

[chromium-dev] Re: Ideas from chromium-discuss that should be implementable as extensions (Message #1 of an infinite series)

2009-03-03 Thread dhhwai
And to make the first post more easily viewable, the hidden quoted text says: I've used google chrome as my main web browser for some time, because I like its simplicity and compact nature. nowadays everyone has, or is getting a widescreen computer monitor and google chrome is nice in that it

[chromium-dev] Re: Inline PDF Support

2009-03-03 Thread Evan Martin
On Tue, Mar 3, 2009 at 8:47 PM, DanielC dpc...@hotmail.com wrote: - Thanks for your reply. I was mainly just hoping we might get something for free with webkit, but it sounds like the PDF support in Safari is native OS support. Alas, I was hoping to find a simple PDF viewer or at least a

[chromium-dev] Re: Inline PDF Support

2009-03-03 Thread Tei
On Wed, Mar 4, 2009 at 5:47 AM, DanielC dpc...@hotmail.com wrote: Hi Amanda, Thanks for your reply. I was mainly just hoping we might get something for free with webkit, but it sounds like the PDF support in Safari is native OS support. Alas, I was hoping to find a simple PDF viewer or at

[chromium-dev] Re: Inline PDF Support

2009-03-03 Thread Tei
On Wed, Mar 4, 2009 at 8:16 AM, Tei oscar.vi...@gmail.com wrote: On Wed, Mar 4, 2009 at 5:47 AM, DanielC dpc...@hotmail.com wrote: Hi Amanda, Thanks for your reply. I was mainly just hoping we might get something for free with webkit, but it sounds like the PDF support in Safari is