Re: [chrony-dev] New online/offline command

2018-05-25 Thread Chris Perl
On Fri, May 25, 2018 at 5:28 AM, Miroslav Lichvar wrote: > > Ok, I went with "onoffline". If something better comes up before the > next release, we can change it. I'm not sure if you have constraints with regard to dashes in the name, or the length. But, to me, something

Re: [chrony-dev] New online/offline command

2018-05-25 Thread Miroslav Lichvar
On Thu, May 24, 2018 at 02:52:19PM +0200, Christian Ehrhardt wrote: > "check-onoffline" maybe, but that sounds as if it would be a read-only > check action. > If you want go with "onoffline", it is not too bad if we make sure the > manpage entry is clear enough. Ok, I went with "onoffline". If

Re: [chrony-dev] New online/offline command

2018-05-24 Thread Christian Ehrhardt
On Thu, May 24, 2018 at 2:45 PM, Miroslav Lichvar wrote: > On Thu, May 24, 2018 at 02:11:58PM +0200, Christian Ehrhardt wrote: > > On auto-deployed config changes of virt systems (with plenty of switch > > interfaces for example) I've seen three digits per second (rare, but

Re: [chrony-dev] New online/offline command

2018-05-24 Thread Miroslav Lichvar
On Thu, May 24, 2018 at 02:11:58PM +0200, Christian Ehrhardt wrote: > On auto-deployed config changes of virt systems (with plenty of switch > interfaces for example) I've seen three digits per second (rare, but > existing). And each one runs all NM dispatcher scripts? I suspect the bottleneck is

Re: [chrony-dev] New online/offline command

2018-05-24 Thread Christian Ehrhardt
On Thu, May 24, 2018 at 11:54 AM, Miroslav Lichvar wrote: > On Wed, May 23, 2018 at 04:44:30PM +0200, Christian Ehrhardt wrote: > > No I'm fine with a single command. > > If it is low on cpu consumption and fast. > > We have to consider that in some environments you might

Re: [chrony-dev] New online/offline command

2018-05-24 Thread Miroslav Lichvar
On Thu, May 24, 2018 at 11:54:49AM +0200, Miroslav Lichvar wrote: > > With just one command neither Stephens nor my suggestion make sense. > > How about just "probe" then? > > I'm not sure. What exactly are we probing here? There are no packets > exchanged. It's just a local check of the routing

Re: [chrony-dev] New online/offline command

2018-05-24 Thread Miroslav Lichvar
On Wed, May 23, 2018 at 04:44:30PM +0200, Christian Ehrhardt wrote: > No I'm fine with a single command. > If it is low on cpu consumption and fast. > We have to consider that in some environments you might have plenty > (really a lot) of changes ongoing. > And you might get a notification for

Re: [chrony-dev] New online/offline command

2018-05-23 Thread Christian Ehrhardt
On Wed, May 23, 2018 at 4:25 PM, Miroslav Lichvar wrote: > On Wed, May 23, 2018 at 04:06:31PM +0200, Christian Ehrhardt wrote: > > First of all I'll like the simplification - so thanks for working on > this. > > Is the expected usage then an unconditional call (no ip's or

Re: [chrony-dev] New online/offline command

2018-05-23 Thread Miroslav Lichvar
On Wed, May 23, 2018 at 04:06:31PM +0200, Christian Ehrhardt wrote: > First of all I'll like the simplification - so thanks for working on this. > Is the expected usage then an unconditional call (no ip's or such) and > chrony will sort out those that apply Yes. There should be no need to work

Re: [chrony-dev] New online/offline command

2018-05-23 Thread Christian Ehrhardt
On Wed, May 23, 2018 at 3:50 PM, Miroslav Lichvar wrote: > I'd like to add a new command to chronyc which would take sources > online or offline depending on whether it is possible to sent packets > to them, i.e. they have a route configured on the local system. The > goal

Re: [chrony-dev] New online/offline command

2018-05-23 Thread Stephen Satchell
On 05/23/2018 06:50 AM, Miroslav Lichvar wrote: I'd like to add a new command to chronyc which would take sources online or offline depending on whether it is possible to sent packets to them, i.e. they have a route configured on the local system. The goal is to simplify the code in the