[cp-patches] FYI: Prevent multiple lines in JTextField

2005-11-15 Thread Meskauskas Audrius
JTextField is always a single line component. In GNU Classpath, it is possible to make it multi line by setting or pasting the line with line feeds. While this is highly impressive, the Sun's implementation never does this, replacing the line feeds by spaces instead. The unwanted resizing of

[cp-patches] FYI: BasicListUI fix

2005-11-15 Thread Roman Kennke
My last 'fix' for BasicListUI introduced some new misbehaviour in JList rendering. This should be fixed by this patch. 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicListUI.java Fixed API docs all over to better explain the changed (but correct)

Re: [cp-patches] FYI: Prevent multiple lines in JTextField

2005-11-15 Thread Roman Kennke
Am Dienstag, den 15.11.2005, 11:27 +0100 schrieb Meskauskas Audrius: JTextField is always a single line component. In GNU Classpath, it is possible to make it multi line by setting or pasting the line with line feeds. While this is highly impressive, the Sun's implementation never does

Re: [cp-patches] FYI: Prevent multiple lines in JTextField

2005-11-15 Thread Roman Kennke
Hi again, The simplest way to reach the identical behaviour is to override setText and replaceSelection, replacing (if present) line feeds and carriage returns by spaces. I have looked into this. The simplest way is to do it in PlainDocument.insertString(), exactly where I implemented this

[cp-patches] FYI: MetalUtils fix for Graphics2D

2005-11-15 Thread Roman Kennke
I fixed the texture for the Graphics2D version of MetalUtils. The metal pattern should now be drawn using textures when in Graphics2D mode (I assume that this is faster than drawing the pattern 'manually'). 2005-11-15 Roman Kennke [EMAIL PROTECTED] *

[cp-patches] FYI: JViewport system property

2005-11-15 Thread Roman Kennke
I've extended the JViewport, so that it recognizes a system property gnu.javax.swing.JViewport.scrollMode=SIMPLE/BACKINGSTORE/BLIT to globally set the scrollmode that should be used by all JViewports as default setting. This is especially useful when testing out Graphics2D which does not have a

Re: [cp-patches] Patch: GtkComponentPeer fix

2005-11-15 Thread Lillian Angel
On Mon, 2005-11-14 at 17:16 -0500, Thomas Fitzsimmons wrote: On Mon, 2005-11-14 at 16:36 -0500, Lillian Angel wrote: This fixes bug #24350. It is rather simple, the ChangeLog explains it all. I think these test cases will only pass because of another bug where a window's position is not

Re: [cp-patches] Patch: GtkComponentPeer fix

2005-11-15 Thread Lillian Angel
http://www.physto.se/~sven/pr24350.patch I reverted my patch and applied Sven's patch for this bug. He had implemented a new function to get the location for a window on the screen. 2005-11-15 Lillian Angel [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GtkComponentPeer.java

Re: [cp-patches] FYI: Prevent multiple lines in JTextField

2005-11-15 Thread Meskauskas Audrius
Yes, your suggestion is the better way to fix that bug. Roman Kennke wrote: Hi again, The simplest way to reach the identical behaviour is to override setText and replaceSelection, replacing (if present) line feeds and carriage returns by spaces. I have looked into this. The

Re: [cp-patches] RFC: java/io/PrintStream.java: Handling of an invalid file.encoding

2005-11-15 Thread Ito Kazumitsu
From: Ito Kazumitsu [EMAIL PROTECTED] Date: Tue, 15 Nov 2005 00:57:35 +0900 (JST) I think an invalid value of file.encoding should be treated as if it were ISO-8859-1. Such is the behaviour of Sun's JDK. A further study shows that an invalid value of file.encoding being treated as if it were

[cp-patches] FYI: Api docs additions in javax.print.attribute

2005-11-15 Thread Wolfgang Baer
Hi, subjects says all. 2005-11-15 Wolfgang Baer [EMAIL PROTECTED] * javax/print/attribute/DateTimeSyntax.java, * javax/print/attribute/EnumSyntax.java, * javax/print/attribute/IntegerSyntax.java, * javax/print/attribute/URISyntax.java: Added and

[cp-patches] Patch: BasicTreeUI painting fix

2005-11-15 Thread Lillian Angel
Roman noticed that JTree painting was rather inefficent with big trees. This was due to the recursion. I fixed this to only paint the rows contained in the clip, using a loop. Also, I did a bit of cleaning up in the class. 2005-11-15 Lillian Angel [EMAIL PROTECTED] *

[cp-patches] Patch: PlainDocument improvements and added functionality

2005-11-15 Thread Anthony Balkissoon
This patch implements ElementChange interface behaviour for PlainDocument. When entire lines are inserted or removed the DocumentEvent must have an ElementChange attached to it describing the new lines or the removed lines. Roman correctly noticed that this behaviour should not be in

[cp-patches] FYI: Was: Re: gnu_java_awt_peer_gtk_GdkFontPeer.c (initStaticState): missing NewGlobalRef?

2005-11-15 Thread Christian Thalinger
Ooops! Almost forgot to commit this. TWISTI 2005-11-15 Christian Thalinger [EMAIL PROTECTED] * native/jni/java-lang/java_lang_VMDouble.c (initIDs): Register clsDouble as global ref. * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkToolkit.c (gtkInit):

Re: [cp-patches] FYI: JViewport system property

2005-11-15 Thread Mark Wielaard
Hi Roman, On Tue, 2005-11-15 at 14:16 +, Roman Kennke wrote: 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/JViewport.java (JViewport): Recognize setting of a system property gnu.javax.swing.JViewport for the scrollMode. ---

Re: [cp-patches] Patch: GtkComponentPeer fix

2005-11-15 Thread Mark Wielaard
Hi Lillian, On Tue, 2005-11-15 at 10:10 -0500, Lillian Angel wrote: http://www.physto.se/~sven/pr24350.patch I reverted my patch and applied Sven's patch for this bug. He had implemented a new function to get the location for a window on the screen. 2005-11-15 Lillian Angel [EMAIL

[cp-patches] FYI:gnu.CORBA.OrbFunctional fix.

2005-11-15 Thread Meskauskas Audrius
This fixes interoperability problems with Sun\s 1.5 jdk. 2005-11-15 Audrius Meskauskas [EMAIL PROTECTED] * gnu/CORBA/OrbFunctional.java (serveStep): Returning ensure that the socket is closed. Index: gnu/CORBA/OrbFunctional.java

Re: [cp-patches] Patch: GtkComponentPeer fix

2005-11-15 Thread Lillian Angel
On Tue, 2005-11-15 at 21:26 +0100, Mark Wielaard wrote: Hi Lillian, On Tue, 2005-11-15 at 10:10 -0500, Lillian Angel wrote: http://www.physto.se/~sven/pr24350.patch I reverted my patch and applied Sven's patch for this bug. He had implemented a new function to get the location for a

[cp-patches] FYI: Basic LF cleanup

2005-11-15 Thread Roman Kennke
Hi, I cleaned up javax.swing.plaf.basic a little. For the most part this replaces all occurances of UIManager.getLookAndFeelDefaults().getXXX() with UIManager.getXXX(). Not only is this shorter, it also has a slightly different semantics (or should have, I'll explain this later when I

[cp-patches] FYI: Metal LF cleanup

2005-11-15 Thread Roman Kennke
I also cleaned up the Metal LF, replacing all UIManager.getLookAndFeelDefaults().getXXX() calls with UIManager.getXXX(). I also removed some redundant init code from MetalTreeUI() which is now delegated to the superclass, which does exactly the same thing. 2005-11-15 Roman Kennke [EMAIL

[cp-patches] FYI: UIManager fix

2005-11-15 Thread Roman Kennke
Here comes the UIManager fix that I prepared with the last two patches. I noticed that the UIManager has an additional 'layer' of settings, I call this user settings. You can access them via the put() and the various getXXX() methods of UIManager. The thing is, if you set something via

[cp-patches] FYI: Releasing the first CORBA/Swing example ( two player network strategy game)

2005-11-15 Thread Meskauskas Audrius
This example should demonstrate the work of CORBA in the Swing based network game.The game was popular in my student times. After doing some web search I concluded that the game is called Five-in-a-row in English. Five-in-a-row is a two player strategy game. The players are connected

Re: [cp-patches] FYI: Releasing the first CORBA/Swing example ( two player network strategy game)

2005-11-15 Thread Roman Kennke
Hi, Am Dienstag, den 15.11.2005, 22:12 +0100 schrieb Meskauskas Audrius: This example should demonstrate the work of CORBA in the Swing based network game.The game was popular in my student times. After doing some web search I concluded that the game is called Five-in-a-row in

[cp-patches] Patch: Tree defaults fix

2005-11-15 Thread Lillian Angel
Fixed the rowHeight defaults for JTree to match the JDK/JRE. 2005-11-15 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicLookAndFeel.java (initComponentDefaults): Default rowHeight for tree's should be 0. This is Sun and IBM's default. *

[cp-patches] FYI: a small addition for WHEN_IN_FOCUSED_WINDOW bindings

2005-11-15 Thread Anthony Balkissoon
This patch removes the bindings for a JComponent when it has been removed from its parent container. 2005-11-15 Anthony Balkissoon [EMAIL PROTECTED] * javax/swing/JComponent.java: (removeNotify): Unregister WHEN_IN_FOCUSED_WINDOW bindings from the KeyboardManager.

Re: [cp-patches] FYI: Releasing the first CORBA/Swing example ( two player network strategy game)

2005-11-15 Thread Roman Kennke
Hi again, Am Dienstag, den 15.11.2005, 22:12 +0100 schrieb Meskauskas Audrius: This example should demonstrate the work of CORBA in the Swing based network game.The game was popular in my student times. After doing some web search I concluded that the game is called Five-in-a-row

[cp-patches] Patch: Tree NPE fix

2005-11-15 Thread Lillian Angel
Fixed another NPE. 2005-11-15 Lillian Angel [EMAIL PROTECTED] * javax/swing/plaf/basic/BasicTreeUI.java (paint): Added check to prevent NPE. Index: javax/swing/plaf/basic/BasicTreeUI.java === RCS file:

[cp-patches] Patch: Window resizing bug

2005-11-15 Thread Lillian Angel
Fixes bug #24234. Tom F. and I fixed this bug. gtk_window_set_resizable always sets the allow_shrink field to false, this was fixed by explicitly setting 'allow_shrink' to 'resizable'. 2005-11-15 Lillian Angel [EMAIL PROTECTED] *

[cp-patches] FYI: JComponent fixlet

2005-11-15 Thread Roman Kennke
Hi, I put the paint() call in paintDoubleBuffered() inside a try-finally block so that the flags are correctly cleaned up when an exception is thrown in paint(). 2005-11-15 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComponent.java (paintDoubleBuffered): Put paint() call

Re: [cp-patches] FYI: gnu_java_awt_peer_gtk_GtkClipboard.c 64-bit fix

2005-11-15 Thread Christian Thalinger
On Mon, 2005-11-07 at 21:36 +0100, Christian Thalinger wrote: On Mon, 2005-11-07 at 14:15 -0700, Tom Tromey wrote: Twisti == Christian Thalinger [EMAIL PROTECTED] writes: Twisti +#if SIZEOF_VOID_P == 8 Twisti +static long current_selection = 0; Twisti +#else Twisti static int

Re: gnu_java_awt_peer_gtk_GdkFontPeer.c (initStaticState): missing NewGlobalRef?

2005-11-15 Thread Christian Thalinger
On Tue, Nov 08, 2005 at 07:09:43PM +0100, Mark Wielaard wrote: code analyzer for this. Please let us know when the paper is published. Here is the first version of the paper: http://www.complang.tuwien.ac.at/cacaojvm//papers/space.dvi.gz TWISTI ___

Re: gnu_java_awt_peer_gtk_GdkFontPeer.c (initStaticState): missing NewGlobalRef?

2005-11-15 Thread Christian Thalinger
On Thu, 2005-11-10 at 20:57 +0100, Mark Wielaard wrote: These indeed look like genuine bugs. Thanks for finding them. Could you post the patch plus a ChangeLog entry to classpath-patches and commit these? Took some time, but done. TWISTI ___

[commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

2005-11-15 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/11/15 13:24:26 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicListUI.java Log message: 2005-11-15 Roman

[commit-cp] classpath ./ChangeLog javax/swing/plaf/metal/Me...

2005-11-15 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/11/15 14:05:31 Modified files: . : ChangeLog javax/swing/plaf/metal: MetalUtils.java Log message: 2005-11-15 Roman Kennke

[commit-cp] classpath gnu/java/awt/peer/gtk/GtkComponentPee...

2005-11-15 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Lillian Angel [EMAIL PROTECTED] 05/11/15 15:11:54 Modified files: gnu/java/awt/peer/gtk: GtkComponentPeer.java include: gnu_java_awt_peer_gtk_GtkComponentPeer.h

[commit-cp] classpath ChangeLog

2005-11-15 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Lillian Angel [EMAIL PROTECTED] 05/11/15 15:38:42 Modified files: . : ChangeLog Log message: Forgot to commit CVSWeb URLs:

[commit-cp] classpath ./ChangeLog javax/print/attribute/Int...

2005-11-15 Thread Wolfgang Baer
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Wolfgang Baer [EMAIL PROTECTED] 05/11/15 16:16:27 Modified files: . : ChangeLog javax/print/attribute: IntegerSyntax.java EnumSyntax.java

[commit-cp] classpath ChangeLog

2005-11-15 Thread Anthony Balkissoon
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Anthony Balkissoon [EMAIL PROTECTED] 05/11/15 19:52:32 Modified files: . : ChangeLog Log message: Improved last ChangeLog entry. CVSWeb URLs:

[commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

2005-11-15 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Lillian Angel [EMAIL PROTECTED] 05/11/15 19:53:49 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicTreeUI.java Log message: 2005-11-15 Lillian

[commit-cp] classpath ./ChangeLog gnu/CORBA/OrbFunctional.java

2005-11-15 Thread Audrius Meškauskas
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Audrius Meškauskas [EMAIL PROTECTED] 05/11/15 20:36:32 Modified files: . : ChangeLog gnu/CORBA : OrbFunctional.java Log message: 2005-11-15 Audrius

[commit-cp] classpath ChangeLog

2005-11-15 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Lillian Angel [EMAIL PROTECTED] 05/11/15 20:39:33 Modified files: . : ChangeLog Log message: Fixed ChangeLog. 2005-11-15 Lillian Angel [EMAIL

[commit-cp] classpath/examples/gnu/classpath/examples/CORBA/swing

2005-11-15 Thread Audrius Meškauskas
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Audrius Meškauskas [EMAIL PROTECTED] 05/11/15 20:39:46 classpath/examples/gnu/classpath/examples/CORBA/swing Update of /cvsroot/classpath/classpath/examples/gnu/classpath/examples/CORBA/swing In

[commit-cp] classpath ./ChangeLog javax/swing/UIManager.java

2005-11-15 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/11/15 21:08:51 Modified files: . : ChangeLog javax/swing: UIManager.java Log message: 2005-11-15 Roman Kennke [EMAIL

[commit-cp] classpath ./ChangeLog native/jni/gtk-peer/gnu_j...

2005-11-15 Thread Lillian Angel
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Lillian Angel [EMAIL PROTECTED] 05/11/15 22:50:53 Modified files: . : ChangeLog native/jni/gtk-peer: gnu_java_awt_peer_gtk_GtkWindowPeer.c Log message:

[commit-cp] classpath ./ChangeLog javax/swing/JComponent.java

2005-11-15 Thread Roman Kennke
CVSROOT:/cvsroot/classpath Module name:classpath Branch: Changes by: Roman Kennke [EMAIL PROTECTED]05/11/15 23:07:23 Modified files: . : ChangeLog javax/swing: JComponent.java Log message: 2005-11-15 Roman Kennke