Re: [cp-patches] Minor refactoring of Character class

2010-12-08 Thread Andrew Haley
On 06/15/2010 07:00 PM, Ivan Maidanski wrote: Hi! Here, I replaced numerous String.zeroBasedStringValue(CharData.xxx[i]) with a single call to convertCharData() (which does the work). The other changes are several minor optimizations of expressions. ChangeLog entries: *

[cp-patches] [PATCH v2] Fix VMClass#getSimpleName() implementation

2010-12-08 Thread Pekka Enberg
This patch replaces VMClass#getSimpleName() implementation with JamVM's version that supposedly comes from GCJ. This fixes a compatibility problem found by Malva. Signed-off-by: Pekka Enberg penb...@kernel.org --- vm/reference/java/lang/VMClass.java | 29 +++-- 1 files

Re: Future blog

2010-12-08 Thread Gary Benson
Dr Andrew John Hughes wrote: On 23:06 Tue 07 Dec, Mark Wielaard wrote: As soon as I am back I would like us to at least start moving to mercurial on savannah if people don't mind. Yes, I do mind. We already discussed this some time back:

Re: Future blog

2010-12-08 Thread Brian Jones
Hi all, long time, no commit. It is unclear from my vantage point what the purpose of Classpath should be. Most of the VMs I'm familiar with who were essentially customers in the past are moving to support openjdk's class library it seems Thank goodness for JamVM and all the rest over the

Re: Future blog

2010-12-08 Thread Mark Wielaard
Hi, On Tue, 2010-12-07 at 23:53 +, Dr Andrew John Hughes wrote: I'll apologise in advance if some of what I've written below sounds harsh, but I'm not that happy with the state of Free Java generally right now. And I apologize for not stating the obvious. You are the only active maintainer

Re: Future blog

2010-12-08 Thread Pekka Enberg
On Wed, Dec 8, 2010 at 12:32 PM, Andrew Haley a...@redhat.com wrote: Anyway, I don't mind that as long as someone else does it.  (Clearly, the issue of developers without commit access is a red herring, as every developer should have commit access.) But it's not a red herring! I don't expect

Re: Future blog

2010-12-08 Thread Pekka Enberg
On Wed, Dec 8, 2010 at 12:32 PM, Andrew Haley a...@redhat.com wrote: I hereby offer to review some patches.  Please send pointers to the list. http://developer.classpath.org/pipermail/classpath-patches/2010-November/006511.html

Re: Future blog

2010-12-08 Thread Andrew Haley
On 12/08/2010 10:56 AM, Pekka Enberg wrote: On Wed, Dec 8, 2010 at 12:32 PM, Andrew Haley a...@redhat.com wrote: Anyway, I don't mind that as long as someone else does it. (Clearly, the issue of developers without commit access is a red herring, as every developer should have commit access.)

Re: Future blog

2010-12-08 Thread Andrew Haley
On 12/08/2010 10:58 AM, Pekka Enberg wrote: On Wed, Dec 8, 2010 at 12:32 PM, Andrew Haley a...@redhat.com wrote: I hereby offer to review some patches. Please send pointers to the list. http://developer.classpath.org/pipermail/classpath-patches/2010-November/006511.html

Re: Future blog

2010-12-08 Thread Pekka Enberg
On Wed, Dec 8, 2010 at 12:32 PM, Andrew Haley a...@redhat.com wrote: But I'm afraid people are looking at the things they think might make a difference, but won't make a difference.  I read the list, and haven't seen a huge number of unreviewed patches, but I admit I haven't been paying close

Re: Future blog

2010-12-08 Thread Andrew Haley
On 12/08/2010 10:58 AM, Pekka Enberg wrote: On Wed, Dec 8, 2010 at 12:32 PM, Andrew Haley a...@redhat.com wrote: I hereby offer to review some patches. Please send pointers to the list. http://developer.classpath.org/pipermail/classpath-patches/2010-November/006511.html This needs a

Re: Future blog

2010-12-08 Thread Pekka Enberg
Hi Andrew, On Wed, Dec 8, 2010 at 1:06 PM, Andrew Haley a...@redhat.com wrote: On 12/08/2010 10:56 AM, Pekka Enberg wrote: On Wed, Dec 8, 2010 at 12:32 PM, Andrew Haley a...@redhat.com wrote: Anyway, I don't mind that as long as someone else does it.  (Clearly, the issue of developers without

Re: Future blog

2010-12-08 Thread Pekka Enberg
On Wed, Dec 8, 2010 at 1:13 PM, Andrew Haley a...@redhat.com wrote: There's also 10-15 patches from Ivan sitting in the archives Hmm, I had seen some discussion around those and thought they were being addressed.  Bring them on! I'm not sure if this is all of it but it's a start anyway:

Re: Future blog

2010-12-08 Thread Pekka Enberg
On Wed, Dec 8, 2010 at 1:13 PM, Andrew Haley a...@redhat.com wrote: http://developer.classpath.org/pipermail/classpath-patches/2010-November/006512.html What compatibility problem does this fix? That the result is not what we get with OpenJDK. JamVM, for example, (and I guess CACAO) has fixed

Re: Future blog

2010-12-08 Thread Andrew Haley
On 12/08/2010 11:32 AM, Pekka Enberg wrote: On Wed, Dec 8, 2010 at 1:13 PM, Andrew Haley a...@redhat.com wrote: There's also 10-15 patches from Ivan sitting in the archives Hmm, I had seen some discussion around those and thought they were being addressed. Bring them on! I'm not sure if

Re: Future blog

2010-12-08 Thread Pekka Enberg
On Wed, Dec 8, 2010 at 1:41 PM, Andrew Haley a...@redhat.com wrote: I'm not sure if this is all of it but it's a start anyway: http://developer.classpath.org/pipermail/classpath-patches/2010-June/006411.html Ah, yes, these were the patches that were sent hex encoded with a MIME type of

Re: Future blog

2010-12-08 Thread Gary Benson
Andrew Haley wrote: On 12/08/2010 11:23 AM, Pekka Enberg wrote: In any case, even if everyone did have commit access, CVS is still painful for *local* development. Not for me. I mean, it's not great, but it's hardly a big factor in the time it takes to develop code. I think different

Re: Future blog

2010-12-08 Thread Andrew Haley
On 12/08/2010 11:37 AM, Pekka Enberg wrote: On Wed, Dec 8, 2010 at 1:13 PM, Andrew Haley a...@redhat.com wrote: http://developer.classpath.org/pipermail/classpath-patches/2010-November/006512.html What compatibility problem does this fix? That the result is not what we get with OpenJDK.

Re: Future blog

2010-12-08 Thread Pekka Enberg
On Wed, Dec 8, 2010 at 1:47 PM, Andrew Haley a...@redhat.com wrote: That the result is not what we get with OpenJDK. JamVM, for example, (and I guess CACAO) has fixed this in their tree as has GCJ. The test case I used for this is ClassTest.testGetSimpleName() here:

Re: Future blog

2010-12-08 Thread Andrew Haley
On 12/08/2010 11:47 AM, Gary Benson wrote: Andrew Haley wrote: On 12/08/2010 11:23 AM, Pekka Enberg wrote: In any case, even if everyone did have commit access, CVS is still painful for *local* development. Not for me. I mean, it's not great, but it's hardly a big factor in the time it

Re: Future blog

2010-12-08 Thread Andrew Haley
On 12/08/2010 11:49 AM, Pekka Enberg wrote: On Wed, Dec 8, 2010 at 1:47 PM, Andrew Haley a...@redhat.com wrote: That the result is not what we get with OpenJDK. JamVM, for example, (and I guess CACAO) has fixed this in their tree as has GCJ. The test case I used for this is

Re: Future blog

2010-12-08 Thread Pekka Enberg
On Wed, Dec 8, 2010 at 2:03 PM, Andrew Haley a...@redhat.com wrote: No need to live with it, I'll fix it up and resend. This is truly weird.  The gcj patch says: 2008-05-22  Andrew Haley  a...@redhat.com        PR libgcj/35020        * java/lang/Class.java (getSimpleName): Import from GNU

Re: Future blog

2010-12-08 Thread Andrew Haley
On 12/08/2010 12:09 PM, Pekka Enberg wrote: On Wed, Dec 8, 2010 at 2:03 PM, Andrew Haley a...@redhat.com wrote: No need to live with it, I'll fix it up and resend. This is truly weird. The gcj patch says: 2008-05-22 Andrew Haley a...@redhat.com PR libgcj/35020 *

Re: Future blog

2010-12-08 Thread Mario Torre
Il giorno mer, 08/12/2010 alle 09.26 +, Gary Benson ha scritto: Dr Andrew John Hughes wrote: On 23:06 Tue 07 Dec, Mark Wielaard wrote: As soon as I am back I would like us to at least start moving to mercurial on savannah if people don't mind. Yes, I do mind. We already

Re: Future blog

2010-12-08 Thread Brian Jones
On Wed, Dec 8, 2010 at 6:49 AM, Andrew Haley a...@redhat.com wrote: On 12/08/2010 11:44 AM, Brian Jones wrote: I've only recently gone from svn to git and honestly git is freaking awesome sauce. I'm pretty sure what you are missing is how much nicer having local branches can be for local

Re: Future blog

2010-12-08 Thread Mario Torre
Il giorno mer, 08/12/2010 alle 13.45 +0200, Pekka Enberg ha scritto: I completely agree. I have Ivan's patches locally and I'm planning to go through them and resend them to the list unless he beats me to it. Pekka If we were using mecurial we could use review board

Re: Future blog

2010-12-08 Thread Andrew Haley
On 12/08/2010 12:57 PM, Mario Torre wrote: Il giorno mer, 08/12/2010 alle 13.45 +0200, Pekka Enberg ha scritto: I completely agree. I have Ivan's patches locally and I'm planning to go through them and resend them to the list unless he beats me to it. Pekka If we

Re: Future blog

2010-12-08 Thread Andrew Haley
On 12/08/2010 01:23 PM, Mario Torre wrote: Il giorno mer, 08/12/2010 alle 13.03 +, Andrew Haley ha scritto: On 12/08/2010 12:57 PM, Mario Torre wrote: If we were using mecurial we could use review board or webrew. We could, but these just introduce extra barriers: it's very easy to just

Re: Future blog

2010-12-08 Thread Dr Andrew John Hughes
On 09:20 Wed 08 Dec , Pekka Enberg wrote: On Wed, Dec 8, 2010 at 1:53 AM, Dr Andrew John Hughes There are several inaccuracies in the points themselves.  I'm not too surprised, given that Pekka is still new to the project, but I am surprised that you'd agree wholeheartedly with such

Re: Future blog

2010-12-08 Thread Dr Andrew John Hughes
On 11:05 Wed 08 Dec , Mark Wielaard wrote: Hi, On Tue, 2010-12-07 at 23:53 +, Dr Andrew John Hughes wrote: I'll apologise in advance if some of what I've written below sounds harsh, but I'm not that happy with the state of Free Java generally right now. And I apologize for not

Re: Future blog

2010-12-08 Thread Dr Andrew John Hughes
On 10:32 Wed 08 Dec , Andrew Haley wrote: On 12/08/2010 10:05 AM, Mark Wielaard wrote: As is, if you're going to put some time in, I'd rather it was spent reviewing patches than messing about with the VCS. Point taken. In my defense, I like tinkering with services around the code

Re: Future blog

2010-12-08 Thread Dr Andrew John Hughes
On 11:13 Wed 08 Dec , Andrew Haley wrote: On 12/08/2010 10:58 AM, Pekka Enberg wrote: On Wed, Dec 8, 2010 at 12:32 PM, Andrew Haley a...@redhat.com wrote: I hereby offer to review some patches. Please send pointers to the list.

Re: Future blog

2010-12-08 Thread Dr Andrew John Hughes
On 08:16 Wed 08 Dec , Pekka Enberg wrote: On Wed, Dec 8, 2010 at 1:53 AM, Dr Andrew John Hughes gnu_and...@member.fsf.org wrote: As soon as I am back I would like us to at least start moving to mercurial on savannah if people don't mind. Yes, I do mind. We already discussed this

Re[2]: Future blog

2010-12-08 Thread Ivan Maidanski
Hi Andrew and Pekka, Thank you Pekka but there are also some more ones (in June 2010): - http://article.gmane.org/gmane.comp.java.classpath.patches/12989 (follow the link in body to get classpath-ivmai-05.diff); - http://article.gmane.org/gmane.comp.java.classpath.patches/12988

Re: Re[2]: Future blog

2010-12-08 Thread Dr Andrew John Hughes
2010/12/8 Ivan Maidanski iv...@mail.ru: Hi Andrew and Pekka, Thank you Pekka but there are also some more ones (in June 2010): - http://article.gmane.org/gmane.comp.java.classpath.patches/12989 (follow the link in body to get classpath-ivmai-05.diff); -