[cp-patches] Re: Absolute URL parsing bug

2005-07-05 Thread Per Bothner
Andrew Haley wrote: The case that we get wrong is this one: $ java TestURLs 'jar:file:/ejbjars/ws.jar!/META-INF/wsdl/ssbEndpoint.wsdl' 'jar:file:ejbjars/ws.jar!/META-INF/wsdl/ssbEndpoint.wsdl' jar:file:ejbjars/ws.jar!/META-INF/wsdl/ssbEndpoint.wsdl None of these are valid URLs as documented i

[cp-patches] Re: [RFA/JDWP] ReferenceTypeCommandSet.java

2005-07-05 Thread Bryce McKinlay
Keith Seitz wrote: On Tue, 2005-07-05 at 16:15 -0400, Bryce McKinlay wrote: Class preparation is distinct from initialization. Preparation is effectively linking the class: laying out its fields, initializing class data structures in the VM, etc. Initialization involves actually running Ja

[cp-patches] Re: [RFA/JDWP] ReferenceTypeCommandSet.java

2005-07-05 Thread Keith Seitz
On Tue, 2005-07-05 at 16:15 -0400, Bryce McKinlay wrote: > Class preparation is distinct from initialization. Preparation is > effectively linking the class: laying out its fields, initializing class > data structures in the VM, etc. Initialization involves actually running > Java code to initia

[cp-patches] Re: [RFA/JDWP] ReferenceTypeCommandSet.java

2005-07-05 Thread Bryce McKinlay
Keith Seitz wrote: There's also a couple places I use classes from java.lang.reflect This is a bit of a problem as it's been pointed out if in the instance of a command like http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdwp/jdwp-protocol.html#JDWP_ReferenceType_GetValues Using the Field obje

[cp-patches] FYI: fix for JTable.getColumnName()

2005-07-05 Thread David Gilbert
A patch I committed earlier today had a fix for the getColumnName() method in JTable that wasn't quite right. This patch fixes it properly: 2005-07-05 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JTable.java (getColumnName): return name from column in data model. Regards,

[cp-patches] Re: [RFA/JDWP] ReferenceTypeCommandSet.java

2005-07-05 Thread Keith Seitz
On Tue, 2005-07-05 at 15:32 -0400, Aaron Luchko wrote: > There are a couple interesting points for this patch. The first is that > upon Keith's suggestion any Command which has something to do with > generics (in this case just queries for the generic signature) we just > throw a NotImplementedExc

[cp-patches] [RFA/JDWP] ReferenceTypeCommandSet.java

2005-07-05 Thread Aaron Luchko
Okay, here's the first CommandSet with some real heft, http://java.sun.com/j2se/1.5.0/docs/guide/jpda/jdwp/jdwp-protocol.html#JDWP_ReferenceType There are a couple interesting points for this patch. The first is that upon Keith's suggestion any Command which has something to do with generics (in

[cp-patches] Re: [RFA/JDWP] IdManager, Events

2005-07-05 Thread Bryce McKinlay
Hi Keith, Sorry I havn't got back to you sooner. Re filtering: I think that whether filtering at the Java level makes a significant difference to performance depends on the proportion of events that are filtered in a typical debugging session. If, say, 90%+ of events are usually filtered out

[cp-patches] [patch] prevent bogus casts in DefaultKeyboardFocusManager.dispatchEvent

2005-07-05 Thread Thomas Fitzsimmons
Hi, This patch adds the check Jeroen and I discussed in this thread: http://lists.gnu.org/archive/html/classpath-patches/2005-06/msg00363.html It should prevent bogus casts to Window during KeyEvent dispatch. I committed this to mainline. Tom 2005-07-05 Thomas Fitzsimmons <[EMAIL PROTECTED]

[cp-patches] Re: [RFA/JDWP] IdManager, Events

2005-07-05 Thread Keith Seitz
[pardon top posting] It's been over a week now, does anyone else have an opinion or does everyone agree with Bryce's comments? Keith On Mon, 2005-06-27 at 17:51 -0700, Keith Seitz wrote: > On Mon, 2005-06-27 at 17:03 -0400, Bryce McKinlay wrote: > > > Please post ChangeLog entries whenever you

Re: [cp-patches] FYI: fix opaque properties for buttons

2005-07-05 Thread Roman Kennke
Am Dienstag, den 05.07.2005, 10:23 -0600 schrieb Tom Tromey: > > "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: > > Roman> I have an application that uses a > Roman> ToggleButton derived from JToggleButton but does not call super() in > Roman> its constructors. > > Just FYI ... you can't

[cp-patches] FYI: RMIC contribution

2005-07-05 Thread Tom Tromey
FYI, I'm checking in Archit's rmic patch. You can see it here: http://lists.gnu.org/archive/html/classpath/2005-06/msg00045.html I wrote a ChangeLog entry for it which I hope isn't too bogus. Tom ___ Classpath-patches mailing list Classpath-patches@g

[cp-patches] Re: [RFA/JDWP] StringReferenceCommandSet.java

2005-07-05 Thread Aaron Luchko
On Tue, 2005-07-05 at 10:47 -0600, Tom Tromey wrote: > > "Aaron" == Aaron Luchko <[EMAIL PROTECTED]> writes: > > Aaron> Here's the updated patch > > Aaron> ChangeLog > Aaron> 2005-07-04 Aaron Luchko <[EMAIL PROTECTED]> > Aaron> * gnu/classpath/jdwp/processor/StringReferenceCommandSe

Re: [cp-patches] Re: Serialization: readResolve and writeReplace in parent class

2005-07-05 Thread Mark Wielaard
On Tue, 2005-07-05 at 10:41 -0600, Tom Tromey wrote: > > "Mark" == Mark Wielaard <[EMAIL PROTECTED]> writes: > Suppose you have a hierarchy like: > > class A { blah blah readResolve() } > class B extends A { } > class C extends B { } > > You compile all of these. > Then you go back and add 'p

Re: [cp-patches] FYI: fix opaque properties for buttons

2005-07-05 Thread Tom Tromey
> "Roman" == Roman Kennke <[EMAIL PROTECTED]> writes: Roman> I have an application that uses a Roman> ToggleButton derived from JToggleButton but does not call super() in Roman> its constructors. Just FYI ... you can't avoid calling super() in a constructor. If you don't call it explicitly,

Re: [cp-patches] Re: Serialization: readResolve and writeReplace in parent class

2005-07-05 Thread Tom Tromey
> "Mark" == Mark Wielaard <[EMAIL PROTECTED]> writes: >> > I wonder if there is a strange case here where someone adds a private >> > method to the class hierarchy "later" (after all the other classes are >> > compiled). Should the private method hide the superclass methods of >> > the same s

[cp-patches] Re: [RFA/JDWP] StringReferenceCommandSet.java

2005-07-05 Thread Tom Tromey
> "Aaron" == Aaron Luchko <[EMAIL PROTECTED]> writes: Aaron> Here's the updated patch Aaron> ChangeLog Aaron> 2005-07-04 Aaron Luchko <[EMAIL PROTECTED]> Aaron> * gnu/classpath/jdwp/processor/StringReferenceCommandSet.java: Aaron> New file. Thanks, please commit. Tom ___

Re: [cp-patches] FYI: Adding read/write to javax/swing/text/JTextComponent.java (fixing bug #13640)

2005-07-05 Thread Tom Tromey
> "Audrius" == Meskauskas Audrius <[EMAIL PROTECTED]> writes: Audrius> +StringBuffer b = new StringBuffer(); Audrius> +int c; Audrius> + Audrius> +// Read till -1 (EOF). Audrius> +while ((c = input.read()) >= 0) Audrius> + b.append((char) c); Ouch. How about reading in b

Re: [cp-patches] FYI: Jlabel revert

2005-07-05 Thread Sven de Marothy
On Tue, 2005-07-05 at 15:37 +0200, Mark Wielaard wrote: > Could you next time please mention the actual change. Your previous > change was a month ago, so it wasn't immediately apparent what was > reverted. (JLabel(Icon)): Horizontal justification changed to CENTER. Ok. I'll do that* next time.

Re: [cp-patches] [patch] refactor text peers to remove GtkTextComponentPeer

2005-07-05 Thread Mark Wielaard
On Tue, 2005-07-05 at 11:22 -0400, Thomas Fitzsimmons wrote: > Should I be building with --enable-Werror? I plan to commit another > patch today that will eliminate these warnings and I thought it was > acceptable to introduce temporary warnings. If not, --enable-Werror > should be the default.

Re: [cp-patches] [patch] refactor text peers to remove GtkTextComponentPeer

2005-07-05 Thread Thomas Fitzsimmons
On Tue, 2005-07-05 at 07:43 +0200, Mark Wielaard wrote: > Hi, > > On Mon, 2005-07-04 at 19:57 -0400, Thomas Fitzsimmons wrote: > > GtkTextComponentPeer is unnecessary since the GTK widgets, GtkTextView > > and GtkEntry are not related. This patch refactors the > > GtkTextComponentPeer code into G

[cp-patches] FYI: minor API doc fix in java.applet.Applet

2005-07-05 Thread David Gilbert
I committed this change to fix a minor API doc problem: 2005-07-05 David Gilbert <[EMAIL PROTECTED]> * java/applet/Applet.java: added import to fix API doc link. Regards, Dave Gilbert Index: java/applet/Applet.java === R

[cp-patches] FYI: Added API docs to (javax.swing.) Action and AbstractAction

2005-07-05 Thread David Gilbert
I committed this patch to add some API doc comments: 2005-07-05 David Gilbert <[EMAIL PROTECTED]> * javax/swing/AbstractAction.java: updated API docs, * javax/swing/Action.java: likewise. Regards, Dave Gilbert Index: javax/swing/AbstractAction.java ===

[cp-patches] FYI: fix opaque properties for buttons

2005-07-05 Thread Roman Kennke
Here comes a small fixlet that fixes how/where the opaque property for Buttons is initialized. According to some tests I have run, this property is not initialized in the buttons UI class, but instead in the buttons constructor. I have an application that uses a ToggleButton derived from JToggl

Re: [cp-patches] Re: Absolute URL parsing bug

2005-07-05 Thread Andrew Haley
Mark Wielaard writes: > Hi, > > On Mon, 2005-07-04 at 18:07 +0100, Andrew Haley wrote: > > When creating a URL: if the spec is absolute and a context URL is > > supplied, we should inherit the host:port part of the context if its > > protocol the same as that of the spec, but we should not

Re: [cp-patches] Re: Absolute URL parsing bug

2005-07-05 Thread Mark Wielaard
Hi, On Mon, 2005-07-04 at 18:07 +0100, Andrew Haley wrote: > When creating a URL: if the spec is absolute and a context URL is > supplied, we should inherit the host:port part of the context if its > protocol the same as that of the spec, but we should not inherit its > file path. Have you added

Re: [cp-patches] Revised patch: JTable and DefaultTableColumnModel

2005-07-05 Thread David Gilbert
Roman Kennke wrote: > > Hi David, > >> Attached is a revised version of the patch I proposed late last week. >> It adds implementations for the isCellEditable() and >> createDefaultColumnsFromModel() methods in JTable, and fixes some bugs >> uncovered while writing Mauve tests for the new methods.

Re: [cp-patches] FYI: Jlabel revert

2005-07-05 Thread Mark Wielaard
Hi Sven, On Tue, 2005-07-05 at 14:16 +0200, Sven de Marothy wrote: > 2005-07-05 Sven de Marothy <[EMAIL PROTECTED]> > > * javax/swing/JLabel.java: > (JLabel): Revert previous change for JLabel(Icon) constructor. Could you next time please mention the actual change. Your previous c

Re: [cp-patches] Revised patch: JTable and DefaultTableColumnModel

2005-07-05 Thread Roman Kennke
Hi David, Attached is a revised version of the patch I proposed late last week. It adds implementations for the isCellEditable() and createDefaultColumnsFromModel() methods in JTable, and fixes some bugs uncovered while writing Mauve tests for the new methods. 2005-07-05 David Gilbert <[EMAI

[cp-patches] FYI: Jlabel revert

2005-07-05 Thread Sven de Marothy
2005-07-05 Sven de Marothy <[EMAIL PROTECTED]> * javax/swing/JLabel.java: (JLabel): Revert previous change for JLabel(Icon) constructor. Index: javax/swing/JLabel.java === RCS file: /cvsroot/classpath/classpath/jav

[cp-patches] FYI: Added API docs to JScrollPane

2005-07-05 Thread Roman Kennke
2005-07-05 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/JScrollPane.java: Added API documentation for class and constructors. /Roman Index: javax/swing/JScrollPane.java === RCS file: /cvsroot/classpath/classpath/j

[cp-patches] FYI: Adding default style to the style table in the StyleContext (fixes 13617)

2005-07-05 Thread Meskauskas Audrius
This should fix the recently submitted bug #13617: (https://savannah.gnu.org/bugs/?func=detailitem&item_id=13617) The reason of throwing that exception is that DefaultStyledDocument constructor tries to set the default style of the newly created StyledContext as its logical style. To get that sty

[cp-patches] Revised patch: JTable and DefaultTableColumnModel

2005-07-05 Thread David Gilbert
Attached is a revised version of the patch I proposed late last week. It adds implementations for the isCellEditable() and createDefaultColumnsFromModel() methods in JTable, and fixes some bugs uncovered while writing Mauve tests for the new methods. 2005-07-05 David Gilbert <[EMAIL PROTECTED]>

[cp-patches] FYI: minor API doc fixes in java.util.*

2005-07-05 Thread David Gilbert
I committed this patch to fix some minor problems in the API docs for the java.util.* package: 2005-07-05 David Gilbert <[EMAIL PROTECTED]> * java/util/BitSet.java: fixed minor problems in API docs, * java/util/Calendar.java: likewise, * java/util/Collections.java: likew

[cp-patches] FYI: fixes for JTable API docs

2005-07-05 Thread David Gilbert
I committed this patch to fix a lot of Eclipse warnings about the API docs for JTable: 2005-07-05 David Gilbert <[EMAIL PROTECTED]> * javax/swing/JTable.java: fixed API doc links all over. Regards, Dave Gilbert ? diff.txt Index: javax/swing/JTable.java ===

[cp-patches] FYI: Adding read/write to javax/swing/text/JTextComponent.java (fixing bug #13640)

2005-07-05 Thread Meskauskas Audrius
This should close the recently submitted bug #13640. These two missing methods are not complicated. As the field 'doc' is not directly assigned, I added the check for null. We do not know how the user may override setText. 2005-07-05 Audrius Meskauskas <[EMAIL PROTECTED]> * javax/swing/text