[cp-patches] RFC: fixed & implemented highlighting

2006-02-20 Thread Robert Schuster
Hi, I am surprised myself but I really got this working. :) What I fixed here are mainly drawing problems. The underlying representation of the highlighted area was mostly correct. There are some small glitches in the behavior which I am going to fix next. Please comment the patch. The ChangeLog

[cp-patches] FYI: fixed backward selection

2006-02-20 Thread Robert Schuster
Hi, in one of my former patches that added or modified the selection actions I introduced a problem where it was not possible to select the first entry in a document. This is fixed by this patch. 2006-02-20 Robert Schuster <[EMAIL PROTECTED]> * javax/swing/text/DefaultEditorKit.java: F

[cp-patches] Re: RFC: Scrollbar fixes for old Events and setting value

2006-02-20 Thread Thomas Fitzsimmons
On Mon, 2006-02-20 at 23:31 +0100, Mark Wielaard wrote: > Hi, > > The GtkScrollbarPeer wasn't setting the new value on the Scrollbar > component. And Component didn't handle translation of the > AdjustmentEvents to old style Events for use in handleEvent(). My test > application was using old styl

[cp-patches] RFC: Scrollbar fixes for old Events and setting value

2006-02-20 Thread Mark Wielaard
Hi, The GtkScrollbarPeer wasn't setting the new value on the Scrollbar component. And Component didn't handle translation of the AdjustmentEvents to old style Events for use in handleEvent(). My test application was using old style Events. It ignored the actual value in the Event. And tried to use

[cp-patches] Re: RFC: Some cairo error reporting help

2006-02-20 Thread Thomas Fitzsimmons
On Sat, 2006-02-18 at 17:20 +0100, Mark Wielaard wrote: > Hi, > > We currently just crash and burn when we have trouble with cairo. This > doesn't really help the user. The following make sure we output a stack > trace and reset the cairo status after a failed drawing operation. Which > will hopef

Re: [cp-patches] [generics] RFC: new Enum java.math.RoundingMode

2006-02-20 Thread Anthony Balkissoon
On Mon, 2006-02-20 at 15:09 -0500, Anthony Balkissoon wrote: > This is RFC because it's my first commit to the generics branch and I > just want to make sure there aren't any special procedures I forgot. > > 2006-02-20 Anthony Balkissoon <[EMAIL PROTECTED]> > > * java/math/RoundingMode:

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Olivier Jolly
Mark Wielaard a écrit : >Please do add a little comment for the isCoreObjectMethod() method >saying this. Just for people like me that might want to be clever and >update the code to be more efficient. Although your new Mauve patches >will now catch them if they try this :) > > > Ok, commited wi

[cp-patches] [generics] RFC: new Enum java.math.RoundingMode

2006-02-20 Thread Anthony Balkissoon
This is RFC because it's my first commit to the generics branch and I just want to make sure there aren't any special procedures I forgot. 2006-02-20 Anthony Balkissoon <[EMAIL PROTECTED]> * java/math/RoundingMode: New Enum. --Tony ? include/gnu_java_net_PlainDatagramSocketImpl.h ? in

[cp-patches] FYI: Make gnu charset Provider constructor package private

2006-02-20 Thread Mark Wielaard
Hi, Small patch to make the gnu charset Provider constructor package private. This prevents adding a new accessor when provider() creates a PrivilegedAction to create one. And helps with gcj 4.0.x which didn't create the accessor constructor at all. 2006-02-20 Mark Wielaard <[EMAIL PROTECTED]>

[cp-patches] Re: Zip patch, perhaps

2006-02-20 Thread Stuart Ballard
D'oh, screwed up the changelog (can you tell I copy and pasted it from my previous patch?) Obviously should have been: 2006-02-20 Stuart Ballard <[EMAIL PROTECTED]> * java/util/zip/ZipConstants.java (LOCSIG): Change type to long. (EXTSIG): Likewise. (CENSIG): Likewise.

[cp-patches] Zip patch, perhaps

2006-02-20 Thread Stuart Ballard
Embarrassingly, I can't actually get classpath to build - all of the compilers I've tried get upset in ways I so far haven't been able to diagnose. So this patch is untested to the point that I don't even know it compiles, let alone works and doesn't introduce regressions. I think it's pretty strai

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Mark Wielaard
Hi Olivier, On Mon, 2006-02-20 at 14:23 +0100, Olivier Jolly wrote: > First I wanted to implement it with a contains, but unfortunately, > contains relies on equals, which will check that the declaring class are > the same before saying that two methods are equals. In this case, we > know we ha

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Archie Cobbs
Olivier Jolly wrote: It's not an error for an interface to declare a method that matches an Object method (such as equals), and then for some bytecode somewhere to INVOKEINTERFACE that method, even though INVOKEVIRTUAL would "make more sense". E.g. code somewhere in Eclipse does this. No, it's n

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Olivier Jolly
Archie Cobbs wrote: Olivier Jolly wrote: [...] What does the failure look like? Within an InvocationHandler, the method instance which is given as parameter is not equals to Object.class.getDeclaredMethod("...", ...) if the interface the proxy is built on redefines one of the "core" Object m

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Archie Cobbs
Olivier Jolly wrote: I bumped into a major problem with spring and easymock which boiled down to being a subtle definition of a Proxy. In the case of the creation of a proxy which defines the same method as Object (which is non final and public), the method in the interface must be so that getD

[cp-patches] FYI: HTML Option

2006-02-20 Thread Roman Kennke
I implemented the Option class in javax.swing.text.html, which is needed for the HTML Renderer as a value class for lists. 2006-02-20 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/text/html/Option.java: New class. /Roman Index: javax/swing/text/html/Option.java ===

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Olivier Jolly
Archie Cobbs wrote: Olivier Jolly wrote: I bumped into a major problem with spring and easymock which boiled down to being a subtle definition of a Proxy. In the case of the creation of a proxy which defines the same method as Object (which is non final and public), the method in the interface

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Archie Cobbs
Olivier Jolly wrote: I bumped into a major problem with spring and easymock which boiled down to being a subtle definition of a Proxy. In the case of the creation of a proxy which defines the same method as Object (which is non final and public), the method in the interface must be so that getD

Re: [cp-patches] Patch: layout/validating fix

2006-02-20 Thread Lillian Angel
On Fri, 2006-02-17 at 14:34 -0500, Lillian Angel wrote: > 2006-02-17 Lillian Angel <[EMAIL PROTECTED]> > > * gnu/java/awt/peer/gtk/GtkComponentPeer.java > (setBounds): Removed check. Coordinates should always be changed > to incorporate the parent's coordinates. >

Re: [cp-patches] RFC: fix in proxy creation of interfaces redefining toString, equals or hashCode

2006-02-20 Thread Olivier Jolly
Re all, Mark Wielaard wrote: I just submitted a mauve testlet to stress this point and here is the proposition of fix in Proxy.java (for non native Proxy implementations, that's it). When iterating over the methods to be added to the proxy, if any is matching an Object one (by its name and param

Re: [cp-patches] FYI: fix for PR 26354

2006-02-20 Thread David Gilbert
Nice work Robert, especially the Mauve tests that back up your change! Regards, Dave Robert Schuster wrote: The attached patch file was empty. Here is the correct one. cya Robert Robert Schuster wrote: Hi, this patch contains my already approved fix for GapContent and another small chan

[cp-patches] FYI: BasicTextUI.damageRange

2006-02-20 Thread Roman Kennke
I implemented the stubbed method BasicTextUI.damageRange(). 2006-02-20 Roman Kennke <[EMAIL PROTECTED]> * javax/swing/plaf/basic/BasicTextUI.java (damageRange): Implemented this method. /Roman Index: javax/swing/plaf/basic/BasicTextUI.java ==

Re: [cp-patches] FYI: fix for PR 26354

2006-02-20 Thread Robert Schuster
The attached patch file was empty. Here is the correct one. cya Robert Robert Schuster wrote: > Hi, > this patch contains my already approved fix for GapContent and another small > change that fixes the remaining issue I was seeing. > > While the GapContent fix makes it possible to remove the 'd

[cp-patches] FYI: fix for PR 26354

2006-02-20 Thread Robert Schuster
Hi, this patch contains my already approved fix for GapContent and another small change that fixes the remaining issue I was seeing. While the GapContent fix makes it possible to remove the 'd' in this document correctly: abc def The change of the order of operations in AbstractDocument.remove m

Re: [cp-patches] RFC: GapContent.shiftEndUp

2006-02-20 Thread Roman Kennke
Hi Robert, Am Montag, den 20.02.2006, 02:33 +0100 schrieb Robert Schuster: > Hi, > although this patch is ridicously simple I ask for what others think about > it. I > too pen & paper to simulate what should happen in shiftGapEndUp and came to > the > conclusion that there is no reason why the m

[cp-patches] FYI: Proxy based RMI stub replacents implemented.

2006-02-20 Thread Audrius Meskauskas
This patch adds the 1.5 feature to replace the missing RMI stub classes by the dynamically created proxy stubs. Our Proxy is working great with jamvm. The stub classes that were previously generated by the RMIC compiler, are no longer required, unless for research stubs or backward compatibil