David Daney wrote:
In preparation for my next change, I committed this cleanup to
gnu/java/net/protocol/http/LimitedLengthInputStream.java.
Said change is not needed, the file is perfect as is, so I will leave it
just as the whitespace cleanup.
David Daney
In preparation for my next change, I committed this cleanup to
gnu/java/net/protocol/http/LimitedLengthInputStream.java.
2008-07-12 David Daney <[EMAIL PROTECTED]>
* gnu/java/net/protocol/http/LimitedLengthInputStream.java: Clean up
white space in entire file.
(handleClose):
o use the
sun/security variant and remove the gnu/java/security one.
Opinions?
Since we already have some sun.* packages, it seems fine to add more. I
would change everything over to refer to this new class and delete the
gnu/java/security one.
Just my $0.02,
David Daney
2008-06-03 R
ave to
allocate another array, we gain nothing over java.lang.StringBuilder
other than making the code more confusing. I am uncomfortable with this
change as well as the use of CPStringBuilder that makes it necessary.
Am I missing something here?
David Daney
re both reasons to apply it.
Thanks,
David Daney
you point to any benchmarks where this helps?
Thanks,
David Daney
David Daney wrote:
Andrew John Hughes wrote:
This adds our new non-copying variant of StringBuilder, which
I've called CPStringBuffer. It should be used internally where
we can get away with a non-synchronized non-copying string buffer.
ChangeLog:
I missed the change log par
String constructor.
In general I like this, but having to use reflection to invoke the
string constructor I think should be avoided.
David Daney
. Other
than that, it seems like a good idea.
David Daney
ntime to compensate for problems in an application. The
applications should add buffering themselves when appropriate.
David Daney
return avail;
}
}
}
#endif
JCL_ThrowException (env, IO_EXCEPTION, strerror (errno));
}
Perhaps:
if ((errno == ENOTTY)
&& (fstat (fd, &statBuffer) == 0)
&& S_ISREG (statBuffer.st_mode))
{
.
.
.
}
David Daney
u believe a check is missing?
David Daney
just call impl.create() from the Socket constructor?
David Daney
Regards,
Jeroen
Index: java/net/Socket.java
===
RCS file: /cvsroot/classpath/classpath/java/net/Socket.java,v
retrieving revision 1.61
diff -u -r1.61 Socket.java
---
7;+'? The compiler converts this to String[Buffer|Builder] when it
generates the byte code. IMO this patch makes the code much more
difficult to understand with *no* improvement in efficiency.
David Daney
David Daney wrote:
Roman Kennke wrote:
Hi again,
On most free JVMs that I know of (libgcj), array accesses are much
faster than the corresponding actions on a java.nio.Buffer.
I don't think so. The normal bytebuffer is also only an array. The
accessor methods should not make
the end of next week.
David Daney.
ce is that, in gcj for example, an array access is
translated in to a machine instruction that directly accesses the
desired element. Access through a java.nio.Buffer involves at least one
function call which is a much heavier weight operation.
David Daney
that on libgcj that there is no
difference on a benchmark that moves a lot of data through the changed
code, then I withdraw my objection.
David Daney
Tom Tromey already did the heavy lifting here. This patch just tweaks
it a bit.
2006-12-21 David Daney <[EMAIL PROTECTED])
* gnu/java/net/protocol/http/Headers.java: Update imports. Implement
Iterable.
(iterator): Make public.
* gnu/java/net/protocol/http/Request.j
In the spirit of using the new generic type capability of Classpath, and
because I already did it while looking at the bug in Collecions, I offer
up this nice patch.
In two of the HTTP support classes I converted a couple of things to use
generics.
2006-12-14 David Daney <[EMAIL PROTEC
This fixes the mauve regression noted by Paul Jenner for the
java.net.URLConnection.getHeaderFields test.
A case of slightly over zealous genericization.
2006-12-13 David Daney <[EMAIL PROTECTED]>
* java/lang/Collections.java
(UnmodifiableEntrySet.toArray): Fix bad
Casey Marshall wrote:
On Dec 13, 2006, at 12:21 PM, David Daney wrote:
Casey Marshall wrote:
On Dec 13, 2006, at 12:56 AM, Marco Trudel wrote:
Hey guys
java.util.Arrays.binarySearch(Object[] a, Object key, Comparator
c) exchanges a[i] and key, this can lead to ClassCastExceptions
as
there is no performance penalty, then we should follow
the behavior of the RI.
David Daney.
Jeroen Frijters wrote:
David Daney wrote:
Jeroen Frijters wrote:
throw new RuntimeException("error instantiating default
socket factory: "
- + ex.toString());
That sounds more like an InternalError than the sup
try
That sounds more like an InternalError than the super-generic
RuntimeException.
David Daney
I just committed this to fix my previous commit.
2006-12-08 David Daney <[EMAIL PROTECTED]>
* native/jni/java-nio/gnu_java_nio_VMChannel.c (is_non_blocking_fd):
Fix comment.
Index: native/jni/java-nio/gnu_java_nio_VMCha
I just committed this:
2006-12-08 David Daney <[EMAIL PROTECTED]>
* NEWS: Mention URLConnection.[get|set]ReadTimeout.
David Daney wrote:
This patch adds the missing [get|set]ReadTimeout methods to
java.net.URLConnection. It is lightly tested, but I will create some
mauve tests for it.
If there are no objections, I will commit it after a couple more of days
of testing.
2006-12-02 David Daney <[EM
David Daney wrote:
My new mauve test for the HTTP timeout patch I posed earlier this week
was failing miserably for me with jamvm/FC6-x86_64. I turns out the the
native socket code was slightly lacking. This patch fixes it up some.
I will commit both this patch and the HTTP timeout patch
of testing and if no objections are raised.
2006-12-08 David Daney <[EMAIL PROTECTED]>
* native/jni/java-nio/gnu_java_nio_VMChannel.c (is_non_blocking_fd):
New method.
(Java_gnu_java_nio_VMChannel_read__ILjava_nio_ByteBuffer_2): Throw
SocketTimeoutException if a blocking
io_connect (int fd, const struct sockaddr *addr, socklen_t addrlen)
{
int retcode;
do
{
retcode = connect (fd, addr, addrlen);
}
while (retcode == EINTR);
return retcode;
}
Except that you should probably also check if the thread was interrupted
as the original patch does for read and write.
David Daney.
This patch adds the missing [get|set]ReadTimeout methods to
java.net.URLConnection. It is lightly tested, but I will create some
mauve tests for it.
If there are no objections, I will commit it after a couple more of days
of testing.
2006-12-02 David Daney <[EMAIL PROTEC
nnel.send(buf, new InetSocketAddress(remote, port));
+ }
+catch (InterruptedIOException ioe)
+ {
+// Ignore; interrupted system call.
+ }
+ }
}
How does the while loop exit?
Just wondering,
David Daney
I just committed the fix for said PR. A test for this was also added to
mauve.
2006-09-20 David Daney <[EMAIL PROTECTED]>
PR classpath/28661
* gnu/java/net/protocol/http/HTTPURLConnection.java (connect): Add
default content-type for POST method.
Index: gnu/ja
ith ENOSYS.
Also I am running gcj/libgcj cross compiler and do not know how this
patch will interact with libgcj.
Well those are my concerns. I guess if things get broken by this we can
add a configure switch to manually disable it.
David Daney.
Tom Tromey wrote:
"David" == David Daney <[EMAIL PROTECTED]> writes:
David> Do we want to bring this into libgcj before this would be
David> imported also?
It is fine by me if you want to do this.
However, if we're going to import 0.92 it might be fri
would hang (instead of immediately
returning EOF).
Earlier today I committed a mauve testcase for this problem.
Do we want to bring this into libgcj before this would be imported also?
2006-08-11 David Daney <[EMAIL PROTECTED]>
PR classpath/28580
* gnu/java/net/pr
ood to me. I beleive this is the prefered idiom for clone() in
many cases. It seems that this is probably one of them, but not being
that familiar with this class I cannot say for sure.
David Daney.
refer a java implementation, but don't really have strong
feelings one way or the other.
David Daney
effort in this area.
David Daney.
nt i = start[0] + start[sub]; i < start[0] + end[sub]; i++)
+ sb.append(matchedCharIndexed.charAt(i));
+ return sb.toString();
+ }
Use StringBuilder instead of StringBuffer.
David Daney.
Wolfgang Baer wrote:
Hi David,
David Daney wrote:
Wolfgang Baer wrote:
Hi,
I wrote mauve tests for the various HttpURLConnection request properties
methods and notices some minor bugs in the new Headers implementation.
The patch fixes these and adds documentation to this class in more
putAll() is broken,
then the change should be made. But change just for change's sake I am
not so sure.
David Daney
This should solve the issue Christian was seeing.
Sorry about that :( Your fix is obviously correct.
David Daney.
David Daney wrote:
PR libgcj/26487 shows problems with our existing header handling.
I hacked up the attached patch, which needs more testing (please test it!)
The basic problem is that the headers were being held in a map which
scrambled them up if there were more than one header of the same
(returning the header names in
their original case in keySet() etc).
In order for the map to be at all useful, I would have to agree.
However if we mimic Sun's brilliant implementation (as shown by
Wolfgang's testing), we can (and must) just do it the easy way.
David Daney.
Wolfgang Baer wrote:
David Daney wrote:
Wolfgang Baer wrote:
[...]
Not correct.
These Maps are only modified internally to classpath. The RFC requires
header name comparisons to be case insensitive. The only way to make
the Map work with String keys is to ensure that the keys get
Wolfgang Baer wrote:
David Daney wrote:
Wolfgang Baer wrote:
Nice to see you have removed that now useless inner Header class. This
was one
of the comments I wanted to make. I worked this day on mauve testcases
for this
rewrite.
These exposed two small bugs in Headers.java:
Index: gnu
(k, l);
! }
! else
! l.add(e.value);
The second value must be added before. The test show
that SUN always adds the last received value for a
key first.
l.add(0, e.value);
Good catch!, I will make this change.
David Daney.
David Daney wrote:
PR libgcj/26487 shows problems with our existing header handling.
I hacked up the attached patch, which needs more testing (please test it!)
The basic problem is that the headers were being held in a map which
scrambled them up if there were more than one header of the same
David Daney wrote:
With this test case (just added to mauve):
import java.net.URL;
public class URLTest {
public static void main(String []args) {
try {
URL url = new URL("http://www.foo.bar.com";);
url = new URL(url, &qu
Olivier Jolly wrote:
Chris Burdess wrote:
David Daney wrote:
With this test case (just added to mauve):
import java.net.URL;
public class URLTest {
public static void main(String []args) {
try {
URL url = new URL("http://www.foo.bar.com";);
url
w for a ':' in the
specification to be appended to the context.
Given that it is explicitly allowed to have a ':' how would you handle this?
David Daney
David Daney.
append the spec to the context in this case instead of replacing
the context.
Unless objections are raised in the next 24 hours, I plan in committing
the folowing patch:
2006-02-28 David Daney <[EMAIL PROTECTED]>
* java/net/URL.java (URL(URL, String, URLStreamHandler)): Treat
spe
was to just hold the headers in a list. This makes some
searching operations less efficient, but seems the best way to keep the
headers from being combined.
Let me know what you think.
2006-02-28 David Daney <[EMAIL PROTECTED]>
* gnu/java/net/protocol/http/HTTPURLConnectio
As per the PR, HTTPURLConnection.getRequestProperties() was returning a
Map with Strings as values instead a Map of Lists of Strings as values.
I just committed this patch:
2006-02-27 David Daney <[EMAIL PROTECTED]>
PR classpath/25851
* gnu/java/net/protoco
David Daney wrote:
The basic problem was that ChunkedInputStream.skip() would skip on the
underlying InputStream. This bypassed the byte counting of the chunked
protocol resulting in failure on reads following the skip.
The fix is to extent InputStream instead of FilterInputStream, as its
I just committed the following to convert
gnu/java/net/protocol/http/HTTPURLConnection to use SystemProperties
instead of AccessController.
2006-02-27 David Daney <[EMAIL PROTECTED]>
* gnu/java/net/protocol/http/HTTPURLConnection.java
(imports): Clea
David Daney wrote:
Currently we keep a HTTP keep-alive connection open forever.
Although allowed by RFC 2616, this is forbidden by several other
specifications derived from it (DLNA and UPnP). In addition to being
incompatible with these other specification, it is a waste of resources
to
roach.
Comments?
2006-02-16 David Daney <[EMAIL PROTECTED]>
PR classpath/26312
* gnu/java/net/protocol/http/ChunkedInputStream.java (imports): Cleaned
up.
(ChunkedInputStream): Extend InputStream.
(in): New field.
(headers): Moved to t
OK today really is not my day WRT e-mail. I am going to try this one
more time.
Original Message
Subject: FYI: ChunkedInputStream.read()
Date: Thu, 16 Feb 2006 13:47:13 -0800
From: David Daney <[EMAIL PROTECTED]>
To: David Daney <[EMAIL PROTECTED]>
CC: Class
Wolfgang Baer wrote:
David Daney wrote:
Thanks, please update: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26081
as appropriate.
If this fixes that bug (which I think it does) the changelog should be
prefixed with 'PR classpath/26081'
Sorry forgot to include this in the changelo
Wolfgang Baer wrote:
Hi all,
Wolfgang Baer wrote:
Hi,
David Daney wrote:
Perhaps make isError() a member of Response
Yes, I also thought of this. Its in HTTPURLConnection because there is
already a method isRedirect(Response r). Both should be moved to Response.
Committed as attached
David Daney wrote:
+class GetPropertiesAction
+ implements PrivilegedAction
+{
+ public Object run()
+ {
+String ttl = System.getProperty("classpath.net.http.keepAliveTTL");
+connectionTTL = (ttl != null && ttl.length() > 0) ?
+
ainst GCC-4.1. If no objections are raised,
I will retest on the classpath HEAD before committing.
2006-02-08 David Daney <[EMAIL PROTECTED]>
PR classpath/26082
* gnu/java/net/protocol/http/HTTPConnection.java (pool): Changed to
type Pool.
(Pool): New
or doing this. As you can see from my PRs, this is something
that I was looking at and you just saved me a bunch of work.
David Daney
getInputStream()
throws an exception because of a 4?? or 5?? status code,
getErrorStream() must contain the response body if any.
connect() should only throw an exception if there are socket level
IOExceptions.
I will update PR 26081 to reflect my new understanding.
David Daney.
implementation does ?
Wolfgang
I don't know what to do WRT to this spec/reference implementation
disagreement, but this entire block of code is incorrect.
Please see:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=26081
David Daney.
Wolfgang Baer wrote:
Hi,
David Daney wrote:
Wolfgang Baer wrote:
+String expect = getHeader("Expect");
+if (expect != null && expect.equals("100-continue"))
^
This *may* have to be a case i
upper or lower case.
Other than that, I like the patch.
David Daney
xpect",
"100-Continue");
David Daney.
ader UNLESS it was
explicitly set by the calling code? My reading of RFC 2616 makes me
think that this is what we should do. If this makes sense submit a
patch that does this.
David Daney
wonder about throwing an exception if we don't recognize the
content-encoding. It seems to me that the caller might well recognize
it somehow.
How would you make this behavior compatible with java.net.*?
What exception would you throw?
What state would the co
think this code is incorrect, as it doesn't respect TTL
properly. I would like to remove it, which is what this patch does.
Comments?
I agree. The standard C library takes care of DNS caching (via nscd) on
most systems, so this extra cache would have no added benefit.
D
Christian Thalinger wrote:
Hi!
While checking some FAILs in tgolem i stumbled across this common fail:
FAIL: gnu.testlet.java.net.InetSocketAddress.InetSocketAddressTest:
Error : test_Constructors failed - 1 No wildcard address returned
(number 1)
I searched a bit and i think toString() return
t this is [EMAIL PROTECTED] Shouldn't this go to mauve-patches ?
David Daney.
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
cks are performed: If there is a
Gary> security manager, the security manager's checkMemberAccess
Gary> method is called with this and Member.PUBLIC...".
Interesting. The 1.5 text is different.
Indeed, no superclass checks. Interesting.
Perhaps the ver
Its constructor could take a String parameter which would be the
exception message.
David Daney.
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
Gary Benson wrote:
David Daney wrote:
Gary Benson wrote:
...I'll commit my original patch for now.
I hate to sound like I have a burr under the saddle, but does
anybody see any merit whatsoever in changing the exception text
as I suggested in my previous response to the patch?
Wha
r now.
I hate to sound like I have a burr under the saddle, but does anybody
see any merit whatsoever in changing the exception text as I suggested
in my previous response to the patch?
David Daney.
___
Classpath-patches mailing list
Classpa
platforms other than your
own, does not imply that they do not exist.
David Daney
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
he exception messages should reflect that.
David Daney.
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches
I guess the subject says it all.
2005-11-18 David Daney <[EMAIL PROTECTED]>
* AUTHORS (David Daney): New entry.
Index: AUTHORS
===
RCS file: /cvsroot/classpath/classpath/AUTHORS,v
retrieving revision 1.30
diff -u
ns if the replacement string
contains the target string.
Thanks Tom. I fixed this now, it uses a StringBuffer for better
performance and also only checks for occurrences of the target string
Try StringBuilder instead of StringBuffer.
David Daney
___
C
swing?
If we do this, wouldn't it logically follow that we should make all of
swing reentrant/thread-safe?
Perhaps a better approach would be to fix the calling code.
David Daney.
___
Classpath-patches mailing list
Classpath-patches@gn
2005-10-21 David Daney <[EMAIL PROTECTED]>
* NEWS: Added entry about HttpURLConnection improvements.
Index: NEWS
===
RCS file: /cvsroot/classpath/classpath/NEWS,v
retrieving revision 1.98
retrieving revision 1.99
d
me is consumed in allocations and coping of the buffer.
You also might want to look at comment #1 of:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21869
David Daney.
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/ma
redundant buffering
causes more memory and CPU resources to be used to allocate and move
data through all the buffers.
Tested with make -k check in GCJ libjava(HEAD) + mauve + jacks with no
regressions.
2005-10-12 David Daney <[EMAIL PROTECTED]>
PR classpath/24259
* gnu/ja
Jeroen Frijters wrote:
David Daney wrote:
Jeroen Frijters wrote:
David Daney wrote:
LimitedLengthInputStream shouldn't have a finalize().
Let's consider the case where a client program did not read
the entire body of the response:
As implemented in the patch, the finalize
Jeroen Frijters wrote:
David Daney wrote:
LimitedLengthInputStream shouldn't have a finalize().
Let's consider the case where a client program did not read the entire
body of the response:
As implemented in the patch, the finalize is indeed needed to clean up
the mess and
This one has been aging for about a week:
http://lists.gnu.org/archive/html/classpath-patches/2005-10/msg00054.html
This one is a little fresher, but as long as I am pinging I thought what
the heck:
http://lists.gnu.org/archive/html/classpath-patches/2005-10/msg00153.html
Thanks,
David
allocate and move
data through all the buffers.
Tested with make -k check in GCJ libjava(HEAD) + mauve + jacks with no
regressions.
2005-10-07 David Daney <[EMAIL PROTECTED]>
PR classpath/24259
* gnu/java/net/LineInputStream.java: Import BufferedInputStream.
(Const
x-gnu with no
regressions. Additional ad hoc testing to verify connection re-use with
Connection: keep-alive for multiple GET and POST requests.
2005-09-29 David Daney <[EMAIL PROTECTED]>
PR classpath/24086, PR classpath/24091:
* gnu/java/net/pr
, and not the key
calculations? An io/nio/net bug perhaps?
I have been debugging some HTTP things and have found ethereal to be a
good friend. If you suspect a problem in the underlying networking
code, looking at the raw bits going over the network might be the only
Soft and Weak references. So the
end effect is that your approach would do very little caching. A
limited size cache using LRU purging and hard references on the other
hand would work well.
David Daney.
___
Classpath-patches mailing list
Clas
e
day :-)
Sorry to rain on your parade. But all these man-hours of discussion
guarantee that this portion of the code is bug free and thus will never
be executed.
David Daney.
___
Classpath-patches mailing list
Classpath-patches@gnu.org
Tom Tromey wrote:
"David" == David Daney <[EMAIL PROTECTED]> writes:
David> Anthony Green wrote:
- // XXX - Ignore coding exceptions? They shouldn't really happen.
- return null;
+ // This shouldn't really happen.
+ throw new Err
Anthony Green wrote:
- // XXX - Ignore coding exceptions? They shouldn't really happen.
- return null;
+ // This shouldn't really happen.
+ throw new Error(e);
Whould it be better to use InternalError? That is a little more specific.
D
or Boolean.FALSE) so the
ultimate effect should be the same.
None of this is necessary. But we do it anyway to make the code better.
For me Boolean.TRUE reads much more cleanly than Boolean.valueOf(true).
I think it improbable that it is less effici
rent than for the more general purpose public API that is
ByteArrayOutputStream.toString.
Any non ASCII characters in the response/headers are in violation of the
RFC. So it probably does not matter what we do, what ever is
easiest/most efficient is probably best.
David Daney
1 - 100 of 106 matches
Mail list logo
