Re: [cp-patches] [PATCH] Fix Use ArrayList.add() in StyleSheet.resolveStyle

2011-03-15 Thread Dr Andrew John Hughes
On 12:55 Tue 15 Mar , Pekka Enberg wrote: > Hi Andrew, > > On Tue, Mar 15, 2011 at 12:47 PM, Dr Andrew John Hughes > wrote: > > Please just make it clear what you're asking for.  If it's a fix > > you're sure about, then just post to the patches > > list with the FYI: subject prefix and commi

Re: [cp-patches] [PATCH] Fix Use ArrayList.add() in StyleSheet.resolveStyle

2011-03-15 Thread Pekka Enberg
Hi Andrew, On Tue, Mar 15, 2011 at 12:47 PM, Dr Andrew John Hughes wrote: > Please just make it clear what you're asking for.  If it's a fix > you're sure about, then just post to the patches > list with the FYI: subject prefix and commit straight away.  If not, > prefix the subject with RFC: and

Re: [cp-patches] [PATCH] Fix Use ArrayList.add() in StyleSheet.resolveStyle

2011-03-15 Thread Dr Andrew John Hughes
On 14 March 2011 21:56, Pekka Enberg wrote: > Hi Andrew! > > On Mon, Mar 14, 2011 at 11:46 PM, Dr Andrew John Hughes > wrote: >> Thanks for catching this bug.  I was going to approve it but you seem to >> have already committed >> it -- why??? > > I thought that'd be OK since the fix was pretty

Re: [cp-patches] [PATCH] Fix Use ArrayList.add() in StyleSheet.resolveStyle

2011-03-14 Thread Pekka Enberg
Hi Andrew! On Mon, Mar 14, 2011 at 11:46 PM, Dr Andrew John Hughes wrote: > Thanks for catching this bug.  I was going to approve it but you seem to have > already committed > it -- why??? I thought that'd be OK since the fix was pretty simple and I was able to work out why the regression was t

Re: [cp-patches] [PATCH] Fix Use ArrayList.add() in StyleSheet.resolveStyle

2011-03-14 Thread Dr Andrew John Hughes
On 22:07 Thu 10 Mar , Pekka Enberg wrote: > The following cleanup patch: > > More warning fixes. > > 2009-03-09 Andrew John Hughes > > [snip] > > * javax/swing/text/html/StyleSheet.java: > Add generic typing. > > changed the code to do ArrayList.set() on an insta

[cp-patches] [PATCH] Fix Use ArrayList.add() in StyleSheet.resolveStyle

2011-03-10 Thread Pekka Enberg
The following cleanup patch: More warning fixes. 2009-03-09 Andrew John Hughes [snip] * javax/swing/text/html/StyleSheet.java: Add generic typing. changed the code to do ArrayList.set() on an instance thats allocated like this: List> attributes = new Array