Re: [Click] nsclick rng support for ns3

2013-01-25 Thread Sascha Alexander Jopen
Hey, i just tested this new patchset for random number support. It includes fallback to userlevel random() or rand() in case of lacking support on the ns3 side. Furthermore, ns3 returns random numbers in the range [0, CLICK_RAND_MAX] whatever CLICK_RAND_MAX is on the platform where click was

Re: [Click] nsclick rng support for ns3

2013-01-25 Thread Eddie Kohler
Hi Sascha! I like this one much better, and checked in a version of it with a few changes. - Explicit case for srandom() which does nothing - Don't chatter if no node, just fall back to user level - No userlevel_random(), just put click_random() in ns/nsclick.cc I hope it works for you. If it

Re: [Click] nsclick rng support for ns3

2013-01-25 Thread Sascha Alexander Jopen
Hi Eddie, but shouldn't we allow seeding the userlevel random number generator, in case there is no support for ns3 random numbers? I do not have any git repositories and do not understand git workflows very well. Do i have to create a github repository as a fork of the click git repository to

Re: [Click] nsclick rng support for ns3

2013-01-25 Thread Eddie Kohler
It's well worth your time to learn Git. It's very, very easy to fork a repository on Github—sign up, and then it's one click. That said I'm happy to take patches if that's much easier for you. I felt it was better to have uniform seeding behavior on NS: seeding *never* works. That's more self

Re: [Click] nsclick rng support for ns3

2013-01-23 Thread Lalith Suresh
Hi, On Mon, Jan 21, 2013 at 12:16 PM, Sascha Alexander Jopen jo...@informatik.uni-bonn.de wrote: Hey, please find attached a patchset for click and ns3 which adds support for drawing random numbers within click simulations from the underlying ns3 random number generator. Each simulated click

Re: [Click] nsclick rng support for ns3

2013-01-23 Thread Eddie Kohler
Hey, Two comments. - Breaking random numbers except for nses that export random numbers considered lame. Why not fall back to the normal random number generator? - The RAND_MAX value seems odd. (-2??) Why this value? Eddie On Wed, Jan 23, 2013 at 3:52 AM, Lalith Suresh suresh.lal...@gmail.com

Re: [Click] nsclick rng support for ns3

2013-01-23 Thread Sascha Alexander Jopen
Hi Eddie, I did not implement a fallback method, because i was not sure how to handle CLICK_RAND_MAX in case a fall back is necessary. In include/click/glue.hh CLICK_RAND_MAX is defined as the maximum value supported by the ns3 implementation. However, if we find the simulator not supporting

Re: [Click] nsclick rng support for ns3

2013-01-23 Thread Eddie Kohler
Why not just set the CLICK_RAND_MAX to 0x7FFFU, which NS can handle as well as normal code? Eddie On 1/23/13 12:35 PM, Sascha Alexander Jopen wrote: Hi Eddie, I did not implement a fallback method, because i was not sure how to handle CLICK_RAND_MAX in case a fall back is necessary. In