On Wed, 17 Nov 2021 00:57:47 GMT, Alexander Zuev wrote:
> Before the new JList accessibility peer implementation sending popup closed
> event to the combobox popup could trigger the native memory access error due
> to the events arriving in the wrong order. After new implementation is done
> it i
On Wed, 13 Oct 2021 07:35:16 GMT, Andrey Turbanov wrote:
>> 8274893: Update java.desktop classes to use try-with-resources
>
> Andrey Turbanov has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8274893: Update java.desktop classes to use try
On Wed, 27 Oct 2021 12:42:50 GMT, Prasanta Sadhukhan
wrote:
> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
> an attempt to fix the swing tests.
> It was seen from the logs that we have color mismatch in these tests.
>
> For example, in PressedIcon test, we had f
On Wed, 17 Nov 2021 08:13:09 GMT, Masanori Yano wrote:
>> I suggest leaving it as is for some time, since it is known that could
>> workaround another bug, linked below.
>
> @mrserb Can I hope this fix will be integrated after JDK-8270874 is fixed?
Yes.
-
PR: https://git.openjdk.j
On Wed, 17 Nov 2021 17:08:36 GMT, Alexander Zuev wrote:
>> Alisen Chung has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - removed trailing whitespace
>> - test change
>
> test/jdk/java/awt/Scrollbar/AquaLFScrollbarTest/ScrollBarBorderTe
On Wed, 17 Nov 2021 00:57:47 GMT, Alexander Zuev wrote:
> Before the new JList accessibility peer implementation sending popup closed
> event to the combobox popup could trigger the native memory access error due
> to the events arriving in the wrong order. After new implementation is done
> it i
On Wed, 17 Nov 2021 19:25:15 GMT, Andrey Turbanov wrote:
>> Non-static classes hold a link to their parent classes, which in many cases
>> can be avoided.
>> I updated only private and package-private classes. Didn't touch
>> public/protected to not break external code.
>> Similar cleanup in ja
> Non-static classes hold a link to their parent classes, which in many cases
> can be avoided.
> I updated only private and package-private classes. Didn't touch
> public/protected to not break external code.
> Similar cleanup in java.base -
> [JDK-8261880](https://bugs.openjdk.java.net/browse/
On Wed, 17 Nov 2021 14:32:16 GMT, Alexey Ivanov wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> [PATCH] Change nested classes in java.desktop to static nested classes
>> fix review comments
>
> src/java.deskto
> Non-static classes hold a link to their parent classes, which in many cases
> can be avoided.
> I updated only private and package-private classes. Didn't touch
> public/protected to not break external code.
> Similar cleanup in java.base -
> [JDK-8261880](https://bugs.openjdk.java.net/browse/
On Wed, 17 Nov 2021 19:21:49 GMT, Andrey Turbanov wrote:
>> Non-static classes hold a link to their parent classes, which in many cases
>> can be avoided.
>> I updated only private and package-private classes. Didn't touch
>> public/protected to not break external code.
>> Similar cleanup in ja
> Adjusted the AquaLF scrollbar to account for border inset settings when
> dragging the thumb and clicking on the track.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
added summary and copyright
-
Changes:
- all: h
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Wed, 17 Nov 2021 00:57:47 GMT, Alexander Zuev wrote:
> Before the new JList accessibility peer implementation sending popup closed
> event to the combobox popup could trigger the native memory access error due
> to the events arriving in the wrong order. After new implementation is done
> it i
On Tue, 16 Nov 2021 23:53:53 GMT, Alexander Zuev wrote:
> Added implementation for all menu related protocol peers;
> Native methods moved to CommonComponentAccessibility so they are called on
> correct peers;
This pull request has now been integrated.
Changeset: 8f5a8f74
Author:Alexander
On Mon, 15 Nov 2021 17:33:09 GMT, Alisen Chung wrote:
>> Adjusted the AquaLF scrollbar to account for border inset settings when
>> dragging the thumb and clicking on the track.
>
> Alisen Chung has updated the pull request incrementally with two additional
> commits since the last revision:
>
On Wed, 17 Nov 2021 16:57:20 GMT, Alexander Zuev wrote:
>> Added implementation for all menu related protocol peers;
>> Native methods moved to CommonComponentAccessibility so they are called on
>> correct peers;
>
> Alexander Zuev has updated the pull request incrementally with two additional
> Added implementation for all menu related protocol peers;
> Native methods moved to CommonComponentAccessibility so they are called on
> correct peers;
Alexander Zuev has updated the pull request incrementally with two additional
commits since the last revision:
- Fixed parameters layout for
On Wed, 17 Nov 2021 09:45:16 GMT, Artem Semenov wrote:
>> Alexander Zuev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fixed parameters layout for better readeability;
>> - Fixed indentation of native methods;
>>Fixed initial ca
On Wed, 17 Nov 2021 09:55:19 GMT, Anton Tarasov wrote:
>> Alexander Zuev has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fixed parameters layout for better readeability;
>> - Fixed indentation of native methods;
>>Fixed initial ca
On Wed, 17 Nov 2021 09:58:14 GMT, Anton Tarasov wrote:
> Besides what @savoptik mentioned, I left only cosmetics comments. Overall
> looks ok to me.
Cosmetics are also important so i fixed them too.
-
PR: https://git.openjdk.java.net/jdk/pull/6421
On Thu, 14 Oct 2021 07:47:33 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which in many cases
> can be avoided.
> I updated only private and package-private classes. Didn't touch
> public/protected to not break external code.
> Similar cleanup in java.ba
On Wed, 10 Nov 2021 05:47:46 GMT, Phil Race wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Review fix
>> - Fix
>
> I don't see a reason to discard the various stability improvements.
> The discussion is l
On Wed, 17 Nov 2021 08:53:07 GMT, Jeremy wrote:
>> This removes code that relied on consulting the Bezier control points to
>> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward
>> to convert the Bezier control points into the x & y parametric equations. At
>> their m
On Tue, 16 Nov 2021 23:53:53 GMT, Alexander Zuev wrote:
> Added implementation for all menu related protocol peers;
> Native methods moved to CommonComponentAccessibility so they are called on
> correct peers;
Besides what @savoptik mentioned, I left only cosmetics comments. Overall looks
ok t
On Tue, 16 Nov 2021 23:53:53 GMT, Alexander Zuev wrote:
> Added implementation for all menu related protocol peers;
> Native methods moved to CommonComponentAccessibility so they are called on
> correct peers;
src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m
On Tue, 16 Nov 2021 04:46:07 GMT, Jeremy wrote:
>> This removes code that relied on consulting the Bezier control points to
>> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward
>> to convert the Bezier control points into the x & y parametric equations. At
>> their m
> This removes code that relied on consulting the Bezier control points to
> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward
> to convert the Bezier control points into the x & y parametric equations. At
> their most complex these equations are cubic polynomials, so
On Sun, 14 Nov 2021 05:55:35 GMT, Sergey Bylokhov wrote:
>> @mrserb How long will it take to review this fix?
>
> I suggest leaving it as is for some time, since it is known that could
> workaround another bug, linked below.
@mrserb Can I hope this fix will be integrated after JDK-8270874 is fi
30 matches
Mail list logo
