Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v6]

2022-03-22 Thread Srinivas Mandalika
> Create a regression test for CCC8000326 > > Issue is identified by > [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which > identifies that after focus moves into JMenuBar, whose focus traversal key is > disabled by default, it never moves to other focusable component. > >

Re: RFR: 8283507: Create a regression test for RFE 4287690 [v2]

2022-03-22 Thread Manukumar V S
> Create a regression test for > [JDK-4287690](https://bugs.openjdk.java.net/browse/JDK-4287690) > Issue description: > I want JComboBox to send an event just before the popup (drop down) list is > displayed. > > Fix: > This requires some additional API targeted for major release of the JDK > (

Integrated: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale

2022-03-22 Thread Ichiroh Takiguchi
On Sat, 26 Feb 2022 16:24:07 GMT, Ichiroh Takiguchi wrote: > On AIX ko_KR locale, I could see following exception after JTable.print() was > called > > java.nio.charset.UnsupportedCharsetException: sun.font.X11KSC5601 > at java.base/java.nio.charset.Charset.forName(Charset.java:527) >

Re: RFR: 8283493: Create an automated regression test for RFE 4231298 [v2]

2022-03-22 Thread Sergey Bylokhov
On Tue, 22 Mar 2022 15:41:19 GMT, Manukumar V S wrote: >> Create a regression test for >> [JDK-4231298](https://bugs.openjdk.java.net/browse/JDK-4231298) >> Issue: >> When a JComboBox first drops down, the renderer is called for >> every element in the list, even those elements that will not >>

Re: RFR: JDK-8283015: Create a test for JDK-4715496 [v2]

2022-03-22 Thread Sergey Bylokhov
On Mon, 14 Mar 2022 06:29:30 GMT, Srinivas Mandalika wrote: >> Create a test for JDK-4715496 >> >> Issue observed in the above bug is that the >> JTable.AccessibleJTableCell.getAccessible name returns the cell instance >> string instead of the cell text. >> The test is being added to verify t

Re: RFR: 8282422: JTable.print() failed with UnsupportedCharsetException on AIX ko_KR locale

2022-03-22 Thread Sergey Bylokhov
On Sat, 26 Feb 2022 16:24:07 GMT, Ichiroh Takiguchi wrote: > On AIX ko_KR locale, I could see following exception after JTable.print() was > called > > java.nio.charset.UnsupportedCharsetException: sun.font.X11KSC5601 > at java.base/java.nio.charset.Charset.forName(Charset.java:527) >

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v4]

2022-03-22 Thread Phil Race
On Wed, 16 Mar 2022 06:02:28 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional com

Integrated: 8283457: [macos] libpng build failures with Xcode13.3

2022-03-22 Thread Phil Race
On Tue, 22 Mar 2022 18:53:20 GMT, Phil Race wrote: > Disable a warning from the Xcode 13.3 clang compiler when compiling libpng, > which is used by libsplashscreen. > > Policy is not to change the upstream code locally unless it is also changed > in the same way upstream. > We could consider r

Re: RFR: 8283457: [macos] libpng build failures with Xcode13.3

2022-03-22 Thread Erik Joelsson
On Tue, 22 Mar 2022 18:53:20 GMT, Phil Race wrote: > Disable a warning from the Xcode 13.3 clang compiler when compiling libpng, > which is used by libsplashscreen. > > Policy is not to change the upstream code locally unless it is also changed > in the same way upstream. > We could consider r

RFR: 8283457: [macos] libpng build failures with Xcode13.3

2022-03-22 Thread Phil Race
Disable a warning from the Xcode 13.3 clang compiler when compiling libpng, which is used by libsplashscreen. Policy is not to change the upstream code locally unless it is also changed in the same way upstream. We could consider reporting it upstream but libpng releases are very infrequent. --

RFR: 8283507: Create a regression test for RFE 4287690

2022-03-22 Thread Manukumar V S
Create a regression test for [JDK-4287690](https://bugs.openjdk.java.net/browse/JDK-4287690) Issue description: I want JComboBox to send an event just before the popup (drop down) list is displayed. Fix: This requires some additional API targeted for major release of the JDK (1.4).The PopupMenu

Re: RFR: 8283493: Create an automated regression test for RFE 4231298 [v2]

2022-03-22 Thread Manukumar V S
> Create a regression test for > [JDK-4231298](https://bugs.openjdk.java.net/browse/JDK-4231298) > Issue: > When a JComboBox first drops down, the renderer is called for > every element in the list, even those elements that will not > actually be drawn on the screen. > > Fix: > Introduced new API

RFR: 8283493: Create an automated regression test for RFE 4231298

2022-03-22 Thread Manukumar V S
Create a regression test for [JDK-4231298](https://bugs.openjdk.java.net/browse/JDK-4231298) Issue: When a JComboBox first drops down, the renderer is called for every element in the list, even those elements that will not actually be drawn on the screen. Fix: Introduced new API to JComboBox: get

Re: RFR: 8282771 : Create test case for JDK-8262981 [v3]

2022-03-22 Thread lawrence . andrews
On Mon, 21 Mar 2022 16:52:26 GMT, Alexandre Iline wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed review comments > > test/jdk/javax/accessibility/JSlider/AccessibleAction/JSliderAccessibleAction.java >

Re: RFR: 8282771 : Create test case for JDK-8262981 [v4]

2022-03-22 Thread lawrence . andrews
> Following methods are covered in this testcase > getAccessibleAction() > getAccessibleActionCount() > doAccessibleAction(int direction) > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Fixed review comments

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v5]

2022-03-22 Thread Maxim Kartashev
On Tue, 22 Mar 2022 13:24:15 GMT, Alexey Ivanov wrote: >> Let's give a while for Sergey and/or Phil to take a look. If no comments are >> received by this evening in Europe, I'll sponsor it. > >> @aivanov-jdk ping > > Sorry, @mkartashev, it slipped from my mind on Wednesday. And I decided not

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v5]

2022-03-22 Thread Alexey Ivanov
On Wed, 16 Mar 2022 13:41:26 GMT, Alexey Ivanov wrote: >> Maxim Kartashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reverted HiDPIRobotScreenCaptureTest back to 8280861 with minor changes > > Let's give a while for Sergey and/or Ph

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v2]

2022-03-22 Thread Alexey Ivanov
On Fri, 11 Mar 2022 13:58:11 GMT, Srinivas Mandalika wrote: > This review is for migrating tests from a closed test suite to open. If you know when the test was first introduced, please update the copyright year to include the year when the test was originally written. - PR: http

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v5]

2022-03-22 Thread Alexey Ivanov
On Thu, 17 Mar 2022 08:13:20 GMT, Srinivas Mandalika wrote: >> Create a regression test for CCC8000326 >> >> Issue is identified by >> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which >> identifies that after focus moves into JMenuBar, whose focus traversal key >> is di

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v2]

2022-03-22 Thread Tejesh R
On Tue, 22 Mar 2022 11:30:13 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > src/java.desktop/share/classes/javax/swing/ImageIcon.java line 341: > >> 339:

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v2]

2022-03-22 Thread Alexey Ivanov
On Tue, 22 Mar 2022 06:45:23 GMT, Tejesh R wrote: >> Removed the println() line from the Interrupted catch block. Since >> waitForID() Interrupt indicates completion of Image Loading, println as >> Interrupt handling was not required. > > Tejesh R has updated the pull request incrementally with

Integrated: JDK-8283087: Create a test or JDK-4715503

2022-03-22 Thread Srinivas Mandalika
On Mon, 14 Mar 2022 09:28:50 GMT, Srinivas Mandalika wrote: > Create a test or > [JDK-4715503](https://bugs.openjdk.java.net/browse/JDK-4715503) > > The getAccessibleContext method for JTable column header cells returns an > AccessibleContext which cannot get the Bounding Rectangle for table