On Mon, 2 May 2022 11:31:17 GMT, Tejesh R wrote:
> The Test had been updated to use all Supported Look and Feel in closed repo.
> The same has been moved to open repo.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/8500
On Wed, 11 May 2022 16:00:32 GMT, Maxim Kartashev
wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust API level to Windows 8 for security.cpp and do some cleanup
>
> This change seem to have made this group
> Issue was when printing a JTable which sits inside a JScrollPane and the
> table is scrolled down to the end to about 1000th row, only the first page is
> printed.
> This is because when the table is scrolled down to last page, the bounds.y
> becomes -ve
> [x=0,y=-15260,width=968,height=1600
On Wed, 11 May 2022 18:01:27 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test updated
>
> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 63:
>
>> 61: + " T
On Wed, 11 May 2022 20:58:37 GMT, Phil Race wrote:
>> This replaces the PR from Toshio https://git.openjdk.java.net/jdk/pull/8329
>> It is similar in the idea from what we converged on towards the end there but
>> 1) I'd like to preserve all the support for the old encodings since JEP-400
>> ex
On Thu, 12 May 2022 01:27:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Wed, 11 May 2022 13:47:43 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/jdk.jpackage/linux/native/applauncher/LinuxPackage.c line 193:
>
>> 191
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
> src/hotspot/share/jfr/
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
> src/hotspot/share/jfr/
On Wed, 11 May 2022 13:43:55 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/java.base/unix/native/libjli/java_md_common.c line 135:
>
>> 133: i
On Wed, 11 May 2022 14:27:27 GMT, Kim Barrett wrote:
>> src/java.base/share/native/libjli/java.c line 1629:
>>
>>> 1627: const char *arg = jargv[i];
>>> 1628: if (arg[0] == '-' && arg[1] == 'J') {
>>> 1629: *nargv++ = (arg[2] == '\0') ? NULL : JLI_StringDup(arg +
>>>
On Wed, 11 May 2022 13:35:43 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/hotspot/share/utilities/compilerWarnings_gcc.hpp line 51:
>
>> 49:
>>
On Wed, 11 May 2022 19:11:16 GMT, Phil Race wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 462:
>>
>>> 460:HARFBUZZ_DISABLED_WARNINGS_gcc := type-limits
>>> missing-field-initializers strict-aliasing
>>> 461:HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := reorder
>>> delete-non-
> In Windows, when desktop scaling is changed the tray icons was
> distorted/blurred a bit each time scaling changes.
>
> With the proposed fix, the tray icon scales according to on-the-fly DPI scale
> settings. A test case has been added which adds a MRI icon to system tray, to
> observe the i
On Tue, 10 May 2022 23:17:36 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
On Mon, 25 Apr 2022 22:36:59 GMT, lawrence.andrews
wrote:
> 1) Removed yesno to eliminate parserException
> 2) Added code to fit into manual framework so that timeout, pass & fail is
> handled.
> 3) Added code to mark the test as pass if printer service is not available
> 4) Added code to handl
On Fri, 29 Apr 2022 22:39:28 GMT, lawrence.andrews
wrote:
> 1) Removed Applet dependent code and used Frame as top level.
> 2) Automated the manual test.
>
> @shurymury
This pull request has now been integrated.
Changeset: 44a60ce1
Author:lawrence.andrews
Committer: Phil Race
URL:
On Tue, 26 Apr 2022 19:42:05 GMT, DamonGuy wrote:
> The insets for buttons were incorrect for L&Fs except for Aqua when the text
> is set to HTML. This was fixed in Aqua by adding a conditional to check for
> the BasicHTML property key in the button component. This same logic can be
> used to
On Wed, 11 May 2022 20:40:17 GMT, Naoto Sato wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8285308
>
> src/java.desktop/windows/classes/sun/awt/windows/WFontConfiguration.java line
> 267:
>
>> 265:
> This replaces the PR from Toshio https://git.openjdk.java.net/jdk/pull/8329
> It is similar in the idea from what we converged on towards the end there but
> 1) I'd like to preserve all the support for the old encodings since JEP-400
> explicitly supports using -Dfile.encoding=windows-31j (for
On Wed, 11 May 2022 18:25:09 GMT, Phil Race wrote:
> This replaces the PR from Toshio https://git.openjdk.java.net/jdk/pull/8329
> It is similar in the idea from what we converged on towards the end there but
> 1) I'd like to preserve all the support for the old encodings since JEP-400
> explic
On Wed, 11 May 2022 17:27:38 GMT, Phil Race wrote:
> As per the bug report and the CSR (please review that too), this makes AWT
> load in headless mode
> if only headless libraries are installed.
>
> It passes all our normal testing which at least should show that this doesn't
> regress anythi
On Wed, 11 May 2022 17:27:38 GMT, Phil Race wrote:
> As per the bug report and the CSR (please review that too), this makes AWT
> load in headless mode
> if only headless libraries are installed.
>
> It passes all our normal testing which at least should show that this doesn't
> regress anythi
On Wed, 11 May 2022 13:35:00 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 462:
>
>> 460:HAR
On Wed, 11 May 2022 13:08:11 GMT, Alexey Ivanov wrote:
>>Disabling Direct3D with -Dsun.java2d.d3d=false changes nothing.
That rules out a pipeline issue so I've no idea.
Fortunately Windows 11 still has lower adoption than Windows XP usage :-)
That's a real stat btw.
-
PR: https:/
This replaces the PR from Toshio https://git.openjdk.java.net/jdk/pull/8329
It is similar in the idea from what we converged on towards the end there but
1) I'd like to preserve all the support for the old encodings since JEP-400
explicitly supports using -Dfile.encoding=windows-31j (for example)
As per the bug report and the CSR (please review that too), this makes AWT load
in headless mode
if only headless libraries are installed.
It passes all our normal testing which at least should show that this doesn't
regress anything.
I had to manually remove libawt_xawt.so to verify that it wil
On Tue, 10 May 2022 06:26:29 GMT, Prasanta Sadhukhan
wrote:
>> Issue was when printing a JTable which sits inside a JScrollPane and the
>> table is scrolled down to the end to about 1000th row, only the first page
>> is printed.
>> This is because when the table is scrolled down to last page,
I checked you pr look good to me @Roger
Le mer. 11 mai 2022 à 15:35, Roger Riggs a écrit :
> On Wed, 11 May 2022 13:27:38 GMT, Adam Sotona wrote:
>
> >> That's good to know. I think the tricky part is mostly about keeping
> track of all these disabled warnings, so they are not kept around longe
On Wed, 20 Apr 2022 23:35:10 GMT, lukeu wrote:
>> Made a small change with the bottom line to match the left line of the border
>
>> Made a small change with the bottom line to match the left line of the border
>
> Great, that looks like it'll fix it so I won't test again, I'll defer to the
> o
On Mon, 9 May 2022 19:45:49 GMT, Zhengyu Gu wrote:
>> Please review this small patch that releases temporary charsets to avoid
>> memory leak.
>>
>> Test:
>>
>> - [x] jdk_2d
>
> Zhengyu Gu has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 11 May 2022 16:20:00 GMT, Alexander Zuev wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TableAccessibility.m
>> line 141:
>>
>>> 139: [rowCache removeObjectForKey:key];
>>> 140: }
>>> 141: cacheValid = YES;
>>
>> It seems to me that here it i
On Wed, 11 May 2022 09:56:46 GMT, Artem Semenov wrote:
> It seems to me that here it is necessary to release the cache.
I am not so sure. Why would we do that? I mean - we removed all the records
from the cache and even if we would release it we would have to immediately
re-create it otherwise
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
On Wed, 11 May 2022 13:31:16 GMT, Roger Riggs wrote:
>> Thanks for quick reaction.
>> I'll keep my eyes on this race of patches and update this pull request
>> accordingly or create a new PR.
>
> I put out a PR for java.base, but thought I'd wait until the javac fixe were
> pushed before integr
On Wed, 11 May 2022 13:56:44 GMT, Kim Barrett wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/java.base/share/native/libjli/java.c line 1629:
>
>> 1627: cons
On Wed, 11 May 2022 08:40:21 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Wed, 11 May 2022 13:27:38 GMT, Adam Sotona wrote:
>> That's good to know. I think the tricky part is mostly about keeping track
>> of all these disabled warnings, so they are not kept around longer than
>> necessary. And that needs coordination with all the subtasks of the umbrella
>> issue
On Wed, 11 May 2022 13:10:10 GMT, Magnus Ihse Bursie wrote:
>> I agree, but if it doesn't happen, I can follow up with a separate PR where
>> I remove the disablement.
>
> That's good to know. I think the tricky part is mostly about keeping track of
> all these disabled warnings, so they are no
On Wed, 11 May 2022 12:48:38 GMT, Alan Bateman wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/java.base/unix/native/libjli/java_md_common.c line 135:
>
>> 133:
On Wed, 11 May 2022 13:05:45 GMT, Erik Gahlin wrote:
>> make/modules/jdk.jfr/Java.gmk line 26:
>>
>>> 24: #
>>> 25:
>>> 26: DISABLED_WARNINGS_java += exports lossy-conversions
>>
>> Note that with the fix of JDK-8286392 (and JDK-8286396) the
>> `lossy-conversions` warning should not be disabl
On Tue, 10 May 2022 17:43:51 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatting changes
>
> Unfortunately, the icon is distorted on Windows 11. When I tested on Windows
> 10, it updat
On Wed, 11 May 2022 12:59:49 GMT, Magnus Ihse Bursie wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8244681: Add a warning for possibly lossy conversion in compound
>> assignments
>> recommended correction of th
On Wed, 11 May 2022 07:45:39 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown if the type of the right-hand ope
On Wed, 11 May 2022 07:45:39 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown if the type of the right-hand ope
On Wed, 11 May 2022 08:40:21 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Fri, 6 May 2022 17:12:26 GMT, Phil Race wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> We don't do @author tags in openjdk
>> Not 2022 ?
>
> src/java.desktop/share/classes/javax/accessibility/AccessibleList.
> A11Y implementation on macOS has to directly call the
> 'JList.setSelectedIndex' method in order to request selection on an item (see
> 'CAccessibility.requestSelection'). The reason is that a11y API lacks
> appropriate method.There's only
> 'javax.accessibility.AccessibleSelection#addAccessi
On Wed, 11 May 2022 08:40:21 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Wed, 11 May 2022 11:48:00 GMT, Magnus Ihse Bursie wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> The harfbuzz disabled warning looks good, so build changes are approv
On Wed, 27 Apr 2022 11:22:48 GMT, Manukumar V S wrote:
> This test verifies that showing a JPopupMenu shouldn't steal the focus out of
> current focused component..
> This fix moves an unstable closed test to open but updated to be more
> comprehensive in testing multiple Look and Feels and wit
On Wed, 11 May 2022 08:40:21 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Tue, 10 May 2022 17:34:34 GMT, Alexander Zuev wrote:
> Moving cache invalidation from the clearCache method to a createRowWithIndex
> method
> eliminating race condition that causes crash. Now clearCache just notifies
> that cache
> is invalid and should be regenerated next time it is being
On Tue, 10 May 2022 17:34:34 GMT, Alexander Zuev wrote:
> Moving cache invalidation from the clearCache method to a createRowWithIndex
> method
> eliminating race condition that causes crash. Now clearCache just notifies
> that cache
> is invalid and should be regenerated next time it is being
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> * src/hotspot/share/oops/array.hpp
> *
> src/hotspot/share/jfr/
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
58 matches
Mail list logo
