On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Wed, 17 Nov 2021 13:29:14 GMT, Prasanta Sadhukhan
wrote:
>> I don't see a reason to discard the various stability improvements.
>> The discussion is long so I may not be summarising correctly but
>> - A product fix may resolve most of the issues and yet
>> - Stability fixes are still valuabl
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Wed, 10 Nov 2021 05:47:46 GMT, Phil Race wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Review fix
>> - Fix
>
> I don't see a reason to discard the various stability improvements.
> The discussion is l
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Tue, 9 Nov 2021 19:25:05 GMT, Sergey Bylokhov wrote:
>
>
>
> If tolerance is not needed and the only issue we have is the visible cursor
> on the screenshot then why do we try to update the tests, maybe we can try to
> update the jdk instead?
I guess it was already discussed before as be
On Mon, 8 Nov 2021 11:53:46 GMT, Prasanta Sadhukhan
wrote:
> I have removed the tolerance change and PL-ed the testAny more comments
> on this PR?
If tolerance is not needed and the only issue we have is the visible cursor on
the screenshot then why do we try to update the tests, maybe we
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Fri, 29 Oct 2021 06:56:24 GMT, Sergey Bylokhov wrote:
> > It was added as part of https://bugs.openjdk.java.net/browse/JDK-8252813
> > comment mentionedin this PR.
>
> So it is even a different bug =(.. Looks like that comment was about using
> some shortcuts and options, I was talking abou
On Fri, 29 Oct 2021 06:41:09 GMT, Prasanta Sadhukhan
wrote:
> > I pointed that out earlier .. even before you raised the cursor size issue.
>
> Missed that, and still cannot find it by searching the discussion above, I
> probably need to rest
I had written (above many hours ago) -
See the co
On Fri, 29 Oct 2021 06:41:09 GMT, Prasanta Sadhukhan
wrote:
> It was added as part of https://bugs.openjdk.java.net/browse/JDK-8252813
> comment mentionedin this PR.
So it is even a different bug =(..
Looks like that comment was about using some shortcuts and options, I was
talking about usin
On Fri, 29 Oct 2021 06:11:28 GMT, Sergey Bylokhov wrote:
>
>
> > I pointed that out earlier .. even before you raised the cursor size issue.
>
> Missed that, and still cannot find it by searching the discussion above, I
> probably need to rest
It was added as part of https://bugs.openjdk.jav
On Fri, 29 Oct 2021 05:49:27 GMT, Phil Race wrote:
>
>
> Shouldn't this use TESTCLASSES or something like that ?
>
> We have used the same way of ImageIO.write() in jtreg tests
>
> OK ..doesn't mean its right please check with jtreg devs etc ..
If it's not right, then we have to
On Fri, 29 Oct 2021 05:56:06 GMT, Phil Race wrote:
> I pointed that out earlier .. even before you raised the cursor size issue.
Missed that, and still cannot find it by searching the discussion above, I
probably need to rest
-
PR: https://git.openjdk.java.net/jdk/pull/6140
On Fri, 29 Oct 2021 06:06:31 GMT, Phil Race wrote:
>
>
> > > We have same test failure in macos-aarch64 in JDK-8266245 and I guess
> > > tolerance level of 5 should not be an issue. I was told earlier tolerance
> > > level of upto 15 should be acceptable..
> >
> >
> > I do not like the tole
On Fri, 29 Oct 2021 06:00:54 GMT, Sergey Bylokhov wrote:
> > We have same test failure in macos-aarch64 in JDK-8266245 and I guess
> > tolerance level of 5 should not be an issue. I was told earlier tolerance
> > level of upto 15 should be acceptable..
>
> I do not like the tolerance approache
> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
> an attempt to fix the swing tests.
> It was seen from the logs that we have color mismatch in these tests.
>
> For example, in PressedIcon test, we had following log
>
> --System.out:(1/75)--
> color
On Fri, 29 Oct 2021 05:49:34 GMT, Prasanta Sadhukhan
wrote:
> We have same test failure in macos-aarch64 in JDK-8266245 and I guess
> tolerance level of 5 should not be an issue. I was told earlier tolerance
> level of upto 15 should be acceptable..
I do not like the tolerance approaches in g
On Fri, 29 Oct 2021 05:38:55 GMT, Sergey Bylokhov wrote:
> > Broader ? Please expand since the change you suggest is only about the
> > cursor
>
> This issue JDK-8276058 is broader than the cursor, related, this is why I
> would like to exclude it from it.
Still not explained. Broader why ?
>
On Fri, 29 Oct 2021 05:38:55 GMT, Sergey Bylokhov wrote:
> but there are suspicious cases like using tolerance.
We have same test failure in macos-aarch64 in JDK-8266245 and I guess tolerance
level of 5 should not be an issue. I was told earlier tolerance level of upto
15 should be acceptable.
On Fri, 29 Oct 2021 05:49:27 GMT, Phil Race wrote:
> So your assumption is the cursor is an arrow. It could be an X .. in which
> case your fix won't work of ots
Can't we add instructions additionally similar to what we have in our test wiki
to only have default arrow cursor. Also, since it is
On Fri, 29 Oct 2021 04:43:10 GMT, Prasanta Sadhukhan
wrote:
> > Regardless, there's value in the test updates, although my existing
> > comments on the specifics there still stand.
>
> Should I pursue with the test updates with this PR as it seems it can be
> addressed by product change?
Ye
On Fri, 29 Oct 2021 05:23:39 GMT, Phil Race wrote:
> Broader ? Please expand since the change you suggest is only about the cursor
This issue JDK-8276058 is broader than the cursor, related, this is why I would
like to exclude it from it.
> The test part of the fix has multiple stability impro
On Fri, 29 Oct 2021 04:31:29 GMT, Sergey Bylokhov wrote:
> This issue is broader than the cursor, not sure that the test which needs a
> "tolerance" will be fixed by the hidden cursor. So the cursor is a separate
> part and could be fixed and especially tested separately. I am still not sure
>
On Fri, 29 Oct 2021 03:49:04 GMT, Phil Race wrote:
> Regardless, there's value in the test updates, although my existing comments
> on the specifics there still stand.
Should I pursue with the test updates with this PR as it seems it can be
addressed by product change? I am not sure what speci
On Fri, 29 Oct 2021 03:49:04 GMT, Phil Race wrote:
> Well .. if you think that's what's needed I suggest you ask the fixer if
> they'd prefer to do that themselves first as the owner of this issue.
This issue is broader than the cursor, not sure that the test which needs a
"tolerance" will be
On Thu, 28 Oct 2021 22:17:13 GMT, Sergey Bylokhov wrote:
> Confirm that the CGDisplayHideCursor/CGDisplayShowCursor solves the problem
> on my side, I'll prepare the patch. I think it should be backported to all
> old trains.
Well .. if you think that's what's needed I suggest you ask the fixe
On Thu, 28 Oct 2021 06:37:40 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Thu, 28 Oct 2021 06:37:40 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Thu, 28 Oct 2021 06:37:40 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Thu, 28 Oct 2021 21:38:03 GMT, Sergey Bylokhov wrote:
> > BTW when accessing the test system remotely it seems that A11Y feature is
> > disabled. The slider has no effect.
>
> So probably the local settings is not default/changed, and what is shown on
> the setting you see is for remote vie
On Thu, 28 Oct 2021 21:30:46 GMT, Phil Race wrote:
> Sorry, not following .. do you mean you think the cursor is captured when it
> is enlarged ? Like somehow a software cursor is used that is painted in a
> different way so that it always show up ? But the screen captures in the bug
> report
On Thu, 28 Oct 2021 21:35:52 GMT, Sergey Bylokhov wrote:
> > Sorry, not following .. do you mean you think the cursor is captured when
> > it is enlarged ? Like somehow a software cursor is used that is painted in
> > a different way so that it always show up ? But the screen captures in the
>
On Thu, 28 Oct 2021 21:15:51 GMT, Sergey Bylokhov wrote:
> Yes looks like it is related to the cursor size in the settings
> Settings->Accessibility->Display->Cursor tab->Increase the size of the cursor
> to large.
Sorry, not following .. do you mean you think the cursor is captured when it
i
On Thu, 28 Oct 2021 06:37:40 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Thu, 28 Oct 2021 06:37:40 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Thu, 28 Oct 2021 20:54:54 GMT, Sergey Bylokhov wrote:
> > I have attached 2 screen capture in JBS taken when PressedIconTest and
> > JInternalFrame test failed and the screenshot at least in this machine
> > shows presence of cursor.
>
> So maybe something was changed in the native API? It
On Thu, 28 Oct 2021 18:50:28 GMT, Prasanta Sadhukhan
wrote:
> I have attached 2 screen capture in JBS taken when PressedIconTest and
> JInternalFrame test failed and the screenshot at least in this machine shows
> presence of cursor.
So maybe something was changed in the native API? It looks
On Thu, 28 Oct 2021 06:37:40 GMT, Prasanta Sadhukhan
wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we
On Thu, 28 Oct 2021 03:13:21 GMT, Phil Race wrote:
> Well .. the cursor issue is a suggestion for root cause [*] Do you have any
> other ideas ? I mean other than ...
As noted above our spec mention that the cursor should not be present on the
screenshot, and we use the appropriate native API
On Wed, 27 Oct 2021 12:42:50 GMT, Prasanta Sadhukhan
wrote:
> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
> an attempt to fix the swing tests.
> It was seen from the logs that we have color mismatch in these tests.
>
> For example, in PressedIcon test, we had f
> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
> an attempt to fix the swing tests.
> It was seen from the logs that we have color mismatch in these tests.
>
> For example, in PressedIcon test, we had following log
>
> --System.out:(1/75)--
> color
On Thu, 28 Oct 2021 01:25:11 GMT, Sergey Bylokhov wrote:
>Since it is unlikely to be the issue related to the cursor,
>it will be better to check what could be root cause.
Well .. the cursor issue is a suggestion for root cause [*] Do you have any
other ideas ? I mean other than ...
> Is it
On Wed, 27 Oct 2021 12:42:50 GMT, Prasanta Sadhukhan
wrote:
> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
> an attempt to fix the swing tests.
> It was seen from the logs that we have color mismatch in these tests.
>
> For example, in PressedIcon test, we had f
On Wed, 27 Oct 2021 17:39:04 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/javax/swing/JButton/8151303/PressedIconTest.java line 88:
>>
>>> 86: robot.waitForIdle();
>>> 87: Color color = robot.getPixelColor(centerX-10, centerY-10);
>>> 88:
>>
>> So the problematic pattern is a
On Wed, 27 Oct 2021 16:33:27 GMT, Phil Race wrote:
>> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
>> an attempt to fix the swing tests.
>> It was seen from the logs that we have color mismatch in these tests.
>>
>> For example, in PressedIcon test, we had follow
On Wed, 27 Oct 2021 12:42:50 GMT, Prasanta Sadhukhan
wrote:
> As per JDK-8252813, some tests fails recurringly in CI macos system. This is
> an attempt to fix the swing tests.
> It was seen from the logs that we have color mismatch in these tests.
>
> For example, in PressedIcon test, we had f
52 matches
Mail list logo
