Re: RFR: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager

2021-11-10 Thread Aleksey Shipilev
On Mon, 8 Nov 2021 13:13:55 GMT, Aleksey Shipilev wrote: > Current test fails on SecurityManager installation. See the bug for failure > details. The fix is to allow SM for this test, until SM is removed wholesale. > > Additional testing: > - [x] Affected test now passes Thank you, folks! --

Integrated: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager

2021-11-10 Thread Aleksey Shipilev
On Mon, 8 Nov 2021 13:13:55 GMT, Aleksey Shipilev wrote: > Current test fails on SecurityManager installation. See the bug for failure > details. The fix is to allow SM for this test, until SM is removed wholesale. > > Additional testing: > - [x] Affected test now passes This pull request has

Withdrawn: 8273355: Lanai: Flickering on tooltip appearance IntelliJ IDEA 2021.2.1

2021-11-10 Thread duke
On Sat, 4 Sep 2021 19:54:55 GMT, Alexey Ushakov wrote: > Used setOpaque() method to set correct background of platform window This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/5373

Integrated: 8276679: Malformed Javadoc inline tags in JDK source in javax/swing

2021-11-10 Thread Prasanta Sadhukhan
On Mon, 8 Nov 2021 07:56:56 GMT, Prasanta Sadhukhan wrote: > Fixed multiple malformed Javadoc inline tags where the `@` is placed in front > of the opening curly bracket (instead of behind). This pull request has now been integrated. Changeset: e01d6d00 Author:Prasanta Sadhukhan URL:

Re: RFR: JDK-8276809: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on Windows

2021-11-10 Thread Matthias Baesken
On Tue, 9 Nov 2021 20:51:30 GMT, Sergey Bylokhov wrote: >> Yeah this looks like the wrong fix. >> -Xcheck:jni only warns like this if there are actual exceptions, doesn't it ? >> So if we had one, where was it ? >> >> Note that Windows Server 2019 is a staple of the CI testing at Oracle and >>

RFR: 8276930: Update ProblemList

2021-11-10 Thread Jesper Wilhelmsson
Update a few entries in the problemlist that refer to bugs that have been closed as duplicates. - Commit messages: - Fixed duplicates Changes: https://git.openjdk.java.net/jdk/pull/6328/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6328&range=00 Issue: https://bugs

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v2]

2021-11-10 Thread Laurent Bourgès
On Wed, 10 Nov 2021 10:23:53 GMT, Laurent Bourgès wrote: >> I agree it is out of the scope of this issue to implement high-precision >> polynom evaluation (compensated horder scheme), that I or anybody else could >> implement it later. >> To ensure bounds2D are enclosing the shape entirely, I p

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v2]

2021-11-10 Thread Laurent Bourgès
On Tue, 9 Nov 2021 10:43:40 GMT, Laurent Bourgès wrote: >> I don't think I can implement that on my own. Even if I fully understood the >> julia code, I assume I'd want to use the Math.fma(..) method. That method >> uses BigDecimals, which I assume (?) we don't want to use in a loop like >> th

Re: RFR: 8276930: Update ProblemList [v2]

2021-11-10 Thread Jesper Wilhelmsson
> Update a few entries in the problemlist that refer to bugs that have been > closed as duplicates. Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Moved non-instrument tests to the right place - Changes: - all:

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v3]

2021-11-10 Thread Ludvig Janiuk
> This change introduces no visual difference, but improves a11y. Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision: Most idiomatic version so far - Changes: - all: https://git.openjdk.java.net/jdk/pull/6291/files - ne

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-10 Thread Ludvig Janiuk
On Tue, 9 Nov 2021 12:30:19 GMT, Alexey Ivanov wrote: >> This change introduces no visual difference, but improves a11y. > >> To me, the table looks correct currently: _Arabic_ Unicode range serves as >> the title for both rows. I wonder how it's read by a screen reader: the >> original version

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v2]

2021-11-10 Thread Ludvig Janiuk
On Tue, 9 Nov 2021 19:35:41 GMT, Alexey Ivanov wrote: >> Ludvig Janiuk has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Achieve correct row headers without header change > > src/java.desktop/share/classes/java/awt/font/NumericShaper.java

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v3]

2021-11-10 Thread Ludvig Janiuk
On Tue, 9 Nov 2021 19:30:39 GMT, Alexey Ivanov wrote: >> Ludvig Janiuk has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Most idiomatic version so far > > src/java.desktop/share/classes/java/awt/font/NumericShaper.java line 133: > >> 131:

Re: RFR: 8276930: Update ProblemList [v2]

2021-11-10 Thread Kevin Walls
On Wed, 10 Nov 2021 10:41:56 GMT, Jesper Wilhelmsson wrote: >> Update a few entries in the problemlist that refer to bugs that have been >> closed as duplicates. > > Jesper Wilhelmsson has updated the pull request incrementally with one > additional commit since the last revision: > > Moved

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-10 Thread Alexey Ivanov
On Wed, 10 Nov 2021 11:03:23 GMT, Ludvig Janiuk wrote: > Concerning ``, quote (emphasis mine): > > > As your tables get a bit more complex in structure, it is useful to give > > them more structural definition. One clear way to do this is by using > > ``, ``, and ``, which allow you to mark up

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v2]

2021-11-10 Thread Alexey Ivanov
On Wed, 10 Nov 2021 11:04:54 GMT, Ludvig Janiuk wrote: >> src/java.desktop/share/classes/java/awt/font/NumericShaper.java line 117: >> >>> 115: * Unicode Range >>> 116: * {@code NumericShaper} Constants >>> 117: * Precedence >> >> Shall we use more descriptive ids? >> Suggestion:

Re: RFR: 8276930: Update ProblemList [v2]

2021-11-10 Thread Chris Plummer
On Wed, 10 Nov 2021 10:41:56 GMT, Jesper Wilhelmsson wrote: >> Update a few entries in the problemlist that refer to bugs that have been >> closed as duplicates. > > Jesper Wilhelmsson has updated the pull request incrementally with one > additional commit since the last revision: > > Moved

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v3]

2021-11-10 Thread Ludvig Janiuk
On Wed, 10 Nov 2021 10:58:08 GMT, Ludvig Janiuk wrote: >> This change introduces no visual difference, but improves a11y. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > Most idiomatic version so far Ah, I see. In that ca

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v4]

2021-11-10 Thread Ludvig Janiuk
> This change introduces no visual difference, but improves a11y. Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision: remove ids, reintroduce two tbodies - Changes: - all: https://git.openjdk.java.net/jdk/pull/6291/files

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v4]

2021-11-10 Thread Alexey Ivanov
On Wed, 10 Nov 2021 17:41:08 GMT, Ludvig Janiuk wrote: >> This change introduces no visual difference, but improves a11y. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > remove ids, reintroduce two tbodies Not ideal, but

Integrated: 8276678: Malformed Javadoc inline tags in JDK source in com/sun/beans/decoder/DocumentHandler.java

2021-11-10 Thread Alisen Chung
On Mon, 8 Nov 2021 17:08:36 GMT, Alisen Chung wrote: > fixed malformed inline tags This pull request has now been integrated. Changeset: 2374abda Author:Alisen Chung Committer: Alexey Ivanov URL: https://git.openjdk.java.net/jdk/commit/2374abda19213d615a72c83f584ea61d5bbba4a3 Stats

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v4]

2021-11-10 Thread Alexey Ivanov
On Wed, 10 Nov 2021 17:41:08 GMT, Ludvig Janiuk wrote: >> This change introduces no visual difference, but improves a11y. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > remove ids, reintroduce two tbodies As expected, th

RFR: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

2021-11-10 Thread Sergey Bylokhov
The bug occurs more often if initially the window is moved partly outside of the first screen(let's name this part as the invisible part), and then slowly moved to the second screen where that invisible part became visible on the second screen. The problem is how we try to repaint the frame. Th

Re: RFR: 8276930: Update ProblemList [v2]

2021-11-10 Thread Jesper Wilhelmsson
On Wed, 10 Nov 2021 16:42:37 GMT, Chris Plummer wrote: >> Jesper Wilhelmsson has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moved non-instrument tests to the right place > > test/jdk/ProblemList.txt line 789: > >> 787: # svc_tools >> 7

Integrated: 8276930: Update ProblemList

2021-11-10 Thread Jesper Wilhelmsson
On Wed, 10 Nov 2021 09:30:38 GMT, Jesper Wilhelmsson wrote: > Update a few entries in the problemlist that refer to bugs that have been > closed as duplicates. This pull request has now been integrated. Changeset: e27a67a9 Author:Jesper Wilhelmsson URL: https://git.openjdk.java.ne

Re: RFR: 8276930: Update ProblemList [v2]

2021-11-10 Thread David Holmes
On Wed, 10 Nov 2021 10:41:56 GMT, Jesper Wilhelmsson wrote: >> Update a few entries in the problemlist that refer to bugs that have been >> closed as duplicates. > > Jesper Wilhelmsson has updated the pull request incrementally with one > additional commit since the last revision: > > Moved

Re: RFR: 8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails

2021-11-10 Thread Sergey Bylokhov
On Thu, 28 Oct 2021 13:24:41 GMT, Alexander Zvegintsev wrote: > This test does not fail on Windows and does fail on Linux. > > After de-iconification we expect to see the button focused: > ![image](https://user-images.githubusercontent.com/77687766/139171852-54413dba-d58a-46d4-ab83-59d93868e28

RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS

2021-11-10 Thread Jayathirth D V
When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set any deployment target when when we use xcrun to create .air file and this issue looks similar to https://developer.apple.com/forums/thread/105719.