> Could you please review the 8262297 bug fixes?
>
> In this case, ImageIO.write() should throw java.io.IOException rather than
> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and
> wrapped in IIOException in ImageIO.write() with this fix. In addition,
> IndexOutOfBou
On Tue, 16 Nov 2021 00:40:35 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriter.java
>> line 1459:
>>
>>> 1457: int biType = imgType.getBufferedImageType();
>>> 1458: int bpp = imgType.getColorModel().getPixelSize();
>>> 1459
On Mon, 15 Nov 2021 08:02:19 GMT, Jayathirth D V wrote:
>> Masanori Yano has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8262297: ImageIO.write() method will throw IndexOutOfBoundsException
>> - 8262297: ImageIO.write() method will th
> The new test java/awt/font/JNICheck/FreeTypeScalerJNICheck.java introduced
> with https://bugs.openjdk.java.net/browse/JDK-8269223 adds -Xcheck:jni to an
> awt related test, and shows on Windows server 2019 the following JNI warning
> , so the test JNICheck/FreeTypeScalerJNICheck.java fails o
On Thu, 23 Sep 2021 13:52:09 GMT, Prasanta Sadhukhan
wrote:
> java/awt/FullScreen/DisplayChangeVITest/DisplayChangeVITest.java is timing
> out on a macOS 12 aarch64 (an Apple Silicon Mac Mini) system due to getting
> locked on frame.dispose() even though test passed.
> Modified test to use JFr
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Fri, 19 Nov 2021 18:06:39 GMT, Mandy Chung wrote:
>> Here are the code changes for the "Deprecate finalizers in the standard Java
>> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
>> review.
>>
>> This change makes the indicated deprecations, and updates the API spe
On Thu, 18 Nov 2021 13:17:16 GMT, Alexey Ivanov wrote:
> It's a little cleanup: make sure `frame` is accessed from EDT only, remove
> unused variables and imports.
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6455
> This removes code that relied on consulting the Bezier control points to
> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward
> to convert the Bezier control points into the x & y parametric equations. At
> their most complex these equations are cubic polynomials, so
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Fri, 19 Nov 2021 18:15:46 GMT, Brent Christian wrote:
>> src/java.base/share/classes/java/lang/Object.java line 481:
>>
>>> 479: * system resources or to perform other cleanup.
>>> 480: *
>>> 481: * When running in a Java virtual machine in which finalization
>>> has been
>>
On Thu, 18 Nov 2021 18:32:30 GMT, Andrey Turbanov wrote:
>> src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java line
>> 463:
>>
>>> 461: new InputStreamReader(is, ISO_8859_1));
>>> 462: defaultStyles.loadRules(r, null);
>>> 463:
On Wed, 17 Nov 2021 18:55:20 GMT, Alisen Chung wrote:
>> Adjusted the AquaLF scrollbar to account for border inset settings when
>> dragging the thumb and clicking on the track.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Fri, 19 Nov 2021 09:14:15 GMT, Matthias Baesken wrote:
>> The new test java/awt/font/JNICheck/FreeTypeScalerJNICheck.java introduced
>> with https://bugs.openjdk.java.net/browse/JDK-8269223 adds -Xcheck:jni to an
>> awt related test, and shows on Windows server 2019 the following JNI warning
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Fri, 19 Nov 2021 06:34:30 GMT, Alexander Zuev wrote:
> Made colorBits and maskBits arrays dynamic so they are allocated on heap
> instead of stack.
> Added regression test.
src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 1060:
> 1058: int nBits = iconSize *
On Fri, 19 Nov 2021 20:21:27 GMT, Sergey Bylokhov wrote:
> I am not sure that the bad_alloc will be properly handled in this
> Java_sun_awt_shell_Win32ShellFolder2_getIconBits method.
I can't see any try-catch.
Is it better to use `malloc` and check for `NULL`?
> Probably it will be better to
On Fri, 19 Nov 2021 06:34:30 GMT, Alexander Zuev wrote:
> Made colorBits and maskBits arrays dynamic so they are allocated on heap
> instead of stack.
> Added regression test.
src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 1059:
> 1057: // Extract the color bi
On Fri, 19 Nov 2021 09:04:22 GMT, Masanori Yano wrote:
>> Could you please review the 8262297 bug fixes?
>>
>> In this case, ImageIO.write() should throw java.io.IOException rather than
>> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and
>> wrapped in IIOException i
On Fri, 19 Nov 2021 20:47:01 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp line 1060:
>>
>>> 1058: int nBits = iconSize * iconSize;
>>> 1059: long * colorBits;
>>> 1060: colorBits = (long*)safe_Malloc(MAX_ICON_SIZ
> Adjusted the AquaLF scrollbar to account for border inset settings when
> dragging the thumb and clicking on the track.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
automated test
-
Changes:
- all: https://git.op
On Fri, 19 Nov 2021 20:01:20 GMT, Sergey Bylokhov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added summary and copyright
>
> test/jdk/java/awt/Scrollbar/AquaLFScrollbarTest/ScrollBarBorderTest.java line
> 114
> Adjusted the AquaLF scrollbar to account for border inset settings when
> dragging the thumb and clicking on the track.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
removed manual tag
-
Changes:
- all: https://gi
On Fri, 19 Nov 2021 20:49:58 GMT, Alexey Ivanov wrote:
> Maybe this could be spelt with regular case rather than caps?
Well, it is just copy-paste from the bug synopsis which is copy-paste from the
error message of the VM crash.
-
PR: https://git.openjdk.java.net/jdk/pull/6473
> Made colorBits and maskBits arrays dynamic so they are allocated on heap
> instead of stack.
> Added regression test.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Added bad_malloc handling
Fixed insets
Declaration and assi
29 matches
Mail list logo
