Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-11-30 Thread Alexey Ushakov
Yes, could you please review it. During the fix of the original issue I’ve uncovered the real problem with pipeline state cache that can lead to OOMs, obtaining wrong rendering states … Best Regards, Alexey > On 29 Nov 2021, at 18:53, Victor Dyakov wrote: > > On Fri, 26 Nov 2021 09:02:37 GMT,

Integrated: 8278019: ProblemList java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and windows

2021-11-30 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and windows - Commit messages: - 8278019: ProblemList java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and windows Changes: https://git.openjdk.java.net/jdk/pull/6

Integrated: 8278019: ProblemList java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and windows

2021-11-30 Thread Daniel D . Daugherty
On Tue, 30 Nov 2021 20:33:54 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and > windows This pull request has now been integrated. Changeset: 5a4a9bb9 Author:Daniel D. Daugherty URL: https://

Re: Integrated: 8278019: ProblemList java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and windows

2021-11-30 Thread Phil Race
On Tue, 30 Nov 2021 20:33:54 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and > windows Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6624

Re: Integrated: 8278019: ProblemList java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and windows

2021-11-30 Thread Daniel D . Daugherty
On Tue, 30 Nov 2021 20:37:42 GMT, Phil Race wrote: >> A trivial fix to ProblemList >> java/awt/dnd/BadSerializationTest/BadSerializationTest.java on linux and >> windows > > Marked as reviewed by prr (Reviewer). @prrace - Thanks for the lightning fast review. - PR: https://git.op

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy

2021-11-30 Thread Liam Miller-Cushon
On Tue, 30 Nov 2021 01:31:24 GMT, Liam Miller-Cushon wrote: > This change updates the serialized objects used by > `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a similar > approach to the previous fix in > [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082).

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy

2021-11-30 Thread Phil Race
On Tue, 30 Nov 2021 01:31:24 GMT, Liam Miller-Cushon wrote: > This change updates the serialized objects used by > `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a similar > approach to the previous fix in > [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082).

Re: RFR: 8277868: Use Comparable.compare() instead of surrogate code [v2]

2021-11-30 Thread Roger Riggs
On Mon, 29 Nov 2021 08:18:47 GMT, Сергей Цыпанов wrote: >> Instead of something like >> >> long x; >> long y; >> return (x < y) ? -1 : ((x == y) ? 0 : 1); >> >> we can use `return Long.compare(x, y);` >> >> All replacements are done with IDE. > > Сергей Цыпанов has updated the pull request inc

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy

2021-11-30 Thread Sergey Bylokhov
On Tue, 30 Nov 2021 01:31:24 GMT, Liam Miller-Cushon wrote: > This change updates the serialized objects used by > `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a similar > approach to the previous fix in > [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082).

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy

2021-11-30 Thread Sergey Bylokhov
On Tue, 30 Nov 2021 20:46:34 GMT, Liam Miller-Cushon wrote: > I regenerated it by following the instructions to compile and run the test > class as a standalone tool on `x86_64 GNU/Linux`, which updated all of the > existing files. I verified it fixes the test on that platform, I don't have a

Re: RFR: 8264666: Reuse Math.multiplyExact/addExact in the LCMSImageLayout class

2021-11-30 Thread Sergey Bylokhov
On Fri, 2 Apr 2021 23:02:50 GMT, Sergey Bylokhov wrote: > - The hand-crafted methods for addition and multiplication are replaced by > the "Math" versions. > - Cleanup: the usage of do/while(false) is removed not now - PR: https://git.openjdk.java.net/jdk/pull/

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2021-11-30 Thread Sergey Bylokhov
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.

2021-11-30 Thread Sergey Bylokhov
On Mon, 27 Sep 2021 03:33:52 GMT, Sergey Bylokhov wrote: > This test depends on the next windows UI performance option: > “Show window contents while dragging”, see > https://answers.microsoft.com/en-us/windows/forum/all/in-windows-7-how-do-i-show-window-contents-while/18e3aee2-bcc7-4005-a45d-c5

Re: RFR: 8266435: WBMPImageReader.read() should not truncate the input stream

2021-11-30 Thread Jayathirth D V
On Thu, 25 Nov 2021 03:56:32 GMT, Sergey Bylokhov wrote: >> If we use a custom stream and specify limit on stream.read() length, >> WBMPImageReader.read() doesnt verify whether we are decoded complete data or >> not. We can check the length of data decoded and rerun the stream.read() or >> use

Integrated: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException

2021-11-30 Thread Masanori Yano
On Thu, 28 Oct 2021 09:29:13 GMT, Masanori Yano wrote: > Could you please review the 8262297 bug fixes? > > In this case, ImageIO.write() should throw java.io.IOException rather than > java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and > wrapped in IIOException in Ima

Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-11-30 Thread Jayathirth D V
On Fri, 26 Nov 2021 09:02:37 GMT, Alexey Ushakov wrote: >> Removed creation of the separate encoder depending on destination properties >> as we don't use this info to customize the encoder properties > > Alexey Ushakov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-11-30 Thread Jayathirth D V
On Fri, 26 Nov 2021 09:02:37 GMT, Alexey Ushakov wrote: >> Removed creation of the separate encoder depending on destination properties >> as we don't use this info to customize the encoder properties > > Alexey Ushakov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8274939: Incorrect size of the pixel storage is used by the robot on macOS

2021-11-30 Thread Prasanta Sadhukhan
On Fri, 8 Oct 2021 10:23:13 GMT, Sergey Bylokhov wrote: > In JDK 9 the native code for the robot class was reworked to get an access to > the HiDPI quality screenshots. So we allocate the data storage for the HiDPI > quality and then request the best quality from the macOS. > > It works fine i

Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-11-30 Thread Jayathirth D V
On Fri, 26 Nov 2021 09:02:37 GMT, Alexey Ushakov wrote: >> Removed creation of the separate encoder depending on destination properties >> as we don't use this info to customize the encoder properties > > Alexey Ushakov has updated the pull request incrementally with one additional > commit sin