On Wed, 24 Nov 2021 11:09:42 GMT, Masanori Yano wrote:
>> Could you please review the 8262297 bug fixes?
>>
>> In this case, ImageIO.write() should throw java.io.IOException rather than
>> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and
>> wrapped in IIOException i
Looks like we have 8 test cases where we are trying to write 15bpp BMP images
and after JDK-8262297 all of them are failing.
We need to update these test cases to not encode 15bpp BMP images or supporting
15bpp BMP images is valid use case. This needs more investigation. I am backing
out changes
On Wed, 1 Dec 2021 10:07:30 GMT, Jayathirth D V wrote:
> Looks like we have 8 test cases where we are trying to write 15bpp BMP images
> and after JDK-8262297 all of them are failing.
> We need to update these test cases to not encode 15bpp BMP images or
> supporting 15bpp BMP images is valid u
On Wed, 1 Dec 2021 10:19:24 GMT, Thomas Schatzl wrote:
> Lgtm, is a clean backout. It would be nice to link the old changes directly
> for easier comparison in the PR text next time.
Thanks Thomas. Sure will do.
-
PR: https://git.openjdk.java.net/jdk/pull/6631
On Wed, 1 Dec 2021 10:07:30 GMT, Jayathirth D V wrote:
> Looks like we have 8 test cases where we are trying to write 15bpp BMP images
> and after JDK-8262297 all of them are failing.
> We need to update these test cases to not encode 15bpp BMP images or
> supporting 15bpp BMP images is valid u
The problem is related to the implementation of font fallback on macOS,
specifically to the path used when text layout
is performed, i.e. the one using `FontSubstitution` and cascade lists.
`CTFontCopyDefaultCascadeListForLanguages`'s output contains an entry for the
font, able to render Armenia
> Testing https://bugs.openjdk.java.net/browse/JDK-8271071
> Step to reproduce
> 1) Run SwingSet2 in JDK 18 ( I used b24 )
> 2) Enable Voiceover.
> 3) Select JTable demo
> 4) Click any row in the table or select the first row . Observe that row is
> selected & VoiceOver reads the column value
On Fri, 26 Nov 2021 01:54:47 GMT, Sergey Bylokhov wrote:
>> Done. thank you very much.
>
> I few questions to thinking about:
> - If the label and icon is not accessible then should we say something? Or
> we should ignore it like we do for any other non-accessible components?
> - Why the image
> This change updates the serialized objects used by
> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a similar
> approach to the previous fix in
> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082).
Liam Miller-Cushon has refreshed the contents of this pull re
On Wed, 1 Dec 2021 07:34:07 GMT, Prasanta Sadhukhan
wrote:
> It seems CheckCommonColors still fails intermittently even with this fix in
> macos aarch64 along with others
> open/test/jdk/java/awt/Robot/HiDPIScreenCapture/ScreenCaptureTest.java,
> open/test/jdk/java/awt/ColorClass/AlphaColorTe
On Wed, 1 Dec 2021 10:52:38 GMT, Dmitry Batrak wrote:
> The problem is related to the implementation of font fallback on macOS,
> specifically to the path used when text layout
> is performed, i.e. the one using `FontSubstitution` and cascade lists.
> `CTFontCopyDefaultCascadeListForLanguages`'
> This change updates the serialized objects used by
> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a similar
> approach to the previous fix in
> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082).
Liam Miller-Cushon has refreshed the contents of this pull re
On Wed, 1 Dec 2021 04:41:39 GMT, Sergey Bylokhov wrote:
>> I couldn't find the review either.
>>
>> I regenerated it by following the instructions to compile and run the test
>> class as a standalone tool on `x86_64 GNU/Linux`, which updated all of the
>> existing files. I verified it fixes th
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec for
> JEP 421. It also updates the relevant @SuppressWarn
On Wed, 1 Dec 2021 04:27:03 GMT, Sergey Bylokhov wrote:
> As of the usefulness of the serializations tests in Swing - it is a good
> coverage of the cleaning code in the L&fs. Each L&F should clean all its data
> when the app switch one LF to another, but if old L&F forget to cleanup then
> th
> This change updates the serialized objects used by
> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a similar
> approach to the previous fix in
> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082).
Liam Miller-Cushon has updated the pull request with a new ta
On Wed, 1 Dec 2021 18:12:51 GMT, Liam Miller-Cushon wrote:
>> This change updates the serialized objects used by
>> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a
>> similar approach to the previous fix in
>> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec for
> JEP 421. It also updates the relevant @SuppressWarn
On Wed, 1 Dec 2021 18:28:13 GMT, Phil Race wrote:
> This test doesn't switch L&Fs .. if it wasn't for mac defaulting to Aqua
> they'd all be using Metal.
It does not change the L&F but it will trigger the same cleanup step.
> So this is an accidental by-product, not the goal of the test.
yes
On Wed, 1 Dec 2021 18:28:43 GMT, Liam Miller-Cushon wrote:
> Ok the other issue was another instance of the same problem with
> `BasicPanelUI`.
>
> I now have the test passing on both linux and mac, after regenerating the
> binary files on mac.
> I'm still not sure if this is the best approac
On Wed, 1 Dec 2021 12:25:56 GMT, Artem Semenov wrote:
>> Testing https://bugs.openjdk.java.net/browse/JDK-8271071
>> Step to reproduce
>> 1) Run SwingSet2 in JDK 18 ( I used b24 )
>> 2) Enable Voiceover.
>> 3) Select JTable demo
>> 4) Click any row in the table or select the first row . Obse
On Wed, 1 Dec 2021 22:14:58 GMT, Sergey Bylokhov wrote:
> Usually the delegate which install some properties/listeners/etc is
> responsible for cleanup.
I'm not sure I understand, aren't these being installed in `BasicPanelUI`?
https://github.com/openjdk/jdk/blob/4166dfd004d16769f8ea1d3441d3d1
On Wed, 1 Dec 2021 22:41:55 GMT, Sergey Bylokhov wrote:
>> Artem Semenov has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new c
On Wed, 1 Dec 2021 06:12:29 GMT, Jayathirth D V wrote:
>> test/jdk/javax/imageio/plugins/wbmp/WBMPStreamTruncateTest.java line 61:
>>
>>> 59: File imageFile = File.
>>> 60: createTempFile("test", ".wbmp", new File(filePath));
>>> 61: imageFile.deleteOnExit();
>>
On Wed, 1 Dec 2021 22:53:47 GMT, Liam Miller-Cushon wrote:
> I'm not sure I understand, aren't these being installed in `BasicPanelUI`?
If it is installs in the BasicListUI only then yes the fix belongs to this
class. These properties changing also in some other classes as well, but some
other
On Fri, 26 Nov 2021 11:50:41 GMT, Matthias Baesken wrote:
> The error occurs when starting the tests from the Windows Task scheduler;
> however when running from the task scheduler the error occurs with the
> fastdebug-JVM not when running the opt/product JVM.
Probably in that case we try to l
On Wed, 1 Dec 2021 19:23:59 GMT, Brent Christian wrote:
>> Here are the code changes for the "Deprecate finalizers in the standard Java
>> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
>> review.
>>
>> This change makes the indicated deprecations, and updates the API
On Tue, 23 Nov 2021 11:05:27 GMT, Jayathirth D V wrote:
> If we use a custom stream and specify limit on stream.read() length,
> WBMPImageReader.read() doesnt verify whether we are decoded complete data or
> not. We can check the length of data decoded and rerun the stream.read() or
> use read
On Fri, 26 Nov 2021 09:02:37 GMT, Alexey Ushakov wrote:
>> Removed creation of the separate encoder depending on destination properties
>> as we don't use this info to customize the encoder properties
>
> Alexey Ushakov has updated the pull request incrementally with one additional
> commit sin
> This change updates the serialized objects used by
> `java/awt/dnd/BadSerializationTest/BadSerializationTest.java` using a similar
> approach to the previous fix in
> [JDK-8039082](https://bugs.openjdk.java.net/browse/JDK-8039082).
Liam Miller-Cushon has updated the pull request incrementally
On Thu, 2 Dec 2021 00:26:16 GMT, Sergey Bylokhov wrote:
> These properties changing also in some other classes as well, but some other
> classes cleanup it properly for example see BasicListUI.uninstallDefaults(),
> but I am not sure that all of them do this.
I looked through other uses of `in
31 matches
Mail list logo
