Re: CFV: New Client Libraries Group Member : Alexey Ivanov (aivanov)

2022-02-10 Thread Alexey Ushakov
Vote: Yes > On 9 Feb 2022, at 21:06, Philip Race wrote: > > I hereby nominate Alexey Ivanov (aivanov) to Membership in the Client > Libraries Group. > > Alexey has worked in the client libraries sustaining team at Oracle since > 2014 and in that time > has contributed 60 client fixes [1], [2]

Re: CFV: New Client Libraries Group Member : Dmitry Markov (dmarkov)

2022-02-10 Thread Alexey Ushakov
Vote: yes > On 9 Feb 2022, at 21:06, Philip Race wrote: > > I hereby nominate Dmitry Markov (dmarkov) to Membership in the Client > Libraries Group. > > Dmitry has worked in the client libraries sustaining team at Oracle since > 2013 and in that time > has contributed 61 client fixes [1], [2]

RFR: 8047749: javadoc for getPathBounds() in TreeUI and BasicTreeUI is incorrect

2022-02-10 Thread Prasanta Sadhukhan
The javadoc descriptions for javax.swing.plaf.TreeUI.getPathBounds() and javax.swing.plaf.basic.BasicTreeUI.getPathBounds() have stated it returns null if any component in path is currently "valid", which is wrong. The getPathBounds() in BasicTreeUI returns null if tree or treeState is null. Fix

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v4]

2022-02-10 Thread Alexey Ivanov
On Thu, 10 Feb 2022 05:36:40 GMT, lawrence.andrews wrote: >> 1) Removed =yesno that was causing the test to fail with following exception >> test result: Error. Parse Exception: Arguments to `manual' option not >> supported: yesno >> After removing =yesno, test was just passing without user int

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v3]

2022-02-10 Thread Alexey Ivanov
On Thu, 10 Feb 2022 05:31:58 GMT, lawrence.andrews wrote: >> test/jdk/java/awt/Graphics/TextAAHintsTest.java line 177: >> >>> 175: 1. Verify that first set of text are rendered >>> correctly. >>> 176: 2. Second set of text are created using BufferedImage >>> of

Re: RFR: 8054449: Incompatible type in example code in TreePath

2022-02-10 Thread Alexey Ivanov
On Thu, 10 Feb 2022 04:33:50 GMT, Prasanta Sadhukhan wrote: > The example code in TreePath throws > error: incompatible types: Object cannot be converted to > DefaultMutableTreeNode >getUserObject(); > Fixed the example code Marked as reviewed by aivanov (Reviewer). -

Re: RFR: 8275345: RasterFormatException when drawing a tiled image made of non-writable rasters [v2]

2022-02-10 Thread Martin Desruisseaux
> This commit fixes a `RasterFormatException` thrown when > `Graphics2D.drawRenderedImage(…)` is invoked with an image containing tiles > that are instances of `Raster` but not `WritableRaster`. > > https://bugs.openjdk.java.net/browse/JDK-8275345 Martin Desruisseaux has updated the pull reques

Re: RFR: 8054449: Incompatible type in example code in TreePath

2022-02-10 Thread Dmitry Markov
On Thu, 10 Feb 2022 04:33:50 GMT, Prasanta Sadhukhan wrote: > The example code in TreePath throws > error: incompatible types: Object cannot be converted to > DefaultMutableTreeNode >getUserObject(); > Fixed the example code Marked as reviewed by dmarkov (Reviewer). -

Integrated: 8054449: Incompatible type in example code in TreePath

2022-02-10 Thread Prasanta Sadhukhan
On Thu, 10 Feb 2022 04:33:50 GMT, Prasanta Sadhukhan wrote: > The example code in TreePath throws > error: incompatible types: Object cannot be converted to > DefaultMutableTreeNode >getUserObject(); > Fixed the example code This pull request has now been integrated. Changeset: 03

Re: RFR: 8241192: [macosx] Wrong letter typed after ´ symbol when using Finnish layout

2022-02-10 Thread Nikita Provotorov
On Fri, 28 Jan 2022 09:38:35 GMT, Prasanta Sadhukhan wrote: > If we press " ´ " (on U.S. keyboard layout it is the [+] button just before > the [delete] button), and then press "s" , 2 "´" characters are entered in a > text field instead of "´s" with "Finish" keyboard layout. > This is because

Re: RFR: 8047749: javadoc for getPathBounds() in TreeUI and BasicTreeUI is incorrect

2022-02-10 Thread Alexey Ivanov
On Thu, 10 Feb 2022 08:11:04 GMT, Prasanta Sadhukhan wrote: > The javadoc descriptions for javax.swing.plaf.TreeUI.getPathBounds() and > javax.swing.plaf.basic.BasicTreeUI.getPathBounds() have stated it returns > null if any component in path is currently "valid", which is wrong. > The getPath

RFR: 8280861: Robot color picker broken on Linux with scaling above 100%

2022-02-10 Thread Maxim Kartashev
The primary API for image capture on modern Linuxes is `gdk_pixbuf_get_from_window()` that expects both coordinates and the size unscaled (i.e. not multiplied by the current desktop scale). At the same time, `gtk3_interface.c:gtk3_get_drawable_data()` gets the coordinates from `Robot` that pre-

Re: RFR: 8241192: [macosx] Wrong letter typed after ´ symbol when using Finnish layout

2022-02-10 Thread Dmitry Markov
On Fri, 28 Jan 2022 09:38:35 GMT, Prasanta Sadhukhan wrote: > If we press " ´ " (on U.S. keyboard layout it is the [+] button just before > the [delete] button), and then press "s" , 2 "´" characters are entered in a > text field instead of "´s" with "Finish" keyboard layout. > This is because

Re: RFR: 8280861: Robot color picker broken on Linux with scaling above 100%

2022-02-10 Thread Sergey Bylokhov
On Thu, 10 Feb 2022 14:08:48 GMT, Maxim Kartashev wrote: > The primary API for image capture on modern Linuxes is > `gdk_pixbuf_get_from_window()` that expects both coordinates and the size > unscaled (i.e. not multiplied by the current desktop scale). At the same > time, `gtk3_interface.c:gtk

Re: RFR: 8280861: Robot color picker broken on Linux with scaling above 100%

2022-02-10 Thread Maxim Kartashev
On Thu, 10 Feb 2022 18:04:37 GMT, Sergey Bylokhov wrote: >> The primary API for image capture on modern Linuxes is >> `gdk_pixbuf_get_from_window()` that expects both coordinates and the size >> unscaled (i.e. not multiplied by the current desktop scale). At the same >> time, `gtk3_interface.c

Re: RFR: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge

2022-02-10 Thread Sergey Bylokhov
On Thu, 10 Feb 2022 04:59:33 GMT, Anton Litvinov wrote: > Hello, > > Could you please review the following fix for the bug. The bug consists in > the fact that When an assistive technology software by means of Java Access > Bridge API executes "AccessibleAction" "click" on "AccessibleContext"

Re: RFR: 8280861: Robot color picker broken on Linux with scaling above 100%

2022-02-10 Thread Phil Race
On Thu, 10 Feb 2022 18:16:29 GMT, Maxim Kartashev wrote: >> src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c line 2874: >> >>> 2872: } >>> 2873: >>> 2874: static gboolean gtk3_get_drawable_data(JNIEnv *env, jintArray >>> pixelArray, >> >> Don't we need to do the same for the gtk2

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v6]

2022-02-10 Thread Harshitha Onkar
> Previously, the JTableHeader Bottom line wasn't visible on MacOS LAF (Aqua). > With the fix the bottom line (light grey) is visible. > > Changes were made to AquaTableHeaderBorder.paintBorder method and the height > of the component+border was adjusted in paint method. > > A new test case (J

Re: RFR: 8281555: [macos] Get rid of deprecated Style Masks constants

2022-02-10 Thread Sergey Bylokhov
On Wed, 9 Feb 2022 17:50:48 GMT, Dmitry Markov wrote: > The Style Masks constants [1], which are utilised by AWT, were deprecated > starting from macOS 10.12 Sierra. It is high time to replace them with new > constants introduced by NSWindowStyleMask enumeration [2]. > > [1] - https://develope

Re: RFR: 8277369: Strange behavior of JMenuBar with RIGHT_TO_LEFT orientation, arrow keys behaves opposite traversing through keyboard

2022-02-10 Thread Sergey Bylokhov
On Wed, 9 Feb 2022 05:39:52 GMT, Prasanta Sadhukhan wrote: > After applying setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) to > the JMenuBar the arrow keys started to behave the opposite of what expected. > Right arrow goes left and Left arrow goes right when trying to traverse >

Re: RFR: 8275345: RasterFormatException when drawing a tiled image made of non-writable rasters [v2]

2022-02-10 Thread Phil Race
On Thu, 10 Feb 2022 10:22:43 GMT, Martin Desruisseaux wrote: >> This commit fixes a `RasterFormatException` thrown when >> `Graphics2D.drawRenderedImage(…)` is invoked with an image containing tiles >> that are instances of `Raster` but not `WritableRaster`. >> >> https://bugs.openjdk.java.ne

RFR: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4

2022-02-10 Thread Phil Race
This test has started failing since we got M1 macs to test on. I don't think we've ever seen this failure elsewhere. I don't know what it is about that architecture that makes it more likely but I can see how it can happen when multiple threads are using the same instance. i

Re: RFR: JDK-8016524: [macosx] Bottom line is not visible for JTableHeader [v6]

2022-02-10 Thread Harshitha Onkar
On Mon, 7 Feb 2022 09:06:06 GMT, Prasanta Sadhukhan wrote: >> I see it fails for me in mac 10.15..DId you see it pass locally for you and >> in CI systems? Also, it should show 3 rows including row showing "A""B""C" >> as it is shown in windows/ubuntu, why it is showing only 1 row here? >> >>

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v5]

2022-02-10 Thread lawrence . andrews
> 1) Removed =yesno that was causing the test to fail with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > After removing =yesno, test was just passing without user interaction so > fixed the following > > Add the following so that

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v4]

2022-02-10 Thread lawrence . andrews
On Thu, 10 Feb 2022 08:47:51 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed RenderingHints.VALUE_TEXT_ANTIALIAS_GASP and fixed the review >> comments > > test/jdk/java/awt/Graphics/

Re: RFR: 8269091: javax/sound/sampled/Clip/SetPositionHang.java failed with ArrayIndexOutOfBoundsException: Array index out of range: -4

2022-02-10 Thread Sergey Bylokhov
On Thu, 10 Feb 2022 23:57:29 GMT, Phil Race wrote: > This test has started failing since we got M1 macs to test on. I don't think > we've ever seen this failure elsewhere. > I don't know what it is about that architecture that makes it more likely but > I can see how it can happen when multiple

Re: RFR: 8280861: Robot color picker broken on Linux with scaling above 100%

2022-02-10 Thread Maxim Kartashev
On Thu, 10 Feb 2022 22:28:56 GMT, Phil Race wrote: >> Maybe not as the previous fix was mode for gtk3 only, but I can >> double-check. Do you know if MATE desktop environment is a good candidate >> for finding gtk2 or are there easier options on Ubuntu? > > I have no idea what MATE is but if y

Re: RFR: 8280861: Robot color picker broken on Linux with scaling above 100%

2022-02-10 Thread Sergey Bylokhov
On Fri, 11 Feb 2022 06:14:27 GMT, Maxim Kartashev wrote: >> I have no idea what MATE is but if you are saying you have a recent Ubuntu >> and you don't have GTK2, I am at least 95% sure GTK2 is still available from >> Ubuntu package manager for all current releases. > > MATE desktop continues t

Re: RFR: 8280861: Robot color picker broken on Linux with scaling above 100%

2022-02-10 Thread Sergey Bylokhov
On Thu, 10 Feb 2022 14:08:48 GMT, Maxim Kartashev wrote: > The primary API for image capture on modern Linuxes is > `gdk_pixbuf_get_from_window()` that expects both coordinates and the size > unscaled (i.e. not multiplied by the current desktop scale). At the same > time, `gtk3_interface.c:gtk

Integrated: 8281419: The source data for the color conversion can be discarded

2022-02-10 Thread Sergey Bylokhov
On Tue, 8 Feb 2022 05:42:47 GMT, Sergey Bylokhov wrote: > When we convert the image from one color profile to another one we copy data > to the temp array, and after conversion, we commit both(src and dst). But the > source array could be discarded since we do not(should not) change it. > > T