On Tue, 15 Mar 2022 18:20:48 GMT, Alexey Ivanov wrote:
>> Maxim Kartashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> HiDPIRobotScreenCaptureTest.java: smaller frame size such that it fits on
>> a 1200x600 screen.
>>
>> ScreenC
> The two tests `ScreenCaptureGtkTest.java` and
> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
> started to intermittently fail under Windows and Linux after the [recent
> changes](https://github.com/openjdk/jdk/commit/cc7cf81256ed4d74493472017b1c4df20fa2208a)
>
On Mon, 14 Mar 2022 22:27:37 GMT, Harshitha Onkar wrote:
>> @prsadhuk Thank you for reviewing.
>>
>> Earlier when I used the default thickness (thickness=1) the cell focus ring
>> was visible but not prominent as shown in the following screenshot. Please
>> let me know if I need to change thi
> The two tests `ScreenCaptureGtkTest.java` and
> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
> started to intermittently fail under Windows and Linux after the [recent
> changes](https://github.com/openjdk/jdk/commit/cc7cf81256ed4d74493472017b1c4df20fa2208a)
>
Hello,
Please review this fix for JDK-8282863.
The failing
`java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test
basically checks that full-screen window remains full-screen when a display
mode change occurs. It has been introduced in JDK-8211999, which also contains
nume
On Wed, 16 Mar 2022 06:05:13 GMT, Prasanta Sadhukhan
wrote:
>> Since List.focusCellHighlightBorder uses the same focusRingColor as used by
>> Table we can change it for List as well. Can I make changes to List using
>> this issue and PR or should I track it by adding a new JBS bug/PR ?
>
> Jus
On Wed, 16 Mar 2022 07:42:00 GMT, Prasanta Sadhukhan
wrote:
>> Just thinking, Do we need to manipulate hue and saturation for focus ring?
>> It seems from native "Numbers" app which is closest to Tables & cells, I see
>> the focus ring is always blue irrespective of what the selection backgrou
> Create a test or
> [JDK-4715503](https://bugs.openjdk.java.net/browse/JDK-4715503)
>
> The getAccessibleContext method for JTable column header cells returns an
> AccessibleContext which cannot get the Bounding Rectangle for table header
> cells. The Bug causes problems with screen reader rev
On Wed, 16 Mar 2022 06:00:10 GMT, Sergey Bylokhov wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments fixed: null check added for Bounding Rectangles Returned.
>
> test/jdk/javax/accessibility/471
On 2022-03-16 07:31, Alan Bateman wrote:
Magnus,
This proposal does not address the previous concerns. As before, you
are proposing to put the data files used to generate the classes for
jdk.localedata and jdk.charsets into src/java.base and I don't think
we should do that. I really think thi
On Wed, 16 Mar 2022 06:31:52 GMT, Manukumar V S wrote:
>> test/jdk/javax/swing/JSplitPane/4820080/JSplitPaneDragColorTest.java line 71:
>>
>>> 69: robot.setAutoWaitForIdle(true);
>>> 70: robot.setAutoDelay(200);
>>> 71: // Skipping NimbusLookAndFeel & GTKLookAndFeel as bo
> Write a regression test for
> [JDK-4820080](https://bugs.openjdk.java.net/browse/JDK-4820080) : RFE: Cannot
> Change the JSplitPane Divider Color while dragging
>
> Issue(as per bug description):
> I want to change the color of the JSplitPane divider. I
> opened the code and found that, the co
On Wed, 16 Mar 2022 07:41:32 GMT, Maxim Kartashev wrote:
>> The two tests `ScreenCaptureGtkTest.java` and
>> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
>> started to intermittently fail under Windows and Linux after the [recent
>> changes](https://github.com/o
On Wed, 16 Mar 2022 07:41:32 GMT, Maxim Kartashev wrote:
>> The two tests `ScreenCaptureGtkTest.java` and
>> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
>> started to intermittently fail under Windows and Linux after the [recent
>> changes](https://github.com/o
On Fri, 11 Mar 2022 14:38:28 GMT, Srinivas Mandalika
wrote:
>> Create a regression test for CCC8000326
>>
>> Issue is identified by
>> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which
>> identifies that after focus moves into JMenuBar, whose focus traversal key
>> is di
On Fri, 11 Mar 2022 14:38:28 GMT, Srinivas Mandalika
wrote:
>> Create a regression test for CCC8000326
>>
>> Issue is identified by
>> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which
>> identifies that after focus moves into JMenuBar, whose focus traversal key
>> is di
On Fri, 11 Mar 2022 14:38:28 GMT, Srinivas Mandalika
wrote:
>> Create a regression test for CCC8000326
>>
>> Issue is identified by
>> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which
>> identifies that after focus moves into JMenuBar, whose focus traversal key
>> is di
On Tue, 15 Mar 2022 16:51:56 GMT, lukeu wrote:
> I believe the only way to get pixel-perfect (& balanced weight) rendering of
> 2 lines next to each other at non-integer scale factors, when using integer
> based APIs like `drawLine`, will be to undo the affine transformation upon
> the pre-sca
On Tue, 8 Mar 2022 10:52:44 GMT, Manukumar V S wrote:
> Create a regression test for the JTree usecase of
> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767)
> Context: Migrating tests from a closed tonga based test suite to open
> regression based one.
>
> Issue identified in
>
> Create a regression test for the JTree usecase of
> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767)
> Context: Migrating tests from a closed tonga based test suite to open
> regression based one.
>
> Issue identified in
> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-
On Tue, 8 Mar 2022 10:06:23 GMT, Manukumar V S wrote:
> Create a regression test for
> [JDK-4330998](https://bugs.openjdk.java.net/browse/JDK-4330998)
> Context: Migrating tests from a closed tonga based test suite to open
> regression based one.
>
> Issue tested:
> When calling JEditorPane.se
On Wed, 16 Mar 2022 16:25:25 GMT, Manukumar V S wrote:
>> Create a regression test for the JTree usecase of
>> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767)
>> Context: Migrating tests from a closed tonga based test suite to open
>> regression based one.
>>
>> Issue identifie
> Create a regression test for
> [JDK-4330998](https://bugs.openjdk.java.net/browse/JDK-4330998)
> Context: Migrating tests from a closed tonga based test suite to open
> regression based one.
>
> Issue tested:
> When calling JEditorPane.setText(null), the following exception is thrown:
>
> jav
On Wed, 16 Mar 2022 16:23:37 GMT, Alexey Ivanov wrote:
>> Manukumar V S has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments fixed: Simplified the test, removed unwanted method
>
> test/jdk/javax/swing/JEditorPane/4330998/JEdi
On Wed, 16 Mar 2022 16:36:22 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JEditorPane/4330998/JEditorPaneSetTextNullTest.java
>> line 41:
>>
>>> 39:
>>> 40: try {
>>> 41: SwingUtilities.invokeAndWait(() ->
>>> editorPane.setText(null));
>>
>> I believe the test cou
> Create a regression test for
> [JDK-4330998](https://bugs.openjdk.java.net/browse/JDK-4330998)
> Context: Migrating tests from a closed tonga based test suite to open
> regression based one.
>
> Issue tested:
> When calling JEditorPane.setText(null), the following exception is thrown:
>
> jav
On Wed, 16 Mar 2022 16:39:24 GMT, Manukumar V S wrote:
> But if we want to throw the RuntimeException with a failure message, I think
> we need to catch it, right?
Yes, if you want to provide a more specific error message.
-
PR: https://git.openjdk.java.net/jdk/pull/7740
> Create a regression test for
> [JDK-4330998](https://bugs.openjdk.java.net/browse/JDK-4330998)
> Context: Migrating tests from a closed tonga based test suite to open
> regression based one.
>
> Issue tested:
> When calling JEditorPane.setText(null), the following exception is thrown:
>
> jav
On Wed, 16 Mar 2022 17:03:33 GMT, Manukumar V S wrote:
>> Create a regression test for
>> [JDK-4330998](https://bugs.openjdk.java.net/browse/JDK-4330998)
>> Context: Migrating tests from a closed tonga based test suite to open
>> regression based one.
>>
>> Issue tested:
>> When calling JEdito
On Wed, 16 Mar 2022 06:02:28 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional com
On Tue, 15 Mar 2022 23:50:20 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Mon, 14 Mar 2022 16:15:47 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added functions for drawing b
On Fri, 11 Mar 2022 23:13:15 GMT, DamonGuy wrote:
> Aqua L&F tables lacked support for `CTRL+ARROW`, `CTRL+PG_UP/DOWN`, and
> `CTRL+SHIFT+PG_UP/DOWN` key bindings. This allows for navigation and
> selection of table cells without the need of a mouse and without deselecting
> the current select
On Sun, 13 Mar 2022 21:06:24 GMT, Alexander Zuev wrote:
> Detect the situation where we do need to perform interpolation during
> ImageIcon
> painting and set a hint to the rendering to perform bicubic approximation so
> image details are preserved during transition.
src/java.desktop/share/clas
On Wed, 16 Mar 2022 06:02:28 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional com
On Wed, 16 Mar 2022 06:24:00 GMT, Miguel Munoz wrote:
> > Apple Pages has no support at all for these table navigation functions
> > other than `COMMAND+LEFT_CLICK`. Excel has a selection mode that can be
> > toggled on/off using SHIFT+F8. I also tested in macOS's `System Preferences
> > > Key
> msg drop for jdk19, Mar 9, 2022
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
removed incorrect translation of compiler configuration file
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7765/files
- new:
On Tue, 15 Mar 2022 23:50:20 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Wed, 16 Mar 2022 18:12:24 GMT, DamonGuy wrote:
> I see your point. I will update the closed repo changes to exclude macOS from
> testing to avoid any issues it may cause. Should a separate issue be raised
> to update
> [this](https://docs.oracle.com/javase/tutorial/uiswing/components/table.
On Sun, 13 Mar 2022 21:06:24 GMT, Alexander Zuev wrote:
> Detect the situation where we do need to perform interpolation during
> ImageIcon
> painting and set a hint to the rendering to perform bicubic approximation so
> image details are preserved during transition.
The problem is attempt to s
On Wed, 16 Mar 2022 07:39:21 GMT, Dmitry Kulikov wrote:
> Hello,
> Please review this fix for JDK-8282863.
>
> The failing
> `java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test
> basically checks that full-screen window remains full-screen when a display
> mode change
On Wed, 16 Mar 2022 08:21:26 GMT, Srinivas Mandalika
wrote:
>> Create a test or
>> [JDK-4715503](https://bugs.openjdk.java.net/browse/JDK-4715503)
>>
>> The getAccessibleContext method for JTable column header cells returns an
>> AccessibleContext which cannot get the Bounding Rectangle for t
On Wed, 16 Mar 2022 10:12:16 GMT, Manukumar V S wrote:
>> Write a regression test for
>> [JDK-4820080](https://bugs.openjdk.java.net/browse/JDK-4820080) : RFE:
>> Cannot Change the JSplitPane Divider Color while dragging
>>
>> Issue(as per bug description):
>> I want to change the color of the
On Wed, 23 Feb 2022 21:34:29 GMT, Emmanuel Bourg wrote:
>> Emmanuel Bourg has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Test case for the window icon update on DPI change (Java generic font
>> names are usually capitalized)
>> - Te
On Wed, 16 Mar 2022 20:56:09 GMT, Alexey Ivanov wrote:
> If the default value for `KEY_INTERPOLATION` is not
> `VALUE_INTERPOLATION_NEAREST_NEIGHBOR`, it will be changed to a non-default
> value after painting the icon. Right?
Yes, that code depends on the understanding that if no hint is set
On Wed, 16 Mar 2022 18:56:39 GMT, Alexander Zuev wrote:
> The problem is attempt to set it back to null causes NPE. null value means it
> is not set and there is no method to remove the hint.
If the default value for `KEY_INTERPOLATION` is not
`VALUE_INTERPOLATION_NEAREST_NEIGHBOR`, it will be
> Following methods are covered in this testcase
> getAccessibleAction()
> getAccessibleActionCount()
> doAccessibleAction(int direction)
>
> @shurymury
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
Fixed review comments
On Wed, 9 Mar 2022 21:36:06 GMT, Alexandre Iline wrote:
>> lawrence.andrews has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added command after the date
>
> test/jdk/javax/swing/JSlider/8262981/JSliderAccessibleAction.java line 179:
>
>
On Tue, 15 Mar 2022 23:50:20 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Wed, 16 Mar 2022 18:31:55 GMT, Alisen Chung wrote:
>> msg drop for jdk19, Mar 9, 2022
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed incorrect translation of compiler configuration file
LGTM. Thanks for the cha
On Wed, 16 Mar 2022 21:31:08 GMT, Naoto Sato wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 12 commits:
>>
>> - Merge branch 'master' into shuffle-data-reborn
>> - Fix merge
>> - Merge tag 'jdk-19+
On Wed, 16 Mar 2022 21:56:53 GMT, Magnus Ihse Bursie wrote:
>> make/modules/jdk.charsets/Gensrc.gmk line 32:
>>
>>> 30: # Generate files using the charsetmapping tool
>>> 31: #
>>> 32: CHARSET_DATA_DIR := $(TOPDIR)/src/java.base/share/data/charsetmapping
>>
>> Is it intentional to leave `java.b
On Thu, 27 Jan 2022 21:47:04 GMT, lawrence.andrews
wrote:
>> 1) Test scenario was just showing test instruction with JTextArea. So added
>> the JTextArea as the instruction and method says.
>> 2) JTextArea is filled with contents so that and an Emoji character making
>> sure that screen reade
On Thu, 16 Dec 2021 19:23:10 GMT, Artem Semenov wrote:
>> Hi @savoptik,
>> a) The test createTextArea() does not have JTextArea . I have attached the
>> screen shot of the test https://bugs.openjdk.java.net/browse/JDK-8278828
>> b) The test does not say its a non-editable JTextArea. Even the ex
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move t
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move t
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move t
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Wed, 16 Dec 2020 18:34:37 GMT, Naoto Sato wrote:
>>> @AlanBateman The process of modularization was not fully completed with
>>> Project Jigsaw, and a few ugly warts remained. I was under the impression
>>> that these should be addressed in follow-up fixes, but this was
>>> unfortunately ne
On Wed, 16 Mar 2022 07:41:32 GMT, Maxim Kartashev wrote:
>> The two tests `ScreenCaptureGtkTest.java` and
>> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
>> started to intermittently fail under Windows and Linux after the [recent
>> changes](https://github.com/o
The JDK's built-in Image I/O JPEG plugin decodes JPEGs which are YCbCr and RGb
and Grayscale but rejects CMYK and YCCK JPEGs.
These would correspond to JFIF encapsulated JPEGs.
This was a reasonable decision to limit support to what was actually likely to
be seen - CMYK JPEGs probably should jus
On Thu, 17 Mar 2022 04:03:52 GMT, Prasanta Sadhukhan
wrote:
> With korean font pack installed, language set to Korean and calling
> Locale.setDefault(Locale.KOREAN) in testcase, we have
>  had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional com
On Wed, 16 Mar 2022 06:02:28 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional com
On Wed, 16 Mar 2022 20:20:39 GMT, Sergey Bylokhov wrote:
> Looks fine, please confirm that mach5 is green before integration.
Confirmed with Mach5 execution in Linux,Mac and Windows machines(10 times run
in each platform) and got all pass.
-
PR: https://git.openjdk.java.net/jdk/pu
On Wed, 16 Mar 2022 06:02:28 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional com
On Thu, 17 Mar 2022 05:05:16 GMT, Prasanta Sadhukhan
wrote:
> Without the fix,
> 
If I compile the testcase with in-built javac and then run with build jdk, then
I get the above imag
On Wed, 16 Mar 2022 20:12:55 GMT, Sergey Bylokhov wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments fixed: null check added for Bounding Rectangles Returned.
>
> Marked as reviewed by serb (Revi
68 matches
Mail list logo
