> Write an automated regression test for
> [JDK-4371575](https://bugs.openjdk.java.net/browse/JDK-4371575)
>
> Issue:
> As part of the Merlin focus project, JComponent.setRequestFocusEnabled was
> deprecated and its implementation was changed to map exactly to the new
> method Component.setFocusa
> Create a regression test for
> [JDK-4287690](https://bugs.openjdk.java.net/browse/JDK-4287690)
> Issue description:
> I want JComboBox to send an event just before the popup (drop down) list is
> displayed.
>
> Fix:
> This requires some additional API targeted for major release of the JDK
> (
> Write a regression test for
> [JDK-4390885](https://bugs.openjdk.java.net/browse/JDK-4390885) Enhancement
> Request.
>
> Issue:
> Please add the ability to set the location of a JFileChooser. This might be a
> bug, but JFileChooser.setLocation() has no effect when
> JFileChooser.showDialog
On Thu, 7 Apr 2022 21:01:30 GMT, Phil Race wrote:
> Before I look at the test, can you get rid of the pointless directory 4371575
> A directory might be needed if you had a lot of files for the test - but you
> don't ! And I really don't like naming directories OR tests with the bugid.
> Someo
On Fri, 8 Apr 2022 00:36:54 GMT, Harshitha Onkar wrote:
>> Following type properties where checked for cellFocusRing color
>>
>> -
>> [alternateSelectedControlColor](https://developer.apple.com/documentation/appkit/nscolor/1533135-alternateselectedcontrolcolor)
>>
>> **Issue:** Doesn't follow
On Wed, 6 Apr 2022 10:27:12 GMT, Tejesh R wrote:
>> Removed the println() line from the Interrupted catch block. Since
>> waitForID() Interrupt indicates completion of Image Loading, println as
>> Interrupt handling was not required.
>
> Tejesh R has updated the pull request incrementally with
On Fri, 8 Apr 2022 06:55:34 GMT, Tejesh R wrote:
>> getText function returned extra endOfLine when appended. The reason was in
>> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)`
>> method, where translation happens from buffer to Out(Writer Object) if
>> endOfLine
> Removed the println() line from the Interrupted catch block. Since
> waitForID() Interrupt indicates completion of Image Loading, println as
> Interrupt handling was not required.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Update
On Fri, 8 Apr 2022 08:38:20 GMT, Prasanta Sadhukhan
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Java coding style fix
>
> src/java.desktop/share/classes/javax/swing/text/DefaultEditorKit.java line
> 350:
>
>> 34
On Fri, 8 Apr 2022 08:51:30 GMT, Tejesh R wrote:
>> Removed the println() line from the Interrupted catch block. Since
>> waitForID() Interrupt indicates completion of Image Loading, println as
>> Interrupt handling was not required.
>
> Tejesh R has updated the pull request incrementally with
On Fri, 8 Apr 2022 08:49:36 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/text/DefaultEditorKit.java line
>> 350:
>>
>>> 348: }
>>> 349: }
>>> 350: out.write(endOfLine);
>>
>> It seems in windows,
Create an automated test for
[JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362)
The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return
BoundedRangeModel.getMaximum() from getMaximumAccessibleValue() in their
AccessibleValue implementation.
The real maximum value
On Fri, 8 Apr 2022 09:00:53 GMT, Prasanta Sadhukhan
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on Review Comments
>
> test/jdk/javax/swing/ImageIcon/LoadInterruptTest.java line 61:
>
>> 59:
> getText function returned extra endOfLine when appended. The reason was in
> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)`
> method, where translation happens from buffer to Out(Writer Object) if
> endOfLine is other than '\n' ( which is '\r\n' in windows). In or
On Fri, 8 Apr 2022 09:02:53 GMT, Prasanta Sadhukhan
wrote:
> ok, so you are telling out.write(array, last, counter - last - 1) will write
> till \r\n and out.write(endOfLine) will write \r\n, is it?
Yes.
-
PR: https://git.openjdk.java.net/jdk/pull/8122
On Fri, 8 Apr 2022 10:10:09 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/ImageIcon/LoadInterruptTest.java line 61:
>>
>>> 59: prevSysOut = System.out;
>>> 60: testOut = new ByteArrayOutputStream();
>>> 61: System.setOut(new PrintStream(testOut, true,
>>> StandardCha
On Fri, 8 Apr 2022 08:51:30 GMT, Tejesh R wrote:
>> Removed the println() line from the Interrupted catch block. Since
>> waitForID() Interrupt indicates completion of Image Loading, println as
>> Interrupt handling was not required.
>
> Tejesh R has updated the pull request incrementally with
On Fri, 8 Apr 2022 10:14:58 GMT, Tejesh R wrote:
>> ok, so you are telling out.write(array, last, counter - last - 1) will write
>> till \r\n and out.write(endOfLine) will write \r\n, is it?
>> ANyway, you need to modify this change as per coding style which is
>>
>> else {
>> }
>
>> ok, so yo
On Fri, 8 Apr 2022 11:25:36 GMT, Prasanta Sadhukhan
wrote:
>>> ok, so you are telling out.write(array, last, counter - last - 1) will
>>> write till \r\n and out.write(endOfLine) will write \r\n, is it?
>>
>> Yes.
>
> So, presently it was writing /r/n/r/n and with fix, it will write
> /r/n, r
On Fri, 8 Apr 2022 11:28:26 GMT, Tejesh R wrote:
>> So, presently it was writing /r/n/r/n and with fix, it will write
>> /r/n, right?
>
> No, presently it was writing /r/r/n and with fix it will write /r/n for every
> line ending.. /r was causing for carriage return and /r/n for an extra
>
On Thu, 7 Apr 2022 14:59:38 GMT, Prasanta Sadhukhan
wrote:
>> Issue was when printing a JTable which sits inside a JScrollPane and the
>> table is scrolled down to the end to about 1000th row, only the first page
>> is printed.
>> This is because when the table is scrolled down to last page,
On Thu, 7 Apr 2022 14:59:38 GMT, Prasanta Sadhukhan
wrote:
>> Issue was when printing a JTable which sits inside a JScrollPane and the
>> table is scrolled down to the end to about 1000th row, only the first page
>> is printed.
>> This is because when the table is scrolled down to last page,
On Fri, 8 Apr 2022 11:31:07 GMT, Prasanta Sadhukhan
wrote:
>> No, presently it was writing /r/r/n and with fix it will write /r/n for
>> every line ending.. /r was causing for carriage return and /r/n for an
>> extra empty line on Text pane...
>
> But should /r/r/n cause 2 line feeds?
On Fri, 8 Apr 2022 08:51:30 GMT, Tejesh R wrote:
>> Removed the println() line from the Interrupted catch block. Since
>> waitForID() Interrupt indicates completion of Image Loading, println as
>> Interrupt handling was not required.
>
> Tejesh R has updated the pull request incrementally with
On Thu, 7 Apr 2022 16:04:35 GMT, Tejesh R wrote:
> >
>
> > Why can't the test be automatic?
>
> Actually had thought about automating the test case, but since endOfLine(Win
> - '\r\n', linux - '\n') is different for different OS, have made it manual.
It just means the original issue is obser
> Issue was when printing a JTable which sits inside a JScrollPane and the
> table is scrolled down to the end to about 1000th row, only the first page is
> printed.
> This is because when the table is scrolled down to last page, the bounds.y
> becomes -ve
> [x=0,y=-15260,width=968,height=1600
> Issue was when printing a JTable which sits inside a JScrollPane and the
> table is scrolled down to the end to about 1000th row, only the first page is
> printed.
> This is because when the table is scrolled down to last page, the bounds.y
> becomes -ve
> [x=0,y=-15260,width=968,height=1600
On Fri, 8 Apr 2022 11:40:47 GMT, Alexey Ivanov wrote:
> You should consider adding the evaluation from this PR description to JBS.
yeah sure.
-
PR: https://git.openjdk.java.net/jdk/pull/8141
On Fri, 8 Apr 2022 11:43:26 GMT, Alexey Ivanov wrote:
>> But should /r/r/n cause 2 line feeds? /r should be just carriage return to
>> cause caret to move from last column to first, why it is inserting new line?
>
> It is common to treat `\r` as new line if it's not followed by `\n`. In a
> vis
On Fri, 8 Apr 2022 10:21:22 GMT, Tejesh R wrote:
>> getText function returned extra endOfLine when appended. The reason was in
>> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)`
>> method, where translation happens from buffer to Out(Writer Object) if
>> endOfLine
On Fri, 8 Apr 2022 11:54:02 GMT, Tejesh R wrote:
>> It is common to treat `\r` as new line if it's not followed by `\n`. In a
>> visual editor `\r` doesn't do anything.
>>
>> Yet it's an interesting detail that wasn't covered in the initial evaluation.
>
>> But should /r/r/n cause 2 line feeds?
On Fri, 8 Apr 2022 11:56:36 GMT, Prasanta Sadhukhan
wrote:
>>> But should /r/r/n cause 2 line feeds? /r should be just carriage return to
>>> cause caret to move from last column to first, why it is inserting new line?
>>
>> \r is converted to \n in setText method... To be specific, in
>>
On Fri, 8 Apr 2022 11:48:24 GMT, Alexey Ivanov wrote:
> > >
> >
> >
> > > Why can't the test be automatic?
> >
> >
> > Actually had thought about automating the test case, but since
> > endOfLine(Win - '\r\n', linux - '\n') is different for different OS, have
> > made it manual.
>
> It ju
On Fri, 8 Apr 2022 11:59:19 GMT, Tejesh R wrote:
>> So, that means presently it is writing /n/r/n not /r/r/n, right?
>
> Initially it is /r/r/n from `getText()` of pane0, later it is /n/r/n from
> `setText()`
When you do out.write(array, last, counter - last); in write(Writer out,
Document
On Fri, 8 Apr 2022 12:08:07 GMT, Prasanta Sadhukhan
wrote:
>> Initially it is /r/r/n from `getText()` of pane0, later it is /n/r/n from
>> `setText()`
>
> When you do out.write(array, last, counter - last); in write(Writer out,
> Document doc, int pos, int len) method, what is being writte
> getText function returned extra endOfLine when appended. The reason was in
> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)`
> method, where translation happens from buffer to Out(Writer Object) if
> endOfLine is other than '\n' ( which is '\r\n' in windows). In or
On Fri, 8 Apr 2022 11:58:03 GMT, Prasanta Sadhukhan
wrote:
>> Issue was when printing a JTable which sits inside a JScrollPane and the
>> table is scrolled down to the end to about 1000th row, only the first page
>> is printed.
>> This is because when the table is scrolled down to last page,
On Fri, 8 Apr 2022 12:13:03 GMT, Tejesh R wrote:
>> When you do out.write(array, last, counter - last); in write(Writer out,
>> Document doc, int pos, int len) method, what is being written? Is it /r/r/n
>> or /n/r/n presently?
>
> Finally its /n/r/n... I mentioned /r/r/n because that was t
On Fri, 8 Apr 2022 12:17:37 GMT, Tejesh R wrote:
>> getText function returned extra endOfLine when appended. The reason was in
>> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)`
>> method, where translation happens from buffer to Out(Writer Object) if
>> endOfLine
On Fri, 8 Apr 2022 12:18:38 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test fix
>
> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 152:
>
>> 150: mainPanel.add(button
> Issue was when printing a JTable which sits inside a JScrollPane and the
> table is scrolled down to the end to about 1000th row, only the first page is
> printed.
> This is because when the table is scrolled down to last page, the bounds.y
> becomes -ve
> [x=0,y=-15260,width=968,height=1600
On Thu, 31 Mar 2022 13:30:40 GMT, Zhengyu Gu wrote:
> Please review this small patch to fix leaking `XShmSegmentInfo` that is
> attached to `XImage`.
>
> Test:
>
> - [x] jdk_2d
Friendly ping!
May I have a second review?
Thanks
-
PR: https://git.openjdk.java.net/jdk/pull/8060
On Fri, 8 Apr 2022 12:41:29 GMT, Prasanta Sadhukhan
wrote:
>> Issue was when printing a JTable which sits inside a JScrollPane and the
>> table is scrolled down to the end to about 1000th row, only the first page
>> is printed.
>> This is because when the table is scrolled down to last page,
On Wed, 6 Apr 2022 09:48:13 GMT, Ajit Ghaisas wrote:
> This PR makes Metal rendering pipeline as the default Java 2D rendering
> pipeline for macOS.
>
> Please refer "JBS Description" for more details.
This pull request has now been integrated.
Changeset: 3a0ddeba
Author:Ajit Ghaisas
URL
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as `
On Fri, 8 Apr 2022 07:55:57 GMT, Prasanta Sadhukhan
wrote:
>> @prrace @prsadhuk
>> The issue with the system color returned by **keyboardFocusIndicatorColor**
>> mentioned above, persists on macOS 12.3 as well.
>
> "accentColor" is swift property so not usable for jdk but you can use
> "contr
On Fri, 8 Apr 2022 06:49:16 GMT, Maxim Kartashev wrote:
>> src/java.desktop/unix/classes/sun/awt/X11/XCanvasPeer.java line 90:
>>
>>> 88: XToolkit.awtUnlock();
>>> 89: }
>>> 90: }
>>
>> I am not sure I understand the purpose of this method, it requests the
>> current de
On Fri, 8 Apr 2022 06:49:09 GMT, Maxim Kartashev wrote:
>> These crashes were not reproducible, so the fix is based on a hypothesis
>> that there are two possible reasons for them:
>> 1. `makeDefaultConfig()` returning `NULL`.
>> 2. A race condition when the number of screens changes.
>> The rac
On Fri, 1 Apr 2022 15:43:29 GMT, Alexey Ushakov wrote:
>> Throwing InvalidPipeException for incompatible surfaces
>
> Alexey Ushakov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskFill
On Fri, 8 Apr 2022 07:08:25 GMT, Manukumar V S wrote:
>> Write an automated regression test for
>> [JDK-4371575](https://bugs.openjdk.java.net/browse/JDK-4371575)
>>
>> Issue:
>> As part of the Merlin focus project, JComponent.setRequestFocusEnabled was
>> deprecated and its implementation was
On Tue, 5 Apr 2022 20:38:58 GMT, Alexey Ivanov wrote:
>> lawrence.andrews has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Dispose the Frame based in EDT
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 135:
>
>> 133:
On Fri, 8 Apr 2022 16:20:10 GMT, Phil Race wrote:
> why did you get rid of the just in case ?
I honestly couldn't find any way for this code to get executed. I can keep it
there, but then I would have to explain why it is needed.
> Actually why is this method being modified at all ?
The change
On Fri, 8 Apr 2022 16:19:30 GMT, Phil Race wrote:
> I don't understand why this was extracted out. It isn't called anywhere else
> and again makes the diff harder to understand.
This AWT lock should be held for a very small portion of the original method.
Initially, I left the code guarded by
On Sat, 2 Apr 2022 23:21:03 GMT, Phil Race wrote:
> Update Swing classes to use JEP 409 sealed and non-sealed modifiers and add
> the final modifier where appropriate.
>
> jtreg tests and JCK API tests pass
>
> CSR for review here : https://bugs.openjdk.java.net/browse/JDK-8284214
This pull r
On Fri, 8 Apr 2022 07:08:25 GMT, Manukumar V S wrote:
>> Write an automated regression test for
>> [JDK-4371575](https://bugs.openjdk.java.net/browse/JDK-4371575)
>>
>> Issue:
>> As part of the Merlin focus project, JComponent.setRequestFocusEnabled was
>> deprecated and its implementation was
On Thu, 7 Apr 2022 07:40:18 GMT, Srinivas Mandalika
wrote:
> Create an automated test for
> [JDK-4170173](https://bugs.openjdk.java.net/browse/JDK-4170173)
>
> Issue
> JTextComponent.AccessibleJTextComponent.getAfterIndex(int part, int index)
> works incorrectly, when 'part' parameter is Acce
On Wed, 6 Apr 2022 10:11:33 GMT, Prasanta Sadhukhan
wrote:
> The test was failing on macos and was excluded in macos because the
> viewposition was not changed after mouse wheel scroll. Seems like mouse wheel
> scroll direction is opposite in macos compared to windows etc so if we try to
> do
On Fri, 8 Apr 2022 07:12:21 GMT, Manukumar V S wrote:
>> Create a regression test for
>> [JDK-4287690](https://bugs.openjdk.java.net/browse/JDK-4287690)
>> Issue description:
>> I want JComboBox to send an event just before the popup (drop down) list is
>> displayed.
>>
>> Fix:
>> This require
On Thu, 7 Apr 2022 08:18:21 GMT, Srinivas Mandalika
wrote:
>> Write an automated regression test for JDK-4670319
>>
>> Issue
>> When a JTree node is expanded or collapsed, an Accessibility PropertyChange
>> event is fired with the old state of "collapsed" and new state of "expanded"
>> (or v
On Wed, 30 Mar 2022 10:33:32 GMT, Srinivas Mandalika
wrote:
>> Create a test for
>> [JDK-4740761](https://bugs.openjdk.java.net/browse/JDK-4740761)
>>
>> The issue observed is in a JFrame with a JTextField and a JScrollPane which
>> contains focused component. When the JScrollPane was
>> is r
On Fri, 8 Apr 2022 19:14:38 GMT, Maxim Kartashev wrote:
>> I don't understand why this was extracted out. It isn't called anywhere else
>> and again makes the diff harder to understand.
>
>> I don't understand why this was extracted out. It isn't called anywhere else
>> and again makes the diff
61 matches
Mail list logo
