On Sun, 30 Oct 2022 12:57:38 GMT, Alexey Ivanov wrote:
>> ravi gupta has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8295774 : Write a test to verify that List Item selection events.
>
> test/jdk/java/awt/event/ComponentEvent/ListItemEve
> This testcase verify that List Item selection via mouse/keys generates
> ItemEvent/ActionEvent appropriately.
>
> a. Single click on the list generate ItemEvent and double click on item
> generates ActionEvent.
> b. UP/DOWN keys on the list generate ItemEvent and enter key on item
> generates
On Wed, 28 Sep 2022 03:12:55 GMT, Sergey Bylokhov wrote:
> This is a request to cleanup the shared code for the colors conversions. That
> code still uses some wrappers which can be simplified and/or deleted after
> KCMS removal. For example, each conversion from one color space to another
> c
On Wed, 28 Sep 2022 03:12:55 GMT, Sergey Bylokhov wrote:
> This is a request to cleanup the shared code for the colors conversions. That
> code still uses some wrappers which can be simplified and/or deleted after
> KCMS removal. For example, each conversion from one color space to another
> c
On Tue, 1 Nov 2022 16:38:34 GMT, Alexey Ivanov wrote:
>> ScientificWare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Corrects a value in a message.
>>
>> A message is added to the result in case of failure only. The updated code
On Wed, 12 Oct 2022 16:41:52 GMT, Rajat Mahajan wrote:
> This fix is based on a similar approach as described here
> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
> We rescale the line border to render the Textfield border correctly, so that
> all sides of the Textfield bor
On Fri, 21 Oct 2022 22:21:09 GMT, Harshitha Onkar wrote:
>> JInternalFrame background color seems to overflow into the border region.
>> This issue is more prominently seen on Windows - Metal LAF (with fractional
>> scaling, as shown below). The primary reason is border scaling issue as
>> obs
On Fri, 21 Oct 2022 08:42:12 GMT, Alexander Scherbatiy
wrote:
> A printed content is truncated on macOS if the content paper size width
> larger than height with portrait orientation or width is less than height
> with landscape orientation.
>
> To reproduce the issue run the
> [CutOffImage]
On Tue, 1 Nov 2022 17:38:57 GMT, Rajat Mahajan wrote:
>> This fix is based on a similar approach as described here
>> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
>> We rescale the line border to render the Textfield border correctly, so that
>> all sides of the Textfield
On Tue, 1 Nov 2022 17:38:57 GMT, Rajat Mahajan wrote:
>> This fix is based on a similar approach as described here
>> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
>> We rescale the line border to render the Textfield border correctly, so that
>> all sides of the Textfield
> This fix is based on a similar approach as described here
> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
> We rescale the line border to render the Textfield border correctly, so that
> all sides of the Textfield border are of same thickness.
Rajat Mahajan has updated the
On Fri, 28 Oct 2022 16:00:10 GMT, Rajat Mahajan wrote:
>> This fix is based on a similar approach as described here
>> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
>> We rescale the line border to render the Textfield border correctly, so that
>> all sides of the Textfield
On Fri, 28 Oct 2022 16:00:10 GMT, Rajat Mahajan wrote:
>> This fix is based on a similar approach as described here
>> https://github.com/openjdk/jdk/pull/7449#issuecomment-1068218648.
>> We rescale the line border to render the Textfield border correctly, so that
>> all sides of the Textfield
On Mon, 31 Oct 2022 09:14:23 GMT, Prasanta Sadhukhan
wrote:
>> If getDefaultEditor() is called before the JTable model is setup, it results
>> in NPE.
>>
>> This is because when JTable sets its model, which ends up firing a table
>> changed event. The testcase is listening for tableChanged ev
On Mon, 31 Oct 2022 09:11:21 GMT, Prasanta Sadhukhan
wrote:
>> If getDefaultEditor() is called before the JTable model is setup, it results
>> in NPE.
>>
>> This is because when JTable sets its model, which ends up firing a table
>> changed event. The testcase is listening for tableChanged ev
On Tue, 27 Sep 2022 03:17:26 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8293776 : Adds CSS 4 and 8 digits hex coded
>> Color](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8293776)
>>
>> This is tracked in JBS as
>> - [JDK-8293776 : Adds CSS 4 and
On Mon, 31 Oct 2022 07:48:38 GMT, Prasanta Sadhukhan
wrote:
>> The behavior of MatteBorder constructors taking Insets object as a parameter
>> is undocumented. It would throw NPE if null object is passed to it, which
>> should be documented in the spec.
>
> Prasanta Sadhukhan has updated the p
On Tue, 1 Nov 2022 14:47:49 GMT, Alan Bateman wrote:
>> Actually... Maybe I could move up the paragraph that says that URL
>> constructors are deprecated up here, just after the title? Would
>> that be better?
>
> Try it, it might be better. I think the main thing is that link brings the
On Tue, 1 Nov 2022 16:10:47 GMT, Daniel Fuchs wrote:
>> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
>> to parse or construct any URL.
>>
>> The `java.net.URL` class does not itself encode or decode any URL components
>> according to the escaping mechanism define
> Deprecate URL constructors. Developers are encouraged to use `java.net.URI`
> to parse or construct any URL.
>
> The `java.net.URL` class does not itself encode or decode any URL components
> according to the escaping mechanism defined in RFC2396. It is the
> responsibility of the caller to e
On Mon, 31 Oct 2022 13:24:30 GMT, Renjith Kannath Pariyangad
wrote:
>> Updated the documentation with proper meaningful message for better
>> understanding.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Up
On Mon, 31 Oct 2022 08:59:31 GMT, Prasanta Sadhukhan
wrote:
>> DefaultListSelectionModel.removeIndexInterva accepts `int` value which
>> allows it to take in Integer.MAX_VALUE theoratically but it does calculation
>> with that value which can results in IOOBE.
>> Fix is to make sure the calcul
On Tue, 1 Nov 2022 03:06:16 GMT, Phil Race wrote:
> The analysis of the problem sounds fine but then it all gets confusing to me
> when I come to the fix.
>
> So first you capture the intended orientation in the switch but do not set it
> to the printer context.
The captured orientation is s
On Tue, 1 Nov 2022 14:22:18 GMT, Daniel Fuchs wrote:
>> To be discussed: I actually wanted the deprecation link ( the link from
>> `@deprecated` ) to lead here because I find that the whole section is
>> relevant for developers who might want to decide whether to actually move
>> away from usi
On Tue, 1 Nov 2022 14:10:01 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/URL.java line 133:
>>
>>> 131: * specified. The optional fragment is not inherited.
>>> 132: *
>>> 133: * Constructing instances of
>>> {@code URL}
>>
>> Would it be better to move the anchor to lin
On Sat, 29 Oct 2022 14:24:09 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Sat, 29 Oct 2022 14:17:12 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Sat, 29 Oct 2022 14:16:24 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Sat, 29 Oct 2022 14:14:22 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits
On Mon, 31 Oct 2022 22:00:01 GMT, Phil Race wrote:
> Deprecate URL constructors. Developers are encouraged to use java.net.URI to
> parse or construct any URL. ... To construct a URL, using URI::toURL should
> be preferred.
>
> You have jumped through some refactoring hoops to be able to apply
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
31 matches
Mail list logo
