Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v3]

2023-08-09 Thread Julian Waters
> We should set the -permissive- flag for the Microsoft Visual C compiler, as > was requested by the now backed out > [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done > with some effort, given that the significantly stricter gcc can now compile > an experimental Window

Re: RFR: 8314076: ICC_ColorSpace#minVal/maxVal have the opposite description

2023-08-09 Thread Alexander Zvegintsev
On Wed, 9 Aug 2023 23:31:39 GMT, Sergey Bylokhov wrote: > Fixed a typo in the spec which changes the meaning of the > ICC_ColorSpace#minVal/maxVal fields to the opposite. Marked as reviewed by azvegint (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15216#pullrequestrevi

Re: RFR: 8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action! [v2]

2023-08-09 Thread Damon Nguyen
> Test fails intermittently on macosx-aarch64. Adding a delay between the first > and second drag fixes the issue since there may be some timing issue between > the two drag events. Tested the change twice, with 100 repeats per test on > all OS's. All tests passed. Also corrected a spelling mist

RFR: 8314076: ICC_ColorSpace#minVal/maxVal have the opposite description

2023-08-09 Thread Sergey Bylokhov
Fixed a typo in the spec which changes the meaning of the ICC_ColorSpace#minVal/maxVal fields to the opposite. - Commit messages: - 8314076: ICC_ColorSpace#minVal/maxVal have the opposite description Changes: https://git.openjdk.org/jdk/pull/15216/files Webrev: https://webrevs.ope

Re: RFR: 8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action!

2023-08-09 Thread Sergey Bylokhov
On Wed, 9 Aug 2023 21:59:23 GMT, Damon Nguyen wrote: > Test fails intermittently on macosx-aarch64. Adding a delay between the first > and second drag fixes the issue since there may be some timing issue between > the two drag events. Tested the change twice, with 100 repeats per test on > all

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v3]

2023-08-09 Thread lawrence . andrews
On Wed, 9 Aug 2023 21:02:37 GMT, Harshitha Onkar wrote: >> lawrence.andrews has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Changed enableScreenCapture method name to screenCapture shorter method >> name >> - Update full name > > tes

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v3]

2023-08-09 Thread Harshitha Onkar
On Wed, 9 Aug 2023 20:55:32 GMT, lawrence.andrews wrote: >> 1) Used builder pattern >> 2) Tested AWT tests and it passed > > lawrence.andrews has updated the pull request incrementally with two > additional commits since the last revision: > > - Changed enableScreenCapture method name to scre

Re: RFR: 8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action!

2023-08-09 Thread Harshitha Onkar
On Wed, 9 Aug 2023 21:59:23 GMT, Damon Nguyen wrote: > Test fails intermittently on macosx-aarch64. Adding a delay between the first > and second drag fixes the issue since there may be some timing issue between > the two drag events. Tested the change twice, with 100 repeats per test on > all

RFR: 8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action!

2023-08-09 Thread Damon Nguyen
Test fails intermittently on macosx-aarch64. Adding a delay between the first and second drag fixes the issue since there may be some timing issue between the two drag events. Tested the change twice, with 100 repeats per test on all OS's. All tests passed. Also corrected a spelling mistake and

Re: Setting printer output bin

2023-08-09 Thread Philip Race
On 8/9/23 3:00 PM, Philip Race wrote: So first step would be an RFE to add it and all the associated implementation work. https://bugs.openjdk.org/browse/JDK-8314070 -phil.

Re: Setting printer output bin

2023-08-09 Thread Philip Race
Output Bin is an IPP extension attribute https://ftp.pwg.org/pub/pwg/candidates/cs-ippoutputbin10-20010207-5100.2.pdf It is not defined in the core RFC on which javax.print was based https://www.ietf.org/rfc/rfc2911.txt So this means it is not in the API and it will get ignored and there's n

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v3]

2023-08-09 Thread Harshitha Onkar
On Wed, 9 Aug 2023 20:55:32 GMT, lawrence.andrews wrote: >> 1) Used builder pattern >> 2) Tested AWT tests and it passed > > lawrence.andrews has updated the pull request incrementally with two > additional commits since the last revision: > > - Changed enableScreenCapture method name to scre

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v3]

2023-08-09 Thread lawrence . andrews
> 1) Used builder pattern > 2) Tested AWT tests and it passed lawrence.andrews has updated the pull request incrementally with two additional commits since the last revision: - Changed enableScreenCapture method name to screenCapture shorter method name - Update full name - Chan

Re: Follow up to "8313698: BaseMultiResolutionImage doesn't work as icon of java.awt.Window on Linux"

2023-08-09 Thread Andrei Rybak
On 09/08/2023 01:35, Andrei Rybak wrote: Hello Aleksei, thank you for looking into this issue. On 08/08/2023 22:04, Aleksei Ivanov wrote: You may want to update your test case so that it generates icons on the fly and uses numbers to easily distinguish one from another. You can get code from W

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v2]

2023-08-09 Thread Harshitha Onkar
On Tue, 8 Aug 2023 21:10:49 GMT, lawrence.andrews wrote: >> 1) Used builder pattern >> 2) Tested AWT tests and it passed > > lawrence.andrews has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 10 commits: > > - Revert changes to Pri

Re: RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v3]

2023-08-09 Thread Tejesh R
> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`. > Converting the `String `to `locale` before adding as command key fix the > issue. > I have verified the test in all other platforms and Look and Feel which has > option to create New Folder, results were fine. No regre

Re: RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v2]

2023-08-09 Thread Tejesh R
On Wed, 9 Aug 2023 06:01:47 GMT, Tejesh R wrote: >> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`. >> Converting the `String `to `locale` before adding as command key fix the >> issue. >> I have verified the test in all other platforms and Look and Feel which has >>

Re: RFR: 8294535 : Add screen capture functionality to PassFailJFrame [v2]

2023-08-09 Thread Alexey Ivanov
On Tue, 8 Aug 2023 21:10:49 GMT, lawrence.andrews wrote: >> 1) Used builder pattern >> 2) Tested AWT tests and it passed > > lawrence.andrews has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 10 commits: > > - Revert changes to Pri

Re: RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v2]

2023-08-09 Thread Alexey Ivanov
On Wed, 9 Aug 2023 06:02:30 GMT, Tejesh R wrote: > Re-opening the PR with proposed fix. After understanding the issue reported > and analysis made, it is observed that on change of locale (mid-application) > all others component labels were update with new locale provided, yet `New > Folder` d

Re: RFR: 8312075: FileChooser.win32.newFolder is not updated when changing Locale [v2]

2023-08-09 Thread Alexey Ivanov
On Wed, 9 Aug 2023 06:01:47 GMT, Tejesh R wrote: >> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`. >> Converting the `String `to `locale` before adding as command key fix the >> issue. >> I have verified the test in all other platforms and Look and Feel which has >>

Re: RFR: 8311247: Some cpp files are compiled with -std:c11 flag

2023-08-09 Thread Daniel Jeliński
On Tue, 8 Aug 2023 18:28:36 GMT, Erik Joelsson wrote: > it's unfortunate that we need to repeat so much. Right. The default make convention uses `CPPFLAGS` for flags shared between preprocessor and both C and C++ compilers. We don't have any shared variable as far as I could tell. Thanks for t

Integrated: 8311247: Some cpp files are compiled with -std:c11 flag

2023-08-09 Thread Daniel Jeliński
On Mon, 3 Jul 2023 17:15:17 GMT, Daniel Jeliński wrote: > Please review this patch that configures C++ arguments on build jobs that > involve compiling CPP files. As a result of this change, CPP files are > compiled with `-std:c++14` command line argument instead of `-std:c11`, which > is used

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-09 Thread Julian Waters
On Wed, 9 Aug 2023 06:37:10 GMT, Thomas Stuefe wrote: >> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 22 additional >> commits

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-09 Thread Patrick Chen
Can you shut the f Le mer. 9 août 2023, 10:10, Thomas Stuefe a écrit : > On Wed, 9 Aug 2023 06:53:49 GMT, David Holmes wrote: > > >> I wrote this code ages ago. I'm not sure what's weird or suspicious > about it, though. The comment at the file's beginning explains this code's > motivation. > >

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-09 Thread Thomas Stuefe
On Wed, 9 Aug 2023 06:53:49 GMT, David Holmes wrote: >> I wrote this code ages ago. I'm not sure what's weird or suspicious about >> it, though. The comment at the file's beginning explains this code's >> motivation. >> >> The buffer was never thought to be used for something different than HA

Re: RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

2023-08-09 Thread Patrick Chen
Relax take it ezzzsy Le mer. 9 août 2023, 08:57, David Holmes a écrit : > On Tue, 8 Aug 2023 19:52:08 GMT, Thomas Stuefe wrote: > > >> I just checked and the value of the sentinel is ultimately the prvalue > 88. I don't know if we'd want to replace all the weird char usages here > with expl