On Tue, 25 Jul 2023 11:59:20 GMT, Abhishek Kumar wrote:
>> The issue exist only for non-editable combobox and the root cause is
>> accessible object is not created due to incorrect index returned from
>> component class which results in no a11y API invoked.
>>
>> Proposed solution is to return
This patch addresses two issues:
* For Windows: The snprintf is available with Visual Studio 2015 and above, so
we do not need to use the windows speciific "_snprintf". We also do not need to
set a zero at the end of the string since the "new" snprintf works according
c99: see this
[link](http
On Mon, 21 Aug 2023 10:42:07 GMT, Abhishek Kumar wrote:
>> Disabled JPasswordField foreground color was not grayed out in GTK LAF.
>>
>> The foreground color in disabled state was close to black color (RGB 0,0,0)
>> for password field which is not differentiable from enabled state foreground
>
> In awt_MenuItem.cpp (712,22): ` mii.dwTypeData = (LPTSTR)(*sb)` produces
> invalid pointer cast warning when complied on clang and moreover this is a
> no-op.
>
> `mii.dwTypeData` is used only when **MIIM_STRING** flag is set in the fMask
> (as per
> [Docs](https://learn.microsoft.com/en-
On Thu, 31 Aug 2023 22:40:27 GMT, Phil Race wrote:
> > > I'll have to check this further
> >
> >
> > It will get it via javaaccessbridge we provided(kind of native interface)
> > and this native lib uses our a11y java code for each component.
>
> Hmm, I didn't know the AWT heavyweights partic
On Fri, 25 Aug 2023 19:18:45 GMT, Harshitha Onkar wrote:
>> In awt_MenuItem.cpp (712,22): ` mii.dwTypeData = (LPTSTR)(*sb)` produces
>> invalid pointer cast warning when complied on clang and moreover this is a
>> no-op.
>>
>> `mii.dwTypeData` is used only when **MIIM_STRING** flag is set i
On Thu, 31 Aug 2023 00:49:01 GMT, Sergey Bylokhov wrote:
> > I'll have to check this further
>
> It will get it via javaaccessbridge we provided(kind of native interface) and
> this native lib uses our a11y java code for each component.
Hmm, I didn't know the AWT heavyweights participated in t
On Wed, 30 Aug 2023 18:42:20 GMT, Phil Race wrote:
>> Please double-check how the external tools like jaws/narrator will work
>> after this change, will they be able to read the correct content of the menu
>> item?
>
>> @mrserb
>>
>> > Please double-check how the external tools like jaws/narra
On Thu, 31 Aug 2023 15:59:35 GMT, Tejesh R wrote:
>> Yes, a helper method which deletes a directory that you pass as a parameter
>> and prints an error if it fails.
>>
>> Then removing the two directories is a matter of calling this method twice:
>> for the English and French directory.
>>
>>
> Found many typos in java.desktop by IDEA's inspection `Proofreading | Typo`
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8312165: Fix typos in java.desktop Swing
apply suggestions from review
-
Changes:
-
On Thu, 31 Aug 2023 18:57:17 GMT, Harshitha Onkar wrote:
>>> @aivanov-jdk I tried it on my High DPI Windows monitor but with scale set
>>> to 100% and that threw the skipped exception. I know by default we always
>>> have some scale setting on Windows for High DPI Monitors, but do we expect
>>
On Thu, 31 Aug 2023 14:03:28 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 57:
>>
>>> 55: public static final String INSTRUCTIONS = "INSTRUCTIONS:\n\n"
>>> 56: + "Verify that high resolution system icons are used for
>>> JCheckBoxMenuIt
On Thu, 31 Aug 2023 16:07:03 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 47:
>>
>>> 45: ByteArrayOutputStream baos = new
>>> ByteArrayOutputStream();
>>> 46: ObjectOutputStream oos = new ObjectOutputStream(
On Thu, 31 Aug 2023 15:54:41 GMT, lawrence.andrews wrote:
>> After the first time a JTableHeader is serialized, it no longer will
>> uninstall its UI upon subsequent serializations.
>> This happens for classes that use the BasicTableHeaderUI class. Any LAF that
>> extends the BasicTableHeaderUI
On Thu, 31 Aug 2023 15:41:15 GMT, Alexey Ivanov wrote:
>> Helper method meaning what I have done right?
>
> Yes, a helper method which deletes a directory that you pass as a parameter
> and prints an error if it fails.
>
> Then removing the two directories is a matter of calling this method twi
On Thu, 31 Aug 2023 08:02:35 GMT, Prasanta Sadhukhan
wrote:
> After the first time a JTableHeader is serialized, it no longer will
> uninstall its UI upon subsequent serializations.
> This happens for classes that use the BasicTableHeaderUI class. Any LAF that
> extends the BasicTableHeaderUI
On Thu, 31 Aug 2023 15:30:01 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JFileChooser/FileChooserNewFolderLocaleTest.java line
>> 77:
>>
>>> 75: System.out.println("Failed to delete file : " +
>>> 76: newFolderEnglish.getName());
>>> 77: }
>>
On Thu, 31 Aug 2023 14:10:39 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> test/jdk/javax/swing/JFileChooser/FileChooserNewFolderLocaleTest.java line 77:
>
>> 75: Sy
On Thu, 31 Aug 2023 14:03:28 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java line 57:
>>
>>> 55: public static final String INSTRUCTIONS = "INSTRUCTIONS:\n\n"
>>> 56: + "Verify that high resolution system icons are used for
>>> JCheckBoxMenuIt
> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`.
> Converting the `String `to `locale` before adding as command key fix the
> issue.
> I have verified the test in all other platforms and Look and Feel which has
> option to create New Folder, results were fine. No regre
On Thu, 31 Aug 2023 07:17:35 GMT, Tejesh R wrote:
>> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`.
>> Converting the `String `to `locale` before adding as command key fix the
>> issue.
>> I have verified the test in all other platforms and Look and Feel which has
>>
On Thu, 31 Aug 2023 10:42:47 GMT, Abhishek Kumar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> test/jdk/javax/swing/JFileChooser/FileChooserNewFolderLocaleTest.java line 66:
>
>> 64:
>> 65:
On Wed, 30 Aug 2023 20:36:45 GMT, Alexey Ivanov wrote:
>> Rajat Mahajan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update bug8031573.java
>>
>> remove macosx from summary .
>
> test/jdk/javax/swing/JMenuItem/8031573/bug8031573.
Thank you for the answer and for your work Aleksei, I really appreciate
it!
Can you share the bug report with the list to let us follow the bug
progress please?
Davide
Il 2023-08-30 20:19 Aleksei Ivanov ha scritto:
Hi Davide,
On 30/08/2023 15:42, Davide Perini wrote:
Ok,
thanks for t
On Fri, 25 Aug 2023 19:18:45 GMT, Harshitha Onkar wrote:
>> In awt_MenuItem.cpp (712,22): ` mii.dwTypeData = (LPTSTR)(*sb)` produces
>> invalid pointer cast warning when complied on clang and moreover this is a
>> no-op.
>>
>> `mii.dwTypeData` is used only when **MIIM_STRING** flag is set i
On Fri, 25 Aug 2023 19:18:45 GMT, Harshitha Onkar wrote:
>> In awt_MenuItem.cpp (712,22): ` mii.dwTypeData = (LPTSTR)(*sb)` produces
>> invalid pointer cast warning when complied on clang and moreover this is a
>> no-op.
>>
>> `mii.dwTypeData` is used only when **MIIM_STRING** flag is set i
On Thu, 31 Aug 2023 00:49:01 GMT, Sergey Bylokhov wrote:
>>> Hmm, so where does JAWS get that info if we no longer set it ? It isn't
>>> scraping pixels and doing OCR.
>>
>> I'll have to check this further.
>
>>I'll have to check this further
>
> It will get it via javaaccessbridge we provide
On Thu, 31 Aug 2023 07:17:35 GMT, Tejesh R wrote:
>> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`.
>> Converting the `String `to `locale` before adding as command key fix the
>> issue.
>> I have verified the test in all other platforms and Look and Feel which has
>>
On Thu, 31 Aug 2023 05:45:27 GMT, David Holmes wrote:
> > So you could create a single createJavaProcessBuilder with add an
> > additional parameter boolean addTestOpts e.g.
> > createJavaProcessBuilder(List command, boolean addTestOpts) { ... }
>
> @msheppar that is actually where we started,
After the first time a JTableHeader is serialized, it no longer will uninstall
its UI upon subsequent serializations.
This happens for classes that use the BasicTableHeaderUI class. Any LAF that
extends the BasicTableHeaderUI like SynthTableHeaderUI and WindowsTableHeaderUI
will get an NotSerial
On Wed, 30 Aug 2023 14:46:29 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Test update
>
> test/jdk/javax/swing/JFileChooser/NewFolderLocale/FileChooserNewFolderLocaleTest.java
> line 78:
>
>> 76
> On `NewFolderAction`, plain String is added `Action.ACTION_COMMAND_KEY`.
> Converting the `String `to `locale` before adding as command key fix the
> issue.
> I have verified the test in all other platforms and Look and Feel which has
> option to create New Folder, results were fine. No regre
32 matches
Mail list logo
