Re: RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17

2024-12-12 Thread SendaoYan
On Thu, 12 Dec 2024 04:32:14 GMT, SendaoYan wrote: > Hi all, > This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c > reported compile warning "ignoring return value of function" by clang17, > which add check the return value of `realpath` function. Risk is low. Compile w

Integrated: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04

2024-12-12 Thread Prasanta Sadhukhan
On Thu, 12 Dec 2024 02:39:07 GMT, Prasanta Sadhukhan wrote: > javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04 > seems to fail in OCI system citing "Test failed" > suggesting caret is not at expected place after text is typed, but I could > not find any CI jobs hav

Re: RFR: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04 [v2]

2024-12-12 Thread Tejesh R
On Fri, 13 Dec 2024 05:14:13 GMT, Prasanta Sadhukhan wrote: >> javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in >> ubuntu22.04 seems to fail in OCI system citing "Test failed" >> suggesting caret is not at expected place after text is typed, but I could >> not find any CI jobs

Re: RFR: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04 [v2]

2024-12-12 Thread Prasanta Sadhukhan
On Fri, 13 Dec 2024 05:02:57 GMT, Tejesh R wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> dispose > > test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.java line 95: > >> 93: jep = new JE

Re: RFR: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04 [v2]

2024-12-12 Thread Prasanta Sadhukhan
> javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04 > seems to fail in OCI system citing "Test failed" > suggesting caret is not at expected place after text is typed, but I could > not find any CI jobs having it failed. > Anyway simplified the test and added stability

Re: RFR: 8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4 [v5]

2024-12-12 Thread Alexander Zvegintsev
On Thu, 12 Dec 2024 13:29:55 GMT, GennadiyKrivoshein wrote: >> Fix for https://bugs.openjdk.org/browse/JDK-8343224, >> print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4. >> >> **Reason of the bug:** >> The reason for the regression bug is a missed check for the standard me

Re: RFR: 8346055: javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04

2024-12-12 Thread Tejesh R
On Thu, 12 Dec 2024 02:39:07 GMT, Prasanta Sadhukhan wrote: > javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04 > seems to fail in OCI system citing "Test failed" > suggesting caret is not at expected place after text is typed, but I could > not find any CI jobs hav

Re: RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17

2024-12-12 Thread SendaoYan
On Fri, 13 Dec 2024 03:38:15 GMT, SendaoYan wrote: >> Hi @prrace, >>> I saw this in another bug report too from the same submitter. >> >> I did create 3 clang17 compile waring issues, the compile warings occur in >> different files, and maybe use should different solutions to solve the >> issu

RFR: 8342096: Popup menus that request focus are not shown on Linux with Wayland

2024-12-12 Thread Alexander Zvegintsev
The previous [JDK-8319103](https://bugs.openjdk.org/browse/JDK-8319103) fix was not complete. The case where a menu item with a focusable component was not a direct child of a window was missing(failing the `if (window == oppositeWindow.getParent() ) {` check), so the ungrab event was posted pr

Re: RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17

2024-12-12 Thread SendaoYan
On Thu, 12 Dec 2024 19:57:13 GMT, Phil Race wrote: > Try running the jdk_desktop group instead. Thanks your advice. Mine meaning was verify this change will not cause new failures, since it will not change behaviour in theory. I will run jdk_desktop group now. - PR Comment: https

Re: RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17

2024-12-12 Thread SendaoYan
On Fri, 13 Dec 2024 03:34:32 GMT, SendaoYan wrote: >> I saw this in another bug report too from the same submitter. >> I don't know that I want to encourage this as a pattern, except in debug >> builds. better might be to just copy dlinfo.dli_fname into buf .. > > Hi @prrace, >> I saw this in an

Re: RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17

2024-12-12 Thread SendaoYan
On Thu, 12 Dec 2024 19:53:12 GMT, Phil Race wrote: >> src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c line 141: >> >>> 139: dladdr((void *)AWT_OnLoad, &dlinfo); >>> 140: if (realpath((char *)dlinfo.dli_fname, buf) == NULL) { >>> 141: perror((char *)dlinfo.dl

Re: RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17

2024-12-12 Thread SendaoYan
On Thu, 12 Dec 2024 19:53:12 GMT, Phil Race wrote: >> src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c line 141: >> >>> 139: dladdr((void *)AWT_OnLoad, &dlinfo); >>> 140: if (realpath((char *)dlinfo.dli_fname, buf) == NULL) { >>> 141: perror((char *)dlinfo.dl

Re: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v10]

2024-12-12 Thread Magnus Ihse Bursie
On Tue, 26 Nov 2024 15:11:58 GMT, Karm Michal Babacek wrote: >> If there is a problem with finding and calling e.g. >> `java/awt/GraphicsEnvironment` in `AWTIsHeadless`, the env' Exception >> remains set and it is not cleared. Later, that manifests as: >> >> Fatal error reported via JNI: C

Re: RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17

2024-12-12 Thread Phil Race
On Thu, 12 Dec 2024 04:32:14 GMT, SendaoYan wrote: > Hi all, > This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c > reported compile warning "ignoring return value of function" by clang17, > which add check the return value of `realpath` function. Risk is low. > > Addit

Re: RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17

2024-12-12 Thread Phil Race
On Thu, 12 Dec 2024 10:28:57 GMT, Magnus Ihse Bursie wrote: >> Hi all, >> This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c >> reported compile warning "ignoring return value of function" by clang17, >> which add check the return value of `realpath` function. Risk is lo

Re: RFR: 8344119: CUPSPrinter does not respect PostScript printer definition specification in case of reading ImageableArea values from PPD files

2024-12-12 Thread Prasanta Sadhukhan
On Thu, 14 Nov 2024 16:15:46 GMT, GennadiyKrivoshein wrote: > **Description:** > The PR updates sun.print.CUPSPrinter's behavior in terms of reading media > imageable area values according to the PostScript Printer Description File > Format Specification. > The actual implementation reads X and

Re: RFR: 8336382: Fixes error reporting in loading AWT and fonts [v10]

2024-12-12 Thread Karm Michal Babacek
On Tue, 26 Nov 2024 15:11:58 GMT, Karm Michal Babacek wrote: >> If there is a problem with finding and calling e.g. >> `java/awt/GraphicsEnvironment` in `AWTIsHeadless`, the env' Exception >> remains set and it is not cleared. Later, that manifests as: >> >> Fatal error reported via JNI: C

Re: RFR: 8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4 [v4]

2024-12-12 Thread GennadiyKrivoshein
On Thu, 12 Dec 2024 11:34:42 GMT, Alexander Zvegintsev wrote: >> GennadiyKrivoshein has updated the pull request incrementally with one >> additional commit since the last revision: >> >> expand imports > > test/jdk/java/awt/print/Dialog/PaperSizeError.java line 2: > >> 1: /* >> 2: * Copyr

Re: RFR: 8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4 [v5]

2024-12-12 Thread GennadiyKrivoshein
> Fix for https://bugs.openjdk.org/browse/JDK-8343224, > print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4. > > **Reason of the bug:** > The reason for the regression bug is a missed check for the standard media > existence during CustomMediaSizeName creation. > After the J

Re: RFR: 8344119: CUPSPrinter does not respect PostScript printer definition specification in case of reading ImageableArea values from PPD files

2024-12-12 Thread GennadiyKrivoshein
On Tue, 10 Dec 2024 10:05:18 GMT, Prasanta Sadhukhan wrote: >> **Description:** >> The PR updates sun.print.CUPSPrinter's behavior in terms of reading media >> imageable area values according to the PostScript Printer Description File >> Format Specification. >> The actual implementation reads

Re: RFR: 8343224: print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4 [v4]

2024-12-12 Thread Alexander Zvegintsev
On Wed, 4 Dec 2024 20:38:52 GMT, GennadiyKrivoshein wrote: >> Fix for https://bugs.openjdk.org/browse/JDK-8343224, >> print/Dialog/PaperSizeError.java fails with MediaSizeName is not A4: A4. >> >> **Reason of the bug:** >> The reason for the regression bug is a missed check for the standard med

Re: RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17

2024-12-12 Thread Magnus Ihse Bursie
On Thu, 12 Dec 2024 04:32:14 GMT, SendaoYan wrote: > Hi all, > This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c > reported compile warning "ignoring return value of function" by clang17, > which add check the return value of `realpath` function. Risk is low. > > Addit

Re: RFR: 8346059: [ASAN] awt_LoadLibrary.c reported compile warning ignoring return value of function by clang17

2024-12-12 Thread Magnus Ihse Bursie
On Thu, 12 Dec 2024 04:32:14 GMT, SendaoYan wrote: > Hi all, > This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c > reported compile warning "ignoring return value of function" by clang17, > which add check the return value of `realpath` function. Risk is low. > > Addit

Re: RFR: 8342869: Errors related to unused code on Windows after 8339120 in awt

2024-12-12 Thread Magnus Ihse Bursie
On Thu, 12 Dec 2024 05:39:04 GMT, Julian Waters wrote: >> You need to split this up into multiple parts. One part is about removing >> dead code. Do not comment it out, just remove it. Open a new JBS issue on >> client-libs for removal of dead code. This should be trivial to get pushed. >> >>