On Fri, 5 Sep 2025 06:12:35 GMT, Sarvesh Kumar Jain wrote:
>> that was for 21 not mainline..
>
> there are 2 links, first one is ML, 2nd is 21.
ok
-
PR Review Comment: https://git.openjdk.org/jdk/pull/27085#discussion_r2324205903
On Fri, 5 Sep 2025 05:31:31 GMT, Sarvesh Kumar Jain wrote:
>> The test is problem listed with incorrect bug JDK-6849371,
>> The bug JDK-6849371 is for a different test and it is closed.
>> A new bug has been raised for ChoiceMouseWheelTest.java test failure.
>
> Sarvesh Kumar Jain has updated the
On Fri, 5 Sep 2025 05:47:08 GMT, Prasanta Sadhukhan
wrote:
>> Sarvesh Kumar Jain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updated with new bugid
>
> test/jdk/ProblemList.txt line 263:
>
>> 261: java/awt/print/PrinterJob/PSQuesti
On Fri, 5 Sep 2025 05:31:31 GMT, Sarvesh Kumar Jain wrote:
>> The test is problem listed with incorrect bug JDK-6849371,
>> The bug JDK-6849371 is for a different test and it is closed.
>> A new bug has been raised for ChoiceMouseWheelTest.java test failure.
>
> Sarvesh Kumar Jain has updated the
> The test is problem listed with incorrect bug JDK-6849371,
> The bug JDK-6849371 is for a different test and it is closed.
> A new bug has been raised for ChoiceMouseWheelTest.java test failure.
Sarvesh Kumar Jain has updated the pull request incrementally with one
additional commit since the l
On Wed, 3 Sep 2025 04:37:21 GMT, Tejesh R wrote:
>> No it was not an error. This is content moved from another file. Files are
>> an artificial division. It is the same content.
>
> Ok, so when we create a new file and move the contents from old file as part
> of refactoring we retain the copyr
On Thu, 4 Sep 2025 17:42:20 GMT, GennadiyKrivoshein wrote:
>> The fix for the https://bugs.openjdk.org/browse/JDK-8251928.
>>
>> **Description**.
>> This PR contains changes to be able to print with DPI higher than 72 on
>> macOS, set default CPrinterJob DPI is 300 like in the PSPrinterJob.
>>
On Thu, 4 Sep 2025 17:39:19 GMT, GennadiyKrivoshein wrote:
> This is the expected behavior, the same as on other OS. I checked the
> GraphicsConfiguration on Windows 11, Ubuntu 22.04 and macOS 10.15 with DPI
> 300 and A4 format. The device boundaries on macOS are 1 pixel different. The
> conso
On Thu, 4 Sep 2025 18:24:02 GMT, Alexey Ivanov wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removes MULTI_FRAME_TEST instance variable and cleans up code
>
> test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanel
On Thu, 4 Sep 2025 18:26:21 GMT, Alexey Ivanov wrote:
>> Done.
>
> This is not done.
Sorry, I have missed this one. I have done it now. Thanks.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2323603804
It doesn't seem like a change that needs a project.
I would make sure that call to colorModel.getRGB(..) isn't needed and I
think that you aren't doing that.
Basically it needs to be sRGB already (as that is the target color space).
-phil.
On 9/4/25 1:37 PM, Daniel Gredler wrote:
Hi Jeremy, L
On Thu, 4 Sep 2025 14:12:50 GMT, Alexey Ivanov wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Organizes imports
>
> test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 28:
>
>> 26: im
On Thu, 4 Sep 2025 16:18:42 GMT, Khalid Boulanouare wrote:
>> Many Mixing tests failed because the work around click lands on the
>> minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid
On Thu, 4 Sep 2025 15:54:29 GMT, Khalid Boulanouare wrote:
>> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 76:
>>
>>> 74: return true;
>>> 75: }
>>> 76: public SimpleOverlappingTestBase() {
>>
>> Suggestion:
>>
>> }
>>
>> public SimpleOverlap
On Thu, 4 Sep 2025 08:32:23 GMT, Srinivas Mandalika
wrote:
>> The java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java test uses object
>> monitors and wait/notify to synchronise actions in the test.
>>
>> Using CountDownLatch could make the test simpler, shorter, clearer.
>> Tested the cod
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request incrementally with one
ad
The test is problem listed with incorrect bug JDK-6849371,
The bug JDK-6849371 is for a different test and it is closed.
A new bug has been raised for ChoiceMouseWheelTest.java test failure.
-
Commit messages:
- correct typographical error
- 8366750: Remove test
'java/awt/Choice/Ch
On Wed, 3 Sep 2025 22:26:55 GMT, Phil Race wrote:
>> GennadiyKrivoshein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove setDevClip usage. Update names. Handle page format orientation.
>
> src/java.desktop/macosx/classes/sun/lwawt/
> The fix for the https://bugs.openjdk.org/browse/JDK-8251928.
>
> **Description**.
> This PR contains changes to be able to print with DPI higher than 72 on
> macOS, set default CPrinterJob DPI is 300 like in the PSPrinterJob.
>
> As described in the macOS drawing guide, the following steps are
On Wed, 3 Sep 2025 09:22:17 GMT, Khalid Boulanouare wrote:
>> Many Mixing tests failed because the work around click lands on the
>> minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid
On Wed, 3 Sep 2025 05:23:02 GMT, Manukumar V S wrote:
>> Issue:
>> java/awt/Focus/ComponentLostFocusTest.java fails intermittently(2/40) with
>> an exception " Execution failed: `main' threw exception:
>> java.lang.RuntimeException: TextField got no focus! Test failed."
>> I have seen it failin
On Mon, 25 Aug 2025 10:13:04 GMT, Alexey Ivanov wrote:
>> @aivanov-jdk Is problem-listing this test the ideal solution?
>
> @DamonGuy If you believe there's a bug on macOS, I agree with your
> evaluation, then problem-listing is a good solution.
>
> For completeness, post a link to the bug that
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request incrementally with one
ad
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request incrementally with one
ad
On Tue, 26 Aug 2025 22:36:33 GMT, Damon Nguyen wrote:
> Do I have to differentiate between X11 and Wayland though?
Do you think it's important? Unless proven otherwise, I say this applies to
both modes.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/26636#discussion_r232121
On Thu, 28 Aug 2025 05:51:40 GMT, Damon Nguyen wrote:
>> When testing jtreg manual tests, some tests were out of date. This PR is an
>> attempt at updating the test and automating it.
>>
>> `MouseDraggedOriginatedByScrollBarTest.java` works as expected when compared
>> to native apps and outp
On Thu, 4 Sep 2025 08:32:23 GMT, Srinivas Mandalika
wrote:
>> The java/awt/Frame/MiscUndecorated/ActiveAWTWindowTest.java test uses object
>> monitors and wait/notify to synchronise actions in the test.
>>
>> Using CountDownLatch could make the test simpler, shorter, clearer.
>> Tested the cod
On Thu, 4 Sep 2025 14:22:01 GMT, Alexey Ivanov wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Organizes imports
>
> test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line
> 115:
>
>> 11
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request incrementally with one
ad
On Thu, 4 Sep 2025 14:38:59 GMT, Alexey Ivanov wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Organizes imports
>
> test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 36:
>
>> 34:
>
On Thu, 4 Sep 2025 10:49:40 GMT, Alexey Ivanov wrote:
>> Khalid Boulanouare has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 46
>> additional com
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request incrementally with three
On Thu, 4 Sep 2025 13:20:32 GMT, Khalid Boulanouare wrote:
>> Many Mixing tests failed because the work around click lands on the
>> minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid
On Thu, 4 Sep 2025 13:20:32 GMT, Khalid Boulanouare wrote:
>> Many Mixing tests failed because the work around click lands on the
>> minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid
On Thu, 4 Sep 2025 12:24:29 GMT, Khalid Boulanouare wrote:
>> The above approach may require additional refactoring, and I see that class
>> initialisers are used to set values of flags.
>
> I suggest the following changes :
>
>
> public GlassPaneOverlappingTestBase() {
> this(true);
On Thu, 4 Sep 2025 10:57:21 GMT, Alexey Ivanov wrote:
>> Khalid Boulanouare has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 46
>> additional com
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request incrementally with one
ad
On Thu, 4 Sep 2025 11:30:13 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line
>> 63:
>>
>>> 61: {
>>> 62: multiFramesTest = false;
>>> 63: }
>>
>> I prefer this is done in a constructor rather than a simple initialiser, it
On Thu, 4 Sep 2025 11:24:53 GMT, Khalid Boulanouare wrote:
>> Many Mixing tests failed because the work around click lands on the
>> minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid
> Many Mixing tests failed because the work around click lands on the
> minimizing area in the window control and causes the tests to fail.
>
> This fix changes the width of base frames which allows most of tests to pass.
Khalid Boulanouare has updated the pull request with a new target base due
40 matches
Mail list logo
