On Fri, 18 Oct 2024 19:31:27 GMT, Harshitha Onkar wrote:
>> Indeed, the test does not play nicely with timeout in `PassFailJFrame`.
>>
>> The workaround could be to pause the timeout. In addition to that, we could
>> set the timeout to 15 minutes. If the user changes time not -1 / +2 hours
>>
On Fri, 18 Oct 2024 18:09:19 GMT, Alexey Ivanov wrote:
> The workaround could be to pause the timeout. In addition to that, we could
> set the timeout to 15 minutes. If the user changes time not -1 / +2 hours but
> rather -5 / +10 minutes, it should be enough.
Either approach sounds good. Easi
On Tue, 15 Oct 2024 23:13:12 GMT, Harshitha Onkar wrote:
>> What an .. interesting .. test. No idea what this does to the jtreg test
>> harness too.
>> FWIW I think this test should be deleted rather than trying to make it nicer.
>
>> Actually, I think what is happening is that when the time is
On Tue, 15 Oct 2024 22:12:08 GMT, Phil Race wrote:
>> Actually, I think what is happening is that when the time is set forward an
>> hour (+2 hours forward from 1 hour behind as in instructions) the test will
>> automatically time out because it thinks an hour has passed. I thought
>> initiall
On Tue, 15 Oct 2024 22:08:19 GMT, Alisen Chung wrote:
>> test/jdk/javax/swing/JButton/TimeChangeButtonClickTest.java line 87:
>>
>>> 85: .instructions(INSTRUCTIONS)
>>> 86: .rows(20)
>>> 87: .columns(40)
>>
>> Suggestion:
>>
>>
On Mon, 14 Oct 2024 18:54:44 GMT, Harshitha Onkar wrote:
>> Alexey Ivanov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Rename instructions -> INSTRUCTIONS
>> - Add @library and @build jtreg tags
>
> test/jdk/javax/swing/JButton/Tim
On Mon, 14 Oct 2024 18:37:43 GMT, Alexey Ivanov wrote:
>> Refactor the test `javax/swing/JButton/TimeChangeButtonClickTest.java` to
>> use the `PassFailJFrame` framework to handle the tester's decision on
>> whether the test passes or fails.
>>
>> I reformatted the instructions for performing
> Refactor the test `javax/swing/JButton/TimeChangeButtonClickTest.java` to use
> the `PassFailJFrame` framework to handle the tester's decision on whether the
> test passes or fails.
>
> I reformatted the instructions for performing the test into HTML.
>
> I preserved the test UI panel which c
On Mon, 14 Oct 2024 17:27:25 GMT, Abhishek Kumar wrote:
>> Alexey Ivanov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Rename instructions -> INSTRUCTIONS
>> - Add @library and @build jtreg tags
>
> test/jdk/javax/swing/JButton/Time
On Fri, 11 Oct 2024 18:47:47 GMT, Alexey Ivanov wrote:
> Refactor the test `javax/swing/JButton/TimeChangeButtonClickTest.java` to use
> the `PassFailJFrame` framework to handle the tester's decision on whether the
> test passes or fails.
>
> I reformatted the instructions for performing the t
Refactor the test `javax/swing/JButton/TimeChangeButtonClickTest.java` to use
the `PassFailJFrame` framework to handle the tester's decision on whether the
test passes or fails.
I reformatted the instructions for performing the test into HTML.
I preserved the test UI panel which contains the bu
11 matches
Mail list logo
