Re: RFR: 8308780: Fix the Java Integer types on Windows

2023-05-31 Thread Julian Waters
On Wed, 24 May 2023 13:56:05 GMT, Julian Waters wrote: > On Windows, the basic Java Integer types are defined as long and __int64 > respectively. In particular, the former is rather problematic since it breaks > compilation as the Visual C++ becomes stricter and more compliant with every > rel

Re: RFR: 8308875: java/awt/Toolkit/GetScreenInsetsCustomGC/GetScreenInsetsCustomGC.java failed with 'Cannot invoke "sun.awt.X11GraphicsDevice.getInsets()" because "device" is null'

2023-05-31 Thread Maxim Kartashev
On Fri, 26 May 2023 08:19:09 GMT, Maxim Kartashev wrote: > 8308875 is a regression after the recent [fix for > 8305578](https://github.com/openjdk/jdk/commit/d7245f70) that effectively > undid a part of [another, older, > change](https://github.com/openjdk/jdk/commit/40f6d697d25293282e3d3ee69

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-31 Thread JoKern65
On Tue, 30 May 2023 21:44:17 GMT, JoKern65 wrote: >> src/hotspot/share/runtime/javaThread.cpp line 115: >> >>> 113: #include >>> 114: #endif >>> 115: >> >> Could these conditionals be included in globalDefinitions_xlc.hpp instead? > > In principle the `#include ` could be included in > globa

Re: RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v7]

2023-05-31 Thread Tejesh R
On Tue, 30 May 2023 09:10:03 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains eight additional commits >> s

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v10]

2023-05-31 Thread Alexey Ivanov
On Wed, 31 May 2023 03:09:12 GMT, Prasanta Sadhukhan wrote: > I already told using your suggested code fails the regression test.. Which regression test do you refer to? The one for `AttributeSet.equals` or another? I can't see how implementing `equals` could affect other tests… unless some

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v10]

2023-05-31 Thread Alexey Ivanov
On Tue, 30 May 2023 17:18:42 GMT, Prasanta Sadhukhan wrote: >> src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 2219: >> >>> 2217: public int hashCode() { >>> 2218: return Float.hashCode(value); >>> 2219: } >> >> why isn't index and lu part of this

Re: RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v8]

2023-05-31 Thread Alexey Ivanov
On Wed, 31 May 2023 06:13:22 GMT, Tejesh R wrote: >> This is a regression from fix >> [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of >> symlink is null in JFileChooser. The fix checks whether the file path is a >> symbolic link using `Files.isSymbolicLink()` metho

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v10]

2023-05-31 Thread Prasanta Sadhukhan
On Wed, 31 May 2023 08:53:56 GMT, Alexey Ivanov wrote: >> It is because only the float "value" is being considered and not the `lu` >> units px/pt > > Yet `equals` currently just compares `svalue`… It looks weird. It might looks weird but it is the one which is working. For example, for `{"font

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v10]

2023-05-31 Thread Alexey Ivanov
On Wed, 31 May 2023 09:23:38 GMT, Prasanta Sadhukhan wrote: >> Yet `equals` currently just compares `svalue`… It looks weird. > > It might looks weird but it is the one which is working. > For example, for `{"font-size: 42px", "font-size: 22px"}` > > `value` is 0.0 > `svalue` is 42px, 22px > `i

Re: RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v9]

2023-05-31 Thread Tejesh R
> This is a regression from fix > [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of > symlink is null in JFileChooser. The fix checks whether the file path is a > symbolic link using `Files.isSymbolicLink()` method with path as input. In > windows for specific folders

Re: RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v9]

2023-05-31 Thread Alexey Ivanov
On Wed, 31 May 2023 09:52:29 GMT, Tejesh R wrote: >> This is a regression from fix >> [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of >> symlink is null in JFileChooser. The fix checks whether the file path is a >> symbolic link using `Files.isSymbolicLink()` metho

Re: RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v10]

2023-05-31 Thread Tejesh R
> This is a regression from fix > [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of > symlink is null in JFileChooser. The fix checks whether the file path is a > symbolic link using `Files.isSymbolicLink()` method with path as input. In > windows for specific folders

Re: RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v10]

2023-05-31 Thread Alexey Ivanov
On Wed, 31 May 2023 10:01:16 GMT, Tejesh R wrote: >> This is a regression from fix >> [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of >> symlink is null in JFileChooser. The fix checks whether the file path is a >> symbolic link using `Files.isSymbolicLink()` metho

Re: RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v10]

2023-05-31 Thread Abhishek Kumar
On Wed, 31 May 2023 10:06:30 GMT, Tejesh R wrote: >> This is a regression from fix >> [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of >> symlink is null in JFileChooser. The fix checks whether the file path is a >> symbolic link using `Files.isSymbolicLink()` metho

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v12]

2023-05-31 Thread Prasanta Sadhukhan
> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() > method which can fail due to missing implementation of equals method in CSS > subclasses. > In this issue, even when two CSS AttributeSet has same 42 font size string > value, Object equality fails. > Fixed by implementi

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v10]

2023-05-31 Thread Prasanta Sadhukhan
On Wed, 31 May 2023 09:47:50 GMT, Alexey Ivanov wrote: >> It might looks weird but it is the one which is working. >> For example, for `{"font-size: 42px", "font-size: 22px"}` >> >> `value` is 0.0 >> `svalue` is 42px, 22px >> `index` false >> `lu.units` px >> so if I check >> >> >> return val

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-05-31 Thread Artem Semenov
> When using the clang compiler to build OpenJDk on Linux, we encounter various > "warnings as errors". > They can be fixed with small changes. Artem Semenov has updated the pull request incrementally with one additional commit since the last revision: update - Changes: - all:

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-05-31 Thread Artem Semenov
On Sun, 28 May 2023 03:57:40 GMT, Kim Barrett wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c line 1163: > >> 1161: #if defined(__clang__)

Re: RFR: 8308286 Fix clang warnings in linux code [v2]

2023-05-31 Thread Artem Semenov
On Tue, 30 May 2023 08:14:59 GMT, Alexey Ushakov wrote: >> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 655: > >> 653: // linker loaded it. We

Re: RFR: 8308286 Fix clang warnings in linux code [v3]

2023-05-31 Thread Weijun Wang
On Wed, 31 May 2023 13:37:06 GMT, Artem Semenov wrote: >> When using the clang compiler to build OpenJDk on Linux, we encounter >> various "warnings as errors". >> They can be fixed with small changes. > > Artem Semenov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Alexander Zvegintsev
> Modern Linux systems often come with > [Wayland](https://wayland.freedesktop.org/) by default. > This comes with some difficulties, and one of them is the inability to get > screenshots from the system. > This is because we now use the [X Window System > API](https://en.wikipedia.org/wiki/X_Wi

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v8]

2023-05-31 Thread Alexander Zvegintsev
On Tue, 30 May 2023 19:33:20 GMT, Phil Race wrote: >> Alexander Zvegintsev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix macos build > > src/java.desktop/unix/classes/sun/awt/screencast/ScreencastHelper.java line > 139: > >> 137:

Re: RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v10]

2023-05-31 Thread Damon Nguyen
On Wed, 31 May 2023 10:06:30 GMT, Tejesh R wrote: >> This is a regression from fix >> [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of >> symlink is null in JFileChooser. The fix checks whether the file path is a >> symbolic link using `Files.isSymbolicLink()` metho

Re: RFR: 8307105: JFileChooser InvalidPathException when selecting some system folders on Windows [v10]

2023-05-31 Thread Damon Nguyen
On Wed, 31 May 2023 10:06:30 GMT, Tejesh R wrote: >> This is a regression from fix >> [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of >> symlink is null in JFileChooser. The fix checks whether the file path is a >> symbolic link using `Files.isSymbolicLink()` metho

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Phil Race
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: JDK-8308288: Fix xlc17 clang warnings in shared code [v2]

2023-05-31 Thread Phil Race
On Fri, 26 May 2023 08:31:46 GMT, JoKern65 wrote: >> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk >> on AIX , we run into various "warnings as errors". >> Some of those are in shared codebase and could be addressed by small >> adjustments. >> A lot of those chang

Re: RFR: JDK-8305593: Add @spec tags in java.desktop [v2]

2023-05-31 Thread Jonathan Gibbons
> Please review a docs-only change to add `@spec` tags into `java.desktop` > public API files Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request c

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Andrey Turbanov
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: JDK-8294427 - Check boxes and radio buttons have rendering issues on Windows in High DPI env [v6]

2023-05-31 Thread Alexey Ivanov
On Tue, 30 May 2023 16:04:55 GMT, Alexey Ivanov wrote: >> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 131: >> >>> 129: } >>> 130: dpiAwareWidgetToTheme.get(dpi).clear(); >>> 131: dpiAwareWidgetToTh

RFR: 8308152: PropertyDescriptor should work with overridden generic getter method

2023-05-31 Thread Sergey Bylokhov
Description of the bug, copied from https://github.com/openjdk/jdk/pull/7190 > In jdk 9 we started to sort the list of methods for each class for two > reasons: > 1. We had a number of bugs which state that our JavaBeans randomly does not > work, examples: JDK-6807471[1] , JDK-6788525[2], the

Re: RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v9]

2023-05-31 Thread Phil Race
On Wed, 31 May 2023 15:03:04 GMT, Alexander Zvegintsev wrote: >> Modern Linux systems often come with >> [Wayland](https://wayland.freedesktop.org/) by default. >> This comes with some difficulties, and one of them is the inability to get >> screenshots from the system. >> This is because we n

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v13]

2023-05-31 Thread Prasanta Sadhukhan
> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() > method which can fail due to missing implementation of equals method in CSS > subclasses. > In this issue, even when two CSS AttributeSet has same 42 font size string > value, Object equality fails. > Fixed by implementi

Re: RFR: 7083187: Class CSS.CssValue is missing implementations of equals() and hashCode() [v12]

2023-05-31 Thread Prasanta Sadhukhan
On Wed, 31 May 2023 12:55:45 GMT, Prasanta Sadhukhan wrote: >> Two CSS AttributeSet-s can be compared using the AttributeSet.isEqual() >> method which can fail due to missing implementation of equals method in CSS >> subclasses. >> In this issue, even when two CSS AttributeSet has same 42 font

RFR: 8006421: GraphicsConfiguration of a frame is changed when the frame is moved to another screen

2023-05-31 Thread Tejesh R
When a frame is dragged from one screen to another screen, the `GraphicsConfigurations` may vary depending on screen/monitor. However, transparency has to be maintained since it is expected as it is set. So the fix addresses in maintaining the translucency capability when frame is moved from on