On Thu, 3 Apr 2025 06:36:04 GMT, Nikita Gubarkov wrote:
>I just accepted any pixel-interleaved surface with 4-byte stride and assumed
>that I can blit it directly.
So you implemented logic similar to [this
one](https://github.com/openjdk/jdk/blob/bd74922157230c866802b4c5269da81e872525aa/src/j
On Thu, 3 Apr 2025 07:32:24 GMT, Sergey Bylokhov wrote:
>>> as of now, we simply don't have generic native loops that support pixel gaps
>>
>> That was kinda what I was actually implementing in Vulkan when I faced this
>> issue. I just accepted any pixel-interleaved surface with 4-byte stride a
> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make
> `Introspector.addMethod()` working properly when filtering methods out.
>
> Also, after PR discussion, added the approptiate test cases with
> corresponding fixes in MethodInfo.java and PropertyInfo.java.
>
> -
> `getMe
On Thu, 3 Apr 2025 20:25:37 GMT, Harshitha Onkar wrote:
>> open sourcing some Swing JTabbedPane tests
>
> test/jdk/javax/swing/JTabbedPane/bug4273320.java line 57:
>
>> 55:
>> 56: TabbedPaneUI ui = tabs.getUI();
>> 57: Rectangle origSize = ui.getTabBounds(tabs, 0);
>
>
On Tue, 1 Apr 2025 23:24:57 GMT, Phil Race wrote:
> open sourcing some Swing JTabbedPane tests
Marked as reviewed by honkar (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24370#pullrequestreview-2741217448
On Thu, 3 Apr 2025 20:51:03 GMT, Phil Race wrote:
>> test/jdk/javax/swing/JTabbedPane/bug4287268.java line 59:
>>
>>> 57: Point point = jtp.getLocationOnScreen();
>>> 58: int width = jtp.getWidth();
>>> 59: int height = jtp.getHeight();
>>
>> Might be good to
On Mon, 10 Mar 2025 20:37:57 GMT, Harshitha Onkar wrote:
>> Good news: it looks like it was possible to resolve the `0x` conflict on
>> the HarfBuzz side by adjusting the HarfBuzz internal representation of AAT
>> deleted glyphs. Amazingly quick turnaround from @behdad! I think we'll want
On Mon, 10 Mar 2025 20:37:57 GMT, Harshitha Onkar wrote:
>> Good news: it looks like it was possible to resolve the `0x` conflict on
>> the HarfBuzz side by adjusting the HarfBuzz internal representation of AAT
>> deleted glyphs. Amazingly quick turnaround from @behdad! I think we'll want
On Fri, 28 Mar 2025 09:41:22 GMT, Daniel Gredler wrote:
> WTaskbarPeer contains a check as to whether the current Windows version is
> Windows 7 or later. The current minimum supported version is Windows 10, so
> this is no longer needed.
>
> There didn't seem to be a public test exercising th
On Wed, 2 Apr 2025 14:55:53 GMT, Abhishek Kumar wrote:
> Font related Applet tests are converted to manual and open sourced.
This pull request has now been integrated.
Changeset: db087268
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/db08726884d90f9139db5d30ee4d36d88
On Wed, 26 Mar 2025 01:49:31 GMT, Sergey Bylokhov wrote:
> Prevailing JDK coding practices use @throws rather than @exception.
> Refactored javadoc in client code to follow this convention, similar requests
> in the past https://github.com/openjdk/jdk/pull/7675 and
> https://github.com/openjdk/
On Thu, 3 Apr 2025 20:01:21 GMT, Phil Race wrote:
>The pattern below seems odd. What is the point of the protected modifier on a
>final class ?
This(and similar) logic was copied from
[Metal](https://github.com/openjdk/jdk/blob/57df89c46449a19bb626fee2ea01c868e6dfb712/src/java.desktop/share/cl
On Wed, 2 Apr 2025 19:32:32 GMT, Phil Race wrote:
>> test/jdk/javax/swing/text/BoxView/BaselineTest.java line 119:
>>
>>> 117: }
>>> 118:
>>> 119: class PaintLabel extends JLabel {
>>
>> Could you please move all the supporting classes `PaintLabel`,
>> `CustomComponentView`, `CustomEditorKit`
On Tue, 1 Apr 2025 12:02:49 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/javax/swing/Popup/TaskbarPositionTest.java line 81:
>>
>>> 79: private static JPopupMenu popupMenu;
>>> 80: private static JPanel panel;
>>> 81: private static Robot robot;
>>
>> Do you think it would be
On Wed, 2 Apr 2025 14:55:53 GMT, Abhishek Kumar wrote:
> Font related Applet tests are converted to manual and open sourced.
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24381#pullrequestreview-2739512832
On Wed, 2 Apr 2025 19:30:43 GMT, Phil Race wrote:
>> Swing text related tests being moved to open source.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8353320
Marked as reviewed by aivanov (Reviewer).
-
PR Re
It looks like this regression actually fits into a longer series of fixes /
regressions in this area:
- [JDK-4517298](https://bugs.openjdk.org/browse/JDK-4517298) fixed metrics for
zero-width characters, but broke some ligatures / glyph substitutions
- [JDK-7017058](https://bugs.openjdk.org/brow
On Thu, 3 Apr 2025 13:04:22 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Updated based on suggesion
>
> test/jdk/javax/swing/Popup/TaskbarPositionTest.java line 223:
>
>> 221:
On Thu, 3 Apr 2025 05:27:23 GMT, Sergey Bylokhov wrote:
>>> please add a test case for this scenario
>>
>> Sure, gonna look into it.
>>
>>> is it possible for pixelStride to be smaller than maxBandOff?
>>
>> Surprisingly, yes! Band offsets are arbitrary, even for
>> `PixelInterleavedSampleMod
On Wed, 2 Apr 2025 19:24:19 GMT, Phil Race wrote:
>> test/jdk/javax/swing/text/html/HTMLEditorKit/bug4245401.java line 61:
>>
>>> 59: kit.read(new StringReader(text), doc, 0);
>>> 60: } catch (Exception e) {
>>> 61: }
>>
>> If an exception occurs, the test should fai
On Tue, 1 Apr 2025 11:16:01 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added screen capture in case of test failure using Robot.
>>
>> Please review and let me know your suggestion if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one
On Fri, 28 Mar 2025 16:34:59 GMT, Mikhail Yankelevich
wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Updated copyright year
>
> test/jdk/javax/swing/Popup/TaskbarPositionTest.java line 78:
>
>> 76:
> Hi Reviewers,
>
> Added screen capture in case of test failure using Robot.
>
> Please review and let me know your suggestion if any.
Renjith Kannath Pariyangad has updated the pull request incrementally with one
additional commit since the last revision:
Updated based on suggesion
-
On Thu, 3 Apr 2025 14:34:08 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added screen capture in case of test failure using Robot.
>>
>> Please review and let me know your suggestion if any.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one
> Hi Reviewers,
>
> Added screen capture in case of test failure using Robot.
>
> Please review and let me know your suggestion if any.
Renjith Kannath Pariyangad has updated the pull request incrementally with one
additional commit since the last revision:
Updated screen capture function
25 matches
Mail list logo
