[ClojureScript] Re: [ANN] Clojure 1.7.0-RC1 now available

2015-05-26 Thread Julien
I just ported an app with significant CLJX usage (55 files) to reader conditionals and it works perfectly! It looks like there is a small issue related to map literal containing comments but I am not sure if it has been reported yet. Julien Le jeudi 21 mai 2015 13:31:16 UTC-3, Alex Miller a

[ClojureScript] Re: [ANN] Clojure 1.7.0-RC1 now available

2015-05-26 Thread Alex Miller
No, please report if so. On Tuesday, May 26, 2015 at 8:39:32 PM UTC-5, Julien wrote: I just ported an app with significant CLJX usage (55 files) to reader conditionals and it works perfectly! It looks like there is a small issue related to map literal containing comments but I am not sure

[ClojureScript] Re: [ANN] Clojure 1.7.0-RC1 now available

2015-05-26 Thread Alex Miller
In what way is it broken? Both before and after wrapped a mutable iterator into a caching seq. The new one is different in that it chunks so reads 32 at a time instead of 1. However combining either with other chunking sequence operations would have the same effect which is to say that using

[ClojureScript] Re: [ANN] Clojure 1.7.0-RC1 now available

2015-05-23 Thread Alan Moore
I've started porting a library to use Reader Conditionals - I haven't seen any issues with it yet but my troubles are more related to the library and re-organizing the code than to RC specifically. I'll report back when I'm done... Alan On Friday, May 22, 2015 at 2:09:28 PM UTC-7, Daniel

[ClojureScript] Re: [ANN] Clojure 1.7.0-RC1 now available

2015-05-22 Thread Jason Wolfe
We haven't shipped it to production yet, but I just verified that our full test suite at Prismatic passes on RC1 after fixing a few tests that were erroneously depending on hash ordering. Thanks everyone for all the hard work on this release! On Thursday, May 21, 2015 at 9:31:08 AM UTC-7,

[ClojureScript] Re: [ANN] Clojure 1.7.0-RC1 now available

2015-05-22 Thread Daniel Compton
One of the most significant features of 1.7 are Reader Conditionals. I'm pretty confident after all the discussion that has gone on that we have a good design. However I haven't seen many or any libraries which have gone through the porting process to use Reader Conditionals. I've worked on

[ClojureScript] Re: [ANN] Clojure 1.7.0-RC1 now available

2015-05-22 Thread Jason Wolfe
Just deployed to our staging environment and ran into an unexpected stack overflow error. Here's a reduced test case: user (- (range 1) (mapcat (fn [_] (java.util.ArrayList. (range 10 (reduce (constantly nil))) java.lang.StackOverflowError: RT.java:509 clojure.lang.RT.seq

[ClojureScript] Re: [ANN] Clojure 1.7.0-RC1 now available

2015-05-22 Thread Jason Wolfe
Thanks for the context. It looks like this is actually the same as CLJ-1237, the scope of the issue is just broader now with that commit. I left a comment there rather than creating a new ticket. On Friday, May 22, 2015 at 3:02:02 PM UTC-7, Ghadi Shayban wrote: This commit [1] for

[ClojureScript] Re: [ANN] Clojure 1.7.0-RC1 now available

2015-05-22 Thread Ghadi Shayban
This commit [1] for CLJ-1589 changed dispatch for InternalReduce, causing a bug similar to CLJ-1237 [2]. [1] https://github.com/clojure/clojure/commit/1242c4878f3d4ef30535a22f6c74144637504fbe [2] http://dev.clojure.org/jira/browse/CLJ-1237 On Friday, May 22, 2015 at 5:01:25 PM UTC-4, Jason