Review: Approve
Wow thanks for the epic docstring rewrite across all integration tests.
It really is a lot easier to read.
I think all of my comments on the previous branch have been addressed. thank
you.
Since the visual diff is so large it isn't fully rendered here.
Couple inline comments r
The proposal to merge ~powersj/cloud-init:integration-test-revamp into
cloud-init:master has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/323588
--
Your team cloud-init commiters is requested to
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:13b033a20eddb1a4b62e5e0eb73ecca8cfda0f6d
https://jenkins.ubuntu.com/server/job/cloud-init-ci/342/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/342/console
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Commit Message changed to:
make deb: Add devscripts dependency for make deb. Cleanup packages/bddeb.
Add a simple dependency check to "make deb" target for devscripts. Rework a bit
of the log
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/323076
--
Your team cloud-init commiters is requested to revi
The proposal to merge ~raharper/cloud-init:fix-net-convert into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/323083
--
Your team cloud-init commiters is requested to review
The proposal to merge ~raharper/cloud-init:fix-net-convert into
cloud-init:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/323083
--
Your team cloud-init commiters is requested to review the pr
Think I'm done with this branch. Thanks Josh for shepherding this all in.
This is good step in the right direction, and since it's in our test code
instead of core, I shouldn't try to be a stickler on some of these concerns as
we can iterate on this without direct impact to core code.
Diff comme
Thanks for the clarification josh. While it feels strange to build a deb on a
different target series --build-os, than test series per --os-name, I suppose
that use case for that could be in cases where we know we can't build on the
target --os-name due to missing deps or something. In those ca
Review: Approve continuous-integration
PASSED: Continuous integration, rev:c68778f468b6fad02b1fcd5612bc086d9e2080f0
https://jenkins.ubuntu.com/server/job/cloud-init-ci/340/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/340
SUCCESS:
htt
Review: Approve continuous-integration
PASSED: Continuous integration, rev:5aa86dc0c9e69256e136759ad5237b99cd0f3a07
https://jenkins.ubuntu.com/server/job/cloud-init-ci/339/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/339
SUCCESS:
htt
Scott Moser has proposed merging
~smoser/cloud-init:bug/1689944-improve-system-is-snappy into cloud-init:master.
Commit message:
Improve detection of snappy to include os-release and kernel cmdline.
Recent core snap images (edge channel revision 1886) do not contain the
previously known files us
The proposal to merge ~smoser/cloud-init:bug/1689944-improve-system-is-snappy
into cloud-init:master has been updated.
Commit Message changed to:
Improve detection of snappy to include os-release and kernel cmdline.
Recent core snap images (edge channel revision 1886) do not contain the
previou
@chad.smith: recall a tree_run will build your local tree. To do that it will
be default use a xenial container to build cloud-init, produce the deb, and
then use that deb on your artful test.
I'm sure if you look at the full output you will see a acquiring image for
artful and xenial.
--
htt
The proposal to merge ~jcastets/cloud-init:fix-net-cfg into cloud-init:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~jcastets/cloud-init/+git/cloud-init/+merge/324114
--
Your team cloud init development team is requested to review the
The proposal to merge ~jcastets/cloud-init:fix-net-cfg into cloud-init:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~jcastets/cloud-init/+git/cloud-init/+merge/324114
--
Your team cloud init development team is requested to revi
I pushed --force with your modifications
--
https://code.launchpad.net/~jcastets/cloud-init/+git/cloud-init/+merge/324114
Your team cloud init development team is requested to review the proposed merge
of ~jcastets/cloud-init:fix-net-cfg into cloud-init:master.
__
The proposal to merge ~jcastets/cloud-init:fix-net-cfg into cloud-init:master
has been updated.
Description changed to:
Add address to config entry generated by _klibc_to_config_entry
If /run/net-.cfg contains an IPV4ADDR or an IPV6ADDR, the config
file generated by _klibc_to_config_entry now c
My only comments here is with respect to dhcp.
If the configuration type was dhcp, then i think its more correct to not
include 'address', as most dhcp stanzas for network config are not going to
have an address so that is at very least confusing.
How about this diff :
http://paste.ubuntu.com/
Review: Approve continuous-integration
PASSED: Continuous integration, rev:881495e7930dacf5a7195e560ec66589e44b55df
https://jenkins.ubuntu.com/server/job/cloud-init-ci/338/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/338
SUCCESS:
htt
Julien Castets has proposed merging ~jcastets/cloud-init:fix-net-cfg into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~jcastets/cloud-init/+git/cloud-init/+merge/324114
Add address to config entry generat
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:4b0731fae934ad731c113a4b9629b3fd99fb6879
https://jenkins.ubuntu.com/server/job/cloud-init-ci/336/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/336/console
Dimitri John Ledkov has proposed merging
~xnox/cloud-init:nplan-ipv6-int-mask2cidr into cloud-init:master.
Commit message:
nplan: correctly generate ipv6 and ipv4 netmask addresses
It appears that the internal networking state parses netmask as
netmask for ipv4, yet as a cidr for ipv6, resulting
23 matches
Mail list logo
