I'm happy with the way it is here... we got rid of all 'import yaml' from
cloudinit.util at least.
and down to a signle place that 'yaml.load' is called.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/374679
Your team cloud-init Commiters is requested to review the
not a real advantage other than getting closer to getting all yaml
usage into a single place.
On Thu, Oct 24, 2019 at 12:56 PM Ryan Harper wrote:
>
> Is there an advantage to moving dumps into safeyaml? I didn't think dump had
> any concerns. Could we just have replaced the yaml.load() calls
just in better use of modules... putting yaml things into their own module
rather than having them all in util.
I'm willing to move load_yaml also if you'd like. which would mean util would
have no yaml code in it.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/374679
Scott Moser has proposed merging
~smoser/cloud-init:fix/1849640-adjust-yaml-usage into cloud-init:master.
Commit message:
Fix usages of yaml, and move yaml_dump to safeyaml.dumps.
Here we replace uses of the pyyaml module directly with functions
provided by cloudinit.safeyaml. Also, change
The proposal to merge ~d-info-e/cloud-init:fix-typos into cloud-init:master has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/374205
--
Your team cloud-init Commiters is requested to review the
The proposal to merge ~d-info-e/cloud-init:fix-typos into cloud-init:master has
been updated.
Commit message changed to:
Small typo fixes in code comments.
For more details, see:
https://code.launchpad.net/~d-info-e/cloud-init/+git/cloud-init/+merge/374205
--
Your team cloud-init Commiters is
thanks for the well done bug report and merge proposal!
Please add a test to the unfortunately long and difficult to follow
tests/unittests/test_net.py .
Also, as this is your first submission:
To contribute, you must sign the Canonical Contributor License Agreement
(CLA) [1].
If you have
doing an import in an exception handling path doesn't seem right.
other than that, good work.
Diff comments:
> diff --git a/cloudinit/util.py b/cloudinit/util.py
> index aa23b3f..49433dc 100644
> --- a/cloudinit/util.py
> +++ b/cloudinit/util.py
> @@ -1599,10 +1599,36 @@ def
The proposal to merge
~chad.smith/cloud-init:bug/180134-openstack-random-seed-encoding into
cloud-init:master has been updated.
Commit message changed to:
util: json.dumps on python 2.7 will handle UnicodeDecodeError on binary
Since python 2.7 doesn't handle UnicodeDecodeErrors with the
seems like filing an issue with astroid would be good thing to do.
but other than that, i guess approve.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/373177
Your team cloud-init Commiters is requested to review the proposed merge of
Did the bionic version of pylint fail?
Really just curious what changed.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/373177
Your team cloud-init Commiters is requested to review the proposed merge of
~raharper/cloud-init:fix/pylint-no-member into cloud-init:master.
I think that this will not really get you what you're after.
Having a list of the files that cloud-init created or appended to or truncated
isn't going to get you to your goal. The partial solution comes at the cost of
2 open and writes for every write. Additionally, we're already writing
For (a), I suggest maybe writing exactly one write for every write?
Why do you need a log of files' you've written? Should we have a separate log
for:
- files opened?
- files checked for existence?
- commands run?
- log files written?
What is motivating you to have this list of files that
Some thoughts:
a.) Why? Why do two writes for every write?
b.) currently atomic write_file is not covered.
Diff comments:
> diff --git a/cloudinit/util.py b/cloudinit/util.py
> index aa23b3f..950921c 100644
> --- a/cloudinit/util.py
> +++ b/cloudinit/util.py
> @@ -1841,6 +1843,55 @@ def
Scott Moser has proposed merging ~smoser/cloud-init:feature/e24cloud into
cloud-init:master.
Commit message:
Add Support for e24cloud to Ec2 datasource.
e24cloud provides an EC2 compatible datasource.
This just identifies their platform based on dmi 'system-vendor'
having 'e24cloud'. https
It can be argued that cloud-init *was* doing the right thing.
It was told that there were no dns servers and no dns 'search' (by lack of that
in network config).
dhcp muddies that argument for sure.
That said, based on the content in the description of the bug (the
previously-existing
I happened to see this false positive when reviewing the add of zstack under
Bug 1841181.
https://code.launchpad.net/~ruansx/cloud-init/+git/cloud-init/+merge/372445
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/372622
Your team cloud-init Commiters is requested to
Just for reference, bug 1661693 has some real collected output that shows:
$ ( cd /sys/class/dmi/id && sudo grep -r . . ) 2>/dev/null
./product_serial:srv-fajvm.gb1.brightbox.com
./bios_vendor:Seabios
./product_version:RHEL 6.6.0 PC
./power/runtime_active_kids:0
./power/runtime_suspended_time:0
Scott Moser has proposed merging ~smoser/cloud-init:fix/brightbox-less-matchy
into cloud-init:master.
Commit message:
Brightbox: restrict detection to require full domain match .brightbox.com
The detection for brightbox in both ds-identify and in
identify_brightbox would incorrectly match
Opened
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/372622
to address the brightbox issue.
--
https://code.launchpad.net/~ruansx/cloud-init/+git/cloud-init/+merge/372445
Your team cloud-init Commiters is requested to review the proposed merge of
Also, this request is still relevant.
* Add doc/rtd/topics/datasources/zstack.rst and update
doc/rtd/topics/datasources.rst to reference it. See Exoscale for a recently
added datasource example.
--
https://code.launchpad.net/~ruansx/cloud-init/+git/cloud-init/+merge/372445
Your team
Some comments inline. I also updated your commit message a bit.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 5c017bf..525121b 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@
The proposal to merge ~ruansx/cloud-init:add-zstack-datasource into
cloud-init:master has been updated.
Commit message changed to:
Add datastore for ZStack platfrom
Zstack platform provides a AWS Ec2 metadata service, and
identifies their platform to the guest by setting the 'chassis asset
In the interest of making "cloud-init debug is way to loud" even worse, Could
one log message be enough?
"Atomic writing to %s via temporary %s", filename, tf.name
If you see such a log and its not followed by a stack trace, then its good.
--
Your successful log path would not even include the final location for the
file, which is ultimately the useful thing (except in the write-failed case,
which is probably rare).
I think I'd prefer logging with a message that included the target file
(filename), not just the temporary file name.
Quick review things:
* make a better commit message (the 'Commit message` above will be be used
when this is ultimately squashed and merged)
* add 'LP: #1841181' to your commit message. See git log for examples. Thats
how MPs get associated with bugs.
* Tests needed.
*
Diff comments:
> diff --git a/doc/rtd/topics/docs.rst b/doc/rtd/topics/docs.rst
> new file mode 100644
> index 000..890f2f5
> --- /dev/null
> +++ b/doc/rtd/topics/docs.rst
> @@ -0,0 +1,83 @@
> +.. _docs:
> +
> +Docs
> +
> +
> +These docs are hosted on Read the Docs. The following will
Diff comments:
> diff --git a/doc/rtd/conf.py b/doc/rtd/conf.py
> index 4174477..9b27484 100644
> --- a/doc/rtd/conf.py
> +++ b/doc/rtd/conf.py
> @@ -17,7 +17,8 @@ from cloudinit.config.schema import get_schema_doc
> # ]
>
> # General information about the project.
> -project = 'Cloud-Init'
I don't personally feel the need to have 'make doc' at all, but its not a
problem to have it.
In the commit message subject line you have 'create markefile'
Diff comments:
> diff --git a/doc/rtd/conf.py b/doc/rtd/conf.py
> index 4174477..9b27484 100644
> --- a/doc/rtd/conf.py
> +++
Diff comments:
> diff --git a/debian/cloud-init.config b/debian/cloud-init.config
> index 6e9c6f7..adaabb8 100644
> --- a/debian/cloud-init.config
> +++ b/debian/cloud-init.config
> @@ -32,13 +32,13 @@ hasEc2Md() {
> get_yaml_list() {
> # get_yaml_list(file, key, def): return a comma
Diff comments:
> diff --git a/debian/cloud-init.config b/debian/cloud-init.config
> index 6e9c6f7..4c35e50 100644
> --- a/debian/cloud-init.config
> +++ b/debian/cloud-init.config
> @@ -32,13 +32,13 @@ hasEc2Md() {
> get_yaml_list() {
> # get_yaml_list(file, key, def): return a comma
fwiw, there is 'parse_yaml_array', in tools/ds-identify, which does better (at
least did not have this bug). Unfortunately that uses functions 'trim' and
'unquote', so you can't just grab the single function.
Second option would be to first *try* to use a proper yaml parser (python).
There
Diff comments:
> diff --git a/tests/unittests/test_net.py b/tests/unittests/test_net.py
> index de4e7f4..e2bbb84 100644
> --- a/tests/unittests/test_net.py
> +++ b/tests/unittests/test_net.py
> @@ -2856,6 +2856,97 @@ USERCTL=no
>
Scott Moser has proposed merging
~smoser/cloud-init:fix/1836949-mtu-lost-in-translation into cloud-init:master.
Commit message:
Fix bug rendering MTU on bond or vlan when input was netplan.
If input to network_state.parse_net_config_data was netplan (v2 yaml)
then the network state would lose
The error shows:
ERROR: pylint: could not install deps [pylint==2.3.1,
-r/var/lib/jenkins/slaves/torkoal/workspace/cloud-init-ci@2/test-requirements.txt];
v =
InvocationError('/var/lib/jenkins/slaves/torkoal/workspace/cloud-init-ci@2/.tox/pylint/bin/pip
install pylint==2.3.1
The proposal to merge ~smoser/cloud-init:fix/1788915-vlan-sysconfig-rendering
into cloud-init:master has been updated.
Description changed to:
For reference:
[1] documentes that no TYPE is present in the vlan examples.
[2] shows that random names are officially not supported.
[1]
Scott Moser has proposed merging ~smoser/cloud-init:fix/no-tox-yaml-warnings
into cloud-init:master.
Commit message:
git tests: no longer show warning about safe yaml.
Currently on 18.04, running tox -e py27 will spew errors like:
.tests/unittests/test_net.py:2649: YAMLLoadWarning: calling
Scott Moser has proposed merging
~smoser/cloud-init:fix/1788915-vlan-sysconfig-rendering into cloud-init:master.
Commit message:
network: Fix type and respect name when rendering vlan in sysconfig.
Prior to this change, vlans were rendered in sysconfig with
'TYPE=Ethernet', and incorrectly
Scott Moser has proposed merging
~smoser/cloud-init:cleanup/openssl-manager-no-cleanup into cloud-init:master.
Commit message:
Azure: Make the openssl manager object not need cleanup.
The 'clean_up' method on the OpenSSLManager object was annoying
as it had to be called or it would leave temp
A doc reference to the tools/ccfg-merge-debug might be useful (probably that
could use some improvements too)
Diff comments:
> diff --git a/doc/rtd/topics/merging.rst b/doc/rtd/topics/merging.rst
> index c75ca59..3761305 100644
> --- a/doc/rtd/topics/merging.rst
> +++
Hi,
This is kind of expected to work on rhel via the code added in
648dbbf6b090c81e989f1ab70bf99f4de16a6a70 .
That provides dhclient hooks in tools/hook-rhel.sh that should write
/run/cloud-init/dhclient.hooks/.json
that should be read from 'find_endpoint' use of _load_dhclient_json.
I
Scott Moser has proposed merging ~smoser/cloud-init:doc/cleanup-doc-errors into
cloud-init:master.
Commit message:
doc: clean up some datasource documentation.
The change to datasources.rst here is obvious typo fix.
The change to azure is to reduce the two 'Customization' sections
to a single
Scott Moser has proposed merging ~smoser/cloud-init:doc/add-new-datasource-doc
into cloud-init:master.
Commit message:
Add documentation on adding a datasource.
This adds documentation intended for a developer on how to add
a new datasource to cloud-init.
Requested reviews:
cloud-init
Scott Moser has proposed merging
~smoser/cloud-init:fix/ds-identify-vmware-detection into cloud-init:master.
Commit message:
ds-identify: fix wrong variable name in ovf_vmware_transport_guestinfo.
ovf_vmware_transport_guestinfo is not currently tested.
It used '$1' instead of '$out' when
Scott Moser has proposed merging
~smoser/cloud-init:cleanup/ovf-transport-signatures into cloud-init:master.
Commit message:
OVF: simplify expected return values of transport functions.
Transport functions (transport_iso9660 and transport_vmware_guestinfo)
would return a tuple of 3 values
Scott Moser has proposed merging
~smoser/cloud-init:feature/1807466-ovf-guestinfo-transport into
cloud-init:master.
Commit message:
Vmware: Add support for the com.vmware.guestInfo OVF transport.
This adds support for reading OVF information over the
'com.vmware.guestInfo' tranport
The proposal to merge
~smoser/cloud-init:feature/1807466-ovf-guestinfo-transport into
cloud-init:master has been updated.
Commit message changed to:
Vmware: Add support for the com.vmware.guestInfo OVF transport.
This adds support for reading OVF information over the
'com.vmware.guestInfo'
@Chad. the first commit is in.
So rebase on mater, and push for c-i.
can you give an example of the end result of this chagne?
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/356427
Your team cloud-init commiters is requested to review the proposed merge of
The proposal to merge ~smoser/cloud-init:fix/tip-pylint-20181210 into
cloud-init:master has been updated.
Commit message changed to:
Update to pylint 2.2.2.
The tip-pylint tox target correctly reported the invalid use of
string formatting. The change here is to:
a.) Fix the error that was
The proposal to merge ~smoser/cloud-init:fix/tip-pylint-20181210 into
cloud-init:master has been updated.
Commit message changed to:
Azure: Fix incorrect string format reported by pylint 2.2.2.
The tip-pylint tox target correctly reported the invalid use of
string formatting. The change here
Scott Moser has proposed merging ~smoser/cloud-init:fix/tip-pylint-20181210
into cloud-init:master.
Commit message:
Azure: Fix incorrect string format.
Fix incorrect order in a format string. If the old code would have
been hit, a stacktrace would have been raised.
Requested reviews:
cloud
The proposal to merge
~raharper/cloud-init:fix/ovf-imc-network-config-gateway-routes into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/359946
--
Your team cloud-init
Could you just add a unit test with exactly:
http://paste.ubuntu.com/p/5sGWRHB2d8/
I realize we mostly have it covered, but the genuine content is nice.
Other than that, I approve.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/359946
Your team cloud-init commiters
The proposal to merge
~raharper/cloud-init:fix/ovf-imc-network-config-gateway-routes into
cloud-init:master has been updated.
Commit message changed to:
ovf: Fix ovf network config generation gateway/routes
Move routes under the nic's subnet rather than use top-level
("global") route config
Scott Moser has proposed merging
~smoser/cloud-init:feature/1805854-add-non-x86-mirrors into cloud-init:master.
Commit message:
config: On ubuntu select cloud archive mirrors for armel, armhf, arm64.
Infrastructure is now set up for Ubuntu to handle Amazon instances
hitting a ports archive
Scott Moser has proposed merging ~smoser/cloud-init:fix/test-mock-order into
cloud-init:master.
Commit message:
tests: fix incorrect order of mocks in test_handle_zfs_root.
The order of parameters to test_handle_zfs_root did not match
the order of the mocks applied.
Thanks to Jason Zions
Scott Moser has proposed merging ~smoser/cloud-init:fix/ovf-id-env-vmware into
cloud-init:master.
Commit message:
OVF: identify label iso9660 filesystems with label 'OVF ENV'.
When deploying an OVA, at least some versions of vmware
attach a cdrom with an ISO9660 filesystem label of 'OVF ENV
The proposal to merge ~smoser/cloud-init:fix/ovf-id-env-vmware into
cloud-init:master has been updated.
Commit message changed to:
OVF: identify label iso9660 filesystems with label 'OVF ENV'.
When deploying an OVA, at least some versions of vmware
attach a cdrom with an ISO9660 filesystem
The proposal to merge ~adepue/cloud-init:master into cloud-init:master has been
updated.
Commit message changed to:
Azure: fix copy/paste error in error handling when reading azure ovf.
Check the appropriate variables based on code review. Correcting what seems to
be a copy/paste mistake for
The proposal to merge ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs
into cloud-init:master has been updated.
Commit message changed to:
logs: collect-logs ignore instance-data-sensitive.json on non-root user
Since /run/cloud-init/instance-data-sensitive.json is root read-only,
The proposal to merge ~chad.smith/cloud-init:bug/1805201-non-root-collect-logs
into cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/359557
--
Your team cloud-init commiters
one commit message fix. other than that, i approve.
Diff comments:
> diff --git a/cloudinit/cmd/devel/logs.py b/cloudinit/cmd/devel/logs.py
> index df72520..4c086b5 100644
> --- a/cloudinit/cmd/devel/logs.py
> +++ b/cloudinit/cmd/devel/logs.py
> @@ -118,21 +133,21 @@ def collect_logs(tarfile,
Generally agree with rharper that the code is duplicate.
lets just put it in a single function?
def should_retry_on_url_exc(exc):
if not isinstance(exc, UrlError):
return False
if exc.code == url_helper.NOT_FOUND
return True
if exc.cause and isinstance(exc.cause,
seems sane. one request.
Diff comments:
> diff --git a/cloudinit/cmd/query.py b/cloudinit/cmd/query.py
> index ff03de9..650bc0a 100644
> --- a/cloudinit/cmd/query.py
> +++ b/cloudinit/cmd/query.py
> @@ -106,8 +107,11 @@ def handle_args(name, args):
>
> try:
> instance_json =
The proposal to merge
~tomerc/cloud-init:patch-replace-nameserver-with-nameservers into
cloud-init:master has been updated.
Commit message changed to:
doc: Change dns_nameserver property to dns_nameservers.
According to the examples in the page, v1 network config DNS should
be defined using
Hi,
Thank you for contributing to cloud-init.
To contribute, you must sign the Canonical Contributor License Agreement (CLA)
[1].
If you have already signed it as an individual, your Launchpad user will be
listed in the contributor-agreement-canonical launchpad group [2].
Unfortunately there
Hi,
Thank you for contributing to cloud-init.
To contribute, you must sign the Canonical Contributor License Agreement (CLA)
[1].
If you have already signed it as an individual, your Launchpad user will be
listed in the contributor-agreement-canonical launchpad group [2].
Unfortunately there
@Jason,
Thank you for finding this.
You're probably right about the redhat also, and we would like that fixed.
Could you fix packages/redhat/cloud-init.spec.in also ?
Thanks again.
--
https://code.launchpad.net/~jasonzio/cloud-init/+git/cloud-init/+merge/357668
Your team cloud-init commiters
I pointed https://jenkins.ubuntu.com/server/job/cloud-init-ci/414/
at this MP.
If it succeeds, I'll grab.
Thanks, Tom!
--
https://code.launchpad.net/~tomerc/cloud-init/+git/cloud-init/+merge/357103
Your team cloud-init commiters is requested to review the proposed merge of
The proposal to merge ~tomerc/cloud-init:remove-colon into cloud-init:master
has been updated.
Commit message changed to:
docs: remove colon from network v1 config example.
The docs for network v1 config contained a errant ':'. Simply drop it.
For more details, see:
looks like you will have to fix a test. so please do that, and then i'll
approve.
--
https://code.launchpad.net/~mskalka/cloud-init/+git/cloud-init/+merge/357775
Your team cloud-init commiters is requested to review the proposed merge of
~mskalka/cloud-init:zfs-package-fix into
Pointed jenkins c-i at this
https://jenkins.ubuntu.com/server/job/cloud-init-ci/413/console
it should report shortly.
--
https://code.launchpad.net/~mskalka/cloud-init/+git/cloud-init/+merge/357775
Your team cloud-init commiters is requested to review the proposed merge of
The proposal to merge ~mskalka/cloud-init:zfs-package-fix into
cloud-init:master has been updated.
Commit message changed to:
Fix the ZFS package name in the LXD module to point to a real package.
On 16.04 and earlier, 'apt-get install zfs' would select the
zfsutils-linux package correctly.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index 39391d0..2a6d5b1 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -619,7 +622,14 @@ class
inline comments.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index 39391d0..11b4ba5 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -207,7 +207,9 @@ BUILTIN_DS_CONFIG = {
>
thoughts?
Diff comments:
> diff --git a/debian/changelog b/debian/changelog
> index 2bb9520..d83e08b 100644
> --- a/debian/changelog
> +++ b/debian/changelog
> @@ -1,3 +1,10 @@
> +cloud-init (18.4-0ubuntu1~18.04.2) bionic-proposed; urgency=medium
can you change that to be 'bionic' not
Scott Moser has proposed merging
~smoser/cloud-init:fix/1798117-allow-toplevel-network-in-network-config into
cloud-init:master.
Commit message:
NoCloud: Allow top level 'network' key in network-config.
NoCloud's 'network-config' file was originally expected to contain
network configuration
The proposal to merge ~smoser/cloud-init:fix/fix-dhclient-hook-down into
cloud-init:master has been updated.
Commit message changed to:
dhclient-hook: cleanups, tests and fix a bug on 'down' event.
I noticed a bug in dhclient_hook on the 'down' event, using 'is'
operator rather than '==' (if
The proposal to merge ~chad.smith/cloud-init:cleanup/metadata-cloud-platform
into cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/355999
--
Your team cloud-init commiters is
How about this:
http://paste.ubuntu.com/p/bbkSPcv7TP/
the primary difference being that setup.py "knows" that the systemd files
should be executable.
versus that being stored in filesystem.
--
https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/356098
Your team cloud-init
if manual_cache_clean is set, then we should be careful not to re-crawl
anything on upgrade. This is most likely a case when there was a "config disk"
in the generic sense. Ie, where a datasource provided a disk (cdrom or block
device) and then later pulled it or user formatted it.
Diff
The proposal to merge ~rjschwei/cloud-init:systemdGenTmpl into
cloud-init:master has been updated.
Commit message changed to:
systemd: Render generator from template to account for system differences.
The systemd generator used had a hard coded path for the location target
file to create.
The proposal to merge ~chad.smith/cloud-init:cleanup/metadata-cloud-platform
into cloud-init:master has been updated.
Commit message changed to:
instance-data: Add standardized keys platform and subplatform. Refactor ec2.
Add the following instance-data.json standardized keys:
* v1._beta_keys:
Scott Moser has proposed merging
~smoser/cloud-init:fix/1796917-ignore-all-zero-macs into cloud-init:master.
Commit message:
net: ignore nics that have "zero" mac address.
Previously we explicitly excluded mac address '00:00:00:00:00:00'.
But then some nics (tunl0 and sit0) ended
document beta_keys somwhere ?
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAliYun.py
> b/cloudinit/sources/DataSourceAliYun.py
> index 858e082..16abd09 100644
> --- a/cloudinit/sources/DataSourceAliYun.py
> +++ b/cloudinit/sources/DataSourceAliYun.py
> @@ -18,25 +18,17 @@ class
Diff comments:
> diff --git a/cloudinit/event.py b/cloudinit/event.py
> index f7b311f..77ce631 100644
> --- a/cloudinit/event.py
> +++ b/cloudinit/event.py
> @@ -2,16 +2,68 @@
>
> """Classes and functions related to event handling."""
>
> +from cloudinit import log as logging
> +from
i'm not all the way through, but here are some comments.
Diff comments:
> diff --git a/cloudinit/cmd/devel/hotplug_hook.py
> b/cloudinit/cmd/devel/hotplug_hook.py
> new file mode 100644
> index 000..c24b1ff
> --- /dev/null
> +++ b/cloudinit/cmd/devel/hotplug_hook.py
> @@ -0,0 +1,195 @@
>
Scott Moser has proposed merging
~raharper/cloud-init:feature/cloud-init-hotplug-handler into cloud-init:master.
Commit message:
wip fixme
Requested reviews:
cloud-init commiters (cloud-init-dev): review-wip
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud
The proposal to merge ~raharper/cloud-init:feature/cloud-init-hotplug-handler
into cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/356152
--
Your team cloud-init
The proposal to merge ~smoser/cloud-init:fix/cent-6-jinja2 into
cloud-init:master has been updated.
Commit message changed to:
Centos 6: Fix jinja rendering on older jinja versions.
jinja2.runtime.implements_to_string is not available in older versions
of jinja2. This just catches that error
we have unit tests that test rendering of jinja2, but because jinja2 is not
required dep, it will skip the tests if it is not available.
the code here is what determined "do we have jinja2". And the tests skip if
not JINJA_AVAILABLE
--
Scott Moser has proposed merging ~smoser/cloud-init:fix/cent-6-jinja2 into
cloud-init:master.
Commit message:
Centos 6: Fix jinja rendering on older jinja versions.
jinja2.runtime.implements_to_string is not available in older versions
of jinja2. This just catches that error separately from
Scott Moser has proposed merging ~smoser/cloud-init:release/18.4 into
cloud-init:master.
Commit message:
release 18.4
Bump the version in cloudinit/version.py to be 18.4 and update ChangeLog.
LP: #1795741
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1795741
Scott Moser has proposed merging
~smoser/cloud-init:bug/74747-no-deb-src-in-sources-list into cloud-init:master.
Commit message:
Ubuntu: update sources.list to comment out deb-src entries.
Other installation modes began to comment out the deb-src lines in
/etc/apt/sources.list sometime in 16.04
The proposal to merge ~smoser/cloud-init:feature/skip-better into
cloud-init:master has been updated.
Commit message changed to:
tests: allow skipping an entire cloud_test without running.
Individual skipTest or setUp SkipTest will still launch the instance.
This allows us to stop the running
Scott Moser has proposed merging ~smoser/cloud-init:feature/skip-better into
cloud-init:master.
Commit message:
tests: allow skipping an entire cloud_test without running.
Individual skipTest or setUp SkipTest will still launch the instance.
This allows us to stop the running of the instance so
Scott Moser has proposed merging
~smoser/cloud-init:fix/disable-lxd-cosmic-tests-1795036 into cloud-init:master.
Commit message:
tests: disable lxd tests on cosmic
Skip lxd tests on cosmic for two reasons:
a.) LP: #1795036 - 'lxd init' fails on cosmic kernel.
b.) apt install lxd installs via
assuming it passes c-i and the failing test passes then looksk good to me.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/355803
Your team cloud-init commiters is requested to review the proposed merge of
Hi,
Thank you for contributing to cloud-init.
To contribute, you must sign the Canonical Contributor License Agreement (CLA)
[1].
If you have already signed it as an individual, your Launchpad user will be
listed in the contributor-agreement-canonical launchpad group [2].
Unfortunately there is
Scott Moser has proposed merging ~smoser/cloud-init:fix/lxd-may-come-in-snap
into cloud-init:master.
Commit message:
lxd: adjust to snap installed lxd.
Relax expectation on path to lxc and lxd. The deb path still does
install them in /usr/bin/ but that is overlay pedantic.
Add a 'lxd
1 - 100 of 1302 matches
Mail list logo
