Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:68b67d18b10ea5fdf8e51d7946b0bf17e6edbf48 https://jenkins.ubuntu.com/server/job/cloud-init-ci/130/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/130 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:c1942769e99f2de99970800e6d86b326620f60c2 https://jenkins.ubuntu.com/server/job/cloud-init-ci/127/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/127 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-17 Thread Joshua Powers
I added class/subclass method you proposed, which I like a lot. There is no reason for duplicate code. My only concern is base.py filling up with a bunch of code, but I think that is ok. However, I had to modify the parameters slightly so nose actually realizes there are tests to run and added

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-17 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:c95f4552408d63519cd72ab0344e12099f57a015 https://jenkins.ubuntu.com/server/job/cloud-init-ci/126/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/126 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-17 Thread Scott Moser
Josh, this looks great. Thank you. The only thing I don't like now is the duplication. There are 2 ways i can think of to reduce it: a.) both tests extend a base class that has the test_* functions. this is just less flexible than 'b', but because these things are identical now, its the easi

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-16 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:cc3aaf5db84ee135409a2345570893dfbcd71d37 https://jenkins.ubuntu.com/server/job/cloud-init-ci/124/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/124 SUCCESS: htt

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-16 Thread Server Team CI bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:41bf34e63ecf25c9960fd820542d8919517e3c16 https://jenkins.ubuntu.com/server/job/cloud-init-ci/123/ Executed test runs: FAILURE: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/123/console

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-16 Thread Joshua Powers
Pulled in smoser's changes from https://paste.ubuntu.com/24191229/ and applied them to both set_password_list and set_password_list_string -- https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319878 Your team cloud init development team is requested to review the proposed merg

Re: [Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-14 Thread Server Team CI bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:2ded8b9e37bb65786655cee48fca3ff48ae1c585 https://jenkins.ubuntu.com/server/job/cloud-init-ci/115/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/115 SUCCESS: htt

[Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-14 Thread Joshua Powers
Joshua Powers has proposed merging ~powersj/cloud-init:test-set-password-list into cloud-init:master. Commit message: test: Add test for setting password as list This adds an integration test for setting passwords when given as a list, rather than a string. This also updates the docs and tests s

[Cloud-init-dev] [Merge] ~powersj/cloud-init:test-set-password-list into cloud-init:master

2017-03-14 Thread Joshua Powers
The proposal to merge ~powersj/cloud-init:test-set-password-list into cloud-init:master has been updated. Status: Work in progress => Superseded For more details, see: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/319877 -- Your team cloud init development team is re