The proposal to merge ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master has been updated.
Commit Message changed to:
cc_ntp: Restructure cc_ntp unit tests add with_logs class attr to unit tests.
Any CiTestCase subclass can now set a class attribute with_logs = True and
tests can
Chad Smith has proposed merging ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/324450
cc_ntp: Restructure cc_ntp unit tests
Review: Approve continuous-integration
PASSED: Continuous integration, rev:201e100de762c6ce47e0639eaf12449f29253344
https://jenkins.ubuntu.com/server/job/cloud-init-ci/373/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/373
SUCCESS:
We could have a version-based check, however the version that breaks this,
2.26, is in proposed and about to migrate to all supported releases at any day.
I certainly expect this to be fixed unless someone tells me that what we are
doing (e.g. running snapd in a container) isn't allowed.
My
Joshua Powers has proposed merging ~powersj/cloud-init:fix-integration-ntp into
cloud-init:master.
Commit message:
tests: Fix ntp integration test regression
LP: #1692686
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
On Mon, 22 May 2017, Ryan Harper wrote:
> Generally looks fine, one question w.r.t confirming explict_dslist check
>
> Diff comments:
>
> > diff --git a/cloudinit/sources/DataSourceEc2.py
> > b/cloudinit/sources/DataSourceEc2.py
> > index 2f9c7ed..818a639 100644
> > ---
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
There only seems to be one unit test which covers this module
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -266,6 +267,12 @@ def parse_strict_mode(cfgval):
> return
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -266,6 +267,12 @@ def parse_strict_mode(cfgval):
> return
Generally looks fine, one question w.r.t confirming explict_dslist check
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
Review: Approve
I think we agreed in standup that since you've fixed this with a workaround for
pylint's bug, you could probably add a structured comment or something that
mark that we should look at pylint tip in the future to see if that issue is
fixed. For bugs on external dependencies
Review: Approve continuous-integration
PASSED: Continuous integration, rev:9c33cb24b8a834aa8034db4c989725901a0814c6
https://jenkins.ubuntu.com/server/job/cloud-init-ci/372/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/372
SUCCESS:
The proposal to merge
~smoser/cloud-init:pylint/1444-pylint-tip-ignore-e1101-from-contextlib into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324401
--
Your team cloud-init
Review: Approve continuous-integration
PASSED: Continuous integration, rev:b01ae9627652e9ef03c68049dcee345755b5e806
https://jenkins.ubuntu.com/server/job/cloud-init-ci/370/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/370
SUCCESS:
Review: Approve continuous-integration
PASSED: Continuous integration, rev:d6518ba988e24f939687d83d5946bb9a3ce2751a
https://jenkins.ubuntu.com/server/job/cloud-init-ci/367/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/nodes=metal-amd64/367
SUCCESS:
Scott Moser has proposed merging
~smoser/cloud-init:pylint/1444-pylint-tip-ignore-e1101-from-contextlib into
cloud-init:master.
Commit message:
pylint: make tox -e pylint-tip pass by ignoring a misreported error.
This just silences a warning in pylint. The issue is reported upstream
at
The proposal to merge
~smoser/cloud-init:pylint/1444-pylint-tip-ignore-e1101-from-contextlib into
cloud-init:master has been updated.
Commit Message changed to:
pylint: make tox -e pylint-tip pass by ignoring a misreported error.
This just silences a warning in pylint. The issue is reported
17 matches
Mail list logo
