Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init

2015-04-20 Thread Scott Moser
My only real comment is that I thikn i'd take 'get_metadata' out of 'get_data'. You can either move it to a stand alone method or a class method. either way, moving it out allows to easier patch it for testing. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1403617/+merge/256812

Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init

2015-04-20 Thread Dan Watkins
I've tested this on a GCE instance, and it works as expected. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1403617/+merge/256812 Your team cloud init development team is requested to review the proposed merge of lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init.

[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init

2015-04-20 Thread Dan Watkins
Dan Watkins has proposed merging lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) Related bugs: Bug #1403617 in cloud-init: "gce datasource does not handle instance ssh keys" https://bugs.launchpad.net/cloud-init/