Not sure that's right (I Think it should be IPV6_GATEWAY0)
On Tue, Jul 18, 2017 at 4:09 PM, Scott Moser wrote:
> I pulled:
>
> Your-commit trunk-comt summary
> 8da074f831c d1e8eb73ac sysconfig: include GATEWAY value if set in subnet
>
> changes:
> i shorted lines in commit messages and made tox
I pulled:
Your-commit trunk-comt summary
8da074f831c d1e8eb73ac sysconfig: include GATEWAY value if set in subnet
changes:
i shorted lines in commit messages and made tox tests pass (had to add the
newly rendered GATEWAY values) to more than the one test you did it to.
$ git diff 8da074f831c..
Looks pretty solid. Just a few in-line comments/fixes
Diff comments:
> diff --git a/tests/cloud_tests/instances/kvm.py
> b/tests/cloud_tests/instances/kvm.py
> new file mode 100644
> index 000..c855e07
> --- /dev/null
> +++ b/tests/cloud_tests/instances/kvm.py
> @@ -0,0 +1,222 @@
> +# This
Review: Approve continuous-integration
PASSED: Continuous integration, rev:31be94b892c57d57d829b0e2c7de5bf333b53d1b
https://jenkins.ubuntu.com/server/job/cloud-init-ci/54/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu L
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:8625408dd166a837f11381c5aea683ba14898e89
https://jenkins.ubuntu.com/server/job/cloud-init-ci/53/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
FAILED: Ubun
Ryan Harper has proposed merging ~raharper/cloud-init:curtin-centos into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1687725 in cloud-init: "sysconfig render does not support type manual
subnets"
https://bugs.launchpad.net/cloud-init/+bug/
The proposal to merge ~raharper/cloud-init:curtin-centos into cloud-init:master
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648
--
Your team cloud-init commiters is requested to r
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:273226e027ba483c3ae26787a2975348ef6b07c5
https://jenkins.ubuntu.com/server/job/cloud-init-ci/52/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
FAILED: Ubun
The proposal to merge ~powersj/cloud-init:cii-kvm into cloud-init:master has
been updated.
Description changed to:
Would like an initial review, please!
Example command:
$ python3 -m tests.cloud_tests run --verbose --platform kvm --os-name xenial -t
modules/locale
Note, not all existing tests
Joshua Powers has proposed merging ~powersj/cloud-init:cii-kvm into
cloud-init:master.
Commit message:
test: Enable the KVM platform on integration tests
The KVM platform includes:
* Ubuntu images from daily stream
* Image setup via mount-image-callback
* Generation and injection
Diff comments:
> diff --git a/tests/unittests/test_datasource/test_ec2.py
> b/tests/unittests/test_datasource/test_ec2.py
> new file mode 100644
> index 000..d7362c1
> --- /dev/null
> +++ b/tests/unittests/test_datasource/test_ec2.py
> @@ -0,0 +1,202 @@
> +# This file is part of cloud-init.
Diff comments:
> diff --git a/tests/unittests/test_datasource/test_ec2.py
> b/tests/unittests/test_datasource/test_ec2.py
> new file mode 100644
> index 000..d7362c1
> --- /dev/null
> +++ b/tests/unittests/test_datasource/test_ec2.py
> @@ -0,0 +1,202 @@
> +# This file is part of cloud-init.
Review: Approve continuous-integration
PASSED: Continuous integration, rev:5837847479ff837e17546245cefaec4ee2097466
https://jenkins.ubuntu.com/server/job/cloud-init-ci/51/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu L
Review: Approve continuous-integration
PASSED: Continuous integration, rev:7181d66d3693919615a884f4e9f43aa14b422244
https://jenkins.ubuntu.com/server/job/cloud-init-ci/49/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu L
Review: Approve continuous-integration
PASSED: Continuous integration, rev:724ef696e776e6937b8e75a41da35607bede7a6a
https://jenkins.ubuntu.com/server/job/cloud-init-ci/50/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
SUCCESS: Ubuntu L
The proposal to merge ~smoser/cloud-init:bug/1683038-ec2-no-warn-on-explicit
into cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324274
--
Your team cloud-init commiters
The proposal to merge ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into
cloud-init:master has been updated.
Commit Message changed to:
tests: fixes for issues uncovered when moving to python3.6
This includes a few fixes found when testing with python 3.6.
- fix eni renderer when target is N
The proposal to merge ~smoser/cloud-init:feature/pregen-locale into
cloud-init:master has been updated.
Commit Message changed to:
locale: Do not re-run locale-gen if provided locale is system default.
If the system configure default in /etc/default/locale is set to the same
value that is provi
The proposal to merge ~smoser/cloud-init:bug/1703697-python3.6-ubuntu into
cloud-init:master has been updated.
Commit Message changed to:
tests: fixes for issues uncovered when moving to python3.6
This includes 2 different fixes both found when testing with python 3.6.
- fix eni renderer when
i cleaned up that register_helper a bit, thanks for the review, Ryan.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327534
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:cleanup/ec2-initial-tests into cloud-init:master.
_
20 matches
Mail list logo
