Chad Smith has proposed merging ~chad.smith/cloud-init:cyaml-loading into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/323088
Use CSafeLoader C-bindings
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index 46cb9c8..d38ea8b 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -233,15 +231,24 @@ def generate_fallback_config(blacklist_drivers=None,
> config_driver=None):
> if
Diff comments:
> diff --git a/cloudinit/net/dhcp.py b/cloudinit/net/dhcp.py
> new file mode 100644
> index 000..4d59bd0
> --- /dev/null
> +++ b/cloudinit/net/dhcp.py
> @@ -0,0 +1,118 @@
> +# Copyright (C) 2017 Canonical Ltd.
> +#
> +# Author: Chad Smit
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 4ec9592..ae0fe26 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -73,21 +77,25 @@ class DataSourceEc2(sources.DataSource):
>
The proposal to merge ~chad.smith/cloud-init:cc-landscape-py3-config-fix into
cloud-init:master has been updated.
Description changed to:
cc_landscape & cc_puppet: Fix six.StringIO use in writing configs
Both landscape and puppet modules had issues with the way they wrote
Chad Smith has proposed merging
~chad.smith/cloud-init:cc-landscape-py3-config-fix into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1699282 in cloud-init: "cloud-init process fails to configure puppet"
https://bugs.launchpad.net/
Approved with minor nits questions inline. +1!
Validated and inspected netplan output with the following:
PYTHONPATH=. ./tools/net-convert.py --network-data=net-config.yaml --kind=yaml
--output-kind=netplan --directory=out.d --mac=eth0,52:54:00:12:34:00
--mac=ens4,52:54:00:12:34:02
Prior to
Thanks for the submit Ryan, is there an existing bug that was filed against
cloud-init for this issue? It'd be great to have the bug as reference for
future concerned parties/clouds.
--
https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/328877
Your team cloud-init commiters
Diff comments:
> diff --git a/tests/unittests/test_datasource/test_ec2.py
> b/tests/unittests/test_datasource/test_ec2.py
> new file mode 100644
> index 000..d7362c1
> --- /dev/null
> +++ b/tests/unittests/test_datasource/test_ec2.py
> @@ -0,0 +1,202 @@
> +# This file is part of
Diff comments:
> diff --git a/tests/unittests/test_datasource/test_ec2.py
> b/tests/unittests/test_datasource/test_ec2.py
> new file mode 100644
> index 000..d7362c1
> --- /dev/null
> +++ b/tests/unittests/test_datasource/test_ec2.py
> @@ -0,0 +1,202 @@
> +# This file is part of
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index d1740e5..8745ee7 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -557,6 +558,67 @@ def get_interfaces():
> return ret
>
>
> +class EphemeralIPv4Network(object):
>
The proposal to merge ~chad.smith/cloud-init:unittests-in-cloudinit-package
into cloud-init:master has been updated.
Commit Message changed to:
cloudinit.net: add initialize_network_device function and tests
This is not yet called, but will be called in a subsequent Ec2-related branch
to
Per our discussion today, I simplified logic in EphemeralIPv4Network context
manager to first attempt to add a network address and handle a non-zero exit
code if the address already exits.
All changes have been made per review comments, I separated out get_ip_info
utility function so we can
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index d1740e5..5a4a232 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -77,7 +78,7 @@ def read_sys_net_int(iface, field):
> return None
> try:
> return
Chad Smith has proposed merging
~chad.smith/cloud-init:unittests-in-cloudinit-package into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327827
cloudinit.net: add
The proposal to merge ~chad.smith/cloud-init:unittests-in-cloudinit-package
into cloud-init:master has been updated.
Commit Message changed to:
cloudinit.net: add initialize_network_device function and unittests
This is not yet called, but will be called in a subsequent Ec2-related branch
to
The proposal to merge ~chad.smith/cloud-init:unittests-in-cloudinit-package
into cloud-init:master has been updated.
Description changed to:
cloudinit.net: add initialize_network_device function and unittest.
This is not yet called, but will be called in a subsequent Ec2-related branch
to
Diff comments:
> diff --git a/tests/unittests/test_distros/test_debian.py
> b/tests/unittests/test_distros/test_debian.py
> new file mode 100644
> index 000..bd7721c
> --- /dev/null
> +++ b/tests/unittests/test_distros/test_debian.py
> @@ -0,0 +1,70 @@
> +# This file is part of cloud-init.
Diff comments:
> diff --git a/tests/unittests/test_distros/test_debian.py
> b/tests/unittests/test_distros/test_debian.py
> new file mode 100644
> index 000..bd7721c
> --- /dev/null
> +++ b/tests/unittests/test_distros/test_debian.py
> @@ -0,0 +1,70 @@
> +# This file is part of cloud-init.
Chad Smith has proposed merging ~chad.smith/cloud-init:gce-mock-test-leak into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327325
test_gce: Fix invalid mock
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Description changed to:
make deb: Add dependency on devscripts for make deb and minor cleanup of
packages/bddeb script.
Add a simple dependency check to "make deb" target for devscripts.
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Commit Message changed to:
make deb: Add dependency on devscripts for make deb and minor cleanup of
packages/bddeb script.
Add a simple dependency check to "make deb" target for devscripts.
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Commit Message changed to:
make deb: Add dependency on devscripts for make deb and minor cleanup of
packages/bddeb script.
Add a simple dependency check to "make deb" target for devscripts.
The proposal to merge ~chad.smith/cloud-init:cyaml-loading into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/323088
--
Your team cloud init development team is
All comments addressed, and we now handle backward compatibility for old
metadata versions.
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index 46cb9c8..d38ea8b 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -175,12
Chad Smith has proposed merging ~chad.smith/cloud-init:aws-local-dhcp into
cloud-init:master with ~chad.smith/cloud-init:unittests-in-cloudinit-package as
a prerequisite.
Commit message:
ec2: Allow Ec2 to run in init-local using dhclient in a sandbox.
This branch is a prerequisite for IPv6
The proposal to merge ~chad.smith/cloud-init:aws-local-dhcp into
cloud-init:master has been updated.
Commit Message changed to:
ec2: Allow Ec2 to run in init-local using dhclient in a sandbox.
This branch is a prerequisite for IPv6 support in AWS and allows Ec2 datasource
to query the
Chad Smith has proposed merging ~chad.smith/cloud-init:analyze into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/328819
tools: Add tooling for basic cloud-init
Just tested on ubuntu AWS. minor fix needed to remove the route before removing
the address, because the side-effect of removing the addr is the route is
auto-deleted.
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327827
Your team cloud-init commiters is requested
Just validated on cent6 too:
2017-07-27 21:33:19,762 - handlers.py[DEBUG]: finish:
init-local/search-Ec2Local: SUCCESS: found local data from DataSourceEc2Local
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/327827
Your team cloud-init commiters is requested to
Chad Smith has proposed merging ~chad.smith/cloud-init:schema-subcommand into
cloud-init:master with ~chad.smith/cloud-init:analyze as a prerequisite.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud
comments addressed
Diff comments:
> diff --git a/tests/unittests/test_handler/test_handler_landscape.py
> b/tests/unittests/test_handler/test_handler_landscape.py
> new file mode 100644
> index 000..d35ba60
> --- /dev/null
> +++ b/tests/unittests/test_handler/test_handler_landscape.py
> @@
The proposal to merge ~chad.smith/cloud-init:schema-subcommand into
cloud-init:master has been updated.
Description changed to:
schema cli: Add schema subcommand to cloud-init cli and cc_runcmd schema
This branch adds an jsonschema definition for the cc_runcmd module. cc_ntp is
the only other
The proposal to merge ~chad.smith/cloud-init:schema-subcommand into
cloud-init:master has been updated.
Description changed to:
schema cli: Add schema subcommand to cloud-init cli and cc_runcmd schema
This branch adds an jsonschema definition for the cc_runcmd module. cc_ntp is
the only other
The proposal to merge ~chad.smith/cloud-init:schema-subcommand into
cloud-init:master has been updated.
Description changed to:
schema cli: Add schema subcommand to cloud-init cli and cc_runcmd schema
This branch adds an jsonschema definition for the cc_runcmd module. cc_ntp is
the only other
Thanks for the patience on this. I figured out the issue I had with my calls to
helpers.wrap_and_call resulted from relying on mock.patch(return_value) instead
of mock.patch(new)
Diff comments:
> diff --git a/tests/unittests/test_handler/test_handler_landscape.py
>
Looks good, just some inline nits and questions
Diff comments:
> diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py
> index abfb81f..b2904e8 100644
> --- a/cloudinit/distros/debian.py
> +++ b/cloudinit/distros/debian.py
> @@ -246,9 +250,17 @@ def apply_locale(locale,
Looks good, initial comments and running through tests now.
Diff comments:
> diff --git a/tests/cloud_tests/images/kvm.py b/tests/cloud_tests/images/kvm.py
> new file mode 100644
> index 000..008acef
> --- /dev/null
> +++ b/tests/cloud_tests/images/kvm.py
> @@ -0,0 +1,75 @@
> +# This file is
Additionally, since you are importing paramiko, we probably need a dev
dependency added to requirements-test.txt
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327646
Your team cloud-init commiters is requested to review the proposed merge of
Diff comments:
> diff --git a/tests/cloud_tests/instances/kvm.py
> b/tests/cloud_tests/instances/kvm.py
> new file mode 100644
> index 000..c855e07
> --- /dev/null
> +++ b/tests/cloud_tests/instances/kvm.py
> @@ -0,0 +1,222 @@
> +# This file is part of cloud-init. See LICENSE file for
Minor comments inline.
--
https://code.launchpad.net/~paul-meyer/cloud-init/+git/cloud-init/+merge/323532
Your team cloud init development team is requested to review the proposed merge
of ~paul-meyer/cloud-init:bug-1687712 into cloud-init:master.
___
Thanks for the bug and fix here paul.
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index f49386e..5aeef4b 100644
> --- a/cloudinit/config/cc_disk_setup.py
> +++ b/cloudinit/config/cc_disk_setup.py
> @@ -910,12 +910,21 @@ def
Review: Approve
--
https://code.launchpad.net/~paul-meyer/cloud-init/+git/cloud-init/+merge/323532
Your team cloud init development team is requested to review the proposed merge
of ~paul-meyer/cloud-init:bug-1687712 into cloud-init:master.
___
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100644
> index 000..00f91f3
> --- /dev/null
> +++ b/tests/unittests/test_ds_identify.py
> @@ -0,0 +1,275 @@
> +# This file is part of cloud-init. See LICENSE file for
Review: Approve
+1 thanks for the rework + docstrings.
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100644
> index 000..de645eb
> --- /dev/null
> +++ b/tests/unittests/test_ds_identify.py
> @@ -0,0 +1,295 @@
> +#
Chad Smith has proposed merging ~chad.smith/cloud-init:sysconfig-has-default
into cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/323819
sysconfig: Properly set
Diff comments:
> diff --git a/tests/cloud_tests/args.py b/tests/cloud_tests/args.py
> index 371b044..ca52b61 100644
> --- a/tests/cloud_tests/args.py
> +++ b/tests/cloud_tests/args.py
> @@ -185,6 +246,17 @@ def normalize_output_args(args):
> return args
>
>
> +def
Comments addressed, thank you much
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325342
Your team cloud-init commiters is requested to review the proposed merge of
~chad.smith/cloud-init:ci-deps into cloud-init:master.
The proposal to merge ~chad.smith/cloud-init:ci-deps into cloud-init:master has
been updated.
Description changed to:
pkg build ci: Add make ci-deps- target to automatically install pkgs
This change adds a couple of makefile targets for ci environments to install
all necessary dependencies
Chad Smith has proposed merging ~chad.smith/cloud-init:schema-autodoc into
cloud-init:master.
Commit message:
docs: Automatically generate module docs form schema attribute if present
We have started adding jsonschema defintions for cloudconfig modules (cc_ntp).
This branch allows us render
The proposal to merge ~chad.smith/cloud-init:schema-autodoc into
cloud-init:master has been updated.
Commit Message changed to:
docs: Automatically generate module docs form schema attribute if present
We have started adding jsonschema defintions for cloudconfig modules (cc_ntp).
This branch
Addressed review comments plus:
- dropped argparse filtering from read-dependencies and brpm now that master
has baked argparse direclty into the spec for py26
- added dry-run param to read-dependencies to allow for viewing intended
install actions
- made sure Requires in redhat and suse
@scott I think I've addressed all comments here
Diff comments:
> diff --git a/packages/pkg-deps.json b/packages/pkg-deps.json
> new file mode 100644
> index 000..2100ec7
> --- /dev/null
> +++ b/packages/pkg-deps.json
> @@ -0,0 +1,84 @@
> +{
> + "debian" : {
> + "build-requires" : [
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -266,6 +267,12 @@ def parse_strict_mode(cfgval):
> return
The proposal to merge ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master has been updated.
Commit Message changed to:
cc_ntp: Restructure cc_ntp unit tests add with_logs class attr to unit tests.
Any CiTestCase subclass can now set a class attribute with_logs = True and
tests can
Chad Smith has proposed merging ~chad.smith/cloud-init:cc-ntp-testing into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/324450
cc_ntp: Restructure cc_ntp unit tests
Review: Approve
+1 land it
--
https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324490
Your team cloud-init commiters is requested to review the proposed merge of
~powersj/cloud-init:fix-blank-line into cloud-init:master.
___
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 225f898..257bb40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -53,14 +53,12 @@ distros = ['centos', 'debian', 'fedora', 'opensuse',
> 'ubuntu']
>
>
> def
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 225f898..257bb40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -69,18 +67,12 @@ def handle(name, cfg, cloud, log, _args):
> " but not a
Chad Smith has proposed merging ~chad.smith/cloud-init:cc-ntp-schema into
cloud-init:master with ~chad.smith/cloud-init:cc-ntp-testing as a prerequisite.
Commit message:
cc_ntp: Add schema definition and passive schema validation logging warnings.
cloud-config files are very flexible
Review: Approve
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> index 9e14885..8559e1f 100644
> --- a/tests/unittests/test_ds_identify.py
> +++ b/tests/unittests/test_ds_identify.py
> @@ -210,6 +210,13 @@ class
Review: Approve
+1 LGTM!
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324557
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:bug/ds-identify-list-none-twice into cloud-init:master.
Review: Needs Fixing
Generally, if we are changing functionality, I'd love to see a unit test
exercising this functionality so we don't have to test it with integration
tests.
It appears that this changeset will only pass this type problem down into
ipv4mask2cidr and ipv6mask2cidr which will
The proposal to merge ~chad.smith/cloud-init:cc-ntp-schema into
cloud-init:master has been updated.
Description changed to:
cc_ntp: Add schema definition and passive schema validation.
cloud-config files are very flexible and permissive. This branch adds a
supported schema definition to
The proposal to merge ~chad.smith/cloud-init:cc-ntp-schema into
cloud-init:master has been updated.
Commit Message changed to:
cc_ntp: Add schema definition and passive schema validation.
cloud-config files are very flexible and permissive. This branch adds a
supported schema definition to
Review: Approve
Wow good to know about format issues on cent6 as I've used it in other places.
I'll be wary for next time. +1
Diff comments:
> diff --git a/tests/unittests/test_handler/test_handler_ntp.py
> b/tests/unittests/test_handler/test_handler_ntp.py
> index 21f2ab1..bc4277b 100644
>
Review: Approve
I think we agreed in standup that since you've fixed this with a workaround for
pylint's bug, you could probably add a structured comment or something that
mark that we should look at pylint tip in the future to see if that issue is
fixed. For bugs on external dependencies
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -266,6 +267,12 @@ def parse_strict_mode(cfgval):
> return
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index 2f9c7ed..818a639 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
There only seems to be one unit test which covers this module
Thanks for the clarification josh. While it feels strange to build a deb on a
different target series --build-os, than test series per --os-name, I suppose
that use case for that could be in cases where we know we can't build on the
target --os-name due to missing deps or something. In those
Think I'm done with this branch. Thanks Josh for shepherding this all in.
This is good step in the right direction, and since it's in our test code
instead of core, I shouldn't try to be a stickler on some of these concerns as
we can iterate on this without direct impact to core code.
Diff
The proposal to merge ~chad.smith/cloud-init:make-deb-cleanup into
cloud-init:master has been updated.
Commit Message changed to:
make deb: Add devscripts dependency for make deb. Cleanup packages/bddeb.
Add a simple dependency check to "make deb" target for devscripts. Rework a bit
of the
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 5cc5453..f2eb5a6 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -52,21 +54,79 @@ NR_POOL_SERVERS = 4
> distros = ['centos', 'debian', 'fedora', 'opensuse', 'ubuntu']
Thanks for the clarification and background on the datasource list ordering.
And I see your point on git log (as that's how I determined what the intent of
the var was in the first place).
+1 on the separate mocked unit test for _is_aliyun() to exercise the interface
we are actually
Review: Approve
+1 thanks for the discussion.
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324807
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/enable-aliyun into cloud-init:master.
Chad Smith has proposed merging ~chad.smith/cloud-init:azure-di-id-asset-tag
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/324875
azure: ds-identify
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index b9458ff..9dc9157 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -319,7 +321,11 @@ class
Chad Smith has proposed merging
~chad.smith/cloud-init:skip-jsonschema-unittest-when-missing-deps into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325024
Tests
Chad Smith has proposed merging ~chad.smith/cloud-init:pyver-fix into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325283
makefile: fix python 2/3 detection
The proposal to merge ~chad.smith/cloud-init:ci-deps into cloud-init:master has
been updated.
Commit Message changed to:
pkg build ci: Add make ci-deps- target to automatically install pkgs
This change adds a couple of makefile targets for ci environments to install
all necessary dependencies
The proposal to merge ~chad.smith/cloud-init:ci-deps into cloud-init:master has
been updated.
Description changed to:
pkg build ci: Add make ci-deps- target to automatically install pkgs
This change adds a couple of makefile targets for ci environments to install
all necessary dependencies
The proposal to merge ~chad.smith/cloud-init:ci-deps into cloud-init:master has
been updated.
Commit Message changed to:
pkg build ci: Add make ci-deps- target to automatically install pkgs
This change adds a couple of makefile targets for ci environments to install
all necessary dependencies
The proposal to merge ~chad.smith/cloud-init:ci-deps into cloud-init:master has
been updated.
Commit Message changed to:
pkg build ci: Add make ci-deps- target to automatically install pkgs
This change adds a couple of makefile targets for ci environments to install
all necessary dependencies
The proposal to merge ~chad.smith/cloud-init:ci-deps into cloud-init:master has
been updated.
Commit Message changed to:
pkg build ci: Add make ci-deps- target to automatically install pkgs
This change adds a couple of makefile targets for ci environments to install
all necessary dependencies
The proposal to merge ~chad.smith/cloud-init:ci-deps into cloud-init:master has
been updated.
Commit Message changed to:
pkg build ci: Add make ci-deps- target to automatically install pkgs
This change adds a couple of makefile targets for ci environments to install
all necessary dependencies
The proposal to merge ~chad.smith/cloud-init:ci-deps into cloud-init:master has
been updated.
Description changed to:
pkg build ci: Add make ci-deps- target to automatically install pkgs
This change adds a couple of makefile targets for ci environments to install
all necessary dependencies
The proposal to merge ~chad.smith/cloud-init:schema-autodoc into
cloud-init:master has been updated.
Description changed to:
docs: Automatically generate module docs form schema attribute if present
We have started adding jsonschema defintions for cloudconfig modules (cc_ntp).
This branch
Addressed renames for six, pyyaml an pyflakes to use python34-* where needed.
I'd like to wait for a separate branch to sort our python3* issues on CentOS to
keep this branch a bit more focused as a "best-effort" for python34 there. Our
existing ci can use this current branch for python2 CentOS
+1 on that suggestion
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
Your team cloud-init commiters is requested to review the proposed merge of
~smoser/cloud-init:feature/freebsd-variant into cloud-init:master.
___
The proposal to merge ~smoser/cloud-init:feature/freebsd-variant into
cloud-init:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/325760
--
Your team cloud-init commiters is requested to
The proposal to merge ~chad.smith/cloud-init:ci-deps into cloud-init:master has
been updated.
Description changed to:
pkg build ci: Add make ci-deps- target to automatically install pkgs
This change adds a couple of makefile targets for ci environments to install
all necessary dependencies
Diff comments:
> diff --git a/tools/read-dependencies b/tools/read-dependencies
> index 4ba2c1b..f22f4a5 100755
> --- a/tools/read-dependencies
> +++ b/tools/read-dependencies
> @@ -144,12 +146,18 @@ def main(distro):
> topd = os.path.realpath(os.environ.get('CLOUD_INIT_TOP_D'))
>
Diff comments:
> diff --git a/tools/run-centos b/tools/run-centos
> index de21d75..f812e93 100755
> --- a/tools/run-centos
> +++ b/tools/run-centos
> @@ -63,26 +78,53 @@ inside() {
> }
>
> inject_cloud_init(){
> -local name="$1"
> -tarball_name='cloud-init.tar.gz'
> -top_d=$(git
Chad Smith has proposed merging ~chad.smith/cloud-init:ci-deps-fixes into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/325693
ci dependency installs: Add --test
The proposal to merge ~chad.smith/cloud-init:ci-deps-fixes into
cloud-init:master has been updated.
Description changed to:
ci dependency installs: Add --test-distro param to read-dependencies to install
deps
read-dependencies now takes --test-distro param to indicate we want to install
all
Diff comments:
> diff --git a/cloudinit/sources/DataSourceAzure.py
> b/cloudinit/sources/DataSourceAzure.py
> index ebb53d0..e5514ad 100644
> --- a/cloudinit/sources/DataSourceAzure.py
> +++ b/cloudinit/sources/DataSourceAzure.py
> @@ -803,18 +803,22 @@ def encrypt_pass(password,
Diff comments:
> diff --git a/cloudinit/config/cc_disk_setup.py
> b/cloudinit/config/cc_disk_setup.py
> index f49386e..32d51e8 100644
> --- a/cloudinit/config/cc_disk_setup.py
> +++ b/cloudinit/config/cc_disk_setup.py
> @@ -936,14 +938,14 @@ def mkfs(fs_cfg):
> if overwrite or
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> new file mode 100644
> index 000..00f91f3
> --- /dev/null
> +++ b/tests/unittests/test_ds_identify.py
> @@ -0,0 +1,275 @@
> +# This file is part of cloud-init. See LICENSE file for
Thanks Ryan for the review points, I know you are commenting on the Safeloader
proposal which is over here
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/323088
so I'll copy them over to that proposal and comment over there.
--
>From Ryan:
Some thoughts on this:
1) we don't want users who apt install cloud-init to also pull down
python-devel, gcc and have to compile the extension, so please don't change
package deps here
2) this is currently an issue for the tox/venv environment, so let's focus on
how to enable the
1 - 100 of 689 matches
Mail list logo
