The proposal to merge ~smoser/cloud-init:feature/curtin-centos3 into
cloud-init:master has been updated.
Commit Message changed to:
templatize systemd unit files for cross distro deltas
Under el7, cloud-init systemd files need some unit tweaks to ensure they
run at the right time. Pull in curr
Diff comments:
> diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py
> index d06d46a..bcf45c6 100644
> --- a/cloudinit/distros/debian.py
> +++ b/cloudinit/distros/debian.py
> @@ -225,4 +217,36 @@ def
> _maybe_remove_legacy_eth0(path="/etc/network/interfaces.d/eth0.cfg"):
>
Ryan Harper has proposed merging
~raharper/cloud-init:sysconfig-resolvconf-duplicate-header-lp1701420 into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1701420 in cloud-init: "Created by cloud-init comment being added on
every rebo
The proposal to merge
~raharper/cloud-init:ntp-configure-timesyncd-fallback-lp-1686485 into
cloud-init:master has been updated.
Description changed to:
cc_ntp: fallback on timesyncd configuration if ntp is not installable
Some systems like Ubuntu-Core do not provide an ntp package for
installa
Ryan Harper has proposed merging
~raharper/cloud-init:ntp-configure-timesyncd-fallback-lp-1686485 into
cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1686485 in cloud-init: "c
This looks really good. Just some questions and clarifications in inline
comments.
Diff comments:
> diff --git a/cloudinit/net/__init__.py b/cloudinit/net/__init__.py
> index 46cb9c8..d38ea8b 100644
> --- a/cloudinit/net/__init__.py
> +++ b/cloudinit/net/__init__.py
> @@ -233,15 +231,24 @@ def
Thanks for the review, I'll fix the issues you raised and push in an update.
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index 31ed64e..0b92a40 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -185,19 +217,25 @@ def writ
Fix suggestions, rebased and updated.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/328427
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-init:ntp-configure-timesyncd-fallback-lp-1686485 into
cloud-init:master.
___
Ryan Harper has proposed merging ~raharper/cloud-init:bug-lp-1709180-v2-params
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1709180 in cloud-init: "cloud-init v2 yaml doesn't preserve bond/bridge
parameters when renderin
he cloud-image disk and seed device
> +% ssh -p ubuntu@localhost
> +% cd /var/lib/cloud-init/data/cloud-init-*-blktrace
> +% sudo zcat vda1.blktrace.* | blkparse -i - -s
> +
> +# or for btt data
> +sudo gunzip *blktrace*
> +sudo blkparse -i vda1 -d bp.vda1.bin
> +sudo b
I believe we've already have one, I've linked the RHEL issue to it.
--
https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/328877
Your team cloud-init commiters is requested to review the proposed merge of
~rmccabe/cloud-init:dns_redirect_detect into cloud-init:master.
Thanks for the patch. I've a couple comments below.
Diff comments:
> diff --git a/cloudinit/config/cc_chef.py b/cloudinit/config/cc_chef.py
> index 02c70b1..94500b6 100644
> --- a/cloudinit/config/cc_chef.py
> +++ b/cloudinit/config/cc_chef.py
> @@ -302,12 +302,16 @@ def install_chef(cloud, che
Ryan Harper has proposed merging ~raharper/cloud-init:update-features-doc into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/328992
doc:capabilities Update supported
Nice work. Couple of questions inline.
Diff comments:
> diff --git a/tests/unittests/test_handler/test_handler_landscape.py
> b/tests/unittests/test_handler/test_handler_landscape.py
> new file mode 100644
> index 000..d35ba60
> --- /dev/null
> +++ b/tests/unittests/test_handler/test_handle
Ryan Harper has proposed merging ~raharper/cloud-init:logging-gmtime into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/329122
Configure logging module to always use
Ryan Harper has proposed merging ~raharper/cloud-init:default-lang-c-utf8 into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/329152
distro: allow distro to specify a
Current Ubuntu (and Debian) images already include the C.UTF-8 locale.
Updating the default in cloud-init (for Ubuntu and Debian) means we can realize
a non-zero speed up during boot.
Building cloud-init from this branch, injecting it into an artful image and
comparing time spent in locale-gen
Diff comments:
> diff --git a/cloudinit/distros/debian.py b/cloudinit/distros/debian.py
> index abfb81f..b2904e8 100644
> --- a/cloudinit/distros/debian.py
> +++ b/cloudinit/distros/debian.py
> @@ -246,9 +250,17 @@ def apply_locale(locale, sys_path=LOCALE_CONF_FN,
> keyname='LANG'):
>
There are some other places upstart is touched (/etc/cloud/cloud.cfg
emit_upstart, cc_ubuntu_init_switch, cc_mounts, handlers/upstart_job)
It's also possible for other distros besides Ubuntu to use cloud-init's upstart
jobs.
We can take this as a task for Artful to no longer package the upstart
The proposal to merge ~chad.smith/cloud-init:unify-datasource-get-data into
cloud-init:master has been updated.
Description changed to:
Datasources: Create DataSource.get_data method in parent and write json
metadata
Each DataSource subclass must define its own get_data method. This branch
form
I dropped your "future branches may do this" from the commit message. Also
edited it's -> its.
And fixed a missing phrase about sensitive/private user-data.
I do have a question about the policy of
write-no-file-if-some-data-is-not-serializable.
Could we instead skip the unseriable blob and in
The commit message mentions 'caching'; I suspect that's meant for outside of
cloud-init use; I was initially confused thinking that cloud-init would re-use
this; but it won't directly as it has the original gata in the cloud object.
We may want to modify the commit language to indicate that we
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> index 1a81a89..c389029 100644
> --- a/tests/unittests/test_ds_identify.py
> +++ b/tests/unittests/test_ds_identify.py
> @@ -48,6 +54,7 @@ P_SEED_DIR = "var/lib/cloud/seed"
> P_DSID_CFG =
It may be more obvious for the MOCK_XXX values always have the same keys (even
if they don't use them).
MOCK_VIRT_IS_KVM = {
'name': 'detect_virt',
'out': "",
'err': "",
'RET': "kvm",
'ret': 0
}
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330242
Your tea
In commit message:
s/it's/its
I'd replace 'caches' metadata, to dumps; cache implies (to me) reuse but
cloud-init doesn't use the json file at all (nor would it since it's already
part of the cloud object).
Drop the 'Subsequent' sentence; while you may follow up with that it's not
needed as
Diff comments:
> diff --git a/cloudinit/sources/__init__.py b/cloudinit/sources/__init__.py
> index 9a43fbe..c08aa51 100644
> --- a/cloudinit/sources/__init__.py
> +++ b/cloudinit/sources/__init__.py
> @@ -78,6 +82,32 @@ class DataSource(object):
> def __str__(self):
> return type_
There are quite a few with open() as fh: fh.read() chunks; if you're using
cloudinit.util then you can just use util.load_file()
same for writing (util.write_file())
Diff comments:
> diff --git a/tests/cloud_tests/instances/base.py
> b/tests/cloud_tests/instances/base.py
> index 959e9cc..af6c
Thanks for tackling this.
I do worry that we're changing existing behavior here: The skipped and forced
were mostly advertising; cloud-init didn't not run modules just because they
didn't declare their distro support.
If we're going to change that we should be careful about how we introduce th
Gave this a try on OpenStack, the instance json was interesting:
"random_seed": "Warning: redacted unserializable type ",
That probably should be serializble ... I wonder why not? I guess it needs
base64 encoding to write as strings?
Other interesting values:
"user-data": "",
"vendor-data":
Hi Dusty,
Thank you for your contribution to cloud-init. Contributions to
cloud-init require the developer to have signed the Canonical Contributors
Agreement [1]. Your launchpad id is not currently listed as a member of
the contributor-agreement-canonical group [2].
Membership in that group is
I'm ok with the changes, though I would much prefer not using a string that's
11 times longer than 'all';
if we can shorten that sanely, I'm +1
--
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330384
Your team cloud-init commiters is requested to review the proposed me
The proposal to merge ~raharper/cloud-init:ds-ovf-use-util-find-devs-with into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/330995
--
Your team cloud-init commiters
Ryan Harper has proposed merging
~raharper/cloud-init:ds-ovf-use-util-find-devs-with into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/330995
DataSourceOVF: use
I've kept the regex filter as suggested and added unittests.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/330995
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-init:ds-ovf-use-util-find-devs-with into cloud-init:master.
__
As it turns out, two parallel instances of /bin/mount pointing to the same
device will cause one to fail; it appears that there is some sort of
locking/ref-counting during a mount operation that results in one of the two
mount processes getting EBUSY as a result.
This sort of race is recreatabl
Ryan Harper has proposed merging
~raharper/cloud-init:ds-ovf-use-util-find-devs-with into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1718287 in cloud-init: "systemd mount targets fail due to device busy or
already mounted&quo
> As it turns out, two parallel instances of /bin/mount pointing
> to the same device will cause one to fail; it appears that there
> is some sort of locking/ref-counting during a mount operation
> that results in one of the two mount processes getting EBUSY as a result.
In particular, when we op
I'll add the os.path.basename(); should we do that in both places?
Diff comments:
> diff --git a/cloudinit/sources/DataSourceOVF.py
> b/cloudinit/sources/DataSourceOVF.py
> index 24b45d5..4b02cbb 100644
> --- a/cloudinit/sources/DataSourceOVF.py
> +++ b/cloudinit/sources/DataSourceOVF.py
> @@ -
On Tue, Oct 3, 2017 at 8:23 AM, Scott Moser wrote:
> i approve with 2 small questions in line.
>
>
> Diff comments:
>
> > diff --git a/cloudinit/user_data.py b/cloudinit/user_data.py
> > index 88cb7f8..de459c9 100644
> > --- a/cloudinit/user_data.py
> > +++ b/cloudinit/user_data.py
> > @@ -222,16
Ryan Harper has proposed merging ~raharper/cloud-init:add-netplan-bridge-stp
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1721157 in cloud-init: "netplan render drops bridge_stp setting"
https://bugs.launchpad.net/cloud
On Wed, Oct 4, 2017 at 9:28 AM, Andrew Jorgensen
wrote:
> > In an exception path, I don't think this matters;
>
> Do I take this to mean it's okay as it is now, and you approve? Or would
> you like me to undo the change that Scott suggested before it gets merged?
>
That was a comment for Scott;
Ryan Harper has proposed merging
~raharper/cloud-init:ubuntu-devel-new-artful-release-v7 into
cloud-init:ubuntu/devel.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1721157 in cloud-init: "ne
Ryan Harper has proposed merging
~raharper/cloud-init:azure-network-dont-config-sriov-devices into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1721579 in cloud-init: "azure: remove sriov device configuration"
https://bugs.lau
Ryan Harper has proposed merging
~raharper/cloud-init:ubuntu-devel-new-bionic-release-v1 into
cloud-init:ubuntu/devel.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1724354 in cloud-init: "WARNING in logs due to missing python-jsonschema&quo
I'm not sure I understand the dropping of instance property from the NoCloud
KVM class vs. the LXD one.
Diff comments:
> diff --git a/tests/cloud_tests/execute_basics.py
> b/tests/cloud_tests/execute_basics.py
> new file mode 100644
> index 000..f679b11
> --- /dev/null
> +++ b/tests/cloud_t
On Wed, Nov 1, 2017 at 1:45 PM, Scott Moser
wrote:
> > I'm not sure I understand the dropping of instance property from the
> NoCloud
> > KVM class vs. the LXD one.
>
> An Image does not have an instance associated with it.
>
> An 'Image' is something you can manipulate the contents of (execute,
One more round on the @property structure, see inline.
Diff comments:
> diff --git a/tests/cloud_tests/images/lxd.py b/tests/cloud_tests/images/lxd.py
> index fd4e93c..fbd5196 100644
> --- a/tests/cloud_tests/images/lxd.py
> +++ b/tests/cloud_tests/images/lxd.py
> @@ -49,15 +49,19 @@ class LXDIma
There's quite a bit of work to make the tables look the same.
Is that required or can we just dump a different format?
Please make sure the subp command used long options:
netstat --route --numeric --extended
ip --oneline ..
etc.
Diff comments:
> diff --git a/cloudinit/netinfo.py b/cloudinit
ah, makes sense; Since we're touching it, it's worth updating for
readers.
>
> On 14 Nov 2017 20:08, "Ryan Harper" wrote:
>
> > There's quite a bit of work to make the tables look the same.
> > Is that required or can we just dump a different format?
&
Diff comments:
> diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py
> index f572796..6e11247 100644
> --- a/cloudinit/net/sysconfig.py
> +++ b/cloudinit/net/sysconfig.py
> @@ -347,6 +347,16 @@ class Renderer(renderer.Renderer):
> else:
>
I was suggesting you pick up that patch and include it with this fix. If you'd
prefer, I can MP that separately.
--
https://code.launchpad.net/~rmccabe/cloud-init/+git/cloud-init/+merge/333759
Your team cloud-init commiters is requested to review the proposed merge of
~rmccabe/cloud-init:bug170
On Thu, Nov 16, 2017 at 12:35 PM, Ryan McCabe wrote:
>
>
> Diff comments:
>
> > diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/sysconfig.py
> > index f572796..6e11247 100644
> > --- a/cloudinit/net/sysconfig.py
> > +++ b/cloudinit/net/sysconfig.py
> > @@ -347,6 +347,16 @@ class Renderer(
> one comment on ryan's patch inline
>
> do not use .split(" "), here is why:
> > "a b c".split()
> ['a', 'b', 'c']
>
> > "a b c".split(" ")
> ['a', 'b', '', '', 'c']
I had to hit reply to see how those two strings looked different
Even cut and pasting, something is removing the additi
What's the use case for the "destroy an image without breaking a snapshot" that
introduces the copy of the image.
Some more comments inline as well.
Diff comments:
> diff --git a/tests/cloud_tests/images/nocloudkvm.py
> b/tests/cloud_tests/images/nocloudkvm.py
> index 1e7962c..8678b07 100644
>
Diff comments:
> diff --git a/cloudinit/distros/net_util.py b/cloudinit/distros/net_util.py
> index 1ce1aa7..fad062d 100644
> --- a/cloudinit/distros/net_util.py
> +++ b/cloudinit/distros/net_util.py
> @@ -148,6 +160,16 @@ def translate_network(settings):
> hw_addr = hw_spli
> An image is a mutable thing.
> General flow of tests is:
> - get an image
> - update the image (install a new deb)
> - create a snapshot
> - launch a snapshot multiple times
>
> After creating a snapshot of the image the image can reasonably be destroyed.
> Just like in a "real cloud".
> -
Diff comments:
> diff --git a/tests/cloud_tests/images/nocloudkvm.py
> b/tests/cloud_tests/images/nocloudkvm.py
> index 1e7962c..8678b07 100644
> --- a/tests/cloud_tests/images/nocloudkvm.py
> +++ b/tests/cloud_tests/images/nocloudkvm.py
> @@ -21,7 +25,13 @@ class NoCloudKVMImage(base.Image):
>
> the Image object has a destroy() method which is valid to call, and should be
> called whne you're "done" with the object.
> i = Image(foo)
> i.execute(['apt-get', 'dist-upgrade'])
> s = i.snapshot()
> i.destroy()
> s.launch()
> ...
>
> the result of snapshot needs to be stand-alone,
On Mon, Nov 27, 2017 at 4:31 PM, Scott Moser
wrote:
>
> It looks like as it is right now we do not call destroy on an image before
> using a snapshot.
> But having NoCloud work like other clouds makes sense.
>
I don't disagree with the goal; however; just as I don't want to upload a
new snapshot
Ryan Harper has proposed merging
~raharper/cloud-init:add-netplan-bridge-port-priority into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1735821 in nplan (Ubuntu): "netplan needs bridge port-priority support"
https://bugs.lau
Ryan Harper has proposed merging
~raharper/cloud-init:cloud-test-add-pylint-and-fix into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/334868
Add pylint support
Didn't mean to run on tools for now.
w.r.t the meta-data bits, I'll defer to Scott, he did that first bit.
On Wed, Dec 6, 2017 at 5:15 PM, Joshua Powers
wrote:
> Review: Needs Fixing
>
> Thanks for doing this! Can you add comment to description/commit message
> about meta-data getting added to
"AWS at the start of tests and deleted on exit."
I think the keys will need to always be deleted no matter whether we finish;
unless we specifically have some flag the user set to keep keys.
I don't think we want automatic runs of this to fail at any stage after
injecting keys and not have it e
Some in-line comments and questions.
Diff comments:
> diff --git a/tests/cloud_tests/platforms.yaml
> b/tests/cloud_tests/platforms.yaml
> index fa4f845..458ab81 100644
> --- a/tests/cloud_tests/platforms.yaml
> +++ b/tests/cloud_tests/platforms.yaml
> @@ -6,8 +6,13 @@ default_platform_config:
>
Replaced my pop() with next() in the in-line comments.
Diff comments:
> diff --git a/tests/cloud_tests/platforms/ec2/platform.py
> b/tests/cloud_tests/platforms/ec2/platform.py
> new file mode 100644
> index 000..8ff2716
> --- /dev/null
> +++ b/tests/cloud_tests/platforms/ec2/platform.py
> @
Diff comments:
> diff --git a/tests/cloud_tests/platforms/ec2/platform.py
> b/tests/cloud_tests/platforms/ec2/platform.py
> new file mode 100644
> index 000..8ff2716
> --- /dev/null
> +++ b/tests/cloud_tests/platforms/ec2/platform.py
> @@ -0,0 +1,255 @@
> +# This file is part of cloud-init.
Diff comments:
> diff --git a/tests/cloud_tests/platforms/ec2/platform.py
> b/tests/cloud_tests/platforms/ec2/platform.py
> index fdb17ba..ba246fe 100644
> --- a/tests/cloud_tests/platforms/ec2/platform.py
> +++ b/tests/cloud_tests/platforms/ec2/platform.py
> @@ -228,4 +230,28 @@ class EC2Platf
Ryan Harper has proposed merging
~raharper/cloud-init:fix/cloud-init-network-rename-with-v2 into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1709715 in cloud-init: "cloud-init apply_net_config_names doesn't grok
v2 config
unittest? comment in line.
Diff comments:
> diff --git a/cloudinit/util.py b/cloudinit/util.py
> index e42498d..779d2b2 100644
> --- a/cloudinit/util.py
> +++ b/cloudinit/util.py
> @@ -1829,58 +1835,60 @@ def subp(args, data=None, rcs=None, env=None,
> capture=True, shell=False,
> env
Add a comment that you switched to using /bin/sh instead of bash in several
scripts. Some comments inline.
Diff comments:
> diff --git a/tests/cloud_tests/platforms/lxd/instance.py
> b/tests/cloud_tests/platforms/lxd/instance.py
> index 0d697c0..e9b76a6 100644
> --- a/tests/cloud_tests/platfor
You've an unrelated change to HACKING.rst
Diff comments:
> diff --git a/HACKING.rst b/HACKING.rst
> index 93e3f42..3bb555c 100644
> --- a/HACKING.rst
> +++ b/HACKING.rst
> @@ -16,6 +16,14 @@ Do these things once
>When prompted for 'Project contact' or 'Canonical Project Manager' enter
>'S
One more question on the unitest. The change looks good though.
Diff comments:
> diff --git a/tests/unittests/test_ds_identify.py
> b/tests/unittests/test_ds_identify.py
> index ad6c5cf..31cc622 100644
> --- a/tests/unittests/test_ds_identify.py
> +++ b/tests/unittests/test_ds_identify.py
> @@
Some comments inline.
Diff comments:
> diff --git a/doc/rtd/topics/boot.rst b/doc/rtd/topics/boot.rst
> index 859409a..47a5998 100644
> --- a/doc/rtd/topics/boot.rst
> +++ b/doc/rtd/topics/boot.rst
> @@ -125,4 +125,6 @@ Things that run here include
> * configuration management plugins (puppet,
Updated based on feedback.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/336464
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-init:fix/cloud-init-network-rename-with-v2 into
cloud-init:master.
typo in comment
Diff comments:
> diff --git a/cloudinit/sources/DataSourceEc2.py
> b/cloudinit/sources/DataSourceEc2.py
> index e14553b..21e9ef8 100644
> --- a/cloudinit/sources/DataSourceEc2.py
> +++ b/cloudinit/sources/DataSourceEc2.py
> @@ -147,6 +147,12 @@ class DataSourceEc2(sources.DataSou
Nifty test, and good change. The comment doesn't quite match the code;
'cloud-init will decode'
should be 'cloud-init will encode'
Right?
--
https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/338586
Your team cloud-init commiters is requested to review the proposed merge of
Ryan Harper has proposed merging ~raharper/cloud-init:fix/netplan-accept-ra-off
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/339437
netplan: disable IPV6 RA mode
The proposal to merge ~raharper/cloud-init:feature/update-ntp-spec into
cloud-init:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/339438
--
Your team cloud-init commiters is requ
Ryan Harper has proposed merging ~raharper/cloud-init:feature/update-ntp-spec
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/339438
Implement ntp client spec with
If anything, this is fallout due to the bug you mention.
LXD should be explicit; as should cloud-init.
On Mon, Feb 26, 2018 at 10:07 AM, Scott Moser
wrote:
> So this *will* cause a change in behavior in all lxd guests.
>
> $ lxd file pull b1/var/lib/cloud/seed/nocloud-net/network-config -
> ver
Ryan Harper has proposed merging ~raharper/cloud-init:feature/update-ntp-spec
into cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/339438
Implement ntp client spec with
I've a bit of a quibble with the description. Mostly because cloud-init has
_no_ control over how DNS or DHCP servers react to dhcp client requests coming
from an instance.
What we (cloud-init) can do is set instance specified hostnames as _soon_ as we
know it, which may be of help to some sit
Sorry for the noise on the get_hostname part; I missed it getting sent through
the datasource object.
Diff comments:
> diff --git a/cloudinit/cmd/main.py b/cloudinit/cmd/main.py
> index d2f1b77..120c3cc 100644
> --- a/cloudinit/cmd/main.py
> +++ b/cloudinit/cmd/main.py
> @@ -354,7 +355,17 @@ def
Ryan Harper has proposed merging
~raharper/cloud-init:add-netplan-bridge-port-priority into cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1735821 in nplan (Ubuntu): "netplan
As of nplan 0.33 netplan supports bridge port-priority.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/334611
Your team cloud-init commiters is requested to review the proposed merge of
~raharper/cloud-init:add-netplan-bridge-port-priority into cloud-init:master.
___
Diff comments:
> diff --git a/cloudinit/net/cmdline.py b/cloudinit/net/cmdline.py
> index 7b2cc9d..a123afb 100755
> --- a/cloudinit/net/cmdline.py
> +++ b/cloudinit/net/cmdline.py
> @@ -160,10 +167,23 @@ def _b64dgz(b64str, gzipped="try"):
> return _decomp_gzip(blob, strict=gzipped != "try"
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py b/cloudinit/config/cc_ntp.py
> index cbd0237..099b8d8 100644
> --- a/cloudinit/config/cc_ntp.py
> +++ b/cloudinit/config/cc_ntp.py
> @@ -103,6 +171,9 @@ def handle(name, cfg, cloud, log, _args):
> ntp_cfg = cfg['ntp']
> if ntp_cf
Ryan Harper has proposed merging
~raharper/cloud-init:fix/lp-1750884-netplan-global-dns into cloud-init:master.
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init commiters (cloud-init-dev)
Related bugs:
Bug #1750884 in cloud-init: "[2.4, b
Looks good, one comment on the docstring for the testcase
Diff comments:
> diff --git a/cloudinit/sources/tests/test_init.py
> b/cloudinit/sources/tests/test_init.py
> index 5065083..8e800e6 100644
> --- a/cloudinit/sources/tests/test_init.py
> +++ b/cloudinit/sources/tests/test_init.py
> @@ -26
some inline comments, questions.
Diff comments:
> diff --git a/cloudinit/sources/DataSourceIBMCloud.py
> b/cloudinit/sources/DataSourceIBMCloud.py
> new file mode 100644
> index 000..99ec4c2
> --- /dev/null
> +++ b/cloudinit/sources/DataSourceIBMCloud.py
> @@ -0,0 +1,275 @@
> +# This file is
The proposal to merge
~raharper/cloud-init:sysconfig-handle-global-static-routes into
cloud-init:master has been updated.
Commit Message changed to:
net/sysconfig: handle global static routes
Cloud-init network-config V1 format allows configuration of "global"
static routes which are not direc
Ryan Harper has proposed merging
~raharper/cloud-init:sysconfig-handle-global-static-routes into
cloud-init:master.
Requested reviews:
cloud-init commiters (cloud-init-dev)
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/342102
--
Your team
Diff comments:
> diff --git a/tests/cloud_tests/platforms/instances.py
> b/tests/cloud_tests/platforms/instances.py
> index 3bad021..fa392b7 100644
> --- a/tests/cloud_tests/platforms/instances.py
> +++ b/tests/cloud_tests/platforms/instances.py
> @@ -98,21 +103,21 @@ class Instance(TargetBase)
OK, I think I've addressed most of the comments here, except I still need to:
- switch to temp_utils.mkstemp() for the custom template; I didn't want to
fight temp_utils for the unittest, but it's the Right Thing(TM) so that's up
next.
I think the current commit log will show you what things I
Thanks for the review, fixing up most.
We do have some discussion to be had re: sysconfig capture and redeploy w.r.t
what files cloud-init will leave around, also cloud-init clean for network
related configuration files.
Diff comments:
> diff --git a/cloudinit/net/sysconfig.py b/cloudinit/net/
Most of this has already been discussed, but saving my comments for history.
Diff comments:
> diff --git a/cloudinit/distros/__init__.py b/cloudinit/distros/__init__.py
> index 55260ea..59bb9f9 100755
> --- a/cloudinit/distros/__init__.py
> +++ b/cloudinit/distros/__init__.py
> @@ -49,6 +49,48 @@
The branch should pass CI now, updates cloud-ci ntp test-cases to specify the
ntp client, added tests for timesyncd and chrony.
I've a couple in-line comments that I think need some discussion before we can
conclude the branch is ready.
Diff comments:
> diff --git a/cloudinit/config/cc_ntp.py
The proposal to merge ~raharper/cloud-init:feature/update-ntp-spec into
cloud-init:master has been updated.
Description changed to:
Implement ntp client spec with auto support for distro selection
Add a base NTP client configuration dictionary and allow Distro
specific changes to be merged. Ad
The proposal to merge ~raharper/cloud-init:feature/update-ntp-spec into
cloud-init:master has been updated.
Commit message changed to:
Implement ntp client spec with auto support for distro selection
Add a base NTP client configuration dictionary and allow Distro
specific changes to be merged.
Refactored all logic into cc_ntp module deferring only to distros for a
preferred ordering of ntp clients.
This passes all unit/ci-cloud tests locally. Next step is testing it in
different datasources/clouds.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/339438
Your
101 - 200 of 445 matches
Mail list logo
