[Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init
The proposal to merge lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1403617/+merge/256812 -- Your team cloud init development team is requested to review the proposed merge of lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
Re: [Cloud-init-dev] [Merge] lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init
My only real comment is that I thikn i'd take 'get_metadata' out of 'get_data'. You can either move it to a stand alone method or a class method. either way, moving it out allows to easier patch it for testing. -- https://code.launchpad.net/~daniel-thewatkins/cloud-init/lp1403617/+merge/256812 Your team cloud init development team is requested to review the proposed merge of lp:~daniel-thewatkins/cloud-init/lp1403617 into lp:cloud-init. ___ Mailing list: https://launchpad.net/~cloud-init-dev Post to : cloud-init-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~cloud-init-dev More help : https://help.launchpad.net/ListHelp
