Updated.
(CI failures are due to an infra problem, which we've hopefully just fixed.)
--
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/372491
Your team cloud-init Commiters is requested to review the proposed merge of
In the interest of making "cloud-init debug is way to loud" even worse, Could
one log message be enough?
"Atomic writing to %s via temporary %s", filename, tf.name
If you see such a log and its not followed by a stack trace, then its good.
--
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:ae70b6bcef3002b3ed7318faba23df4dda2d188b
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1110/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
FAILED:
OK, I've updated the log message to indicate we're writing to a temporary file,
and added a log message for the rename (because I think failures could happen
in either of those steps, and this allows us to distinguish between those).
(We will also have the different logger name to distinguish
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master.
Commit message:
atomic_helper: add DEBUG logging to write_file
Fixes LP: #1843276
Requested reviews:
Server Team CI bot (server-team-bot): continuous-integration
cloud-init
Oh yeah, great points. Will fix.
--
https://code.launchpad.net/~daniel-thewatkins/cloud-init/+git/cloud-init/+merge/372491
Your team cloud-init Commiters is requested to review the proposed merge of
~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master.
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:cea88e21a22c752bfd268e1ca49fada2858ab858
https://jenkins.ubuntu.com/server/job/cloud-init-ci/1109/
Executed test runs:
SUCCESS: Checkout
SUCCESS: Unit & Style Tests
SUCCESS: Ubuntu LTS: Build
FAILED:
Your successful log path would not even include the final location for the
file, which is ultimately the useful thing (except in the write-failed case,
which is probably rare).
I think I'd prefer logging with a message that included the target file
(filename), not just the temporary file name.
Dan Watkins has proposed merging
~daniel-thewatkins/cloud-init/+git/cloud-init:lp1843276 into cloud-init:master.
Commit message:
atomic_helper: add DEBUG logging to write_file
Fixes LP: #1843276
Requested reviews:
cloud-init Commiters (cloud-init-dev)
Related bugs:
Bug #1843276 in
9 matches
Mail list logo