I merged this.
Had to fix flake8 tox and made one code change. basically in add_snap_user i
returned if there was no 'email' and then un-indented the rest of that block.
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/304700
Your team cloud init development team is requ
The proposal to merge ~raharper/cloud-init:snapuser-create into
cloud-init:master has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/304700
--
Your team cloud init development team is requested to re
over all, looks good.
you dont have to clean up the handle, but if you see easy way to do that that'd
be nice.
is the snappy path now valid on non-snappy system ? (ubuntu server with 'snap'
support).
lastly, please just review your commit message and make sure its up to date
with all changes
The proposal to merge ~raharper/cloud-init:snapuser-create into
cloud-init:master has been updated.
Description changed to:
Add support for snap create-user on Ubuntu Core images
Ubuntu Core images use the `snap create-user` to add users to a Ubuntu
Core system. Add support for creating snap u
On Wed, Oct 19, 2016 at 8:52 AM, Ryan Harper
wrote:
>
>
> On Wed, Oct 19, 2016 at 8:04 AM, Scott Moser wrote:
>
>> over all, looks good.
>> you dont have to clean up the handle, but if you see easy way to do that
>> that'd be nice.
>>
>> is the snappy path now valid on non-snappy system ? (ubunt
On Wed, Oct 19, 2016 at 8:04 AM, Scott Moser wrote:
> over all, looks good.
> you dont have to clean up the handle, but if you see easy way to do that
> that'd be nice.
>
> is the snappy path now valid on non-snappy system ? (ubuntu server with
> 'snap' support).
>
It is, and util.is_system_snap
over all, looks good.
you dont have to clean up the handle, but if you see easy way to do that that'd
be nice.
is the snappy path now valid on non-snappy system ? (ubuntu server with 'snap'
support).
lastly, please just review your commit message and make sure its up to date
with all changes
Thanks, it was enlightening and easy to read.
Diff comments:
> diff --git a/cloudinit/config/cc_snap_config.py
> b/cloudinit/config/cc_snap_config.py
> new file mode 100644
> index 000..667b9c6
> --- /dev/null
> +++ b/cloudinit/config/cc_snap_config.py
> @@ -0,0 +1,177 @@
> +# vi: ts=4 exp
Thanks for looking at the code!
Diff comments:
> diff --git a/cloudinit/config/cc_snap_config.py
> b/cloudinit/config/cc_snap_config.py
> new file mode 100644
> index 000..667b9c6
> --- /dev/null
> +++ b/cloudinit/config/cc_snap_config.py
> @@ -0,0 +1,177 @@
> +# vi: ts=4 expandtab
> +#
> +#
Quick look just because I wanted to know more about the impl.
Diff comments:
> diff --git a/cloudinit/config/cc_snap_config.py
> b/cloudinit/config/cc_snap_config.py
> new file mode 100644
> index 000..667b9c6
> --- /dev/null
> +++ b/cloudinit/config/cc_snap_config.py
> @@ -0,0 +1,177 @@
>
Is this still needed or desired ?
--
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/304700
Your team cloud init development team is requested to review the proposed merge
of ~raharper/cloud-init:snapuser-create into cloud-init:master.
Ryan Harper has proposed merging ~raharper/cloud-init:snapuser-create into
cloud-init:master.
Requested reviews:
cloud init development team (cloud-init-dev)
Related bugs:
Bug #1619393 in cloud-init: "cloud-init useradd/groupadd fails on
ubuntu-core-16 with readonly /etc/passwd"
https://bu
12 matches
Mail list logo
