[Cloud-init-dev] [Merge] lp:~harmw/cloud-init/freebsd into lp:cloud-init

2014-09-02 Thread noreply
The proposal to merge lp:~harmw/cloud-init/freebsd into lp:cloud-init has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~harmw/cloud-init/freebsd/+merge/231024 -- https://code.launchpad.net/~harmw/cloud-init/freebsd/+merge/231024 Your team cl

Re: [Cloud-init-dev] [Merge] lp:~harmw/cloud-init/freebsd into lp:cloud-init

2014-08-28 Thread Joshua Harlow
Diff comments: > === modified file 'cloudinit/config/cc_resizefs.py' > --- cloudinit/config/cc_resizefs.py 2014-08-26 19:53:41 + > +++ cloudinit/config/cc_resizefs.py 2014-08-28 17:55:48 + > @@ -40,8 +40,13 @@ > return ('xfs_growfs', devpth) > > > +<<< TREE > def _resiz

Re: [Cloud-init-dev] [Merge] lp:~harmw/cloud-init/freebsd into lp:cloud-init

2014-08-28 Thread Joshua Harlow
Diff comments: > === modified file 'cloudinit/config/cc_resizefs.py' > --- cloudinit/config/cc_resizefs.py 2014-08-26 19:53:41 + > +++ cloudinit/config/cc_resizefs.py 2014-08-28 17:55:48 + > @@ -40,8 +40,13 @@ > return ('xfs_growfs', devpth) > > > +<<< TREE > def _resiz

Re: [Cloud-init-dev] [Merge] lp:~harmw/cloud-init/freebsd into lp:cloud-init

2014-08-24 Thread Scott Moser
The test that fails is the one you added. it fails because I'm running it on linux, where there is no /etc/rc.conf. I stuffed a 'raise Exception("FOO")' in to show the stack trace. == ERROR: test_simple_write_freebsd (tests.u

Re: [Cloud-init-dev] [Merge] lp:~harmw/cloud-init/freebsd into lp:cloud-init

2014-08-23 Thread Harm Weites
ok, I've merged your bikeshedding work and added some minor fixes/changes on top. I realy have no clue why that test suddenly fails, nor do have an idea how to fix it. How should I go and fix this? About your suggestion to compile the re instead of using re.match, I'm afraid I don't know what

Re: [Cloud-init-dev] [Merge] lp:~harmw/cloud-init/freebsd into lp:cloud-init

2014-08-22 Thread Scott Moser
some comments: a.) please merge/pull the changes i have in my branch at lp:~smoser/cloud-init/freebsd-cleanups b.) test_simple_write_freebsd is failing for me on ubuntu I think that cloud.freebsd.cfg can't be put into config/ as I think it will be copied/installed/used on linux and screw things u

[Cloud-init-dev] [Merge] lp:~harmw/cloud-init/freebsd into lp:cloud-init

2014-08-15 Thread Harm Weites
Harm Weites has proposed merging lp:~harmw/cloud-init/freebsd into lp:cloud-init. Requested reviews: cloud init development team (cloud-init-dev) For more details, see: https://code.launchpad.net/~harmw/cloud-init/freebsd/+merge/231024 Several FreeBSD fixes, a full changelog can be viewed in